nagai/fune
3
0
Fork 0
forked from mirrors/gecko-dev
Code Pull requests Activity
856575 commits 1 branch 98 tags 6.4 GiB
Commit graph

187 commits

Author SHA1 Message Date
Tom Marble
d596ebea8e Bug 1853243 - convert .ini manifests to .toml: batch 5 browser/**/browser.ini r=jmaher,mossop,webcompat-reviewers,twisniewski,search-reviewers,Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D188427
 2023-09-21 22:47:07 +00:00
Marco Bonardo
70fdad6676 Bug 1852963 - Rename BrowserTestUtils.loadURIString() to .startLoadingURIString(). r=dao 
This should make a bit clearer that it is only starting the load, not waiting
for its completion.

Differential Revision: https://phabricator.services.mozilla.com/D188213
 2023-09-15 09:16:34 +00:00
Sandor Molnar
950a3c620d Backed out 3 changesets (bug 1852963) for causing remote failures on remote/shared/messagehandler/test/browser/browser_session_data.js CLOSED TREE 
Backed out changeset 98de7bc404c3 (bug 1852963)
Backed out changeset edf1527c9a99 (bug 1852963)
Backed out changeset 34357750f69c (bug 1852963)
 2023-09-14 20:29:06 +03:00
Marco Bonardo
61f8ecc425 Bug 1852963 - Rename BrowserTestUtils.loadURIString() to .startLoadingURIString(). r=dao 
This should make a bit clearer that it is only starting the load, not waiting
for its completion.

Differential Revision: https://phabricator.services.mozilla.com/D188213
 2023-09-14 16:33:13 +00:00
Gregory Pappas
8a35d5cf5f Bug 1845311 - [Part 2] Use ChromeUtils.defineLazyGetter in more places r=arai,webcompat-reviewers,necko-reviewers,extension-reviewers,settings-reviewers,application-update-reviewers,credential-management-reviewers,devtools-reviewers,fxview-reviewers,sync-reviewers,anti-tracking-reviewers,tabbrowser-reviewers,bytesized,twisniewski,sgalich,mak,kershaw,sclements,pbz,robwu,geckoview-reviewers,amejiamarmol 
Differential Revision: https://phabricator.services.mozilla.com/D184623
 2023-08-01 23:01:02 +00:00
William Durand
8196f35844 Bug 1844004 - Only set ERROR_USER_CANCELED when the cancellation originated from the user. r=geckoview-reviewers,robwu,owlish 
Differential Revision: https://phabricator.services.mozilla.com/D184478
 2023-07-28 08:09:01 +00:00
Rob Wu
3c0c3a2676 Bug 1836482 - Replace AddonManager.jsm imports with AddonManager.sys.mjs r=Standard8,webcompat-reviewers,twisniewski 
This patch was generated as follows:

Run:
`./mach esmify --imports . --prefix=toolkit/mozapps/extensions/AddonManager`
In the output there are linter/prettifier errors due to unused
XPCOMUtils or separate importESModule calls. These have been fixed
manually and verified with `./mach lint --outgoing`.

The `esmify` script also inserts many unwanted newlines around imports
that are broken on two lines due to length. Due to the number of these,
I fixed them programatically.

1. Create patch from the changes so far.
2. From the patch, delete all lines that consist of "+" (i.e. added blank line).
3. Reset the working dir and apply the revised patch.
4. Verify that the diff between step 1 and 3 looks reasonable.
5. Verify that this patch as a whole looks reasonable.

Commands:

```
git diff > rename.diff
:%g/^+$/d
git commit -va -m WIP-rename
git revert HEAD
git apply --recount rename.diff
git diff HEAD^  # and verify that the removed lines are ok.
git commit -va  # one last review to verify correctness of whole patch.
git rebase -i HEAD~3  # drop the WIP + reverted commit, pick only the last.
```

`git apply` has the `--recount` option to force it to ignore mismatches
in line counts, which happens because we deleted added lines (^+$)
without fixing up the line counts in the file headers.

Differential Revision: https://phabricator.services.mozilla.com/D179874
 2023-06-04 13:44:45 +00:00
Mark Banner
5d59c7aecd Bug 1824613 - Convert consumers of toolkit/mozapps/extensions/ to import ES modules directly. r=extension-reviewers,settings-reviewers,application-update-reviewers,credential-management-reviewers,devtools-reviewers,sync-reviewers,sgalich,bytesized,robwu,skhamis 
Depends on D179819

Differential Revision: https://phabricator.services.mozilla.com/D179820
 2023-06-02 20:00:35 +00:00
Saira Abdulla
9691ab4a5f Bug 1824612 - Convert consumers of toolkit/components/extensions to ES modules. r=robwu,webcompat-reviewers,geckoview-reviewers,settings-reviewers,application-update-reviewers,credential-management-reviewers,devtools-reviewers,cookie-reviewers,twisniewski,sgalich,valentin,nalexander,mconley,m_kato 
Depends on D175553

Differential Revision: https://phabricator.services.mozilla.com/D176005
 2023-05-31 15:27:03 +00:00
Iulian Moraru
90b739a400 Backed out 2 changesets (bug 1824612) for causing dt failures on browser_dbg-features-source-tree.js. CLOSED TREE 
Backed out changeset c3f38adc818e (bug 1824612)
Backed out changeset 58ba8bb3398a (bug 1824612)
 2023-05-31 17:28:16 +03:00
Saira Abdulla
2e8db5969a Bug 1824612 - Convert consumers of toolkit/components/extensions to ES modules. r=robwu,webcompat-reviewers,geckoview-reviewers,settings-reviewers,application-update-reviewers,credential-management-reviewers,devtools-reviewers,cookie-reviewers,twisniewski,sgalich,valentin,nalexander,mconley,m_kato 
Depends on D175553

Differential Revision: https://phabricator.services.mozilla.com/D176005
 2023-05-31 10:21:37 +00:00
Eemeli Aro
411a529019 Bug 1793557 - Convert Extension.jsm strings to Fluent. r=mkmelin,geckoview-reviewers,robwu,flod,owlish 
This changes the arguments of `ExtensionData.formatPermissionStrings()`.
The second `bundle` arg is dropped, and a `localization` option is added.
Call sites in m-c are updated, but this will also need a matching update for Thunderbird.
A few Thunderbird test cases will also need to be updated,
as they currently point to a non-existing localization file paths
"messenger/addons.ftl" and "messenger/addonPermissions.ftl".

As discussed at the addon workweek,
the Fluent l10n keys for extension permissions match the pattern:

    webext-perms-description-{name}

where `{name}` is the permission's sanitized name.
A fluent-lint exception is added for the capitalization of these generated names.
To allow for message updates and subsequent l10n identifier updates,
a `PERMISSION_L10N_ID_OVERRIDES` map is provided.

Because Fluent localization keys are not enumerable
and attempting to format a missing key is an error,
the `PERMISSIONS_WITH_MESSAGE` set must be kept in sync with message updates.

Differential Revision: https://phabricator.services.mozilla.com/D158663
 2023-05-23 12:00:01 +00:00
Mark Banner
130a655906 Bug 1826062 - Automatic fixes for upgrading Prettier to 2.8.8. r=mossop,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,denschub,devtools-reviewers,sparky,calu 
Differential Revision: https://phabricator.services.mozilla.com/D177027
 2023-05-20 12:26:53 +00:00
Mark Banner
8219a5c503 Bug 1826062 - Automatic fixes for Prettier 2.0.5 upgrade. r=mossop,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,denschub,devtools-reviewers,sparky,owlish 
Differential Revision: https://phabricator.services.mozilla.com/D177025
 2023-05-20 12:26:49 +00:00
Katherine Patenio
ac4145f34d Bug 1830419 - Convert PanelMutiView.jsm and CustomizableUITestUtils.jsm in browser/components/customizableui to ESMs r=search-reviewers,Standard8,devtools-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D178362
 2023-05-18 18:34:51 +00:00
Mark Banner
474708c181 Bug 1826702 - Convert PermissionTestUtils to an ES module. r=permissions-reviewers,settings-reviewers,media-playback-reviewers,pbz,padenot 
Differential Revision: https://phabricator.services.mozilla.com/D174846
 2023-04-06 15:07:56 +00:00
William Durand
b9acf99c16 Bug 1820124 - Remove addonManager.action/link/view Telemetry events. r=rpl,settings-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D171541
 2023-03-20 20:11:15 +00:00
Luca Greco
c8e682ead9 Bug 1819940 - Remove expired histogram EXTENSION_INSTALL_PROMPT_RESULT. r=willdurand 
Depends on D171112

Differential Revision: https://phabricator.services.mozilla.com/D171113
 2023-03-15 13:23:39 +00:00
Stanca Serban
bbb825ee9e Backed out 3 changesets (bug 1819940) for causing Bug 1820248 and Bug 1820250 as requested by dev. CLOSED TREE 
Backed out changeset 1bcff70fd329 (bug 1819940)
Backed out changeset 234b68df6453 (bug 1819940)
Backed out changeset 39c2d3bf84a2 (bug 1819940)
 2023-03-03 23:34:59 +02:00
Luca Greco
796a297357 Bug 1819940 - Remove expired histogram EXTENSION_INSTALL_PROMPT_RESULT. r=willdurand 
Depends on D171112

Differential Revision: https://phabricator.services.mozilla.com/D171113
 2023-03-03 11:45:30 +00:00
Joel Maher
a62ef05cdb Bug 1816191 - Skip tests in order to keep win7 running @ azure. r=gbrown,necko-reviewers,settings-reviewers,application-update-reviewers,media-playback-reviewers,credential-management-reviewers,nalexander,sgalich,alwu 
Differential Revision: https://phabricator.services.mozilla.com/D169523
 2023-02-14 23:44:12 +00:00
Gijs Kruitbosch
efef52fc92 Bug 1795255 - autofix duplicate imports in tests under browser/, r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D166179
 2023-01-31 11:48:41 +00:00
Hanna Jones
18a071166c Bug 1798335 - replace aboutaddons toggles with moz-toggle r=mstriemer,desktop-theme-reviewers,dao,sfoster 
* replaced the toggle in the addons card that controls enabling/disabling the addon
* replaced the toggle that controls optional permissions
* fixed tests, added overrides for fx-toggle styles

Depends on D160971

Differential Revision: https://phabricator.services.mozilla.com/D160815
 2023-01-19 20:56:02 +00:00
Gijs Kruitbosch
9946c4fcbb Bug 1810995 - update BrowserTestUtils.loadURI consumers to use loadURIString (automated) - browser - r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D167153
 2023-01-19 20:16:42 +00:00
William Durand
899d6a234d Bug 1797050 - Part 4 - Use browser_specific_settings instead of applications in remaining tests. r=rpl,application-update-reviewers,bytesized 
Differential Revision: https://phabricator.services.mozilla.com/D160060
 2022-10-28 09:53:10 +00:00
Sandor Molnar
cb84cda02c Backed out changeset 53ce60b1b515 (bug 1797050) for causing bc failures in browser/components/preferences/tests/browser_extension_controlled.js CLOSED TREE 2022-10-26 15:01:23 +03:00
William Durand
61e4eb1bab Bug 1797050 - Part 4 - Use browser_specific_settings instead of applications in remaining tests. r=rpl,application-update-reviewers,bytesized 
Differential Revision: https://phabricator.services.mozilla.com/D160060
 2022-10-26 11:15:12 +00:00
Daisuke Akatsuka
1ae5e445bd Bug 1792971: Suppress popup notification while async tab switching. r=adw,zombie 
Differential Revision: https://phabricator.services.mozilla.com/D158480
 2022-10-11 00:10:26 +00:00
Mark Banner
8d1ebcb9d6 Bug 1792365 - Convert toolkit/modules consumers to use ES module imports directly. r=webdriver-reviewers,perftest-reviewers,geckoview-reviewers,extension-reviewers,preferences-reviewers,desktop-theme-reviewers,application-update-reviewers,pip-reviewers,credential-management-reviewers,robwu,Gijs,sgalich,bytesized,AlexandruIonescu,dao,m_kato 
Differential Revision: https://phabricator.services.mozilla.com/D158094
 2022-09-29 06:52:34 +00:00
Mark Banner
1c23a90c8e Bug 1782008 - Remove now unnecessary ESLint test definitions from other .eslintrc.js files. r=mossop,media-playback-reviewers,alwu 
Differential Revision: https://phabricator.services.mozilla.com/D153216
 2022-08-03 11:16:20 +00:00
Joel Maher
5bf232d7af Bug 1776212 - cleanup e10s in manifest conditions for bc/dt. r=aryx,necko-reviewers,extension-reviewers,preferences-reviewers,dragana,zombie 
Differential Revision: https://phabricator.services.mozilla.com/D150127
 2022-06-23 17:49:07 +00:00
Gijs Kruitbosch
7298feb0ee Bug 1753696 - move common setup/init tasks in head.js files to use add_setup, r=Standard8 
Without this, changing to add_setup in individual test files causes the tasks to be reordered, which causes tests to fail.

I also had to adjust an enterprise policy test that was expecting setup tests to run inbetween tasks.

Differential Revision: https://phabricator.services.mozilla.com/D142457
 2022-03-30 16:16:43 +00:00
Gijs Kruitbosch
8e67201171 Bug 1753696 - Automatic rewrite: replace add_task(setup with add_setup in browser mochitest, r=Standard8,webcompat-reviewers,twisniewski 
Differential Revision: https://phabricator.services.mozilla.com/D141437
 2022-03-30 16:16:42 +00:00
Norisz Fay
acdd6851cd Backed out 2 changesets (bug 1753696) for causing multiple dt and bc failures CLOSED TREE 
Backed out changeset 67fd9edfbcea (bug 1753696)
Backed out changeset a9d957ea887b (bug 1753696)
 2022-03-30 12:17:55 +03:00
Gijs Kruitbosch
27039e2946 Bug 1753696 - Automatic rewrite: replace add_task(setup with add_setup in browser mochitest, r=Standard8,webcompat-reviewers,twisniewski 
Differential Revision: https://phabricator.services.mozilla.com/D141437
 2022-03-30 08:18:51 +00:00
Luca Greco
160f5d7342 Bug 1759737 - Require user gesture on XPInstalls requests. r=mixedpuppy 
Differential Revision: https://phabricator.services.mozilla.com/D141474
 2022-03-23 19:42:27 +00:00
Marian-Vasile Laza
1ee05bd5b0 Backed out changeset 9a5b9d5e5a20 (bug 1759737) for causing screenshots failures on browser_permissionPrompts.js. CLOSED TREE 2022-03-23 00:48:47 -07:00
Luca Greco
549a20771e Bug 1759737 - Require user gesture on XPInstalls requests. r=mixedpuppy 
Differential Revision: https://phabricator.services.mozilla.com/D141474
 2022-03-22 18:11:33 +00:00
Luca Greco
d9c980ced7 Bug 1754441 - Explicit set prefs to enable InstallTrigger on all tests that depend on its availability. r=mixedpuppy 
Differential Revision: https://phabricator.services.mozilla.com/D138793
 2022-03-18 20:02:54 +00:00
Mark Banner
8bb4667fae Bug 1758474 - Implement an ESLint rule to disallow passing {} as the target parameter for ChromeUtils.import. r=Gijs,mossop,perftest-reviewers,preferences-reviewers,sparky 
Differential Revision: https://phabricator.services.mozilla.com/D140517
 2022-03-11 16:41:29 +00:00
smolnar
e89faa903f Backed out changeset 5018856d8fee (bug 1758474) for causing node eslint failure. CLOSED TREE 2022-03-10 11:58:45 +02:00
Mark Banner
fe937b78bd Bug 1758474 - Implement an ESLint rule to disallow passing {} as the target parameter for ChromeUtils.import. r=Gijs,mossop,perftest-reviewers,preferences-reviewers,sparky 
Differential Revision: https://phabricator.services.mozilla.com/D140517
 2022-03-10 09:25:28 +00:00
Florian Quèze
969ec01ebd Bug 1744993 - avoid leaving about:robots open at the end of browser-chrome mochitests, r=Gijs. 
Depends on D132055

Differential Revision: https://phabricator.services.mozilla.com/D133205
 2021-12-09 11:27:41 +00:00
raquelvargas
0aadb60b82 Bug 1738229 - Stop using the second argument to ChromeUtils.import in various files in browser. r=Standard8,webcompat-reviewers,twisniewski 
Differential Revision: https://phabricator.services.mozilla.com/D129842
 2021-11-02 17:21:07 +00:00
Molly Howell
25a4ed28ec Bug 1698030 - Remove a redundant warning icon. r=preferences-reviewers,Gijs 
The only difference between the icon that was removed and the one kept is that
the removed one has a default fill color in the SVG. This meant everywhere the
icon was replaced, we have to make sure that a fill color is defined in CSS.
In a few cases, that necessitated adding a new class. In a few others, colors
were already being defined for the icon, so there was no need to add any here.

Differential Revision: https://phabricator.services.mozilla.com/D121030
 2021-07-28 23:55:51 +00:00
Sam Foster
3834704712 Bug 1708008 - Remove browser's extension icon, always use extensionGeneric as default extension icon. r=mixedpuppy 
Differential Revision: https://phabricator.services.mozilla.com/D119931
 2021-07-19 16:58:11 +00:00
Sonia Singla
c2ffd0413b Bug 1661517 - Removed extensions.allowPrivateBrowsingByDefault preference. r=mixedpuppy 
Differential Revision: https://phabricator.services.mozilla.com/D97094
 2021-06-02 21:48:05 +00:00
Leslie Orellana
85649427ab Bug 1702451 - Replace BrowserTestUtils.waitForCondition with TestUtils.waitForCondition. r=prathiksha 
Differential Revision: https://phabricator.services.mozilla.com/D111171
 2021-04-08 20:21:55 +00:00
Luca Greco
1c5b244f49 Bug 1689240 - Rename aboutaddons custom event from ViewChanged to view-loaded. r=robwu 
Depends on D108513

Differential Revision: https://phabricator.services.mozilla.com/D108514
 2021-03-25 11:44:13 +00:00
Emilio Cobos Álvarez
501a3f8567 Bug 1695338 - Tweak extension approval panel layout so that the messages are inline. r=mconley,robwu 
Differential Revision: https://phabricator.services.mozilla.com/D107998
 2021-03-21 17:02:10 +00:00