Commit graph

82 commits

Author SHA1 Message Date
Kelly Cochrane
c5ca126b8e Bug 1845356 - Update Firefox View toolbarbutton icon and label/tooltip r=fluent-reviewers,desktop-theme-reviewers,fxview-reviewers,flod,dao,sclements
Differential Revision: https://phabricator.services.mozilla.com/D184970
2023-08-29 12:40:52 +00:00
Cristian Tuns
d0d03369a4 Backed out changeset c35a3bb94b22 (bug 1845356) for causing bc failures in browser_feature_callout_position.js CLOSED TREE 2023-08-28 17:53:19 -04:00
Kelly Cochrane
750fa918eb Bug 1845356 - Update Firefox View toolbarbutton icon and label/tooltip r=fluent-reviewers,desktop-theme-reviewers,fxview-reviewers,flod,dao,sclements
Differential Revision: https://phabricator.services.mozilla.com/D184970
2023-08-28 19:52:09 +00:00
Sandor Molnar
1d305e9817 Backed out changeset a91b29868240 (bug 1845356) for causing bc failures in browser/components/firefoxview/tests/browser/browser_feature_callout.js CLOSED TREE 2023-08-28 21:48:52 +03:00
Kelly Cochrane
3c494ef8b2 Bug 1845356 - Update Firefox View toolbarbutton icon and label/tooltip r=fluent-reviewers,desktop-theme-reviewers,fxview-reviewers,flod,dao,sclements
Differential Revision: https://phabricator.services.mozilla.com/D184970
2023-08-28 15:04:58 +00:00
Sam Foster
a24c7b1d6b Bug 1819675 - Include tabs from all windows in all views of recently-closed tabs and re-open them into the current window. r=dao,sclements,fxview-reviewers,fluent-reviewers,flod,robwu,sessionstore-reviewers,tabbrowser-reviewers
* Menu Bar History menu recently-closed tab items includes closed tabs from all currently-open windows
* Toolbar/Appmenu history menu recently-closed tabs list includes closed tabs from all currently-open windows
* Firefox view recently-closed tab list includes closed tabs from all currently-open windows
* All recently-closed tab menu/items re-open in the current window
* Re-open all tabs menu item re-opens all tabs into the current window

* Ensure we filter out tabs without any useful state in firefox-view
* Add a target window argument to undoCloseTab and undoCloseById
* undoCloseTab will remove the tab data from the source window collection and re-open the tab into the target window
* Add an options argument to SessionStore.getWindows to get all private or non-private windows
* Add a getWindowForTabClosedId method on SessionStore, allowing look-up of the window associated with a closed tab
* Ensure recently-closed tab lists only include tabs from non-private windows when attached (i.e. opened from) a non-private window. And vice-versa.
* Update the sessionstore closed tab tests to assert on the new behavior

* Update the browser.sessions.restore implementation to always find and pass the source window when restoring a closed tab
* sessions.restore should always restore closed tabs to the source window as there's no implicit top or current window in the API context

Differential Revision: https://phabricator.services.mozilla.com/D174501
2023-07-06 22:49:52 +00:00
Cosmin Sabou
f16c094fd9 Backed out 2 changesets (bug 1819675) for causing a spike in wpt and browser-chrome failures.
Backed out changeset aa4368bfb81a (bug 1819675)
Backed out changeset e5be8edfd9cf (bug 1819675)
2023-07-08 13:44:40 +03:00
Sam Foster
39d8ed9ddf Bug 1819675 - Include tabs from all windows in all views of recently-closed tabs and re-open them into the current window. r=dao,sclements,fxview-reviewers,fluent-reviewers,flod,robwu,sessionstore-reviewers,tabbrowser-reviewers
* Menu Bar History menu recently-closed tab items includes closed tabs from all currently-open windows
* Toolbar/Appmenu history menu recently-closed tabs list includes closed tabs from all currently-open windows
* Firefox view recently-closed tab list includes closed tabs from all currently-open windows
* All recently-closed tab menu/items re-open in the current window
* Re-open all tabs menu item re-opens all tabs into the current window

* Ensure we filter out tabs without any useful state in firefox-view
* Add a target window argument to undoCloseTab and undoCloseById
* undoCloseTab will remove the tab data from the source window collection and re-open the tab into the target window
* Add an options argument to SessionStore.getWindows to get all private or non-private windows
* Add a getWindowForTabClosedId method on SessionStore, allowing look-up of the window associated with a closed tab
* Ensure recently-closed tab lists only include tabs from non-private windows when attached (i.e. opened from) a non-private window. And vice-versa.
* Update the sessionstore closed tab tests to assert on the new behavior

* Update the browser.sessions.restore implementation to always find and pass the source window when restoring a closed tab
* sessions.restore should always restore closed tabs to the source window as there's no implicit top or current window in the API context

Differential Revision: https://phabricator.services.mozilla.com/D174501
2023-07-06 22:49:52 +00:00
Mark Banner
2a53076d43 Bug 1826063 - Automatic fixes for enabling Prettier on production xhtml and html files. r=mossop,webdriver-reviewers,webcompat-reviewers,geckoview-reviewers,extension-reviewers,settings-reviewers,application-update-reviewers,credential-management-reviewers,fxview-reviewers,sgalich,nalexander,devtools-reviewers,sclements,denschub,robwu,owlish
Differential Revision: https://phabricator.services.mozilla.com/D177938
2023-05-20 12:26:56 +00:00
Mike Kaply
ecba5585e8 Bug 1831601 - Switch view chrome URLS to have a firefoxview specific path. r=kcochrane,fxview-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D177283
2023-05-09 18:09:17 +00:00
Noemi Erli
68ea2b47d4 Backed out changeset 9e894095a614 (bug 1831601) for causing failures in browser_all_files_referenced.js CLOSED TREE 2023-05-08 18:15:12 +03:00
Mike Kaply
7c4ee19fa7 Bug 1831601 - Switch view chrome URLS to have a firefoxview specific path. r=kcochrane,fxview-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D177283
2023-05-08 14:11:12 +00:00
Francesco Lodolo (:flod)
01af1e915d Bug 1826755 - Move Firefox account Fluent term to toolkit, r=fluent-reviewers,settings-reviewers,credential-management-reviewers,fxview-reviewers,mconley,sclements,sgalich,eemeli
Differential Revision: https://phabricator.services.mozilla.com/D175097
2023-04-12 15:51:42 +00:00
Francesco Lodolo (:flod)
962126e608 Bug 1822388 - Move brandings.ftl from browser to toolkit, r=eemeli,settings-reviewers,credential-management-reviewers,devtools-reviewers,fxview-reviewers,sgalich,Mardak
Differential Revision: https://phabricator.services.mozilla.com/D172643
2023-03-15 17:00:48 +00:00
Dão Gottwald
3c21bc3bef Bug 1820475 - Remove colorways-card.mjs and related code. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D171696
2023-03-07 12:35:52 +00:00
Csoregi Natalia
422f2645bd Backed out changeset d59fe9707337 (bug 1820475) for failures on browser_multistage_spotlight.js. CLOSED TREE 2023-03-07 12:35:33 +02:00
Dão Gottwald
438ea15da5 Bug 1820475 - Remove colorways-card.mjs and related code. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D171696
2023-03-07 09:24:21 +00:00
Kelly Cochrane
976c5c450b Bug 1801204 - Update recently-closed-tabs.mjs to be template-driven r=sfoster,mstriemer
Differential Revision: https://phabricator.services.mozilla.com/D169010
2023-02-24 21:32:25 +00:00
Marian-Vasile Laza
4a61d97608 Backed out changeset 2ca3d042a78d (bug 1801204) for causing multiple bc failures. 2023-02-14 00:19:16 +02:00
Kelly Cochrane
324e9bc05f Bug 1801204 - Update recently-closed-tabs.mjs to be template-driven r=sfoster,mstriemer
Differential Revision: https://phabricator.services.mozilla.com/D169010
2023-02-13 20:56:56 +00:00
Bernard Igiri
a5575bb205 Bug 1785268 - Prevent FxView subtitles from being announced as clickable by VO r=Gijs
Changed the the section subtitles to heading tags so that VO will recognize them as part of the heading and not a separate clickable element.

Differential Revision: https://phabricator.services.mozilla.com/D165217
2023-01-17 15:03:55 +00:00
Meg Viar
90822c532c Bug 1805930 - Change featureCallout.mjs to featureCallout.sys.mjs and update all references to filename r=barret,aminomancer
Differential Revision: https://phabricator.services.mozilla.com/D164824
2022-12-29 14:27:02 +00:00
Stanca Serban
57387cef60 Backed out changeset a92af276c945 (bug 1805930) for causing bustages in packager.mk. CLOSED TREE 2022-12-19 21:41:40 +02:00
Meg Viar
ca348fa725 Bug 1805930 - Change featureCallout.mjs to FeatureCallout.sys.mjs and update all references to filename r=barret
Differential Revision: https://phabricator.services.mozilla.com/D164824
2022-12-19 18:55:05 +00:00
Sam Foster
98969866a3 Bug 1803505 - Simplify the tab-pickup-container initialization. r=sclements
* Adds a promise that resolves when the tab-pickup-list is ready
* Use that promise to trigger tab data request for the list when we enter the setup-complete state
* Remove the workarounds for overlapping setup and tabs requests

Differential Revision: https://phabricator.services.mozilla.com/D163750
2022-12-07 16:42:19 +00:00
Sarah Clements
6fffe2e852 Bug 1794610 - Change error state for password change r=sfoster,kcochrane,fluent-reviewers,flod
* Add new strings and add a new signed-out error type
* Update tests

Differential Revision: https://phabricator.services.mozilla.com/D162275
2022-12-06 14:30:39 +00:00
Dão Gottwald
4d433a2196 Bug 1801037 - Remove "New colorways are on the way" message from Firefox View. r=sfoster
Differential Revision: https://phabricator.services.mozilla.com/D162264
2022-11-18 06:25:41 +00:00
Tim Giles
ab6393a1df Bug 1800689 - Remove colorways null state. r=sclements
Differential Revision: https://phabricator.services.mozilla.com/D162154
2022-11-17 17:05:27 +00:00
Norisz Fay
c2c3b8b6ff Backed out changeset 3811dbb4b859 (bug 1800689) for causing bc failures on browser_colorways_card.js CLOSED TREE 2022-11-16 19:53:33 +02:00
Tim Giles
6110c7d188 Bug 1800689 - Remove colorways null state. r=sclements
Differential Revision: https://phabricator.services.mozilla.com/D162154
2022-11-16 17:12:28 +00:00
Kelly Cochrane
0b08e1821d Bug 1788152 - Update presentation of Recently Closed and Tab Pickup empty states r=flod,fluent-reviewers,desktop-theme-reviewers,sfoster
Differential Revision: https://phabricator.services.mozilla.com/D160545
2022-11-07 14:07:52 +00:00
Bernard Igiri
18bf606914 Bug 1796004 - Updated disclosure arrow direction and positioning in Fx View r=sclements
Updated disclosure arrow direction and positioning in Fx View, to match Figma, for both LTR an RTL presentations.

Differential Revision: https://phabricator.services.mozilla.com/D160134
2022-11-01 15:24:13 +00:00
Hanna Jones
aa990624c1 Bug 1791474 - show more specific message for locked primary password error r=sfoster,fluent-reviewers
* Updated the error message to use the text [here](https://www.figma.com/file/SE4xHgOW84yLiv7vFugm9R/Firefox-View-Stepping-Stone)
* Updated the existing password test to verify the message contents

Differential Revision: https://phabricator.services.mozilla.com/D159787
2022-10-24 18:29:53 +00:00
Bernard Igiri
d4ae4b52b6 Bug 1780239 - Fix screen reader order of Colorway Landmark in FxView r=Gijs
Added dynamic DOM reordering to FX View so that the order of announcement in screen readers and tab sorting, matches the visual changes made by the responsive CSS layout.

Differential Revision: https://phabricator.services.mozilla.com/D157256
2022-10-07 20:21:49 +00:00
Dan Mosedale
3f9fc9ce37 Bug 1791873 - fix FxView sync-setup-container kbd access,r=Gijs
Backout tabIndex changes that caused the problem and add an integration test.

Differential Revision: https://phabricator.services.mozilla.com/D157988
2022-09-26 18:43:31 +00:00
Bernard Igiri
964b89f399 Bug 1785274 - Changed container of Fx View logo and title to a non-navigational tag r=sclements
Replaced tag containing Fx View logo and title with a non-navigational tag, so that screen readers do not announce it as a navigational element.

Differential Revision: https://phabricator.services.mozilla.com/D157260
2022-09-21 12:37:16 +00:00
Dan Mosedale
14b1464ab7 Bug 1790651 - place focus better on feature callout close, r=ayeddi,emcminn
When the user moves focus outside of a callout popup while it's open, this patch tracks and saves the most recently focused element until the focus moves back to the popup. Once the user exits the callout series, the focus is (visibly) placed back where the user last left it.

Differential Revision: https://phabricator.services.mozilla.com/D157398
2022-09-15 19:11:19 +00:00
Gijs Kruitbosch
ca20a99d4c Bug 1787559 - update recently closed tabs description in Firefox View, r=flod,fluent-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D157123
2022-09-12 15:58:17 +00:00
Mike Conley
3e971d367c Bug 1787441 - Use the browser brand icon as the favicon for about:firefoxview. r=sfoster
Differential Revision: https://phabricator.services.mozilla.com/D156585
2022-09-07 13:35:35 +00:00
Sam Foster
1c6bf94d61 Bug 1784902 - Implement the collapsible fx-view sections as details/summary elements. r=Gijs
* Both CEs now extend HTMLDetailsElement
* Keep the title string on the twisty/toggle element
* The whole summary element gets the focus highlight, and is clickable to collapse/expand the associated content
* Maintain the hover behavior on the twisty button to provide a visual cue for collapsibility
* The setup cards will be collapsible in all states, bug 1779384 will ensure we ignore a persisted closed state during sync setup so this content is always initially visible in a new session

Differential Revision: https://phabricator.services.mozilla.com/D155508
2022-09-02 18:53:21 +00:00
Sarah Clements
3312ce0c28 Bug 1764137 - Add correct aria-roles to named-deck in firefoxview r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D156085
2022-09-02 10:59:13 +00:00
Noemi Erli
51e237f373 Backed out changeset 59536058a947 (bug 1784902) for causing failures in browser_setup_state.js 2022-09-02 04:42:49 +03:00
Sam Foster
1f18bceffa Bug 1784902 - Implement the collapsible fx-view sections as details/summary elements. r=Gijs
* Both CEs now extend HTMLDetailsElement
* Keep the title string on the twisty/toggle element
* The whole summary element gets the focus highlight, and is clickable to collapse/expand the associated content
* Ensure the summary focus outline doesnt get clipped by the zap-card border below it
* Maintain the hover behavior on the twisty button to provide a visual cue for collapsibility
* The setup cards will be collapsible in all states, bug 1779384 will ensure we ignore a persisted closed state during sync setup so this content is always initially visible in a new session

Differential Revision: https://phabricator.services.mozilla.com/D155508
2022-09-01 22:30:42 +00:00
Dão Gottwald
43ae100762 Bug 1785265 - [Colorway Closet] Set role="presentation" on colorway illustrations. r=bigiri,extension-reviewers,rpl
Differential Revision: https://phabricator.services.mozilla.com/D154902
2022-08-18 15:49:25 +00:00
Sarah Clements
e5ff65130e Bug 1780242 - Add aria labels to collapsible container elements r=fluent-reviewers,morgan,flod
* Add aria labels and role to button and div that contains the content

Differential Revision: https://phabricator.services.mozilla.com/D154106
2022-08-16 09:48:10 +00:00
Meg Viar
3dfe381d04 Bug 1781084 - Add CSS transitions when moving Feature Callout from one element to the next r=Mardak
Depends on D154143

Differential Revision: https://phabricator.services.mozilla.com/D154275
2022-08-15 23:11:13 +00:00
Sam Foster
cd88b9a70d Bug 1783278 - Allow primary buttons to wrap in card layout at narrow widths. r=sclements
Differential Revision: https://phabricator.services.mozilla.com/D154312
2022-08-12 00:46:55 +00:00
Niklas Baumgardner
6a2b0e1cdd Bug 1783273 - Remove hover state from Firefox View sync setup containers. r=sfoster
Differential Revision: https://phabricator.services.mozilla.com/D154138
2022-08-10 13:35:51 +00:00
Meg Viar
eadd77632f Bug 1779024 - Create Feature Callout message surface using aboutwelcome r=pdahiya,Gijs,Mardak
Differential Revision: https://phabricator.services.mozilla.com/D152449
2022-08-04 11:47:01 +00:00
Sarah Clements
7ad1c6b17a Bug 1768695 - Add error states handling to FirefoxView r=sfoster,fluent-reviewers,desktop-theme-reviewers
* Add new card and styling for network offline, sync error and sync disabled by admin errors
* Change loading spinner to rotating sync svg
* Add tests

Differential Revision: https://phabricator.services.mozilla.com/D153069
2022-08-03 12:14:32 +00:00