nagai/fune
3
0
Fork 0
forked from mirrors/gecko-dev
Code Pull requests Activity
856575 commits 1 branch 98 tags 6.4 GiB
Commit graph

1716 commits

Author SHA1 Message Date
Tom Marble
d596ebea8e Bug 1853243 - convert .ini manifests to .toml: batch 5 browser/**/browser.ini r=jmaher,mossop,webcompat-reviewers,twisniewski,search-reviewers,Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D188427
 2023-09-21 22:47:07 +00:00
Stephanie Cunnane
05f20bb579 Bug 1846368 - Implement SERP categorization logic. r=jteow 
Differential Revision: https://phabricator.services.mozilla.com/D187810
 2023-09-19 16:22:58 +00:00
James Teow
d1761aed79 Bug 1850000 - Add listener and in-memory storage of Search Categorization collection - r=Standard8,leplatrem 
Differential Revision: https://phabricator.services.mozilla.com/D186805
 2023-09-18 13:42:53 +00:00
Marco Bonardo
70fdad6676 Bug 1852963 - Rename BrowserTestUtils.loadURIString() to .startLoadingURIString(). r=dao 
This should make a bit clearer that it is only starting the load, not waiting
for its completion.

Differential Revision: https://phabricator.services.mozilla.com/D188213
 2023-09-15 09:16:34 +00:00
Marco Bonardo
68e8e4ff48 Bug 1852963 - Fix tests awaiting on BrowserTestUtils.loadURIString(). r=dao,webdriver-reviewers,devtools-reviewers,whimboo 
BrowserTestUtils.loadURIString() is not async, nor returning a promise, it's
effectively not awaiting for the page to be loaded.

Differential Revision: https://phabricator.services.mozilla.com/D188211
 2023-09-15 09:16:34 +00:00
Sandor Molnar
950a3c620d Backed out 3 changesets (bug 1852963) for causing remote failures on remote/shared/messagehandler/test/browser/browser_session_data.js CLOSED TREE 
Backed out changeset 98de7bc404c3 (bug 1852963)
Backed out changeset edf1527c9a99 (bug 1852963)
Backed out changeset 34357750f69c (bug 1852963)
 2023-09-14 20:29:06 +03:00
Marco Bonardo
61f8ecc425 Bug 1852963 - Rename BrowserTestUtils.loadURIString() to .startLoadingURIString(). r=dao 
This should make a bit clearer that it is only starting the load, not waiting
for its completion.

Differential Revision: https://phabricator.services.mozilla.com/D188213
 2023-09-14 16:33:13 +00:00
Marco Bonardo
2d21eb4e99 Bug 1852963 - Fix tests awaiting on BrowserTestUtils.loadURIString(). r=dao,webdriver-reviewers,devtools-reviewers,whimboo 
BrowserTestUtils.loadURIString() is not async, nor returning a promise, it's
effectively not awaiting for the page to be loaded.

Differential Revision: https://phabricator.services.mozilla.com/D188211
 2023-09-14 16:33:13 +00:00
James Teow
95d7447e73 Bug 1849728 - Compare URLs in page to the URL being visited in the network process - r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D186681
 2023-09-13 23:14:17 +00:00
Stephanie Cunnane
aec7784b82 Bug 1847794 - Ensure the Search component's browser mochitests and XPCShell tests use add_setup correctly. r=search-reviewers,daleharvey 
Differential Revision: https://phabricator.services.mozilla.com/D187935
 2023-09-12 22:41:40 +00:00
James Teow
bc39159ac4 Bug 1842554 - Enable SERP Telemetry improvements - r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D186552
 2023-09-07 10:18:43 +00:00
Stephanie Cunnane
6bd56eddeb Bug 1846357 - Extract domains for basic SERP links. r=jteow 
Differential Revision: https://phabricator.services.mozilla.com/D185609
 2023-09-05 16:49:53 +00:00
Dale Harvey
6a30a8ed22 Bug 1848048 - Add a result menu to disable trending results. r=dao,fluent-reviewers,settings-reviewers,flod,Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D187066
 2023-09-01 08:38:54 +00:00
Mark Banner
2248e9f289 Bug 1849924 - Remove unnecessary init-complete observers from search bar and search one-offs code. r=search-reviewers,mcheang 
Depends on D186737

Differential Revision: https://phabricator.services.mozilla.com/D186741
 2023-08-28 13:31:15 +00:00
Mark Banner
fd39fd3f7a Bug 1848321 - Improve the browser.search.content.* documentation. r=search-reviewers,jteow 
Differential Revision: https://phabricator.services.mozilla.com/D185995
 2023-08-14 11:13:05 +00:00
Mark Banner
12b89c5f24 Bug 1847246 - Remove remaining parts of browser.search.hiddenOneOffs preference. r=search-reviewers,settings-reviewers,mcheang 
Differential Revision: https://phabricator.services.mozilla.com/D185444
 2023-08-05 09:21:56 +00:00
James Teow
9e73d7364c Bug 1836156 - Remove extraPageRegexps from search-telemetry-v2 - r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D180862
 2023-08-04 15:04:02 +00:00
Gregory Pappas
8a35d5cf5f Bug 1845311 - [Part 2] Use ChromeUtils.defineLazyGetter in more places r=arai,webcompat-reviewers,necko-reviewers,extension-reviewers,settings-reviewers,application-update-reviewers,credential-management-reviewers,devtools-reviewers,fxview-reviewers,sync-reviewers,anti-tracking-reviewers,tabbrowser-reviewers,bytesized,twisniewski,sgalich,mak,kershaw,sclements,pbz,robwu,geckoview-reviewers,amejiamarmol 
Differential Revision: https://phabricator.services.mozilla.com/D184623
 2023-08-01 23:01:02 +00:00
Gregory Pappas
3eac12bbd7 Bug 1845311 - Use ChromeUtils.defineLazyGetter in more places r=arai,webdriver-reviewers,geckoview-reviewers,extension-reviewers,application-update-reviewers,credential-management-reviewers,devtools-reviewers,fxview-reviewers,anti-tracking-reviewers,sessionstore-reviewers,pbz,joschmidt,robwu,issammani,bytesized,owlish,dao 
Differential Revision: https://phabricator.services.mozilla.com/D184481
 2023-07-26 16:28:11 +00:00
Stephanie Cunnane
57f2cb8390 Bug 1829671 - Move search telemetry tests into a separate sub-directory. r=jteow,search-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D182196
 2023-07-25 16:02:25 +00:00
Dale Harvey
89f4a029b6 Bug 1843386 - Dont deduplicate rich suggestions. r=mak 
Differential Revision: https://phabricator.services.mozilla.com/D183881
 2023-07-21 08:37:25 +00:00
Marco Bonardo
8259e0e3d5 Bug 1816572 - Allow more time for Address Bar heuristic results to be returned. r=adw 
Differential Revision: https://phabricator.services.mozilla.com/D181128
 2023-07-07 15:48:34 +00:00
Jonathan Kingston
cc4861a27b Bug 1836958 - Update DuckDuckGo favicon with latest version. r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D182679
 2023-07-06 09:03:26 +00:00
Drew Willcoxon
ce2ff6f009 Bug 1841408 - Unify rich suggestions, best match, Firefox Suggest sponsored results, and Pocket Suggestions. r=dao,daleharvey 
This does a few things:

* Unify the view implementations of rich suggestions, Firefox Suggest sponsored
  results, and best match. I did this by using the best match implementation
  and extending it to rich suggestions and Suggest sponsored.
* Use the unified implementation for Pocket suggestions too.
* Add a bottom-text concept since Pocket suggestions shown as top picks need to
  show both a description and some text below it. (The actual bottom text per
  result is added in D182632 since I didn't want to make this patch bigger than
  necessary)

I have a couple motivations for these changes:

* I'm implementing Pocket suggestions, which need to show some text below the
  suggestion title as well as the URL. I was going to just use the Firefox
  Suggest sponsored approach, where the action text is wrapped below the title,
  but that doesn't work because it can't show both the wrapped action text and
  the URL.
* IMO we should use rich suggestions as the basis for all rows going forward,
  i.e., unify the different row implementations around rich suggestions.

The reason I chose the best match implementation instead of the rich suggestions
implementation is because the grid-based approach of rich suggestions doesn't
work well when the URL also needs to be shown. The URL should be
baseline-aligned with the row title, which isn't easy to do when the URL is
outside the grid. The rich suggestions implementation also doesn't wrap the URL.

Other details:

* The `rich-suggestion=no-icon` attribute value is only used for styling, so we
  can replace it with `@supports -moz-bool-pref()`. That lets us make the
  `rich-suggestion` attribute a simple boolean.
* I kept the `isBestMatch` property for results since
  `searchEngagementTelemetryGroup()` uses it to return "top_pick", and the view
  also uses it to create the "Top pick" row/group label. It still has semantic
  meaning so I think that's OK. It's no longer used by the view to create
  different DOM or styling.
* Move `isRichSuggestion` from the payload to the result itself, since it's no
  longer used for only one type of result. It's like `isBestMatch`, which is
  also on the result.
* Add `richSuggestionIconSize` to the result too. The best match icon size
  is 52. The Pocket best match icon size is 24 (but will have added padding and
  a background color to make it appear 52px). IMO this is better than adding
  rules for each type of suggestion to the CSS. It's cleaner and also indicates
  what the "standard" icon sizes are.

Depends on D182580

Differential Revision: https://phabricator.services.mozilla.com/D182537
 2023-07-05 15:47:24 +00:00
James Teow
1571699546 Bug 1839461 - Enable SERP Telemetry improvements on Nightly - r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D181596
 2023-07-05 14:30:51 +00:00
Butkovits Atila
1f7b14ac8e Backed out changeset 986f4f6398a4 (bug 1816572) for causing failures at browser_search_bookmarks.js. CLOSED TREE 2023-07-04 16:29:04 +03:00
Marco Bonardo
834caa9a69 Bug 1816572 - Allow more time for Address Bar heuristic results to be returned. r=adw 
Differential Revision: https://phabricator.services.mozilla.com/D181128
 2023-07-04 09:28:46 +00:00
Dale Harvey
3650d1d639 Bug 1121903 - Use encodeURIComponent for keyword url encoding. r=mak 
Differential Revision: https://phabricator.services.mozilla.com/D181697
 2023-06-23 13:31:16 +00:00
James Teow
f568003e7e Bug 1833495 - Check if an ad is well above the possible viewable window - r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D181179
 2023-06-19 14:03:16 +00:00
Mark Banner
277ae4e069 Bug 1838744 - Unify Search Service channel handling between the production code and tests. r=mkaply 
This makes the code and the tests use the same detection for the channel, to avoid the issue where
ESR builds fail whilst they are setting up the branch (the update channel is set, but the version is not).

Originally, I was thinking that this was reasonable test to ensure the settings are correct on ESR, but it
ends up that the test is only expecting the branch to be on release. Hence, it isn't really a valid test case
and we should trust that the ESR flags are correctly set once ESR starts, and that there's QA/other testing
already in place to verify that fact.

Differential Revision: https://phabricator.services.mozilla.com/D181218
 2023-06-19 13:07:10 +00:00
Mark Banner
ae619c5049 Bug 1838155 - Clean up some console.error calls that had been migrated from Cu.reportError. r=jdescottes,perftest-reviewers,geckoview-reviewers,credential-management-reviewers,search-reviewers,sgalich,owlish,jteow,sparky 
This goes through the previous changes in the dependencies of bug 877389, and does two things:
1) Remove instances of \n
2) Change reporting of exceptions so that they are passed as separate arguments. This should result
   in an improved display of the exception in the browser console, should it occur.

Differential Revision: https://phabricator.services.mozilla.com/D180843
 2023-06-15 08:33:57 +00:00
Itiel
cf26dda371 Bug 1830679 - Convert element.setAttribute(data-l10n-{id,args}) uses in the codebase to document.l10n.setAttributes(element, id, args) r=eemeli,Gijs,willdurand,extension-reviewers,settings-reviewers,search-reviewers,devtools-reviewers,fxview-reviewers,mconley,Standard8,jdescottes,kcochrane,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D176791
 2023-06-14 17:16:39 +00:00
Iulian Moraru
1a03d0ff0d Backed out changeset 76c5afdda762 (bug 1830679) for causing xpcshell failures on test_VariablesView_filtering-without-controller.js. CLOSED TREE 2023-06-12 22:03:43 +03:00
Karandeep
7cb8d5c951 Bug 1643887 - Move handling of search engine one-off hidden from preferences into the search settings. r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D180229
 2023-06-12 18:03:52 +00:00
Itiel
d6ff8a9975 Bug 1830679 - Convert element.setAttribute(data-l10n-{id,args}) uses in the codebase to document.l10n.setAttributes(element, id, args) r=eemeli,Gijs,willdurand,extension-reviewers,settings-reviewers,search-reviewers,devtools-reviewers,fxview-reviewers,mconley,Standard8,jdescottes,kcochrane,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D176791
 2023-06-12 17:16:35 +00:00
Stephanie Cunnane
5ec17b63fa Bug 1825058 - Add test to verify a click on a non-ad link does not record an abandonment event. r=jteow,search-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D180356
 2023-06-09 14:10:40 +00:00
James Teow
ce144701bb Bug 1837429 - Rename hasShoppingTab to shoppingTabDisplayed - r=scunnane 
Differential Revision: https://phabricator.services.mozilla.com/D180346
 2023-06-08 19:55:51 +00:00
James Teow
74322cab78 Bug 1836507 - Prevent tab-history events from triggering a click event - r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D179966
 2023-06-08 16:13:59 +00:00
Mark Banner
6a7e28b354 Bug 1836803 - Drop the language parameter for Bing search suggestions url. r=search-reviewers,jteow 
Differential Revision: https://phabricator.services.mozilla.com/D179973
 2023-06-07 16:13:12 +00:00
Mark Banner
6725448902 Bug 1834176 - Convert consumers of NetUtil.jsm to import the ES module directly. r=arai,webdriver-reviewers,perftest-reviewers,valentin,extension-reviewers,devtools-reviewers,sync-reviewers,cookie-reviewers,robwu,afinder,whimboo 
Differential Revision: https://phabricator.services.mozilla.com/D178589
 2023-06-07 08:42:36 +00:00
Mark Banner
1f51377023 Bug 1832117 - Ensure places history is cleared between search tests. r=jteow 
This avoids leaking of places data across tests, which may affect suggested results.

Differential Revision: https://phabricator.services.mozilla.com/D179931
 2023-06-05 13:37:19 +00:00
Stephanie Cunnane
527b260019 Bug 1829953 - Add follow_on_from_refine_on_SERP tracking to the SERP impression event. r=jteow 
Differential Revision: https://phabricator.services.mozilla.com/D179491
 2023-06-03 17:58:13 +00:00
Mark Banner
5d59c7aecd Bug 1824613 - Convert consumers of toolkit/mozapps/extensions/ to import ES modules directly. r=extension-reviewers,settings-reviewers,application-update-reviewers,credential-management-reviewers,devtools-reviewers,sync-reviewers,sgalich,bytesized,robwu,skhamis 
Depends on D179819

Differential Revision: https://phabricator.services.mozilla.com/D179820
 2023-06-02 20:00:35 +00:00
Mark Banner
9da713aa30 Bug 1836107 - Add schema validation testing for search-telemetry-v2. r=jteow 
Differential Revision: https://phabricator.services.mozilla.com/D179582
 2023-06-02 10:11:49 +00:00
James Teow
53880174c8 Bug 1775917 - Disable the persist search tip from appearing in browser_rich_suggestions.js - r=daleharvey 
Differential Revision: https://phabricator.services.mozilla.com/D179502
 2023-06-01 21:33:10 +00:00
James Teow
b7663bfe8c Bug 1835321 - Allow any link on SERPs that don't match an ad expression to be considered a non-ad - r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D179367
 2023-06-01 02:13:18 +00:00
James Teow
e4f466f766 Bug 1834100 - Use timing distribution for categorizing components in SearchSERPTelemetryChild - r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D179116
 2023-05-31 14:24:34 +00:00
James Teow
457573b4b5 Bug 1834701 - Refactor SearchSERPTelemetry to have more isolation of page data - r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D178911
 2023-05-31 14:24:34 +00:00
Marco Bonardo
b5d4c2d0ad Bug 1834989 - Clean up UrlbarTestUtils use. r=adw 
Differential Revision: https://phabricator.services.mozilla.com/D179056
 2023-05-26 14:56:55 +00:00
Stephanie Cunnane
add45db8d4 Bug 1834401 - Replace certain calls to SpecialPowers.spawn with calls to BrowserTestUtils.synthesizeMouseAtCenter in search SERP telemetry mochitests. r=jteow 
Differential Revision: https://phabricator.services.mozilla.com/D179126
 2023-05-26 14:40:56 +00:00