Commit graph

40009 commits

Author SHA1 Message Date
Meg Viar
4b1e713247 Bug 1903416 - Add a pref to control the display of set default guidance notification a=dmeehan
Add a pref and nimbus variable to control whether users see set to default guidance notifications when one-click set to default is disabled. Windows only.

This patch supports the [[ https://experimenter.services.mozilla.com/nimbus/one-click-set-to-default-new-users/summary | one-click set to default guidance experiment ]].

Original Revision: https://phabricator.services.mozilla.com/D214700

Differential Revision: https://phabricator.services.mozilla.com/D214758
2024-06-25 17:20:07 +00:00
Nathan Barrett
ac2a0c2da8 Bug 1900418 - update thumbnails for wallpapers, use selectedWallpaper if availible a=RyanVM
Original Revision: https://phabricator.services.mozilla.com/D214435

Differential Revision: https://phabricator.services.mozilla.com/D214672
2024-06-22 20:55:25 +00:00
scottdowne
d26cf26a79 Bug 1896677 - Home and newtab weather widget fetch retry a=RyanVM
Original Revision: https://phabricator.services.mozilla.com/D214314

Differential Revision: https://phabricator.services.mozilla.com/D214484
2024-06-22 00:13:59 +00:00
scottdowne
852fdd765a Bug 1902109 - Home and newtab wallpapers v2 fixing lint rule for fluent dom a=RyanVM
Original Revision: https://phabricator.services.mozilla.com/D214290

Differential Revision: https://phabricator.services.mozilla.com/D214485
2024-06-22 00:13:15 +00:00
Nathan Barrett
d8c70fce78 Bug 1903123 - Update default temp unit based on locale a=RyanVM
Original Revision: https://phabricator.services.mozilla.com/D214109

Differential Revision: https://phabricator.services.mozilla.com/D214486
2024-06-22 00:12:41 +00:00
Moritz Beier
82dee7b55e Bug 1903608 - Pressing enter on search bar settings icon does not open settings. a=RyanVM
Original Revision: https://phabricator.services.mozilla.com/D214287

Differential Revision: https://phabricator.services.mozilla.com/D214515
2024-06-21 23:56:10 +00:00
DJ
2361bd68c9 Bug 1878038 - show entire viewport in tab preview. a=RyanVM
Original Revision: https://phabricator.services.mozilla.com/D212709

Differential Revision: https://phabricator.services.mozilla.com/D214432
2024-06-21 23:17:25 +00:00
Erik Nordin
64ea984262 Bug 1903838 - Fix change-to-language telemetry edge case a=RyanVM
Fixes an edge case in the SelectTranslationsPanel where,
on Windows and Linux, if both the from-language and to-language
are changed via keyboard before triggering re-translation, then
only the change-from-language event is logged to telemetry.

Original Revision: https://phabricator.services.mozilla.com/D214419

Differential Revision: https://phabricator.services.mozilla.com/D214429
2024-06-21 00:57:08 +00:00
Yazan Al Macki
8043a755f3 Bug 1902323 - Ensure mimetype info is passed when creating new blobs in order to correctly render application provided search engine icons if they are svg based. a=RyanVM
Original Revision: https://phabricator.services.mozilla.com/D213671

Differential Revision: https://phabricator.services.mozilla.com/D214414
2024-06-21 00:54:18 +00:00
Gijs Kruitbosch
aa15db38ef Bug 1054947 - Also check prefs.js last modified time before showing profile reset notification after a long absence, a=RyanVM
Original Revision: https://phabricator.services.mozilla.com/D212960

Differential Revision: https://phabricator.services.mozilla.com/D214078
2024-06-20 18:26:52 +00:00
Mark Banner
6ee0795092 Bug 1897142 - Fix test_UrlbarSearchUtils.js on Beta. a=RyanVM
Differential Revision: https://phabricator.services.mozilla.com/D214410
2024-06-20 15:46:14 +00:00
Mark Banner
76c337cc6f Bug 1897142 - Update Search Config tests. a=RyanVM
Original Revision: https://phabricator.services.mozilla.com/D211926

Differential Revision: https://phabricator.services.mozilla.com/D214125
2024-06-20 13:36:18 +00:00
Kelly Cochrane
19618faf81 Bug 1896988 - Fix for intermittent failure in browser_customize_sidebar.js r=sidebar-reviewers,nsharpley a=test-only 2024-06-19 00:10:52 -04:00
Jason Prickett
4f716e0a16 Bug 1901499 - Allow extensions success link to open in spotlight a=RyanVM
This patch allows the extensions success link to also be opened when the migration wizard is running in the spotlight. The issue seems to be that the browser element used in `OpenAboutAddons` doesn't exist when running in spotlight, so I've opted to instead allow the event to be handled with `OpenURL` when running in the aboutwelcome bundle, and also adding a parameter to handle trusted links with OpenURL.

Original Revision: https://phabricator.services.mozilla.com/D213666

Differential Revision: https://phabricator.services.mozilla.com/D214182
2024-06-19 03:45:12 +00:00
Erik Nordin
3a831aa110 Bug 1903393 - Send the text source to telemetry a=RyanVM
Adds the ability for the SelectTranslationsPanel to send
to telemetry whether the source text came from an active
selection or from a right-clicked hyperlink's text.

Original Revision: https://phabricator.services.mozilla.com/D214161

Differential Revision: https://phabricator.services.mozilla.com/D214197
2024-06-19 03:20:25 +00:00
Erik Nordin
dfa01e7bd5 Bug 1903392 - Send source-language changes to telemetry a=RyanVM
Adds the ability for the SelectTranslationsPanel to send
telemetry events when the source language is changed and a
translation is requested from the unsupported-language view.

Original Revision: https://phabricator.services.mozilla.com/D214160

Differential Revision: https://phabricator.services.mozilla.com/D214196
2024-06-19 03:20:25 +00:00
Erik Nordin
8d13b36dbc Bug 1903391 - Send from- and to-language changes to telemetry a=RyanVM
Adds the ability for the SelectTranslationsPanel to send
telemetry events when the from-language or the to-language
is changed in the panel such that a new translation is triggered.

Original Revision: https://phabricator.services.mozilla.com/D214159

Differential Revision: https://phabricator.services.mozilla.com/D214194
2024-06-19 03:20:24 +00:00
Erik Nordin
8c5b4dc839 Bug 1903151 - Await panel open in init-failure tests a=RyanVM
This patch ensures that the init-failure telemetry
tests for the SelectTranslationsPanel properly await
the "popupshown" event when the try-again button is
pressed, since that re-opens the panel.

Original Revision: https://phabricator.services.mozilla.com/D214056

Depends on D213890

Differential Revision: https://phabricator.services.mozilla.com/D214148
2024-06-19 01:42:51 +00:00
Erik Nordin
008d8a64cd Bug 1902717 - Attempt to fix Translations high-freq test failures a=RyanVM
Attempts to fix some of the Translations high-freq test
failures that were introduced by Bug 1900023.

Original Revision: https://phabricator.services.mozilla.com/D213849

Depends on D213889

Differential Revision: https://phabricator.services.mozilla.com/D213890
2024-06-19 01:42:50 +00:00
Erik Nordin
ad63f69e97 Bug 1902583 - Split up try-again-button keypress test a=RyanVM
Splits up the tests for try-again-button keypresses
in the SelectTranslationsPanel to avoid an intermittent
test timeout failure in CI.

Original Revision: https://phabricator.services.mozilla.com/D213765

Depends on D213893

Differential Revision: https://phabricator.services.mozilla.com/D213889
2024-06-19 01:42:50 +00:00
Erik Nordin
84bb27b512 Bug 1900023 - Fix SelectTranslationsPanel keyboard navigation on macOS a=RyanVM
This patch ensures that every button in the SelectTranslationsPanel
can be invoked both with the Enter key or the space bar on all
operating systems.

Original Revision: https://phabricator.services.mozilla.com/D213635

Differential Revision: https://phabricator.services.mozilla.com/D213893
2024-06-19 01:42:49 +00:00
Jason Prickett
0ef97dd55d Bug 1896090 - Fix about:welcome dismiss button position when in reverse-split mode a=RyanVM
Original Revision: https://phabricator.services.mozilla.com/D213728

Differential Revision: https://phabricator.services.mozilla.com/D214169
2024-06-18 21:12:49 +00:00
Erik Nordin
2892d24942 Bug 1903087 - Refresh languageInfo cache on every panel open a=RyanVM
Ensures that the SelectTranslationsPanel languageInfo cache
is refreshed every time the panel would be opened. This prevents
a case where the incorrect (previous) document language tag
is reported to telemetry in some cases.

Original Revision: https://phabricator.services.mozilla.com/D214011

Differential Revision: https://phabricator.services.mozilla.com/D214139
2024-06-18 17:38:12 +00:00
Niklas Baumgardner
6b44186ea0 Bug 1902683 - Early return on keydown when screenshots button is focused. r=sfoster a=RyanVM
Differential Revision: https://phabricator.services.mozilla.com/D213811
2024-06-15 13:40:07 +00:00
Eric Chen
b8288a50a7 Bug 1901840 - restore browser.privateWindowSeparation.enabled pref a=RyanVM
Original Revision: https://phabricator.services.mozilla.com/D213651

Differential Revision: https://phabricator.services.mozilla.com/D214120
2024-06-18 14:41:53 +00:00
scottdowne
182408d33f Bug 1902948 - Home and newtab fixing RTL issues in weather and wallpapers a=RyanVM
Original Revision: https://phabricator.services.mozilla.com/D213907

Differential Revision: https://phabricator.services.mozilla.com/D214064
2024-06-18 14:34:11 +00:00
scottdowne
4fdfcf7226 Bug 1901134 - Home and newtab wallpaper solid color selector a=RyanVM
Original Revision: https://phabricator.services.mozilla.com/D212890

Differential Revision: https://phabricator.services.mozilla.com/D214063
2024-06-18 14:33:13 +00:00
Dale Harvey
6ca49729fa Bug 1871054 - Dont show suggestions for single character query. a=RyanVM
Original Revision: https://phabricator.services.mozilla.com/D213774

Differential Revision: https://phabricator.services.mozilla.com/D214093
2024-06-18 14:27:48 +00:00
Nathan Barrett
50ae660151 Bug 1900103 - Add Weather telemetry event for location search a=RyanVM
Original Revision: https://phabricator.services.mozilla.com/D213654

Differential Revision: https://phabricator.services.mozilla.com/D213905
2024-06-18 03:00:25 +00:00
Amy Churchwell
4f2ddd1826 Bug 1900423 - Refine nested wallpapers styles. a=RyanVM
Original Revision: https://phabricator.services.mozilla.com/D212611

Differential Revision: https://phabricator.services.mozilla.com/D213895
2024-06-18 02:38:44 +00:00
Erik Nordin
0977764ccc Bug 1902254 - Increase SelectTranslationsPanel resize buffer a=RyanVM
Increases the buffer kept between the bottom edge of the
panel and the bottom of the screen or window to be relative
to 1/5 of the panel's starting height upon open, rather than
an arbitrarily set 20 pixels.

Original Revision: https://phabricator.services.mozilla.com/D213589

Differential Revision: https://phabricator.services.mozilla.com/D213887
2024-06-18 01:05:55 +00:00
Erik Nordin
3c51004d26 Bug 1901351 - Do not offer Translate Link Text for URLs a=RyanVM
This patch ensures that the Translate Link Text
option is not offered in the context menu when
right clicking hyperlinked text that would result
in only a URL being translated.

Original Revision: https://phabricator.services.mozilla.com/D212980

Differential Revision: https://phabricator.services.mozilla.com/D213885
2024-06-18 01:05:54 +00:00
Anna Yeddi
07eae88758 Bug 1901314 - Improve Select Translations panel labelling. a=RyanVM
Ensure the Select Translations panel's label is including "Beta" marker (while it is present), that the description includes the Manage Settings button, and that the `<textarea>` is labeled.

Original Revision: https://phabricator.services.mozilla.com/D212966

Differential Revision: https://phabricator.services.mozilla.com/D213892
2024-06-18 01:05:53 +00:00
Michael Kaply
4e591050fa Bug 1892961 - Add support for addons that can only be installed via policy. a=RyanVM
Original Revision: https://phabricator.services.mozilla.com/D211987

Differential Revision: https://phabricator.services.mozilla.com/D213933
2024-06-18 00:19:22 +00:00
Shane Hughes
003bd7527b Bug 1899757 - Allow targeting the trigger tab for feature callouts. a=RyanVM
Also add a global `browserIsSelected` context property for all triggers,
so you can entirely avoid showing a message if the triggering browser
was in the background. You can use the selector and the context property
together or separately.

Context targeting:
`browserIsSelected`

Background tab selector:
`#tabbrowser-tabs:not([overflow]):not([haspinnedtabs]) %triggerTab%`

Current tab selector:
`#tabbrowser-tabs:not([overflow]):not([haspinnedtabs]) %triggerTab%[visuallyselected]`

Child of tab selector:
`#tabbrowser-tabs:not([overflow]):not([haspinnedtabs]) %triggerTab% .tab-icon-image`

Original Revision: https://phabricator.services.mozilla.com/D212494

Differential Revision: https://phabricator.services.mozilla.com/D213921
2024-06-17 21:10:29 +00:00
Jared Hirsch
46d26a10e5 Bug 1901979 - Ensure shopping code never runs in private windows. r=Gijs, a=RyanVM
* Rearrange the `ShoppingSidebarManagerClass` to clearly separate
  public and private APIs.

* Ensure all public methods include a PBM check and add a comment
  encouraging future refactorings to preserve this property of the
  public API as a whole.

* Also add a check at the IPC layer, updating the child and parent
  actor code to bail out if a message is received in a private window.

Differential Revision: https://phabricator.services.mozilla.com/D213618
2024-06-13 21:18:05 +00:00
Gijs Kruitbosch
68106b733c Bug 1901899 - exempt primary password users from startup OS reauth migration a=RyanVM
Original Revision: https://phabricator.services.mozilla.com/D213574

Differential Revision: https://phabricator.services.mozilla.com/D213599
2024-06-14 01:48:03 +00:00
Erik Nordin
16496f4617 Bug 1900107 - Fix clickTryAgainButton test race condition r=ohall,translations-reviewers a=test-only
Fixes a race condition specific to testing the
SelectTranslationsPanel try-again button, in which
the test case will sometimes start waiting for
the panel to move to the "translatable" phase
after it has already moved from the "translatable"
phase to the "translating" phase.

Differential Revision: https://phabricator.services.mozilla.com/D213451
2024-06-12 18:29:45 +00:00
Erik Nordin
20a8c6332d Bug 1900107 - Fix SelectTranslationsPanel init-failure test r=ohall,translations-reviewers a=test-only
Attempts to fix the high-frequency intermittent test
failure associated with the SelectTranslationsPanel
init-failure test case.

Differential Revision: https://phabricator.services.mozilla.com/D213160
2024-06-11 15:23:38 +00:00
Mark Banner
c8c164e3ab Bug 1901208 - Add an integration test to ensure that searchWith pings are correctly recorded. r=search-reviewers,mcheang
Differential Revision: https://phabricator.services.mozilla.com/D212921
2024-06-09 10:22:53 +00:00
Jason Prickett
53a0149209 Bug 1896597 - Add custom event for migration wizard anchors to be handled in spotlight r=mconley,migration-reviewers,mviar
Differential Revision: https://phabricator.services.mozilla.com/D212898
2024-06-08 03:53:10 +00:00
Stanca Serban
df70b34d17 Backed out changeset 75215e4ff218 (bug 1896597) for causing mochitests failures. 2024-06-08 04:24:47 +03:00
Jason Prickett
4a3aa18e7e Bug 1896597 - Add custom event for migration wizard anchors to be handled in spotlight r=mconley,migration-reviewers,mviar
Differential Revision: https://phabricator.services.mozilla.com/D212898
2024-06-08 00:47:23 +00:00
Maxx Crawford
d4f1a850e2 Bug 1900854 - Add telemetry events for dismiss and cta clicks for Wallpaper feature highlight r=home-newtab-reviewers,thecount
Differential Revision: https://phabricator.services.mozilla.com/D212952
2024-06-07 20:44:50 +00:00
Dale Harvey
59b7067ff0 Bug 1900601 - Dont enter search mode when '>' is pressed. r=daisuke,settings-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D212558
2024-06-07 13:32:36 +00:00
Emilio Cobos Álvarez
8c8585c629 Bug 1901194 - Fix a test I missed.
MANUAL PUSH: Trivial fix CLOSED TREE
2024-06-07 15:35:29 +02:00
Emilio Cobos Álvarez
10a52a5365 Bug 1901194 - Remove useless tail-with-learn-more class on <span>s. r=settings-reviewers
It doesn't do anything on a span so it's just confusing.

Differential Revision: https://phabricator.services.mozilla.com/D212902
2024-06-07 12:11:23 +00:00
Karandeep
a4a050993c Bug 1898437 - Fix TypeError on re-submitting a search link by ensuring details.result is defined. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D212111
2024-06-07 12:04:02 +00:00
Francesco Lodolo (:flod)
197b096c22 Bug 1901191 - Tweak use of moz-support-link in privacy-preserving setting, r=emilio,settings-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D212900
2024-06-07 10:35:02 +00:00
Ed Lee
9c113718ee Bug 1894999 - Expose chat prefs via experiments featuregate r=tarek,fluent-reviewers,settings-reviewers,desktop-theme-reviewers,flod,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D209639
2024-06-07 04:28:22 +00:00