nagai/fune
3
0
Fork 0
forked from mirrors/gecko-dev
Code Pull requests Activity
909794 commits 1 branch 98 tags 6.4 GiB
Commit graph

353 commits

Author SHA1 Message Date
Mozilla L10n Automation Bot
cd1ff86a9f [components] Import l10n. 2021-04-12 00:20:39 +00:00
Mozilla L10n Automation Bot
8fc62d6ac9 [components] Import l10n. 2021-04-11 00:20:31 +00:00
Mugurell
2f5eb09d12 [components] For https://github.com/mozilla-mobile/android-components/issues/10005 - Replace layout manager to effectively change stackFromEnd 
The `stackFromEnd` property is not initially set even though
`endOfMenuAlwaysVisible` might be true since when having a bottom expandable
menu, that should always be scrolled to the top.
And we know if we're in that situation only later, after menu is configured and
based on it it can be inferred if it should be collapsed or not.

Setting `stackFromEnd` only after this steps, even if the menu is not yet on
the screen seems to have no effect.

The only solution is to replace menu's layout manager with one that has this
`stackFromEnd` from the beginning.
 2021-04-06 15:09:59 +00:00
Mozilla L10n Automation Bot
6e18ad2b07 [components] Import l10n. 2021-04-05 00:22:33 +00:00
Mugurell
1c2b5a60da [components] For https://github.com/mozilla-mobile/android-components/issues/9922 - Calculate menu width only once, before layout 
Previously the width could've change while the menu was scrolled or the width
may have been too small / big for the entire list when a larger / narrower
would be initially off screen, waiting for a scroll to be laid out.
 2021-04-02 07:05:15 +00:00
Mozilla L10n Automation Bot
b17b68b046 [components] Import l10n. 2021-04-02 00:14:52 +00:00
Mugurell
62436ef348 [components] For https://github.com/mozilla-mobile/android-components/issues/9904 - Add isCollapsingMenuLimit support to most of the menu items 
Most of the menu items should support this new property and allow AC clients to
configure the menus to show any one of them as the last one showing in a
collapsed menu.
 2021-03-30 14:15:53 +00:00
Mugurell
bdcc3a4003 [components] For https://github.com/mozilla-mobile/android-components/issues/9904 - Refactor BrowserMenu to use ExpandableLayout 
To support using the new functionality browser menu should:
- intercept the menu layout before being used to create a new PopupWindow and
possibly wrap it in the ExpandableLayout.
- identify when the menu wants to be shown as collapsed/expanded. This will be
inferred based on the new `isCollapsingMenuLimit` API of BrowserMenuItem.
- offer a straightforward, reliable way to know as soon as possible if the
menu should be anchored to the top or to the bottom of the screen.

Most of the refactoring from this patch was needed for the last part.
Previously the PopupWindow was created with a menu and then we used different
methods to infer where to place the menu.
Now we needed to know this before creating the PopupWindow since as per the
UX specs the menu should be expandable only when it is anchored to the bottom.
 2021-03-30 14:15:53 +00:00
Mugurell
2c91d40118 [components] For https://github.com/mozilla-mobile/android-components/issues/9904 - Add ExpandableLayout as a menu wrapper used by PopupWindow 
This new layout is specifically designed for one particular purpose:
wrapping a bottom placed menu to allow it to:
- first being displayed as collapsed until a specific menu item index
- inform about touches in the empty space left by the collapsed view
- automatically expand when users swipes up it will expand.
Once expanded it will remain so.

This was the only viable solution for allowing bottom anchored PopupWindows
to be expanded and collapsed.
 2021-03-30 14:15:53 +00:00
Mozilla L10n Automation Bot
a999cf4597 [components] Import l10n. 2021-03-30 00:21:24 +00:00
mcarare
084d327d6a [components] For https://github.com/mozilla-mobile/android-components/issues/9840: Add support for icon, label and custom checkbox menu item. 2021-03-29 09:34:48 +00:00
mcarare
75582d0d3c [components] No issue: REVERT renaming add-ons to extensions. 2021-03-18 13:36:22 +00:00
mcarare
cdc4719255 [components] For https://github.com/mozilla-mobile/android-components/issues/9873: Move extension sub-menu in the placeholder set by client apps. 2021-03-17 09:54:36 +00:00
mcarare
8e7358c07e [components] For https://github.com/mozilla-mobile/android-components/issues/9873: Update Add-ons naming to Extensions. 2021-03-17 09:54:36 +00:00
Mozilla L10n Automation Bot
fbe06980e1 [components] Import l10n. 2021-03-14 00:22:50 +00:00
Mozilla L10n Automation Bot
98e4f66268 [components] Import l10n. 2021-03-01 00:16:06 +00:00
Mozilla L10n Automation Bot
b3ce384e2c [components] Import l10n. 2021-02-25 00:28:15 +00:00
Mozilla L10n Automation Bot
83cc420397 [components] Import l10n. 2021-02-23 00:27:48 +00:00
Mozilla L10n Automation Bot
e2ba42940d [components] Import l10n. 2021-02-20 00:22:57 +00:00
Mozilla L10n Automation Bot
814ac109c3 [components] Import l10n. 2021-02-06 00:14:29 +00:00
Mozilla L10n Automation Bot
9bd22333d0 [components] Import l10n. 2021-02-05 00:27:06 +00:00
Roger Yang
f5c4421496 [components] Revert "For https://github.com/mozilla-mobile/android-components/issues/9101 - Show BrowserMenu at the right location on Android <=23" 
This reverts commit 8365d2d7dfe0400e7a9243b64b33033fec1fd90d.
 2021-02-02 14:54:31 +00:00
Mozilla L10n Automation Bot
0245ee0aeb [components] Import l10n. 2021-01-26 00:18:52 +00:00
Mozilla L10n Automation Bot
a074547dd9 [components] Import l10n. 2020-12-29 00:20:41 +00:00
Mozilla L10n Automation Bot
e6368dc807 [components] Import l10n. 2020-12-24 00:20:09 +00:00
Mugurell
5a022dcfa7 [components] For https://github.com/mozilla-mobile/android-components/issues/9101 - Show BrowserMenu at the right location on Android <=23 
Have the menu placed exactly above the anchor.
 2020-12-07 09:37:19 +00:00
Sebastian Kaspari
60c4cf4b2a [components] Update AndroidX dependencies. 2020-12-02 12:17:31 +00:00
Mozilla L10n Automation Bot
f2ea2e579a [components] Import l10n. 2020-11-16 00:17:46 +00:00
Christian Sadilek
b69eec6b77 [components] Closes https://github.com/mozilla-mobile/android-components/issues/8867: Correctly handle PageAction enabled state 2020-11-04 17:36:29 +00:00
Mozilla L10n Automation Bot
1b28c11a02 [components] Import l10n. 2020-11-04 00:21:39 +00:00
Mozilla L10n Automation Bot
665146892b [components] Import l10n. 2020-10-31 00:21:41 +00:00
Tiger Oakes
b1a7210c5b [components] For https://github.com/mozilla-mobile/android-components/issues/7833: Generate concept-menu items for addons 2020-10-20 17:30:59 +00:00
mcarare
be0274fb71 [components] For https://github.com/mozilla-mobile/android-components/issues/8593: Allow extensions to be moved to main browser menu. 2020-10-15 17:57:24 +00:00
Mozilla L10n Automation Bot
50454aa9ac [components] Import l10n. 2020-10-11 00:17:15 +00:00
Mozilla L10n Automation Bot
35c8de4ab5 [components] Import l10n. 2020-10-05 00:29:08 +00:00
Mozilla L10n Automation Bot
51662a3fe3 [components] Import l10n. 2020-10-04 00:25:33 +00:00
Mozilla L10n Automation Bot
7286b82036 [components] Import l10n. 2020-09-30 10:13:19 +00:00
Tiger Oakes
a035a49d2c [components] For https://github.com/mozilla-mobile/android-components/issues/7833: Introduce async drawable menu item 2020-09-29 02:51:25 +00:00
Mozilla L10n Automation Bot
b427b25d68 [components] Import l10n. 2020-09-25 00:22:10 +00:00
Mozilla L10n Automation Bot
dbb6c1e9e1 [components] Import l10n. 2020-09-22 09:28:45 +00:00
Mozilla L10n Automation Bot
bd3ac9a8dd [components] Import l10n. 2020-09-14 00:08:17 +00:00
Mozilla L10n Automation Bot
ad197c4761 [components] Import l10n. 2020-09-10 13:02:00 +02:00
Mozilla L10n Automation Bot
f67c8d27e1 [components] Import l10n. 2020-09-09 00:05:30 +00:00
Mozilla L10n Automation Bot
29070805dd [components] Import l10n. 2020-08-27 00:08:31 +00:00
MozLando
9466111420 [components] Merge https://github.com/mozilla-mobile/android-components/pull/8184 
8184: Import strings from android-l10n. r=jonalmeida a=mozilla-l10n-automation-bot

n/t

Co-authored-by: Mozilla L10n Automation Bot <release+l10n-automation-bot@mozilla.com>
 2020-08-25 16:25:20 +00:00
mcarare
4fe34a5f99 [components] For https://github.com/mozilla-mobile/android-components/issues/8223: Fix compound drawable position for RTL. 2020-08-25 14:07:21 +03:00
Mozilla L10n Automation Bot
c325d0c9e4 [components] Import l10n. 2020-08-25 00:01:46 +00:00
Tiger Oakes
f9fee46f63 [components] Add changelog 2020-08-21 11:15:41 -07:00
Tiger Oakes
0cc4b4deab [components] Add MenuStyle support to menu1 2020-08-21 11:15:21 -07:00
MozLando
1d6efe3367 [components] Merge https://github.com/mozilla-mobile/android-components/pull/8061 
8061: For https://github.com/mozilla-mobile/android-components/issues/8060 - a11y - `BrowserMenuImageSwitch` highlights the entire row  r=NotWoods a=BranescuMihai




Co-authored-by: Mihai Branescu <branescu.mihai@gmail.com>
 2020-08-21 11:23:51 +00:00
MozLando
cc25071649 [components] Merge https://github.com/mozilla-mobile/android-components/pull/8128 
8128: Import strings from android-l10n. r=Amejia481 a=mozilla-l10n-automation-bot

n/t

Co-authored-by: Mozilla L10n Automation Bot <release+l10n-automation-bot@mozilla.com>
 2020-08-20 17:34:55 +00:00
MozLando
9f89180e9a [components] Merge https://github.com/mozilla-mobile/android-components/pull/8055 
8055: For https://github.com/mozilla-mobile/android-components/issues/8054 - Unify addons icons design with the one for favicons r=Amejia481,brampitoyo a=Mugurell

This is a breaking change, specifying a different background is not possible
anymore.

Will use the same vector glyph with inherent padding as default addons icon.



Co-authored-by: Mugurell <Mugurell@users.noreply.github.com>
 2020-08-20 11:48:26 +00:00
Mozilla L10n Automation Bot
d494cb50c2 [components] Import l10n. 2020-08-20 00:09:22 +00:00
Mugurell
43f6a55830 [components] For https://github.com/mozilla-mobile/android-components/issues/8054 - Use the same vector glyph as addons icon. 
It is a vector glyph with inherent padding and will be the only drawable to be
used as addons icon.

It will replace the "mozac_ic_addons_extensions" drawable, resource added
because we needed the addons icon used in menu items to contain padding.
 2020-08-19 07:47:07 +03:00
Mihai Branescu
eefb5a9ab2 [components] For https://github.com/mozilla-mobile/android-components/issues/8060 - make BrowserMenuImageSwitch highlight the entire row for a11y 
Fixed by making the switch not important for accessibility, and making the parent view forward the click event instead
 2020-08-12 16:59:51 +03:00
Mozilla L10n Automation Bot
977403cc2b [components] Import l10n. 2020-08-12 00:01:49 +00:00
Mozilla L10n Automation Bot
40f12f14cd [components] Import l10n. 2020-08-11 00:12:54 +00:00
Mozilla L10n Automation Bot
6b1375f5de [components] Import l10n. 2020-08-10 00:04:27 +00:00
MozLando
b1155efa7a [components] Merge https://github.com/mozilla-mobile/android-components/pull/7838 
7838: For https://github.com/mozilla-mobile/android-components/issues/7836: Refine add-ons badge design r=Amejia481 a=hakkikaancaliskan

cc @brampitoyo

https://github.com/mozilla-mobile/fenix/issues/12845#issuecomment-663272360

Colors are coming from extensions. They need to set more stylish colors.

<img src="https://user-images.githubusercontent.com/17825767/88461470-61e02e00-ceac-11ea-99a4-822e3bc05d8f.png" width="200"><img src="https://user-images.githubusercontent.com/17825767/88461472-63115b00-ceac-11ea-968e-3cee2eea8d7f.png" width="200"><img src="https://user-images.githubusercontent.com/17825767/88461474-63115b00-ceac-11ea-90a8-ba043509c1e6.png" width="200">
<!-- Text above this line will be added to the commit once "bors" merges this PR -->

### Pull Request checklist
<!-- Before submitting the PR, please address each item -->
- [x] **Quality**: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
- [x] **Tests**: This PR includes thorough tests or an explanation of why it does not
- [x] **Changelog**: This PR includes [a changelog entry](https://github.com/mozilla-mobile/android-components/blob/master/docs/changelog.md) or does not need one
- [x] **Accessibility**: The code in this PR follows [accessibility best practices](https://github.com/mozilla-mobile/shared-docs/blob/master/android/accessibility_guide.md) or does not include any user facing features

### After merge
- **Milestone**: Make sure issues closed by this pull request are added to the [milestone](https://github.com/mozilla-mobile/android-components/milestones) of the version currently in development.
- **Breaking Changes**: If this is a breaking change, please push a draft PR on [Reference Browser](https://github.com/mozilla-mobile/reference-browser) to address the breaking issues.


Co-authored-by: Hakkı Kaan Çalışkan <caliskanhkaan@gmail.com>
 2020-08-09 14:30:43 +00:00
Hakkı Kaan Çalışkan
a1349add80 [components] For https://github.com/mozilla-mobile/android-components/issues/7836: Refine add-ons badge design 2020-08-09 17:16:14 +03:00
Mozilla L10n Automation Bot
f8ef7b6121 [components] Import l10n. 2020-08-08 00:02:51 +00:00
MozLando
e1e36da97e [components] Merge https://github.com/mozilla-mobile/android-components/pull/7947 https://github.com/mozilla-mobile/android-components/pull/7968 (part 1) 
7947: Uplift some menu features to menu2 r=pocmo a=NotWoods



7968: For https://github.com/mozilla-mobile/android-components/issues/7964 - Don't set initial orientation in MediaFullscreenOrientationFeature r=jonalmeida a=Mugurell

The Store that MediaFullscreenOrientationFeature is initialized with can either
have a null activeFullscreenOrientation if media wasn't playing before or,
because we use a global Store shared by all application's components it could
have an activeFullscreenOrientation already set by another component.

We'll ignore setting the initial orientation (which may be stall) for the new
component using MediaFullscreenOrientationFeature and only act upon subsequent
media orientation changes.




Co-authored-by: Tiger Oakes <toakes@mozilla.com>
Co-authored-by: Mugurell <Mugurell@users.noreply.github.com>
 2020-08-06 17:06:09 +00:00
Mozilla L10n Automation Bot
a9784f474d [components] Import l10n. 2020-08-06 00:12:53 +00:00
Tiger Oakes
aebdcef1e7 [components] Remove SimpleBrowserMenuHighlightableItem.itemType 2020-08-05 10:38:29 -07:00
Tiger Oakes
e1e5585495 [components] Uplift some menu features to menu2 2020-08-04 15:39:30 -07:00
MozLando
ce2d3e0e3b [components] Merge https://github.com/mozilla-mobile/android-components/pull/7962 
7962: Closes https://github.com/mozilla-mobile/android-components/issues/7961 - Hide keyboard on menu button clicks r=NotWoods a=ekager



Co-authored-by: ekager <ekager@mozilla.com>
 2020-08-04 21:21:30 +00:00
Mozilla L10n Automation Bot
5e4d6b00c2 [components] Import l10n. 2020-08-04 00:04:39 +00:00
ekager
ae22a6efda [components] Closes https://github.com/mozilla-mobile/android-components/issues/7961 - Hide keyboard on menu button clicks 2020-08-03 16:13:35 -04:00
Mozilla L10n Automation Bot
d4277f291c [components] Import l10n. 2020-08-02 00:08:29 +00:00
Tiger Oakes
4aa626125c [components] Closes https://github.com/mozilla-mobile/android-components/issues/7840: Menu is only long clickable if listener is set 2020-07-30 15:51:45 -07:00
Mozilla L10n Automation Bot
9b56156ef4 [components] Import l10n. 2020-07-29 00:06:03 +00:00
Mozilla L10n Automation Bot
072f295c1a [components] Import l10n. 2020-07-28 00:24:01 +00:00
Mozilla L10n Automation Bot
3a2564dca8 [components] Import l10n. 2020-07-27 00:10:28 +00:00
Tiger Oakes
e83cf8b1d2 [components] Create new menu2 component 
browser-menu v2: A new browser menu designed to work with lib-state.

This introduces a new API using immutable data classes to represent
options. Stateful functionality like the two-state button is replaced
with swapping out data classes and submitting a new list of options.

Internally this uses a recycler view and the view holders intentionally
do not map 1:1 to data classes. This way we can use different views
based on properties instead of introducing all new classes for every
combination of properties.
 2020-07-24 09:31:23 -07:00
Mozilla L10n Automation Bot
9934e0a9b2 [components] Import l10n. 2020-07-23 00:14:08 +00:00
Kainalu Hagiwara
26274f933f [components] Closes https://github.com/mozilla-mobile/android-components/issues/7644: Add long click listener to BrowserMenuItemToolbar items. 2020-07-10 12:47:52 -07:00
Simon Chae
454f30737d [components] For https://github.com/mozilla-mobile/fenix/issues/11679: submenu items order depends on appendExtensionSubMenuAtStart 2020-06-25 10:54:27 -04:00
MozLando
220765f7fa [components] Merge https://github.com/mozilla-mobile/android-components/pull/7467 
7467: Add NestedMenuCandidate concept item r=psymoon a=NotWoods

Broken out from the main menu2 PR. Adds a new concept menu type and corresponding view holder.



Co-authored-by: Tiger Oakes <toakes@mozilla.com>
 2020-06-23 21:51:23 +00:00
Tiger Oakes
fffa85812d [components] Add NestedMenuCandidate concept item 2020-06-23 14:35:01 -07:00
Tiger Oakes
bf2b8ac041 [components] Add asEffect helper to browser menu highlight 2020-06-23 09:51:22 -07:00
MozLando
22d5df2f1d [components] Merge https://github.com/mozilla-mobile/android-components/pull/7355 
7355: Fixes https://github.com/mozilla-mobile/android-components/issues/7354: Changes the add-ons icon from toolbar menu r=Amejia481 a=ValentinTimisica



Co-authored-by: ValentinTimisica <valentin.timisica@softvision.ro>
 2020-06-22 08:13:53 +00:00
Mugurell
b78ae6372a [components] For https://github.com/mozilla-mobile/android-components/issues/7392 - Material design sanity checks for BrowserMenu min/max width 
DynamicWidthRecyclerView will still be able to have a dynamic width between xml
set minWidth and maxWidth attributes but we'll now enforce the following:
- minimum width 112 dp
- maximum width - screen width minus a 48dp tappable “exit area”
 2020-06-15 17:54:05 +03:00
ValentinTimisica
c949e6397a [components] Fixes https://github.com/mozilla-mobile/android-components/issues/7354: Changes the add-ons icon from toolbar menu 2020-06-12 12:16:56 +03:00
Simon Chae
c1301adcf3 [components] Set overflow item only visible for ParentBrowserMenuItem 2020-05-29 10:38:37 -04:00
MozLando
844104e5bc [components] Merge https://github.com/mozilla-mobile/android-components/pull/7111 
7111: For https://github.com/mozilla-mobile/android-components/issues/7110: Dismiss menu popup window when anchor is detached from window. r=Amejia481,psymoon a=mcarare



Co-authored-by: mcarare <mihai.carare.dev@gmail.com>
 2020-05-29 05:37:18 +00:00
Simon Chae
13f0da91a6 [components] Closes https://github.com/mozilla-mobile/android-components/issues/7158: Add right chevron arrow in ParentBrowserMenuItem 2020-05-28 11:04:39 -04:00
mcarare
4c3485d644 [components] For https://github.com/mozilla-mobile/android-components/issues/7110: Add attached state listener for menu anchor. 
Dismiss popup window when anchor is detached from window.
 2020-05-28 08:26:48 +03:00
mcarare
448e7d09d7 [components] For https://github.com/mozilla-mobile/android-components/issues/7107: Set buttons height to match parent in browser item toolbar. 2020-05-26 13:42:16 +03:00
Simon Chae
93a613ff5f [components] Closes https://github.com/mozilla-mobile/android-components/issues/7062: Add nested menu UI for web extensions actions 2020-05-25 16:47:06 -04:00
Tiger Oakes
223af0811e [components] For https://github.com/mozilla-mobile/android-components/issues/6261 - Move browser.menu2 to concept-menu2 
Move the current dumb data classes into a concept component

Co-authored-by: Jonathan Almeida <jalmeida@mozilla.com>
 2020-05-12 10:29:09 -07:00
Mugurell
e9fe72b5c5 [components] For https://github.com/mozilla-mobile/android-components/issues/6499 - Add min/max width support for BrowserMenu 
BrowserMenu will now use a RecyclerView with dynamic width, automatically set
between
- `mozac_browser_menu_width_min`
- `mozac_browser_menu_width_max`
allowing for a better fit for all menu items.

By default `mozac_browser_menu_width_min` and `mozac_browser_menu_width_max`
have the same value ensuring the same previous behavior for all clients -
fixed width, the value of mozac_browser_menu_width.
`mozac_browser_menu_width_min` and `mozac_browser_menu_width_max` must have
different values for BrowserMenu to have dynamic width.
 2020-05-07 10:43:20 +03:00
MozLando
dc21f352d2 [components] Merge https://github.com/mozilla-mobile/android-components/pull/6863 https://github.com/mozilla-mobile/android-components/pull/6869 https://github.com/mozilla-mobile/android-components/pull/6874 (part 1) 
6863: For https://github.com/mozilla-mobile/android-components/issues/6825: Implement a custom tooltip for SDK 26. r=Amejia481 a=mcarare



6869: Closes https://github.com/mozilla-mobile/android-components/issues/6832: Ignore initial loads of about:blank for extension pages r=pocmo a=csadilek

We already have a workaround to ignore initial loads of about:blank. When switching to an extension page, there's a process switch involved, which triggers the same problem. This is pretty annoying, as we always see about:blank loads before loading the actual extension page e.g. the uBlock dashboard, or a reader view page.

GV can't fix this and advised to ignore all about:blank loads (https://bugzilla.mozilla.org/show_bug.cgi?id=1634428), which also doesn't seem right to me. So, here I am only ignoring the initial loads of about:blank when switching between regular and extension pages (after a process switch).

Not pretty, but does the trick and it's in line with our existing workaround at least. @pocmo can you take a look at this one?

6874:  Docs update (20200505-120948) [ci skip] r=pocmo a=MickeyMoz



Co-authored-by: mcarare <mihai.carare.dev@gmail.com>
Co-authored-by: Christian Sadilek <christian.sadilek@gmail.com>
Co-authored-by: MickeyMoz <sebastian@mozilla.com>
 2020-05-05 12:29:43 +00:00
mcarare
e10c7414c1 [components] For https://github.com/mozilla-mobile/android-components/issues/6825: Implement a custom tooltip for SDK 26. 2020-05-05 09:32:38 +03:00
ValentinTimisica
f77db70001 [components] For https://github.com/mozilla-mobile/android-components/issues/6558: Adds tests for the menu with simple highlightable items 2020-05-04 12:17:30 +03:00
ValentinTimisica
b1c23e94c2 [components] For https://github.com/mozilla-mobile/android-components/issues/6558: Adds a menu with simple highlightable items 2020-05-04 12:17:20 +03:00
Jonathan Almeida
b86fa6dfb5 [components] Close https://github.com/mozilla-mobile/android-components/issues/6601: Update targetSdkVersion to 29 2020-04-28 03:16:54 -04:00
Simon Chae
b28f7f286e [components] Closes https://github.com/mozilla-mobile/android-components/issues/6228: Expose allowedInPrivateBrowsing control 2020-04-20 15:55:40 -04:00
mcarare
dc9d3756e0 [components] For https://github.com/mozilla-mobile/android-components/issues/6593: Update content description when item has dot notification 2020-04-09 17:11:34 +03:00
Mihai Branescu
6bdc149aeb [components] For https://github.com/mozilla-mobile/android-components/issues/6308 - Added unit tests for all BrowserMenuItem.getHighlight scenarios 2020-03-20 14:05:26 +02:00
Mihai Branescu
c3f0515cc5 [components] For https://github.com/mozilla-mobile/android-components/issues/6308 - Added canPropagate param so that other components may opt out 
of displaying it (ex: three-dot menu can now hide the notification dot
for some items)
 2020-03-20 14:05:26 +02:00
mcarare
5fd60fd902 [components] For https://github.com/mozilla-mobile/android-components/issues/6137: Set BrowserMenuCategory padding same as other items in menu 2020-03-02 13:11:19 +02:00
MozLando
252c56a7a8 [components] Merge https://github.com/mozilla-mobile/android-components/pull/6103 
6103: For https://github.com/mozilla-mobile/android-components/issues/6102 - Use app:srcCompat instead of android:src r=gabrielluong a=ekager



Co-authored-by: ekager <ekager@mozilla.com>
 2020-02-27 23:32:41 +00:00
ekager
572b102758 [components] For https://github.com/mozilla-mobile/android-components/issues/6102 - Use app:srcCompat instead of android:src 2020-02-27 10:44:39 -08:00
Gabriel Luong
5ca4ae1b85 [components] Closes https://github.com/mozilla-mobile/android-components/issues/6033: Emit Facts for Web Extension Browser Menu 2020-02-26 13:54:38 -05:00
MozLando
3123137d99 [components] Merge https://github.com/mozilla-mobile/android-components/pull/6071 
6071: Closes https://github.com/mozilla-mobile/android-components/issues/6070: Mark badgeView invisible if it's null r=Amejia481 a=psymoon



Co-authored-by: Simon Chae <chaesmn@gmail.com>
 2020-02-26 02:34:50 +00:00
MozLando
2d2baccee3 [components] Merge https://github.com/mozilla-mobile/android-components/pull/6074 
6074: Closes https://github.com/mozilla-mobile/android-components/issues/6073: Adds animation to showPopupWhereBestFits menu r=Amejia481 a=sblatz



Co-authored-by: Sawyer Blatz <sdblatz@gmail.com>
 2020-02-25 22:16:39 +00:00
Sawyer Blatz
ab062468fb [components] Closes https://github.com/mozilla-mobile/android-components/issues/6073: Adds animation to showPopupWhereBestFits menu 2020-02-25 13:51:42 -08:00
Simon Chae
7c4ab1b7ee [components] Closes https://github.com/mozilla-mobile/android-components/issues/6070: Mark badgeView invisible if it's null 2020-02-25 11:28:34 -05:00
MozLando
e432f6f333 [components] Merge https://github.com/mozilla-mobile/android-components/pull/6055 
6055: For https://github.com/mozilla-mobile/fenix/issues/8706: Add padding to web-ext menu item badge text r=Amejia481 a=psymoon

https://github.com/mozilla-mobile/fenix/issues/8706

Co-authored-by: Simon Chae <chaesmn@gmail.com>
 2020-02-25 00:58:16 +00:00
MozLando
5c6fea154b [components] Merge https://github.com/mozilla-mobile/android-components/pull/6051 
6051: For https://github.com/mozilla-mobile/fenix/issues/8524 - Use SwitchCompat for BrowserMenuImageSwitch r=psymoon a=ekager



Co-authored-by: ekager <ekager@mozilla.com>
 2020-02-24 23:55:19 +00:00
Simon Chae
9f0cb6db89 [components] For https://github.com/mozilla-mobile/fenix/issues/8706: Add padding to web-ext menu item badge text 2020-02-24 18:53:16 -05:00
ekager
823b00f884 [components] For https://github.com/mozilla-mobile/fenix/issues/8524 - Use SwitchCompat for BrowserMenuImageSwitch 2020-02-24 13:33:32 -08:00
Arturo Mejia
808b7aa150 [components] Remove double background from mozac_browser_menu_web_extension 2020-02-24 15:57:15 -05:00
Simon Chae
e024da5bee [components] Closes https://github.com/mozilla-mobile/android-components/issues/6004: Show web ext badge in browser menu item 2020-02-20 11:17:24 -05:00
Christian Sadilek
cc1bbaaa99 [components] Closes https://github.com/mozilla-mobile/android-components/issues/5708: Browser/Page actions don't have stable ordering 2020-01-24 11:01:47 -05:00
Simon Chae
cd41fe6124 [components] Set web extension menu label clickable to false 2020-01-23 19:37:00 -05:00
Simon Chae
d4d7831a78 [components] For https://github.com/mozilla-mobile/android-components/issues/5572: Refactor web extension popup initialization 2020-01-23 19:36:58 -05:00
Tiger Oakes
4452fe5af8 [components] For https://github.com/mozilla-mobile/android-components/issues/5373 - Add menu candidate class 2020-01-22 19:50:04 -08:00
MozLando
66b907c26e [components] Merge https://github.com/mozilla-mobile/android-components/pull/5679 https://github.com/mozilla-mobile/android-components/pull/5683 https://github.com/mozilla-mobile/android-components/pull/5688 (part 3) 
5679: Closes https://github.com/mozilla-mobile/android-components/issues/5677: Catch all known non-fatal push errors r=grigoryk a=jonalmeida

Previously, we wanted to throw on all unknown push errors so that we
were notified on them. Since this seems to be more common than
originally expected, we should just catch them and in a future version,
we should log them without crashing.

All of these push errors can be considered recoverable except
for InternalPanic.




5683: Closes https://github.com/mozilla-mobile/android-components/issues/5682: Remove failedToLaunch property from AppLinksUseCases r=NotWoods a=rocketsroger



5688: Closes https://github.com/mozilla-mobile/android-components/issues/5684: Intermittent failures in WebExtensionBrowserMenuItemTest r=Amejia481,psymoon a=csadilek



Co-authored-by: Jonathan Almeida <jalmeida@mozilla.com>
Co-authored-by: Roger Yang <royang@mozilla.com>
Co-authored-by: Christian Sadilek <christian.sadilek@gmail.com>
 2020-01-23 02:15:20 +00:00
Christian Sadilek
905f4f2641 [components] Closes https://github.com/mozilla-mobile/android-components/issues/5684: Intermittent failures in WebExtensionBrowserMenuItemTest 2020-01-22 17:26:06 -05:00
Arturo Mejia
f035568ade [components] Closes https://github.com/mozilla-mobile/android-components/issues/4470 Wire up UI for page action support. 2020-01-22 11:44:19 -05:00
MozLando
daa11d1481 [components] Merge https://github.com/mozilla-mobile/android-components/pull/5651 
5651: Issue https://github.com/mozilla-mobile/android-components/issues/4470: Wire up API for page action support r=Amejia481 a=csadilek

Part 1: Bring in the engine and store API and wire it up.

Part 2 will be to add the action to our UIs (toolbar and browser menu) which we'll do separately.

Co-authored-by: Christian Sadilek <christian.sadilek@gmail.com>
 2020-01-20 22:53:46 +00:00
Christian Sadilek
70570d5ac2 [components] Issue https://github.com/mozilla-mobile/android-components/issues/4470: Wire up API for page action support 
- This is basically just a copy of our browser action API, with some
refactoring to make some types and methods generic
 2020-01-20 17:41:21 -05:00
Tiger Oakes
ee5372f81b [components] For https://github.com/mozilla-mobile/fenix/issues/7506 - Expose MenuButton 2020-01-16 17:44:49 -08:00
Simon Chae
215f44237e [components] For https://github.com/mozilla-mobile/fenix/pull/7517: Update menu container style to use 16dp padding 
Also allow mozac_browser_menu_web_extension to use "@style/Mozac.Browser.Menu.Item.Container"
 2020-01-16 14:37:51 -05:00
Simon Chae
d057441342 [components] Closes https://github.com/mozilla-mobile/android-components/issues/5355: Add web extension action browser-menu support 2020-01-16 10:50:50 -05:00
Eitan Isaacson
2f6b9f0331 [components] Provide full menu item count to accessibility services. 
We need to count buttons inside of toolbar items, and ignore dividers.

This fixes https://github.com/mozilla-mobile/fenix/issues/2143
 2020-01-09 16:02:38 -08:00
salvatorep
95b7cfdf88 [components] Added tooltips to browser toolbar images when long pressed 2019-12-31 10:05:18 +00:00
Tiger Oakes
fe50c6d630 [components] Add BrowserMenuHighlightableSwitch 2019-12-20 19:12:01 -08:00
Tiger Oakes
0fb42f90e2 [components] Add low priority menu highlight 2019-11-26 14:49:07 -08:00
mcarare
bfe614ecf1 [components] For https://github.com/mozilla-mobile/android-components/issues/3837 & https://github.com/mozilla-mobile/android-components/issues/3276: Vertically align elements in HighlightableMenuItem 2019-11-01 15:26:56 +02:00
MozLando
42ec8887ff [components] Merge https://github.com/mozilla-mobile/android-components/pull/4806 
4806: For https://github.com/mozilla-mobile/android-components/issues/4804 Fix RTL issues r=Amejia481 a=mcarare



Co-authored-by: mcarare <mihai.carare.dev@gmail.com>
 2019-10-22 18:34:12 +00:00
MozLando
4bd0e28e75 [components] Merge https://github.com/mozilla-mobile/android-components/pull/4748 
4748: For https://github.com/mozilla-mobile/android-components/issues/4747 Added menu animations for RTL layout direction r=Amejia481 a=mcarare



Co-authored-by: mcarare <mihai.carare.dev@gmail.com>
 2019-10-22 18:06:01 +00:00
Sebastian Kaspari
11c1e9cbdf [components] Issue https://github.com/mozilla-mobile/android-components/issues/1514: Update unit tests. 2019-10-22 11:47:36 -04:00
mcarare
4872e38421 [components] For https://github.com/mozilla-mobile/android-components/issues/4804 Improve menu items to support RTL 2019-10-21 17:32:19 +03:00
mcarare
6c211d23e4 [components] For https://github.com/mozilla-mobile/android-components/issues/4747 Added menu animations for RTL layout direction 2019-10-16 18:13:50 +03:00
mcarare
ec89853ae2 [components] For https://github.com/mozilla-mobile/android-components/issues/4560 Added BrowserMenuCategory menu item 2019-10-16 11:03:18 +03:00
ssaqua
69ea3c04e7 [components] For https://github.com/mozilla-mobile/android-components/issues/4672: Fix background ripple of Switch in BrowserMenuImageSwitch 2019-10-11 17:02:21 +02:00
Tiger Oakes
43728082d4 [components] Fix double-focus in browser menu 2019-10-04 21:35:52 -07:00
Tiger Oakes
08dc3db810 [components] Uplift Theme.resolveAttribute from Fenix 2019-09-26 07:40:39 -07:00
Denys M
b95c932f81 [components] For https://github.com/mozilla-mobile/android-components/issues/4460. Fix detekt warning about license in project files. 2019-09-24 01:01:03 +04:00
Mihai Adrian
813d7cba13 [components] Update mozac_browser_menu_item_image_switch.xml 2019-09-18 19:45:55 +03:00
mihai-adrian
dca01ea0ea [components] For https://github.com/mozilla-mobile/android-components/issues/3715 Support adding icon to a BrowserMenuSwitch 
Added BrowserMenuImageSwitch, a BrowserMenuSwitch with added icon.
No paddingEnd for switch cause it would leave to much empty space.
Added changelog entry
 2019-09-16 10:34:57 +03:00
Sawyer Blatz
53f4f0144f [components] No issue: Updates HighlightableMenuItem to allow startImage 2019-08-27 19:30:26 -04:00
mihai-adrian
a271be7a99 [components] Fixes https://github.com/mozilla-mobile/android-components/issues/4174 setting setUseCompatPadding to allow for padding on CardView 
setUseCompatPadding = true adds same padding values on all platforms>21
 2019-08-21 17:46:11 +03:00
Sawyer Blatz
38469fcf58 [components] Closes https://github.com/mozilla-mobile/android-components/issues/3990: Update specs of browser menu 2019-08-13 11:36:12 +02:00
Tiger Oakes
5377ef2f1a [components] Closes https://github.com/mozilla-mobile/android-components/issues/4004 - Increase limit for LongMethod rule 2019-08-02 13:34:17 -04:00
Sawyer Blatz
e31b10e1e1 [components] For https://github.com/mozilla-mobile/android-components/issues/3838: Adds selectableItemBackground to HighlightableMenuitem 2019-08-01 15:48:51 -07:00
Tiger Oakes
8b15550b24 [components] Replaced View.forEach with Android KTX 2019-07-23 12:29:55 -04:00
Tiger Oakes
b58e5f1e47 [components] Add helper for one-time OnGlobalLayoutListener 2019-07-15 10:10:05 -04:00
Arturo Mejia
6b2466ab7e [components] Closes https://github.com/mozilla-mobile/android-components/issues/3211: Support endOfMenuAlwaysVisible for Android 6 and below. 2019-06-26 15:10:34 -07:00
Tiger Oakes
e5b6e27420 [components] Fixes https://github.com/mozilla-mobile/android-components/issues/2605 - Replace pxToDp with dpToPx 2019-06-25 06:05:10 -07:00
Nikit Bhandari
eda43fe989 [components] Fixes https://github.com/mozilla-mobile/android-components/issues/3509: remove redundant qualifier 2019-06-23 15:32:52 -04:00
Tiger Oakes
0621656720 [components] Closes https://github.com/mozilla-mobile/android-components/issues/3101 - Support highlighting menu button 2019-06-14 07:42:29 -07:00
Denys M
1f8fc3fa5b [components] For https://github.com/mozilla-mobile/android-components/issues/1481. Enable unit test binary resources globally. 
Excluded few modules.
 2019-06-13 09:29:52 +02:00
Arturo Mejia
dc5ade9e8a [components] Closes https://github.com/mozilla-mobile/android-components/issues/3211: Added endOfMenuAlwaysVisible to BrowserMenu.show. 2019-06-11 10:09:50 -04:00
Denys M
89dd2a7983 [components] For https://github.com/mozilla-mobile/android-components/issues/1481. Use androidx runner in browser-menu. 2019-06-11 12:38:45 +02:00
Arturo Mejia
f68edb1c88 [components] Closes https://github.com/mozilla-mobile/android-components/issues/2916: Improve BrowserMenu popup orientation. 2019-06-07 14:59:50 -04:00
Tiger Oakes
035bedf336 [components] Fixes https://github.com/mozilla-mobile/android-components/issues/3032 - Add animation for browser-menu 2019-06-05 13:27:47 -07:00
Tiger Oakes
a59e0a0dfb [components] Remove overscroll effect in menu 
Fixes https://github.com/mozilla-mobile/fenix/issues/1634
Normal overflow menus have no overscroll effect, and the effect here
didn't align with the edges of the menu anyways.
 2019-05-28 07:14:01 -07:00
Sawyer Blatz
dd38c53128 [components] For https://github.com/mozilla-mobile/android-components/issues/3100: Adds highlightable menu item 2019-05-23 15:23:23 -07:00
Denys M
b001dcf37f [components] For https://github.com/mozilla-mobile/android-components/issues/2346. Enable kotlin warningsAsErrors for browser-menu module. 2019-05-22 09:01:24 -04:00
Tiger Oakes
2efff816d1 [components] Issue https://github.com/mozilla-mobile/android-components/issues/170: Change to invalidate pattern 
Updates samples to show usage of the toolbar.invalidateActions() pattern
 2019-05-21 14:55:33 -04:00
Tiger Oakes
f980fdf3c1 [components] Closes https://github.com/mozilla-mobile/android-components/issues/169, https://github.com/mozilla-mobile/android-components/issues/170: Dynamically update items 
Adds the ability to dynamically update BrowserMenuItemToolbar buttons
by updating an observer. Additionally makes the single state buttons'
disabled state controlled through a lambda, similar to the
TwoStateButton.
 2019-05-21 14:55:33 -04:00
Sebastian Kaspari
5c54ec453d [components] Closes https://github.com/mozilla-mobile/android-components/issues/842: Migrate from support libraries to AndroidX. 2019-05-02 16:08:55 +02:00
Sawyer Blatz
bb6e56a38c [components] Closes https://github.com/mozilla-mobile/android-components/issues/2674: Adds facts to custom tabs 2019-04-16 19:51:52 +02:00
ekager
9cfc0c7732 [components] Close https://github.com/mozilla-mobile/android-components/issues/2201 - Adds TwoStateButton in BrowserMenuItemToolbar 2019-03-12 19:01:17 +01:00
Sawyer Blatz
d1a5af71d1 [components] Closes https://github.com/mozilla-mobile/android-components/issues/2316: Adding textSize parameter to SimpleBrowserMenuItem. 2019-03-11 14:35:01 -07:00
Emily Kager
eac37b6338 [components] Closes https://github.com/mozilla-mobile/android-components/issues/2235 - Removes redundant BrowserMenuImageText contentDescription 2019-03-06 10:51:54 +01:00
Eitan Isaacson
972c443fe1 [components] Closes https://github.com/mozilla-mobile/android-components/issues/2236: BrowserMenuImageText's TextView should be have importantForAccessibility set to off. 2019-03-04 10:32:56 -05:00
Sawyer Blatz
cf1d18ed6d [components] Closes https://github.com/mozilla-mobile/android-components/issues/2028: Adds textColor to menu items 2019-02-26 08:23:16 -08:00
Sawyer Blatz
674e1cd49a [components] Closes https://github.com/mozilla-mobile/android-components/issues/2024: Adds theming to menu background 2019-02-22 10:57:19 -08:00
Jonathan Almeida
29dcfbff61 [components] Closes https://github.com/mozilla-mobile/android-components/issues/1913: Make text in BrowserMenuImageText unclickable 2019-02-01 04:13:26 -05:00
Jonathan Almeida
5482f932d1 [components] Closes https://github.com/mozilla-mobile/android-components/issues/1398: Add menu items to Custom Tab Toolbar 2019-01-22 20:27:11 -05:00
Sebastian Kaspari
89b012ef0f [components] Issue https://github.com/mozilla-mobile/android-components/issues/1744:: BrowserMenu.determineMenuOrientation(): Wrap bit masking. 2019-01-18 19:05:51 +01:00
Arturo Mejia
d9b55396d7 [components] Adding sample code for menu customization to Sample Toolbar app. 2019-01-18 11:35:16 -05:00
Arturo Mejia
4eda4eb706 [components] Refactoring all common text styles in browser text menus into a Style. 2019-01-18 11:35:16 -05:00
Arturo Mejia
02123b559d [components] Closes https://github.com/mozilla-mobile/android-components/issues/1544: Added support for image and text in browser menus. 2019-01-18 11:35:16 -05:00
Sebastian Kaspari
f9b741819b [components] Closes https://github.com/mozilla-mobile/android-components/issues/1744: Support "UP" and "DOWN" orientations in browser-menu (supporting bottom toolbars). 2019-01-18 17:07:50 +01:00
Arturo Mejia
bdb2cdbf59 [components] Closes https://github.com/mozilla-mobile/android-components/issues/1545 - Add support for menu dividers. 2019-01-17 10:29:56 +01:00
Arturo Mejia
6f7550cbb0 [components] Closes https://github.com/mozilla-mobile/android-components/issues/1712: Added docs for customizing BrowserMenu. 2019-01-16 12:10:55 -05:00
Arturo Mejia
d65452df54 [components] Refactoring PromptsFeature 2019-01-16 10:32:29 -05:00
Sebastian Kaspari
48096d68bf [components] BrowserMenuItemToolbar: Allow overriding isVisible lambda. 2019-01-11 15:18:12 +01:00
Mitchell Hentges
8fd19cdf3a [components] Moves description to be part of project.ext 2019-01-11 10:08:32 +01:00
Mitchell Hentges
3ee4d96a84 [components] Reads componentsVersion from .buildconfig.yml 2019-01-11 10:08:32 +01:00
Jonathan Almeida
8abe869152 [components] Closes https://github.com/mozilla-mobile/android-components/issues/1603: Add switch menu item 2019-01-02 11:43:25 -05:00
Jonathan Almeida
778cc01c54 [components] Closes https://github.com/mozilla-mobile/android-components/issues/1577: Request Desktop checkbox doesn't show selected state 2018-12-18 16:20:53 -05:00
ali-abdullah
89f3263d12 [components] included buildSrc in ktlint and detekt checks 2018-11-16 12:40:04 +01:00
Sebastian Kaspari
4fcc11ef9b [components] Issue https://github.com/mozilla-mobile/android-components/issues/404: Build with and target SDK 28 (+ update support libraries) 
* Build with and target SDK 28.
* Use Robolectric 4.0-alpha-3.
* Update support libraries to 28.0.0.
* .travis.yml: Update platform version.
 2018-11-15 18:12:42 +01:00
Sebastian Kaspari
53b3d1a71f [components] Update repository information in README files. 2018-10-25 15:37:46 +02:00
Sebastian Kaspari
9e17b84339 [components] Simplify build configuration. 2018-10-24 10:21:12 +02:00
Johan Lorenzo
0ca864a1bf [components] Stop Bintray. Update {group,artifact}Ids. Remove massage task 2018-10-22 14:35:51 +02:00
Wajahat Karim
ed0729232c [components] Closes https://github.com/mozilla-mobile/android-components/issues/922: Update READMEs to point to maven.mozilla.org and use new artifact names. 2018-10-03 09:20:43 +02:00
Sebastian Kaspari
95cbd85360 [components] Revert "Issue https://github.com/mozilla-mobile/android-components/issues/404: Build with and target SDK 28 (+ update support libraries)" 
This reverts commit c5038c7fab.
 2018-09-26 15:39:38 +02:00
Sebastian Kaspari
68f864a763 [components] Issue https://github.com/mozilla-mobile/android-components/issues/404: Build with and target SDK 28 (+ update support libraries) 
* Build with and target SDK 28.
* Use Robolectric 4.0-alpha-3.
* Update support libraries to 28.0.0.
* .travis.yml: Update platform version.
 2018-09-25 10:05:55 +02:00
Subhrajyoti Sen
ebdd6e7711 [components] Resolve https://github.com/mozilla-mobile/android-components/issues/754: refactor View.dp() as Resources.pxToDp 2018-09-17 13:40:31 -04:00
Jonathan Almeida
be422f354a [components] Issue https://github.com/mozilla-mobile/android-components/issues/647: Desktop mode support 
Closes https://github.com/mozilla-mobile/android-components/issues/647
 2018-08-29 11:36:07 -04:00
Sebastian Kaspari
946410ca86 [components] Configure dependencies from buildSrc Kotlin code. 2018-08-21 11:16:21 -04:00
Angelo Rüggeberg
4e497962b0 [components] Closes https://github.com/mozilla-mobile/android-components/issues/291 - Unified lint warnings as error and fail on error 2018-07-03 14:29:55 -04:00
Sebastian Kaspari
b58dd3798a [components] Issue https://github.com/mozilla-mobile/android-components/issues/232: Add READMEs for every component and link them from the root README. 2018-05-28 17:33:12 +02:00