nagai/fune
3
0
Fork 0
forked from mirrors/gecko-dev
Code Pull requests Activity
694134 commits 1 branch 98 tags 6.4 GiB
Commit graph

156 commits

Author SHA1 Message Date
Mirko Brodesser
efbaffc13c Bug 1615581: part 19) Decouple UpdateSelectionCacheOnRepaintSelection from nsFrameSelection. r=jfkthame 
Differential Revision: https://phabricator.services.mozilla.com/D63482

--HG--
extra : moz-landing-system : lando
 2020-03-03 09:15:22 +00:00
Mirko Brodesser
2e40a7367b Bug 1615581: part 18) Move core of nsFrameSelection::HandleTableSelection to TableSelection::HandleSelection. r=jfkthame 
Differential Revision: https://phabricator.services.mozilla.com/D63481

--HG--
extra : moz-landing-system : lando
 2020-03-02 15:09:34 +00:00
Mirko Brodesser
4e70ce992b Bug 1615581: part 17) Correct style in nsFrameSelection::HandleTableSelection. r=jfkthame 
Differential Revision: https://phabricator.services.mozilla.com/D63480

--HG--
extra : moz-landing-system : lando
 2020-03-02 15:09:36 +00:00
Mirko Brodesser
b0148d9b7a Bug 1615581: part 16) Move nsFrameSelection::SelectRowOrColumn to TableSelection. r=jfkthame 
Differential Revision: https://phabricator.services.mozilla.com/D63324

--HG--
extra : moz-landing-system : lando
 2020-03-02 15:09:38 +00:00
Mirko Brodesser
88584c4608 Bug 1615581: part 15) Update style in nsFrameSelection::SelectRowOrColumn. r=jfkthame 
Differential Revision: https://phabricator.services.mozilla.com/D63323

--HG--
extra : moz-landing-system : lando
 2020-03-02 15:09:17 +00:00
Mirko Brodesser
b2c626c5ff Bug 1615581: part 14) Move SelectBlockOfCells to TableSelection. r=jfkthame 
Differential Revision: https://phabricator.services.mozilla.com/D63307

--HG--
extra : moz-landing-system : lando
 2020-03-02 15:09:19 +00:00
Mirko Brodesser
4b67e294f7 Bug 1615581: part 13) Move mDragSelectingCells to TableSelection. r=jfkthame 
Differential Revision: https://phabricator.services.mozilla.com/D63297

--HG--
extra : moz-landing-system : lando
 2020-03-02 15:09:22 +00:00
Mirko Brodesser
e8f4f2644a Bug 1615581: part 12) Decouple AddCellsToSelection from nsFrameSelection. r=jfkthame 
Simplifies reasoning about `nsFrameSelection` and allows to decouple
more code from it.

Differential Revision: https://phabricator.services.mozilla.com/D63296

--HG--
extra : moz-landing-system : lando
 2020-03-02 15:09:24 +00:00
Mirko Brodesser
7ee453e1fb Bug 1615581: part 11) Use free function SelectCellElement in AddCellsToSelection. r=jfkthame 
Differential Revision: https://phabricator.services.mozilla.com/D63295

--HG--
extra : moz-landing-system : lando
 2020-03-02 15:09:26 +00:00
Mirko Brodesser
eb1d4d2a75 Bug 1615581: part 10) Update style in nsFrameSelection::AddCellsToSelection. r=jfkthame 
Simplifies reviewing the following part.

Differential Revision: https://phabricator.services.mozilla.com/D63294

--HG--
extra : moz-landing-system : lando
 2020-03-02 15:09:29 +00:00
Narcis Beleuzu
44ec37a8cf Backed out 10 changesets (bug 1615581) for bustages on nsFrameSelection.cpp . CLOSED TREE 
Backed out changeset 47087b5b4e42 (bug 1615581)
Backed out changeset 1489a8cb97e9 (bug 1615581)
Backed out changeset 1f89d7b3668a (bug 1615581)
Backed out changeset ea9869a4fb04 (bug 1615581)
Backed out changeset 9678a5d6a970 (bug 1615581)
Backed out changeset 13fd32562d0c (bug 1615581)
Backed out changeset c3c657e53988 (bug 1615581)
Backed out changeset 5272f4d02c88 (bug 1615581)
Backed out changeset 83dbbfb4b4e8 (bug 1615581)
Backed out changeset 9aa0aef619ed (bug 1615581)
 2020-03-02 17:05:00 +02:00
Mirko Brodesser
523f549231 Bug 1617165: part 2) Rename nsFrameSelection::PostReason and PopReason. r=jfkthame 
Differential Revision: https://phabricator.services.mozilla.com/D63668

--HG--
extra : moz-landing-system : lando
 2020-03-02 13:48:24 +00:00
Mirko Brodesser
bbb9d9ba21 Bug 1615581: part 19) Decouple UpdateSelectionCacheOnRepaintSelection from nsFrameSelection. r=jfkthame 
Differential Revision: https://phabricator.services.mozilla.com/D63482

--HG--
extra : moz-landing-system : lando
 2020-03-02 10:25:56 +00:00
Mirko Brodesser
c5f6e249b8 Bug 1615581: part 18) Move core of nsFrameSelection::HandleTableSelection to TableSelection::HandleSelection. r=jfkthame 
Differential Revision: https://phabricator.services.mozilla.com/D63481

--HG--
extra : moz-landing-system : lando
 2020-03-02 10:25:54 +00:00
Mirko Brodesser
4a5e298cee Bug 1615581: part 17) Correct style in nsFrameSelection::HandleTableSelection. r=jfkthame 
Differential Revision: https://phabricator.services.mozilla.com/D63480

--HG--
extra : moz-landing-system : lando
 2020-03-02 10:25:51 +00:00
Mirko Brodesser
9cb478e6df Bug 1615581: part 16) Move nsFrameSelection::SelectRowOrColumn to TableSelection. r=jfkthame 
Differential Revision: https://phabricator.services.mozilla.com/D63324

--HG--
extra : moz-landing-system : lando
 2020-03-02 10:25:44 +00:00
Mirko Brodesser
6b59f98679 Bug 1615581: part 15) Update style in nsFrameSelection::SelectRowOrColumn. r=jfkthame 
Differential Revision: https://phabricator.services.mozilla.com/D63323

--HG--
extra : moz-landing-system : lando
 2020-03-02 10:25:41 +00:00
Mirko Brodesser
795f2590f4 Bug 1615581: part 14) Move SelectBlockOfCells to TableSelection. r=jfkthame 
Differential Revision: https://phabricator.services.mozilla.com/D63307

--HG--
extra : moz-landing-system : lando
 2020-03-02 10:59:37 +00:00
Mirko Brodesser
ee9cbbd1d4 Bug 1615581: part 13) Move mDragSelectingCells to TableSelection. r=jfkthame 
Differential Revision: https://phabricator.services.mozilla.com/D63297

--HG--
extra : moz-landing-system : lando
 2020-03-02 10:25:37 +00:00
Mirko Brodesser
49b48fa2d9 Bug 1615581: part 12) Decouple AddCellsToSelection from nsFrameSelection. r=jfkthame 
Simplifies reasoning about `nsFrameSelection` and allows to decouple
more code from it.

Differential Revision: https://phabricator.services.mozilla.com/D63296

--HG--
extra : moz-landing-system : lando
 2020-03-02 10:25:34 +00:00
Mirko Brodesser
2e1d8cdbbf Bug 1615581: part 11) Use free function SelectCellElement in AddCellsToSelection. r=jfkthame 
Differential Revision: https://phabricator.services.mozilla.com/D63295

--HG--
extra : moz-landing-system : lando
 2020-03-02 10:25:30 +00:00
Mirko Brodesser
e71876a917 Bug 1615581: part 10) Update style in nsFrameSelection::AddCellsToSelection. r=jfkthame 
Simplifies reviewing the following part.

Differential Revision: https://phabricator.services.mozilla.com/D63294

--HG--
extra : moz-landing-system : lando
 2020-03-02 10:25:27 +00:00
Sylvestre Ledru
ca6530131a Bug 1519636 - Reformat recent changes to the Google coding style r=Ehsan,kvark 
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D63787

--HG--
extra : moz-landing-system : lando
 2020-02-24 15:33:38 +00:00
Mirko Brodesser
34837d9fc2 Bug 1615581: part 9) Decouple SelectCellElement core from nsFrameSelection. r=jfkthame 
Allows to move `nsFrameSelection::AddCellsToSelection`, a caller of
`SelectCellElement, from `nsFrameSelection` to `TableSelection` in a
subsequent step.

Differential Revision: https://phabricator.services.mozilla.com/D63158

--HG--
extra : moz-landing-system : lando
 2020-02-20 15:03:26 +00:00
Mirko Brodesser
7b16ca222e Bug 1615581: part 8) Decouple CreateAndAddRange from nsFrameSelection. r=jfkthame 
Preparation to move `SelectCellElement` to `TableSelection`.

Differential Revision: https://phabricator.services.mozilla.com/D63157

--HG--
extra : moz-landing-system : lando
 2020-02-20 15:03:19 +00:00
Mirko Brodesser
8308badf1c Bug 1615581: part 7) Move UnselectCells to TableSelection. r=jfkthame 
Differential Revision: https://phabricator.services.mozilla.com/D63063

--HG--
extra : moz-landing-system : lando
 2020-02-20 14:06:30 +00:00
Mirko Brodesser
c308359bf2 Bug 1615581: part 6) Move GetFirstCellRange to TableSelection. r=jfkthame 
Differential Revision: https://phabricator.services.mozilla.com/D63061

--HG--
extra : moz-landing-system : lando
 2020-02-18 12:52:08 +00:00
Mirko Brodesser
ea6f268216 Bug 1615581: part 5) Move GetNextCellRange to TableSelection. r=jfkthame 
Differential Revision: https://phabricator.services.mozilla.com/D63060

--HG--
extra : moz-landing-system : lando
 2020-02-18 12:48:44 +00:00
Mirko Brodesser
63edde2d24 Bug 1615581: part 4) Declare GetFirstCellNodeInRange's range argument const. r=jfkthame 
Differential Revision: https://phabricator.services.mozilla.com/D62905

--HG--
extra : moz-landing-system : lando
 2020-02-18 12:29:07 +00:00
Mirko Brodesser
ed3750ee94 Bug 1615581: part 3) Rename mSelectingTableCellMode to mMode. r=jfkthame 
Differential Revision: https://phabricator.services.mozilla.com/D62904

--HG--
extra : moz-landing-system : lando
 2020-02-18 12:28:59 +00:00
Mirko Brodesser
7471880b9b Bug 1615581: part 2) Group table-cell-selection related members in common struct. r=jfkthame 
Simplifies reasoning about table-cell related code, because it's less
coupled with `nsFrameSelection`.

Differential Revision: https://phabricator.services.mozilla.com/D62903

--HG--
extra : moz-landing-system : lando
 2020-02-18 12:28:52 +00:00
Mirko Brodesser
f170973369 Bug 1615581: part 1) Rename TableSelection to TableSelectionMode. r=jfkthame 
See part 2) why this is necessary.

Differential Revision: https://phabricator.services.mozilla.com/D62902

--HG--
extra : moz-landing-system : lando
 2020-02-18 12:28:45 +00:00
Mirko Brodesser
4688607b42 Bug 1615581: part 0) Correct style around TableSelection usage. r=jfkthame 
Preparatory step for the following parts.

Differential Revision: https://phabricator.services.mozilla.com/D63058

--HG--
extra : moz-landing-system : lando
 2020-02-18 12:28:32 +00:00
Mirko Brodesser
3d79d25cdf Bug 1615304: part 1) Move nsFrameSelection::DeleteFromDocument to Selection. r=smaug 
Helps to clarify the role of `nsFrameSelection`.

Differential Revision: https://phabricator.services.mozilla.com/D62879

--HG--
extra : moz-landing-system : lando
 2020-02-14 10:58:06 +00:00
Simon Giesecke
b50347f917 Bug 1611415 - Prefer using std::move over forget. r=froydnj 
Differential Revision: https://phabricator.services.mozilla.com/D60980

--HG--
extra : moz-landing-system : lando
 2020-02-13 14:38:48 +00:00
shindli
91aa0518dd Backed out changeset 0c982bc69cb3 (bug 1611415) for causing build bustages in /builds/worker/workspace/build/src/obj-firefox/dist/include/nsCOMPtr CLOSED TREE 2020-02-12 20:13:29 +02:00
Simon Giesecke
f604a47fa5 Bug 1611415 - Applied FixItHints from mozilla-non-std-move. r=froydnj 
Differential Revision: https://phabricator.services.mozilla.com/D60980

--HG--
extra : moz-landing-system : lando
 2020-02-12 17:24:41 +00:00
Mirko Brodesser
ea1f257885 Bug 1614636: simplify arguments of nsFrameSelection::HandleClick. r=jfkthame 
Simplifies understanding its dependent methods.

Differential Revision: https://phabricator.services.mozilla.com/D62433

--HG--
extra : moz-landing-system : lando
 2020-02-11 15:12:26 +00:00
Mirko Brodesser
4a2c7022b1 Bug 1613378: part 6) Remove copy&pasted IsValidSelectionPoint function. r=smaug 
Differential Revision: https://phabricator.services.mozilla.com/D62039

--HG--
extra : moz-landing-system : lando
 2020-02-11 10:50:57 +00:00
Brindusan Cristian
a68356b907 Backed out 5 changesets (bug 1613378) for mochitest failures at test_general.html. CLOSED TREE 
Backed out changeset f38b806ee78b (bug 1613378)
Backed out changeset cee4bbabc4b5 (bug 1613378)
Backed out changeset e3a2ab6d7267 (bug 1613378)
Backed out changeset 6fe76439f1d3 (bug 1613378)
Backed out changeset f3baf3407cbe (bug 1613378)
 2020-02-11 12:27:49 +02:00
Mirko Brodesser
dd99b9338c Bug 1613378: part 6) Remove copy&pasted IsValidSelectionPoint function. r=smaug 
Differential Revision: https://phabricator.services.mozilla.com/D62039

--HG--
extra : moz-landing-system : lando
 2020-02-10 13:25:03 +00:00
Mirko Brodesser
ce8bf8cde1 Bug 1613378: part 4) Declare some methods in nsFrameSelection static. r=smaug 
Differential Revision: https://phabricator.services.mozilla.com/D62037

--HG--
extra : moz-landing-system : lando
 2020-02-07 16:13:27 +00:00
Mirko Brodesser
6c8a08fecb Bug 1613378: part 2) Remove unnecessary dependency from nsFrameSelection::GetCellLayout to mPresShell and declare it static. r=smaug 
Differential Revision: https://phabricator.services.mozilla.com/D61692

--HG--
extra : moz-landing-system : lando
 2020-02-07 09:24:43 +00:00
Mirko Brodesser
a205cfcd91 Bug 1613071: rename RangeData to StyledRange and move it to separate file. r=smaug 
Breaks the dependency from Selection.h. Allows reuse for Selection
across the Shadow DOM boundary, which will require styled ranges to be
stored in `DocumentOrShadowRoot` too.

Differential Revision: https://phabricator.services.mozilla.com/D61549

--HG--
extra : moz-landing-system : lando
 2020-02-05 09:12:23 +00:00
Cosmin Sabou
8833c36c14 Backed out changeset 6c68992f760e (bug 1613071) for build bustages on XPathGenerator.cpp 
CLOSED TREE
 2020-02-04 16:40:28 +02:00
Mirko Brodesser
b6e8bf3ef9 Bug 1613071: rename RangeData to StyledRange and move it to separate file. r=smaug 
Breaks the dependency from Selection.h. Allows reuse for Selection
across the Shadow DOM boundary, which will require styled ranges to be
stored in `DocumentOrShadowRoot` too.

Differential Revision: https://phabricator.services.mozilla.com/D61549

--HG--
extra : moz-landing-system : lando
 2020-02-04 14:14:03 +00:00
Masayuki Nakano
450b71f763 Bug 1612085 - part 1: Hide constructor of nsRange r=smaug 
`nsRange` instances are allocated a lot in the heap especially by editor and
spellchecker.  The allocation cost is too bad for benchmarks.  Therefore,
we should reuse released instances as far as possible.  For managing it in
static factory methods of `nsRange`, we need to hide `nsRange` constructor.

Differential Revision: https://phabricator.services.mozilla.com/D61237

--HG--
extra : moz-landing-system : lando
 2020-01-30 13:23:35 +00:00
Kousuke Takaki
04bba6950f Bug 1602088 - Move nsIScrollableFrame::ScrollUnit to namespace scope. r=botond 
Differential Revision: https://phabricator.services.mozilla.com/D61140

--HG--
extra : source : 69fded25adc2ac25e302b49c1128f8926e1311a3
 2020-01-30 09:13:19 +00:00
Cosmin Sabou
5a3d320cd0 Backed out changeset 69fded25adc2 (bug 1602088) for causing several box-shadow reftest failures. 
CLOSED TREE
 2020-01-30 13:23:10 +02:00
Kousuke Takaki
9681569b70 Bug 1602088 - Move nsIScrollableFrame::ScrollUnit to namespace scope. r=botond 
Differential Revision: https://phabricator.services.mozilla.com/D61140

--HG--
extra : moz-landing-system : lando
 2020-01-30 09:13:19 +00:00