nagai/fune
3
0
Fork 0
forked from mirrors/gecko-dev
Code Pull requests Activity
811513 commits 1 branch 98 tags 6.4 GiB
Commit graph

142 commits

Author SHA1 Message Date
Kagami Sascha Rosylight
102bd338be Bug 1695435 - Part 2: Add more words to the chrome script heuristic in use-isInstance r=preferences-reviewers,Gijs,webdriver-reviewers,whimboo,sgalich 
Differential Revision: https://phabricator.services.mozilla.com/D110932
 2022-08-24 22:47:42 +00:00
Kagami Sascha Rosylight
a41415cb68 Bug 1695435 - Part 1: Use isInstance in XUL files r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D154841
 2022-08-22 18:34:44 +00:00
André Bargull
60863b7187 Bug 1783404: Support --fix option when eslint-plugin-spidermonkey-js is used. r=tcampbell 
Differential Revision: https://phabricator.services.mozilla.com/D153843
 2022-08-12 06:10:55 +00:00
Max Smolens
8596bc0440 Bug 1617103 - Add documentation for yamllint. r=sylvestre DONTBUILD 
Differential Revision: https://phabricator.services.mozilla.com/D154108
 2022-08-09 19:13:45 +00:00
André Bargull
96daf134a0 Bug 1782491 - Part 1: Add self-hosted code environment plugin. r=tcampbell 
Adds a simple ESLint plugin for custom environments.

The plugin has a single exported value named `globals`, which is an object with
keys for all globally available self-hosted identifiers. All self-hosted values
are read-only, so we set all properties of `globals` to `"readonly"`.

BytecodeEmitter special identifiers are added to the `.eslintrc.js` file,
because that keeps them closer to the SpiderMonkey source tree when compared
to "tools/lint/eslint/eslint-plugin-spidermonkey-js".

Also see:
- tools/lint/eslint/eslint-plugin-mozilla/lib/environments/
- https://eslint.org/docs/latest/user-guide/configuring/language-options

Differential Revision: https://phabricator.services.mozilla.com/D153337
 2022-08-05 09:58:58 +00:00
Mark Banner
4ed899ee38 Bug 1782008 - Add existing test directories to the ESLint test path definition file. r=mossop 
Differential Revision: https://phabricator.services.mozilla.com/D152735
 2022-08-03 11:16:19 +00:00
Tooru Fujisawa
de340512f3 Bug 1779988 - Part 2: Add ESLint rule that rejects multiple ChromeUtils.defineESModuleGetters call on the same object. r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D152880
 2022-07-28 00:54:20 +00:00
Francesco Lodolo (:flod)
2d85581b2c Bug 1781010: Fluent linter, add checks for hard-coded brand names,r=gregtatum,linter-reviewers,sylvestre 
Differential Revision: https://phabricator.services.mozilla.com/D152718
 2022-07-26 19:48:08 +00:00
Tooru Fujisawa
5cda6987cf Bug 1780543 - Part 11: Update document for environment. r=Standard8 
Depends on D152648

Differential Revision: https://phabricator.services.mozilla.com/D152649
 2022-07-26 02:46:32 +00:00
Andrew Halberstadt
e818e28315 Bug 1780087 - Convert some searchfox links under 'docs/code-quality' to the new role, r=linter-reviewers,sylvestre 
This is more to demonstrate the use of the role than anything else.

Differential Revision: https://phabricator.services.mozilla.com/D152125
 2022-07-19 15:41:08 +00:00
Mark Banner
a869ce033b Bug 1779989 - Explicitly disallow ES modules in ESLint import-globals-from statements. r=arai 
Differential Revision: https://phabricator.services.mozilla.com/D152002
 2022-07-19 05:57:15 +00:00
Tooru Fujisawa
c26c3f5551 Bug 1667455 - Part 14: Stop importing Services.jsm in documents. r=kmag,necko-reviewers,dragana 
Differential Revision: https://phabricator.services.mozilla.com/D150903
 2022-07-11 12:41:54 +00:00
Mark Banner
6cc792275f Bug 1777451 - Add a rule to prevent/recommend against using globalThis or window in non-system modules for lazy getters. r=arai 
Differential Revision: https://phabricator.services.mozilla.com/D151083
 2022-07-06 08:35:59 +00:00
Mark Banner
e3f245f121 Bug 1764513 - Update ESLint docs for how to set up test configuration and how to use ES modules. r=arai 
Differential Revision: https://phabricator.services.mozilla.com/D151039
 2022-07-05 17:09:43 +00:00
Tooru Fujisawa
8cc73badc6 Bug 1776837 - Part 2: Reject defining lazy getter for module that is already loaded eagerly at top-level. r=mossop 
Depends on D150935

Differential Revision: https://phabricator.services.mozilla.com/D150936
 2022-07-05 01:01:35 +00:00
Mark Banner
05e3f1ea83 Bug 1646183 - Extend ESLint rule reject-importGlobalProperties to also handle defineLazyGlobalGetters. r=arai,webdriver-reviewers,webcompat-reviewers,extension-reviewers,whimboo,twisniewski,kmag 
Differential Revision: https://phabricator.services.mozilla.com/D150353
 2022-06-29 22:37:57 +00:00
Makoto Kato
93e0a3fccb Bug 1776804 - Update spotless information in firefox-source-docs. r=geckoview-reviewers,agi 
"Google Java Format plug-in" link is broken now.

Also we should add spotless information to
https://firefox-source-docs.mozilla.org/code-quality/.

Differential Revision: https://phabricator.services.mozilla.com/D150440
 2022-06-28 22:58:11 +00:00
Kagami Sascha Rosylight
39d7ee6f91 Bug 1773740 - Part 3: Cover js files including ChromeUtils r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D148938
 2022-06-27 20:31:33 +00:00
Tooru Fujisawa
ab853db23f Bug 1773747 - Part 6: Add ESLint rule to check immediately-used lazy getter. r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D149867
 2022-06-24 11:03:53 +00:00
Tooru Fujisawa
81ada6ab87 Bug 1772358 - Add ESLint rule to reject defining lazy getters for always available modules. r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D149872
 2022-06-24 11:03:50 +00:00
Mark Banner
e4e8d3c73f Bug 1771173 - Add ESLint rule to check for correct usages of lazy. r=arai 
Differential Revision: https://phabricator.services.mozilla.com/D149718
 2022-06-21 20:42:16 +00:00
Tooru Fujisawa
088b6d97cd Bug 1771097 - Add ESLint rule for ChromeUtils.defineESModuleGetters lazy object name. r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D147400
 2022-06-17 04:59:13 +00:00
criss
8fc8ec5d8e Backed out 8 changesets (bug 1771092, bug 1768870, bug 1771097, bug 1769002, bug 1768819) for causing mochitest failures on browser_sendQuery.js. CLOSED TREE 
Backed out changeset 8a4d712f819a (bug 1771092)
Backed out changeset f4e27a35c83c (bug 1771092)
Backed out changeset 072323bc72cc (bug 1771092)
Backed out changeset 2ccf2a00fff7 (bug 1769002)
Backed out changeset ba7086fd9b1f (bug 1768819)
Backed out changeset 6205d3e2c666 (bug 1771097)
Backed out changeset 960f0aee97d5 (bug 1768870)
Backed out changeset 5f53760c5637 (bug 1768870)
 2022-06-17 05:44:37 +03:00
Tooru Fujisawa
c0ff62bb21 Bug 1771097 - Add ESLint rule for ChromeUtils.defineESModuleGetters lazy object name. r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D147400
 2022-06-17 01:30:23 +00:00
Mark Banner
8ca4d49d65 Bug 1766228 - Add an ESLint rule to ensure that member property accesses of Services are valid. r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D149393
 2022-06-16 21:11:24 +00:00
Molnar Sandor
c1ae6857f8 Backed out 9 changesets (bug 1769002, bug 1768870, bug 1771097, bug 1771092, bug 1768819) for causing lint failures. CLOSED TREE 
Backed out changeset 829df1dfad70 (bug 1769002)
Backed out changeset f0537d333adc (bug 1771092)
Backed out changeset 25b43856bc00 (bug 1771092)
Backed out changeset a49f754ca73f (bug 1771092)
Backed out changeset 164f85686a32 (bug 1769002)
Backed out changeset ef5cf9ceb915 (bug 1768819)
Backed out changeset c64e6c1fbfe7 (bug 1771097)
Backed out changeset f85393f988a8 (bug 1768870)
Backed out changeset fe708d13cc1d (bug 1768870)
 2022-06-16 20:15:14 +03:00
Tooru Fujisawa
a1c76f5683 Bug 1771097 - Add ESLint rule for ChromeUtils.defineESModuleGetters lazy object name. r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D147400
 2022-06-16 16:20:36 +00:00
Norisz Fay
7cd43cc697 Backed out 5 changesets (bug 1766228) for causing lint failures on test_restrequest.js CLOSED TREE 
Backed out changeset 5ff1634cfe18 (bug 1766228)
Backed out changeset 01642c97e7a5 (bug 1766228)
Backed out changeset cbba28151712 (bug 1766228)
Backed out changeset 76a32127865d (bug 1766228)
Backed out changeset 2c7ef1ad380a (bug 1766228)
 2022-06-16 16:36:44 +03:00
Mark Banner
1383258437 Bug 1766228 - Add an ESLint rule to ensure that member property accesses of Services are valid. r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D149393
 2022-06-16 12:09:28 +00:00
Tooru Fujisawa
2337bc5418 Bug 1772299 - Reject modification to globalThis inside system module. r=Standard8,webdriver-reviewers,jdescottes 
Differential Revision: https://phabricator.services.mozilla.com/D148116
 2022-06-15 22:20:53 +00:00
Ray Kraesig
4fc7f7613e Bug 1772856 - Clean up formatting r=sylvestre DONTBUILD 
Differential Revision: https://phabricator.services.mozilla.com/D148417
 2022-06-15 07:12:02 +00:00
Ray Kraesig
24e0619a0d Bug 1772856 - Add designated initializers to list of acceptable C++ features r=firefox-build-system-reviewers,bholley,glandium DONTBUILD 
Differential Revision: https://phabricator.services.mozilla.com/D148416
 2022-06-15 07:12:02 +00:00
Tooru Fujisawa
9975cd7318 Bug 1771751 - Reject static import for system module from non-system module. r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D149183
 2022-06-14 21:56:55 +00:00
Tooru Fujisawa
371b3c1d97 Bug 1607331 - Part 3: Reject global this usage in JSM. r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D148551
 2022-06-14 21:56:55 +00:00
Bobby Holley
99677cea83 Bug 1772234 - Update the style guide to deprecate rooting API typedefs. r=tcampbell 
Differential Revision: https://phabricator.services.mozilla.com/D148081
 2022-06-02 21:01:42 +00:00
Mark Banner
889c6efaf2 Bug 1768031 - Reject top-level await in modules via an ESLint rule. r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D145892
 2022-05-11 14:08:15 +00:00
Janvi Bajoria
c68c01937d Bug 1759754 - fix use the static preference API link in C++ coding style documentation r=KrisWright 
Differential Revision: https://phabricator.services.mozilla.com/D144191
 2022-05-10 17:26:31 +00:00
Tooru Fujisawa
231114fa17 Bug 1548308 - Remove modules.json. r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D145695
 2022-05-06 12:35:33 +00:00
Mathew Hodson
05c78de712 Bug 1630027 - Migrate RTL Guidelines from MDN. r=sylvestre DONTBUILD 
Differential Revision: https://phabricator.services.mozilla.com/D142183
 2022-05-06 07:16:58 +00:00
Mathew Hodson
34e2ece16f Bug 1630027 - Migrate CSS Guidelines from MDN. r=sylvestre DONTBUILD 
Differential Revision: https://phabricator.services.mozilla.com/D142163
 2022-05-06 07:16:48 +00:00
Mathew Hodson
d83e906b06 Bug 1630027 - Migrate SVG Guidelines from MDN. r=sylvestre DONTBUILD 
Differential Revision: https://phabricator.services.mozilla.com/D142184
 2022-05-06 07:16:48 +00:00
Mark Banner
67e9352298 Bug 1766238 - Disallow more than one argument to ChromeUtils.import via ESLint. r=mossop 
Depends on D144562

Differential Revision: https://phabricator.services.mozilla.com/D144563
 2022-04-27 08:38:35 +00:00
Barret Rennie
c34d04e40e Bug 1765675 - Reject OS.Path usage in reject-osfile lint r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D144307
 2022-04-26 17:34:35 +00:00
Kagami Sascha Rosylight
7f736cdebf Bug 1703953 - Part 1: Implement mozilla/use-isinstance rule r=Gijs,Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D111354
 2022-04-06 11:57:56 +00:00
Mark Banner
a6d11f320d Bug 1760286 - Add missing docs for rules in eslint-plugin-mozilla. r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D142285
 2022-03-30 17:40:15 +00:00
Gijs Kruitbosch
4d3b6146b8 Bug 1753696 - use an eslint rule to switch to add_setup(), r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D139542
 2022-03-30 16:16:42 +00:00
Norisz Fay
acdd6851cd Backed out 2 changesets (bug 1753696) for causing multiple dt and bc failures CLOSED TREE 
Backed out changeset 67fd9edfbcea (bug 1753696)
Backed out changeset a9d957ea887b (bug 1753696)
 2022-03-30 12:17:55 +03:00
Gijs Kruitbosch
35d2a4ca12 Bug 1753696 - use an eslint rule to switch to add_setup(), r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D139542
 2022-03-30 08:18:51 +00:00
criss
4eec7e25a3 Backed out 3 changesets (bug 1703953) for causing multiple failures. CLOSED TREE 
Backed out changeset 871a1fac289e (bug 1703953)
Backed out changeset 8151244bda18 (bug 1703953)
Backed out changeset eaf6d4c353be (bug 1703953)
 2022-03-29 17:01:58 +03:00
Kagami Sascha Rosylight
cbfca993e7 Bug 1703953 - Part 1: Implement mozilla/use-isinstance rule r=Gijs,Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D111354
 2022-03-29 13:10:59 +00:00