Commit graph

3818 commits

Author SHA1 Message Date
Ben Hearsum
3e28c91b15 Bug 1743465: send additional information about existing installations in installation.first_seen Telemetry event. r=nalexander
This patch does two things:
1) Adds a few new pieces of information to the installation "first_seen" event. Specifically:
    * other_inst - true when any non-MSIX installation other than the running one was present when this event was prepared
    * other_msix_inst - true when any MSIX installation other that the running one was present when this event was prepared
2) Begins sending this event for MSIX installations

Differential Revision: https://phabricator.services.mozilla.com/D134326
2022-01-20 23:34:52 +00:00
Barret Rennie
b7cb7d865e Bug 1747461 - Remove FileUtils.getFile from browser/modules r=bytesized
Differential Revision: https://phabricator.services.mozilla.com/D134899
2022-01-19 18:37:26 +00:00
William Lachance
af8f04a00d Bug 1746941 - Add tags to all Firefox-on-Glean metrics r=janerik
Based on our experience with Firefox for Android, annotating Glean metrics
with issue tracker component information can provide valuable context to
anyone searching for metrics.

This adds a new set of tags corresponding to the components in the
tree, annotates the existing Glean metrics. Finally, it also adds a new
mach command called `update-glean-tags` to update the tags files based
on build metadata.

Differential Revision: https://phabricator.services.mozilla.com/D134332
2022-01-14 18:11:08 +00:00
Sandor Molnar
c5d5f045aa Backed out changeset c0de94959204 (bug 1746941) for causing pythong unit test failures. CLOSED TREE 2022-01-14 18:59:04 +02:00
William Lachance
cf406dbbc9 Bug 1746941 - Add tags to all Firefox-on-Glean metrics r=janerik
Based on our experience with Firefox for Android, annotating Glean metrics
with issue tracker component information can provide valuable context to
anyone searching for metrics.

This adds a new set of tags corresponding to the components in the
tree, annotates the existing Glean metrics. Finally, it also adds a new
mach command called `update-glean-tags` to update the tags files based
on build metadata.

Differential Revision: https://phabricator.services.mozilla.com/D134332
2022-01-14 16:43:08 +00:00
Gijs Kruitbosch
3c19578956 Bug 1735429 - tests, r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D128315
2022-01-14 00:31:07 +00:00
Hannah Peuckmann
f5c826b962 Bug 1745389 - Split up SecuritySettingsCleaner. r=geckoview-reviewers,pbz,keeler,jonalmeida
Differential Revision: https://phabricator.services.mozilla.com/D134119
2022-01-13 15:04:05 +00:00
Magnus Melin
f7e5c723cb Bug 1646160 - make notificationbox labels Fluent capable. r=mstriemer
Differential Revision: https://phabricator.services.mozilla.com/D134375
2022-01-05 21:02:14 +00:00
Drew Willcoxon
996a2cafe4 Bug 1747973 - Cache the top-sites query context like we cache other contexts. r=harry
This caches the top-sites context like we cache other contexts. The cache is
cleared when the top sites change or are enabled/disabled.

Unlike other contexts, which are evicted from the cache once too many newer
contexts are cached, the top-sites context is never evicted due to space reasons
because showing the top sites is a frequent action.

I wanted to keep the logic around when/whether the top sites have changed or
been enabled/disabled isolated to the top-sites provider, since it's the class
concerned with top sites in the first place, instead of spreading it out to
`QueryContextCache`. However, by the same token I didn't want to cache contexts
directly in the provider in order to keep all context caching in
`QueryContextCache`. (Contexts are also per window/urlbar, not global, so if we
were to cache contexts in the provider, we'd need to store them in map from
windows to contexts or something similar.)

So I added a more general listener system to the provider. Listeners are called
when the top sites change or they are enabled/disabled. `QueryContextCache` adds
a listener function so it can evict its cached top-sites context. The provider
keeps weak references to the listener functions because currently `UrlbarView`
doesn't have a way to tell when it's destroyed, so it doesn't know when it
should remove listeners.

Finally, there doesn't seem to be a way to observe the `TopSitesFeed` from the
outside, and I don't think it's the role of `TopSitesFeed` to broadcast an
observer message to the entire browser or something like that, so I modified
`AboutNewTab` to subscribe to changes in its activity stream object and then
compare the new top sites to the last seen top sites, and if they're different,
then broadcast a new "newtab-top-sites-changed" notification.

Differential Revision: https://phabricator.services.mozilla.com/D134863
2022-01-03 19:18:54 +00:00
Iulian Moraru
b805b8a1cc Backed out changeset df6f22573bb0 (bug 1745495) for causing multiple leaks. CLOSED TREE 2021-12-22 15:00:31 +02:00
Brendan Dahl
efbcfe5c99 Bug 1745495 - Don't initialize activity stream when new tab is disabled. r=daleharvey
This will also load activity stream if the pref is enabled again.

Differential Revision: https://phabricator.services.mozilla.com/D133541
2021-12-22 09:10:05 +00:00
Neil Deakin
791ec344f3 Bug 1745272, remove soon to expire subframe crash telemetry, r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D134187
2021-12-18 11:05:21 +00:00
Toshihito Kikuchi
baa43db813 Bug 1743663 - Remove windowContext.hasActivePeerConnections. r=peterv
TabUnloader.jsm can directly call windowGlobal.hasActivePeerConnections(),
so windowContext.hasActivePeerConnections is not needed.

Differential Revision: https://phabricator.services.mozilla.com/D132654
2021-12-16 16:14:13 +00:00
Chris H-C
a1187db712 Bug 1715542 - Give Glean and GleanPings a BackstagePass r=janerik,application-update-reviewers,nalexander
Differential Revision: https://phabricator.services.mozilla.com/D131824
2021-12-14 20:51:03 +00:00
Mike Conley
f6d6ef9e42 Bug 1745267 - Add new TabSwitched event to AsyncTabSwitcher. r=dthayer
Differential Revision: https://phabricator.services.mozilla.com/D133672
2021-12-14 14:33:11 +00:00
Chris H-C
59f494d61a Bug 1742133 - Expose FOG service as Services.fog and convert uses r=janerik
Differential Revision: https://phabricator.services.mozilla.com/D132742
2021-12-08 21:18:19 +00:00
Edgar Chen
be408c368a Bug 1742714 - Get rid of nsIFormSubmitObserver; r=geckoview-reviewers,agi,smaug
Differential Revision: https://phabricator.services.mozilla.com/D132091
2021-12-06 12:23:08 +00:00
Punam Dahiya
00d26b7582 Bug 1740377 - Update More From Mozilla section inside about:preferences to use new UI template r=preferences-reviewers,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D131560
2021-12-03 20:30:52 +00:00
Joel Maher
63bf096aef Bug 1743907 - Remove webrender annotation from manifestparser manifests. r=ahal,webdriver-reviewers,whimboo
Differential Revision: https://phabricator.services.mozilla.com/D132682
2021-12-03 16:04:29 +00:00
Chris H-C
3b5d233474 Bug 1741674 - Use the new fog_test_reset_fog method to clear data before instrumentation tests r=janerik
Differential Revision: https://phabricator.services.mozilla.com/D131703
2021-11-22 20:07:39 +00:00
Chris H-C
5ee0631774 Bug 1741674 - Record active_ticks and uri_count in Glean as well as Telemetry r=TravisLong
Differential Revision: https://phabricator.services.mozilla.com/D131641
2021-11-22 20:07:38 +00:00
Toshihito Kikuchi
599a77edff Bug 1734099 - Never unload tabs with active RTCPeerConnection instances. r=peterv,jesup
This patch makes sure the Tab Unloading feature does not unload tabs that have
active peer connections not to disrupt browsing experience based on WebRTC peer
connections.

To enable JS code to access the number of active peer connections, this patch
moves `nsPIDOMWindowInner::mTotalActivePeerConnections` to `WindowGlobalParent`.

Differential Revision: https://phabricator.services.mozilla.com/D128761
2021-11-18 22:59:12 +00:00
Emilio Cobos Álvarez
e97b882edc Bug 1739539 - Rename titlebar pref and add migration from old pref. r=mconley
Something like this ought to do?

Differential Revision: https://phabricator.services.mozilla.com/D130858
2021-11-10 21:17:32 +00:00
Punam Dahiya
eaeec96d4b Bug 1738187 - Add telemetry for MoreFromMozilla section inside about:preferences r=preferences-reviewers,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D130409
2021-11-09 21:53:02 +00:00
Haik Aftandilian
1f882ebd64 Bug 1737085 - Mac browser_TabUnloader.js Nightly as Beta test failure r=spohl
Test-only fix: pref-on tab unloading and memory-pressure notifications when the test is run on beta or release. Tab unloading and memory pressure notifications are limited to Nightly at this time.

Differential Revision: https://phabricator.services.mozilla.com/D129665
2021-10-28 15:34:31 +00:00
Toshihito Kikuchi
be8b495bbf Bug 1737860 - Make the minimum inactive duration configurable through pref. r=haik
For end-to-end testing, this value needs to be configurable.

Differential Revision: https://phabricator.services.mozilla.com/D129731
2021-10-28 02:37:02 +00:00
Gian-Carlo Pascutto
1605433b10 Bug 1738021 - Make sure to replace all dashes for Telemetry probes. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D129678
2021-10-27 19:29:55 +00:00
Jon Barson
cf47bf9cbf Bug 1632476 changed hostname for media permissions to include the port r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D128109
2021-10-21 11:56:35 +00:00
Emilio Cobos Álvarez
f317384568 Bug 1736518 - Make browser.tabs.drawInTitlebar a tri-state. r=stransky,Gijs
To more properly support Linux having a different default at runtime.

Expose the resolved value in appinfo for convenience, and use it in the
front-end as needed.

Differential Revision: https://phabricator.services.mozilla.com/D129004
2021-10-21 09:07:12 +00:00
Toshihito Kikuchi
16a8fe4d37 Bug 1729911 - Define minInactiveDurationInMS not to unload fresh tabs. r=NeilDeakin
Tab unloading should not unload "fresh" tabs i.e. tabs that were accessed
very recently, even though one of them was the least recently used tab.

To achieve it, this patch introduces the minimum inactive duration and we
prevent tabs that were accessed in the last period of that duration from
being unloaded.

This patch sets the default value to 10 minutes based on the historgram
`TAB_UNLOAD_TO_RELOAD` where the median was 60sec and the 75th percentile
was 1040sec.  This value can be overriden by the parameter of the TabUnloader's
APIs so that about:unloads and the tests can unload those fresh tabs.

Differential Revision: https://phabricator.services.mozilla.com/D125824
2021-10-20 23:22:57 +00:00
Joel Maher
fed2831742 Bug 1727943 - turn on mochitest* tests that were skipped on win10-ccov and now pass. r=MasterWayZ
Differential Revision: https://phabricator.services.mozilla.com/D128817
2021-10-19 20:01:29 +00:00
Bobby Holley
2898f5a9dd Bug 1736438 - Fix import for sendStandalonePing. r=nanj
I'm not actually sure how to test this, given that it passed on CI. But
the fix seems simple enough.

Differential Revision: https://phabricator.services.mozilla.com/D128787
2021-10-18 19:52:59 +00:00
Bobby Holley
9dec540173 Bug 1734262 - Hoist standalone telemetry ping helper from PingCentre to TelemetrySend. r=chutten,nanj
I ended up writing more or less exactly this before discovering it.

Differential Revision: https://phabricator.services.mozilla.com/D127715
2021-10-16 16:29:29 +00:00
Michael Kohler
c84c59e032 Bug 1672486 - Remove browser.toolbars.bookmarks.2h2020 pref from browser/customizableui/places r=mak
Differential Revision: https://phabricator.services.mozilla.com/D127588
2021-10-14 07:51:14 +00:00
Noemi Erli
abf9ab56bc Backed out 5 changesets (bug 1734262) for causing failures in test_HealthPing.js CLOSED TREE
Backed out changeset c3b0edc896e9 (bug 1734262)
Backed out changeset a6ecb9d9697a (bug 1734262)
Backed out changeset 1e4cafb39d62 (bug 1734262)
Backed out changeset 19eb67d15f2a (bug 1734262)
Backed out changeset 845c7749c2c3 (bug 1734262)
2021-10-12 21:46:19 +03:00
Paul Zuehlcke
d3c5057f4f Bug 1733073 - Updated requestStorageAccess permission doorhanger tests. r=johannh
- Updated PermissionUI prompt test to also test permission states for prompts which do not use the permission manager
- Also do permission panel checks in storageAccessDoorhanger for block state

Differential Revision: https://phabricator.services.mozilla.com/D127962
2021-10-12 17:48:14 +00:00
Paul Zuehlcke
01c38b4d38 Bug 1733073 - Update StorageAccessPermissionPrompt to use 3rdPartyStorage permission. r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D127961
2021-10-12 17:48:14 +00:00
Bobby Holley
24751c0dde Bug 1734262 - Hoist standalone telemetry ping helper from PingCentre to TelemetrySend. r=nanj
I ended up writing more or less exactly this before discovering it.

Differential Revision: https://phabricator.services.mozilla.com/D127715
2021-10-12 17:31:19 +00:00
Toshihito Kikuchi
6943ad1b55 Bug 1733002 - Never discard tabs playing sound, using WebRTC, or using PiP. r=haik
Differential Revision: https://phabricator.services.mozilla.com/D127141
2021-10-05 08:04:04 +00:00
Dão Gottwald
f7bcee9115 Bug 1733345 - Move theme modules into browser/themes/. r=harry
Differential Revision: https://phabricator.services.mozilla.com/D127090
2021-10-04 15:05:54 +00:00
Mirko Brodesser
c61c10a2ce Bug 1731994: part 8) Rename nsIContentPermissionRequest's isHandlingUserInput to hasValidTransientUserGestureActivation. r=edgar
It's more accurate.

Differential Revision: https://phabricator.services.mozilla.com/D126916
2021-10-04 12:16:00 +00:00
Mirko Brodesser
b0b4e0cd28 Bug 1731994: part 5) Rename ContentPermissionRequestParent::mMaybeUnsafePermissionDelegate to ContentPermissionRequestParent::mIsRequestDelegatedToUnsafeThirdParty. r=johannh
This seems clearer. "Is" is more precise then "maybe".

Differential Revision: https://phabricator.services.mozilla.com/D126502
2021-09-30 08:19:28 +00:00
Michelle Goossens
c159e29e05 Bug 1727943 - Part 2: Migrate mochitest, reftest and crashtest Windows 10 ccov suites from AWS to Azure r=jmaher
Differential Revision: https://phabricator.services.mozilla.com/D125350
2021-09-28 15:27:39 +00:00
Gijs Kruitbosch
9ab5dbc4be Bug 1731665 - tests, r=NeilDeakin
Differential Revision: https://phabricator.services.mozilla.com/D124269
2021-09-27 14:00:16 +00:00
Mirko Brodesser
121d42b756 Bug 1731264: update documentation about PopupNotifications in PermissionsUI.jsm. r=pbz DONTBUILD
Differential Revision: https://phabricator.services.mozilla.com/D126081
2021-09-23 13:14:01 +00:00
Kirk Steuber
cacea3d12a Bug 1718444 - Convert nsIUpdateCheckListener to async r=nalexander,application-update-reviewers
I want to be able to check if the update-available notification is fired during testing. The entry point to firing that notification is UpdateService.onCheckComplete, but it currently kicks off its work and does not wait for it to finish. This means that I can wait for the update-available notification to be fired, but I cannot easily wait for it NOT to be fired, which is what I want to be able to test here.

It looks though like it should be easy enough to just convert this interface to an asynchronous one. This will make it much easier to call onCheckComplete and know by the end of it if the update-available notification gets fired or not.

Differential Revision: https://phabricator.services.mozilla.com/D126162
2021-09-21 23:57:22 +00:00
Mike Conley
b50fd4a2ec Bug 1707582 - Make browser_UsageTelemetry_interaction.js less susceptible to intermittent failure. r=mtigley,Gijs
This test was brittle for a few reasons:

1. The bookmarks toolbar is, by default, configured to show and hide
   depending on whether or not about:home/about:newtab is displayed.
   This meant that sometimes when trying to click on a bookmark
   toolbar item, a transition from the visible-to-collapsed or
   collapsed-to-visible state would be underway, and the click
   event would ultimately miss its mark.
2. The bookmarks toolbar also populates itself lazily, so the test has
   been adjusted to ensure that there are items in the toolbar before
   it attempts to click on one.

Differential Revision: https://phabricator.services.mozilla.com/D125761
2021-09-20 16:17:26 +00:00
Neil Deakin
9fc3821798 Bug 1690390, add a flag to limit telemetry collection for notification bars to just selected changes as we only want to measure shown state for the subframe crash one, r=mstriemer
Differential Revision: https://phabricator.services.mozilla.com/D125735
2021-09-17 09:05:00 +00:00
Neil Deakin
d3c5d06270 Bug 1690390, add ability to perform telemetry when a notification bar is shown, a button is pressed, or is dismissed. Use this for the subframe crash notification bar which currently does this a different way, r=mstriemer,chutten
Differential Revision: https://phabricator.services.mozilla.com/D107756
2021-09-17 09:04:59 +00:00
Neil Deakin
a62618baa7 Bug 1690390, change appendNotification to take a smaller number of arguments: the string type value, a dictionary containing the notification details, and the button list, r=mstriemer
Differential Revision: https://phabricator.services.mozilla.com/D107755
2021-09-17 09:04:59 +00:00