Commit graph

957 commits

Author SHA1 Message Date
Gijs Kruitbosch
f1911aef9a Bug 1718082 - track current tab using browserId instead of top browsing context id for network prioritization purposes, r=nika,mconley,necko-reviewers,kershaw,valentin
Differential Revision: https://phabricator.services.mozilla.com/D171646
2023-03-13 17:32:08 +00:00
Sean Feng
e62365a145 Bug 1820192 - Add a hint of ORB blocking to developer console r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D172263
2023-03-13 15:39:38 +00:00
Butkovits Atila
ac029a126f Backed out changeset 188db2f94c8e (bug 1809931) for causing failures at test_fetch_event.html. CLOSED TREE 2023-03-01 17:39:38 +02:00
Andreas Farre
4b69c300a0 Bug 1809931 - Explicitly check for top-level loads when running ORB. r=sefeng,necko-reviewers,valentin
With HTTPS-First top-level loads can have a loading principal, so we
need to explicitly check the load info if we're doing a top-level
load.

Differential Revision: https://phabricator.services.mozilla.com/D171315
2023-03-01 14:52:25 +00:00
Sean Feng
27084394a5 Bug 1809518 - Special case the HTTPS Only timeout request to make it bypass ORB r=farre,necko-reviewers
This particular request is used to identify the potential timeout issue
for HTTPS only requests. ORB doesn't need to block this request.

Differential Revision: https://phabricator.services.mozilla.com/D170251
2023-02-28 19:46:11 +00:00
Sean Feng
84f1835811 Bug 1809518 - Allow requests that are maded by devtools bypass ORB r=farre,necko-reviewers
Devtools use its own mainThreadFetch to fetch resources when it's
needed. For example, fetching the content of a source file. Importantly,
these request use `TYPE_OTHER` which could be blocked by ORB. Having
ORB block requests coming from devtools break some of it
functionalities.

Differential Revision: https://phabricator.services.mozilla.com/D170250
2023-02-28 19:46:11 +00:00
Marian-Vasile Laza
c39ea4a713 Backed out 15 changesets (bug 1809518) for wpt failures on navigation-headers.https.html.
Backed out changeset d245efcf2257 (bug 1809518)
Backed out changeset 3f29ad282371 (bug 1809518)
Backed out changeset 8f77fb0ddfef (bug 1809518)
Backed out changeset b1f9dcd5f147 (bug 1809518)
Backed out changeset eda8f3ef3fdb (bug 1809518)
Backed out changeset 85f4c2ca24e0 (bug 1809518)
Backed out changeset 92b774c122c9 (bug 1809518)
Backed out changeset b6e6065c79ff (bug 1809518)
Backed out changeset 724a5c7bba6a (bug 1809518)
Backed out changeset 224ccbc28c49 (bug 1809518)
Backed out changeset cc88d68be920 (bug 1809518)
Backed out changeset c02d3f25c880 (bug 1809518)
Backed out changeset 597cb423049d (bug 1809518)
Backed out changeset ae56071e154f (bug 1809518)
Backed out changeset 563403090c7f (bug 1809518)
2023-02-28 20:42:23 +02:00
Joshua Marshall
b0c912c415 Bug 1645054 - Disable/purge service workers when dom.serviceWorkers.enabled is false r=dom-worker-reviewers,necko-reviewers,asuth,webdriver-reviewers,whimboo
Differential Revision: https://phabricator.services.mozilla.com/D167550
2023-02-28 15:57:55 +00:00
Sean Feng
bfba867972 Bug 1809518 - Special case the HTTPS Only timeout request to make it bypass ORB r=farre,necko-reviewers
This particular request is used to identify the potential timeout issue
for HTTPS only requests. ORB doesn't need to block this request.

Differential Revision: https://phabricator.services.mozilla.com/D170251
2023-02-28 15:28:04 +00:00
Sean Feng
702eb65533 Bug 1809518 - Allow requests that are maded by devtools bypass ORB r=farre,necko-reviewers
Devtools use its own mainThreadFetch to fetch resources when it's
needed. For example, fetching the content of a source file. Importantly,
these request use `TYPE_OTHER` which could be blocked by ORB. Having
ORB block requests coming from devtools break some of it
functionalities.

Differential Revision: https://phabricator.services.mozilla.com/D170250
2023-02-28 15:28:04 +00:00
sunil mayya
3ae22e6d6f Bug 1817980 - replace ReferrerInfo::IsCrossOriginRequest with nsScriptSecurityManager::CheckSameOriginURI for determining cross-origin redirects. r=necko-reviewers,valentin
Since Bug 1802086, we strip authentication headers when redirected to a cross-origin page. However, the api   ReferrerInfo::IsCrossOriginRequest  used for determining whether a request is cross-origin cannot be used as it compares the triggering principal's uri with the redirected channel's uri. This comparison might sometimes yield to false positives.
For e.g consider the following scenario:
1. Load `https://example.org/` and send the following fetch request from browser console
```
fetch("https://test.com/some_location", {
  "headers": {
    "Authorization": "Token foo"
  }
});
```
2. Server responds with  a redirect to https://test.com/another_location

In the above scenario, the api ReferrerInfo::IsCrossOriginRequest  will yield the above request as cross origin since the triggering principal uri here is example.com. Hence, this will be treated as cross-origin redirect resulting in removal of auth headers.

Thus ReferrerInfo::IsCrossOriginRequest  has been replaced with nsScriptSecurityManager::CheckSameOriginURI  where we directly compare the origins for the two requests.

Differential Revision: https://phabricator.services.mozilla.com/D170868
2023-02-28 12:06:36 +00:00
Csoregi Natalia
47428da2d3 Backed out 8 changesets (bug 1809518) for causing fetch related failures. CLOSED TREE
Backed out changeset b448bddfa364 (bug 1809518)
Backed out changeset ce3a811a4522 (bug 1809518)
Backed out changeset f5add471e7f9 (bug 1809518)
Backed out changeset d2e6d1734eec (bug 1809518)
Backed out changeset 2299a5bdc7a9 (bug 1809518)
Backed out changeset 3eb92dc5aac9 (bug 1809518)
Backed out changeset 3061e4fbf237 (bug 1809518)
Backed out changeset 678468cb98cd (bug 1809518)
2023-02-23 04:33:37 +02:00
Sean Feng
4cfd97b195 Bug 1809518 - Special case the HTTPS Only timeout request to make it bypass ORB r=farre,necko-reviewers
This particular request is used to identify the potential timeout issue
for HTTPS only requests. ORB doesn't need to block this request.

Differential Revision: https://phabricator.services.mozilla.com/D170251
2023-02-22 20:17:04 +00:00
Sean Feng
7d217e6674 Bug 1809518 - Allow requests that are maded by devtools bypass ORB r=farre,necko-reviewers
Devtools use its own mainThreadFetch to fetch resources when it's
needed. For example, fetching the content of a source file. Importantly,
these request use `TYPE_OTHER` which could be blocked by ORB. Having
ORB block requests coming from devtools break some of it
functionalities.

Differential Revision: https://phabricator.services.mozilla.com/D170250
2023-02-22 20:17:03 +00:00
Cristian Tuns
ef9fa152c1 Backed out 8 changesets (bug 1809518) for causing build bustages on JSOracleChild.h CLOSED TREE
Backed out changeset 1057c5d5a0a5 (bug 1809518)
Backed out changeset 1ddffd079624 (bug 1809518)
Backed out changeset 3f43f1cd3e8b (bug 1809518)
Backed out changeset 16bd31105745 (bug 1809518)
Backed out changeset d86c04497104 (bug 1809518)
Backed out changeset 25a5bf657f5c (bug 1809518)
Backed out changeset bf67b8c14aa0 (bug 1809518)
Backed out changeset 5cc0653b2072 (bug 1809518)
2023-02-22 12:20:40 -05:00
Sean Feng
0c077ca87a Bug 1809518 - Special case the HTTPS Only timeout request to make it bypass ORB r=farre,necko-reviewers
This particular request is used to identify the potential timeout issue
for HTTPS only requests. ORB doesn't need to block this request.

Differential Revision: https://phabricator.services.mozilla.com/D170251
2023-02-22 14:07:48 +00:00
Sean Feng
a72b4cc41c Bug 1809518 - Allow requests that are maded by devtools bypass ORB r=farre,necko-reviewers
Devtools use its own mainThreadFetch to fetch resources when it's
needed. For example, fetching the content of a source file. Importantly,
these request use `TYPE_OTHER` which could be blocked by ORB. Having
ORB block requests coming from devtools break some of it
functionalities.

Differential Revision: https://phabricator.services.mozilla.com/D170250
2023-02-22 14:07:48 +00:00
Marian-Vasile Laza
3b94af9f92 Backed out changeset 06c46706c118 (bug 1645054) for marionette failures. CLOSED TREE 2023-02-16 18:21:05 +02:00
Joshua Marshall
f123641ebe Bug 1645054 - Disable/purge service workers when dom.serviceWorkers.enabled is false r=dom-worker-reviewers,necko-reviewers,asuth,webdriver-reviewers,whimboo
Differential Revision: https://phabricator.services.mozilla.com/D167550
2023-02-16 14:12:39 +00:00
Andreas Farre
e235fbcc4f Bug 1812051 - Add telemetry to count if ORB is ever used. r=smaug,necko-reviewers,valentin
Differential Revision: https://phabricator.services.mozilla.com/D169417
2023-02-16 10:07:01 +00:00
Kershaw Chang
179c96d6fb Bug 1755660 - Test progress notification with and without proxy r=necko-reviewers,valentin
Differential Revision: https://phabricator.services.mozilla.com/D153062
2023-02-09 16:55:09 +00:00
Yulia Startsev
1c5ad3e91d Bug 1247687 - Implement csp for Module Workers; r=evilpie,asuth,rpl,ckerschb
Depends on D155691

Differential Revision: https://phabricator.services.mozilla.com/D156102
2023-01-18 13:46:33 +00:00
sunil mayya
cb305f0962 Bug 1802086 - remove auth header from redirected cross-origin requests. r=necko-reviewers,smaug,valentin
The change also updates WPT based on the discussions here https://github.com/web-platform-tests/wpt/pull/37145/files#r1042166622

Differential Revision: https://phabricator.services.mozilla.com/D163904
2023-01-17 16:13:51 +00:00
Andreas Farre
dce97430cc Bug 1778135 - Add profile marker for ORB safelist check. r=necko-reviewers,smaug,kershaw
Differential Revision: https://phabricator.services.mozilla.com/D164569
2023-01-17 14:03:41 +00:00
Andreas Farre
5a0687b02f Bug 1804638 - Add telemetry probes to measure ORB JavaScript performance. r=necko-reviewers,smaug,sefeng,kershaw
Differential Revision: https://phabricator.services.mozilla.com/D164568
2023-01-17 14:03:41 +00:00
Nika Layzell
852d02ec16 Bug 1809753 - Part 3: Replace all callers of GetCurrentEventTarget with GetCurrentSerialEventTarget, r=mccr8,necko-reviewers,valentin
This only changes the behaviour when called with a TaskQueue or other type
using SerialEventTargetGuard on the stack. They are being switched over as the
existing GetCurrentEventTarget method is being removed, as it is somewhat
confusing, and poorly documented.

Callers which need to get the current thread even when on a threadpool or
behind a TaskQueue were switched to GetCurrentEventTarget in the previous part.

Differential Revision: https://phabricator.services.mozilla.com/D166607
2023-01-16 23:14:11 +00:00
Sandor Molnar
41b78439d0 Backed out 6 changesets (bug 1809752, bug 1809753) for causing perma failures in browser/components/firefoxview/tests/browser/browser_feature_callout_position.js
Backed out changeset ea05784d74c4 (bug 1809753)
Backed out changeset 7c9b20eebcc8 (bug 1809753)
Backed out changeset d0267ac2256d (bug 1809753)
Backed out changeset aa9f2971bd6f (bug 1809753)
Backed out changeset f0d9fcfaa6f8 (bug 1809752)
Backed out changeset 6d58c799cffe (bug 1809752)
2023-01-17 03:19:24 +02:00
Nika Layzell
8d118308de Bug 1809753 - Part 3: Replace all callers of GetCurrentEventTarget with GetCurrentSerialEventTarget, r=mccr8,necko-reviewers,valentin
This only changes the behaviour when called with a TaskQueue or other type
using SerialEventTargetGuard on the stack. They are being switched over as the
existing GetCurrentEventTarget method is being removed, as it is somewhat
confusing, and poorly documented.

Callers which need to get the current thread even when on a threadpool or
behind a TaskQueue were switched to GetCurrentEventTarget in the previous part.

Differential Revision: https://phabricator.services.mozilla.com/D166607
2023-01-16 23:14:11 +00:00
Andreas Farre
ead5ce5973 Bug 1810544 - OpaqueResponse::Alllow -> OpaqueResponse::Allow. r=smaug,necko-reviewers,valentin
Differential Revision: https://phabricator.services.mozilla.com/D166927
2023-01-16 19:17:14 +00:00
Sandor Molnar
8f39acfaf1 Backed out 2 changesets (bug 1804638, bug 1778135) for causing build bustage in netwerk/protocol/http/OpaqueResponseUtils.cpp CLOSED TREE
Backed out changeset 0fd928c03e0f (bug 1778135)
Backed out changeset abafc3718310 (bug 1804638)
2023-01-16 21:59:15 +02:00
Andreas Farre
e2cdc7e8c3 Bug 1778135 - Add profile marker for ORB safelist check. r=necko-reviewers,smaug,kershaw
Differential Revision: https://phabricator.services.mozilla.com/D164569
2023-01-16 15:46:21 +00:00
Andreas Farre
03a7b88b41 Bug 1804638 - Add telemetry probes to measure ORB JavaScript performance. r=necko-reviewers,smaug,sefeng,kershaw
Differential Revision: https://phabricator.services.mozilla.com/D164568
2023-01-16 15:46:21 +00:00
Tim Huang
80ba0dbd0c Bug 1808212 - Part 2: Implement the ETP level2 list pref for the private browsing mode. r=dimi
Depends on D165937

Differential Revision: https://phabricator.services.mozilla.com/D165938
2023-01-05 13:37:33 +00:00
Valentin Gosu
c56863a357 Bug 1596845 - Pass TRR skip reason to child channel r=necko-reviewers,kershaw
Moves the TRRSkipReasons to nsITRRSkipReason.idl so they are available to JS.

Depends on D164345

Differential Revision: https://phabricator.services.mozilla.com/D164348
2022-12-23 09:26:15 +00:00
Valentin Gosu
fe60b134d1 Bug 1596845 - Pass effectiveTRRMode to HTTP child channel r=necko-reviewers,kershaw
Differential Revision: https://phabricator.services.mozilla.com/D164345
2022-12-23 09:26:15 +00:00
Marian-Vasile Laza
56b22ee0ba Backed out 9 changesets (bug 1596845) for causing xpcshell failures on test_trr_enterprise_policy.js. CLOSED TREE
Backed out changeset 231acfc052bb (bug 1596845)
Backed out changeset 7d02dad4d720 (bug 1596845)
Backed out changeset b0449eec2671 (bug 1596845)
Backed out changeset 5cd033c9ef7c (bug 1596845)
Backed out changeset 98d583f1d19e (bug 1596845)
Backed out changeset b78bc0049605 (bug 1596845)
Backed out changeset 88919aaff89b (bug 1596845)
Backed out changeset f4adb3e7b8e1 (bug 1596845)
Backed out changeset b171f7ac0b40 (bug 1596845)
2022-12-23 09:21:39 +02:00
Valentin Gosu
dae40829fc Bug 1596845 - Pass TRR skip reason to child channel r=necko-reviewers,kershaw
Moves the TRRSkipReasons to nsITRRSkipReason.idl so they are available to JS.

Depends on D164345

Differential Revision: https://phabricator.services.mozilla.com/D164348
2022-12-23 01:20:01 +00:00
Valentin Gosu
a1617e68bc Bug 1596845 - Pass effectiveTRRMode to HTTP child channel r=necko-reviewers,kershaw
Differential Revision: https://phabricator.services.mozilla.com/D164345
2022-12-23 01:20:01 +00:00
Sandor Molnar
56d5efdcae Backed out 9 changesets (bug 1596845) for causing mochitest failures in browser/base/content/test/about/browser_aboutCertError_telemetry.js
Backed out changeset eb1e34c3041f (bug 1596845)
Backed out changeset af6d41439c60 (bug 1596845)
Backed out changeset f1447dd8df04 (bug 1596845)
Backed out changeset a383f2bbcaae (bug 1596845)
Backed out changeset 950c66dd6133 (bug 1596845)
Backed out changeset ab300239fd69 (bug 1596845)
Backed out changeset 8e1fe024b680 (bug 1596845)
Backed out changeset 80e5048d1f35 (bug 1596845)
Backed out changeset b14a4910d73b (bug 1596845)
2022-12-23 00:56:35 +02:00
Valentin Gosu
b1e4e1e730 Bug 1596845 - Pass TRR skip reason to child channel r=necko-reviewers,kershaw
Moves the TRRSkipReasons to nsITRRSkipReason.idl so they are available to JS.

Depends on D164345

Differential Revision: https://phabricator.services.mozilla.com/D164348
2022-12-22 21:16:06 +00:00
Valentin Gosu
2ca88c649b Bug 1596845 - Pass effectiveTRRMode to HTTP child channel r=necko-reviewers,kershaw
Differential Revision: https://phabricator.services.mozilla.com/D164345
2022-12-22 21:16:05 +00:00
Norisz Fay
8cf029b070 Backed out 15 changesets (bug 1247687) as requested by dev CLOSED TREE
Backed out changeset 81d052cabf84 (bug 1247687)
Backed out changeset d698041e5174 (bug 1247687)
Backed out changeset 2adf67f910e8 (bug 1247687)
Backed out changeset 0bc871906e97 (bug 1247687)
Backed out changeset 1700d5b79273 (bug 1247687)
Backed out changeset 31888ffde37a (bug 1247687)
Backed out changeset 9153182c650d (bug 1247687)
Backed out changeset 45de9ffeec19 (bug 1247687)
Backed out changeset 59207e959b7c (bug 1247687)
Backed out changeset 49f18430c465 (bug 1247687)
Backed out changeset 0ae1fd421d4f (bug 1247687)
Backed out changeset 7770ec4717fd (bug 1247687)
Backed out changeset 68b476066248 (bug 1247687)
Backed out changeset c94a9dc60dff (bug 1247687)
Backed out changeset 0ab366c6eaaf (bug 1247687)
2022-12-21 10:48:15 +02:00
Yulia Startsev
dcbacd54c8 Bug 1247687 - Implement csp for Module Workers; r=evilpie,asuth,rpl,ckerschb
Depends on D155691

Differential Revision: https://phabricator.services.mozilla.com/D156102
2022-12-20 20:56:15 +00:00
Csoregi Natalia
c382c6a7ca Backed out 16 changesets (bug 1247687) for frequent string bundle related crashes with PDF viewer (bug 1806064). a=backout
Backed out changeset 721f612fd09f (bug 1247687)
Backed out changeset c6c5750cf713 (bug 1247687)
Backed out changeset 5d05ab0c7cde (bug 1247687)
Backed out changeset 2429599729cb (bug 1247687)
Backed out changeset 55f13fb4ee3f (bug 1247687)
Backed out changeset 354711cf113a (bug 1247687)
Backed out changeset 40b8abaf1c0b (bug 1247687)
Backed out changeset 0c9650a1ac48 (bug 1247687)
Backed out changeset e7b103c79b1a (bug 1247687)
Backed out changeset 4dbd510fb042 (bug 1247687)
Backed out changeset 9276c7e1ddd9 (bug 1247687)
Backed out changeset 6ee318df6641 (bug 1247687)
Backed out changeset 6c129bd72b61 (bug 1247687)
Backed out changeset 4b0a4fcc6894 (bug 1247687)
Backed out changeset 34680059b9f0 (bug 1247687)
Backed out changeset 85b827971a48 (bug 1247687)
2022-12-17 11:27:32 +02:00
Yulia Startsev
4916e53611 Bug 1247687 - Implement csp for Module Workers; r=evilpie,asuth,rpl,ckerschb
Depends on D155691

Differential Revision: https://phabricator.services.mozilla.com/D156102
2022-12-14 14:55:38 +00:00
Sean Feng
304592ae1b Bug 1802216 - Don't start nsCompressedAudioVideoImageDetector and nsUnknownDecoder in the same time r=farre,necko-reviewers,valentin
We should only need to start nsCompressedAudioVideoImageDetector when
nsUnknownDecoder is not going to be started. Generally, they are not
designed to be working together.

Differential Revision: https://phabricator.services.mozilla.com/D163063
2022-12-02 18:29:35 +00:00
mleclair
7b13f01ed4 Bug 1792187 - added proxy attribute to verify if a proxy is used r=necko-reviewers,kershaw
Differential Revision: https://phabricator.services.mozilla.com/D161011
2022-12-02 16:54:23 +00:00
Manuel Bucher
8b9959b96e Bug 1771867 - Early Hints Phase 2 - Part 3: Add mechanism to notify EarlyHintPreloader that HttpChannelParent is ready to complete the redirect r=necko-reviewers,kershaw,valentin
Differential Revision: https://phabricator.services.mozilla.com/D161178
2022-12-02 16:15:54 +00:00
Manuel Bucher
2a9cb26225 Bug 1771867 - Early Hints Phase 2 - Part 2: Pass early hint preloads to preloader from IPC r=necko-reviewers,valentin
Differential Revision: https://phabricator.services.mozilla.com/D161173
2022-12-02 16:15:53 +00:00
Csoregi Natalia
5a260d61a4 Backed out 13 changesets (bug 1771867) for causing CanonicalBrowsingContext crashes. CLOSED TREE
Backed out changeset 120838b58449 (bug 1771867)
Backed out changeset aea7ca0bbd17 (bug 1771867)
Backed out changeset 2fe2afdee09d (bug 1771867)
Backed out changeset 8bdb1f682d22 (bug 1771867)
Backed out changeset a9f3158ed688 (bug 1771867)
Backed out changeset 1177913e1edf (bug 1771867)
Backed out changeset d33ccbbf407d (bug 1771867)
Backed out changeset 110ac12e16f5 (bug 1771867)
Backed out changeset 7f20525f5e94 (bug 1771867)
Backed out changeset b3d65b1aa872 (bug 1771867)
Backed out changeset 7cdf3cef2773 (bug 1771867)
Backed out changeset 5090eae24a5c (bug 1771867)
Backed out changeset f8a03d226c73 (bug 1771867)
2022-12-02 13:44:55 +02:00