Commit graph

238 commits

Author SHA1 Message Date
Mark Striemer
db43a5ce41 Bug 1819372 - Part 2: Use moz-button-group in Cookie Banner Reduction panel r=pbz
Differential Revision: https://phabricator.services.mozilla.com/D173892
2023-04-13 16:20:50 +00:00
Tom Ritter
3c46efdcb3 Bug 1824160: Add 'Fonts' to the reasons a Site Might Not Be Working r=fluent-reviewers,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D173565
2023-03-29 16:02:37 +00:00
ganna
5ea9f76714 Bug 1802364 - Convert ETP breakage report links to toolbarbuttons in ETP panel. r=hjones,desktop-theme-reviewers,anti-tracking-reviewers,Itiel,pbz
Differential Revision: https://phabricator.services.mozilla.com/D172957
2023-03-28 19:44:11 +00:00
Jared Hirsch
76a6a422ec Bug 1812796 - Refactor and simplify cookie banner handling UI state r=pbz,desktop-theme-reviewers,Itiel
Differential Revision: https://phabricator.services.mozilla.com/D172075
2023-03-28 16:31:48 +00:00
omega judith
f065c7b3d4 Bug 1822985 - Convert toolkit/components/antitracking to ES modules. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D172887
2023-03-21 09:59:34 +00:00
Tim Huang
9c5f792a23 Bug 1819662 - Showing the domains of the blocked email tracker in the tracker category on the protection panel. r=anti-tracking-reviewers,pbz
This patch makes the tracker category on the protection panel to show
the email tracker domains when they are blocked. The tracker category
will handle the email tracking content blocking events and show the
domains of blocked email trackers on the tracker category subview when
email tracking protection is enabled.

Differential Revision: https://phabricator.services.mozilla.com/D171714
2023-03-08 20:00:54 +00:00
Emilio Cobos Álvarez
097eb3703e Bug 1820534 - Move front-end to modern flexbox. r=Gijs,dao,settings-reviewers,credential-management-reviewers,sgalich,devtools-reviewers,nchevobbe
Done mostly automatically via find/replace following the conversions
specified here:

  https://groups.google.com/a/mozilla.org/g/firefox-dev/c/9sGpF1TNbLk/m/QpU3oTUuAgAJ

For the most part I think the "flex: N N" usage could be simplified to
just "flex: N", but I wanted to preserve behavior (-moz-box-flex sets
both flex-grow and flex-shrink).

I changed legacy layout to also look at the order property rather than
-moz-box-ordinal-group because it made splitters and treecols easier (we
don't need to deal with both orders).

Differential Revision: https://phabricator.services.mozilla.com/D171715
2023-03-08 16:13:57 +00:00
Stanca Serban
923ef223cd Backed out changeset c25af897c9bc (bug 1820534) for causing reftests and mochitests failures. 2023-03-08 17:34:42 +02:00
Emilio Cobos Álvarez
57e476145f Bug 1820534 - Move front-end to modern flexbox. r=Gijs,dao,settings-reviewers,credential-management-reviewers,sgalich,devtools-reviewers,nchevobbe
Done mostly automatically via find/replace following the conversions
specified here:

  https://groups.google.com/a/mozilla.org/g/firefox-dev/c/9sGpF1TNbLk/m/QpU3oTUuAgAJ

For the most part I think the "flex: N N" usage could be simplified to
just "flex: N", but I wanted to preserve behavior (-moz-box-flex sets
both flex-grow and flex-shrink).

I changed legacy layout to also look at the order property rather than
-moz-box-ordinal-group because it made splitters and treecols easier (we
don't need to deal with both orders).

Differential Revision: https://phabricator.services.mozilla.com/D171715
2023-03-08 14:11:35 +00:00
Jared Hirsch
77fc94925b Bug 1818536 - Do not clear regular site data when disabling cookie banner handling in private mode. r=pbz
Differential Revision: https://phabricator.services.mozilla.com/D170933
2023-02-24 21:00:23 +00:00
Jared Hirsch
978a1b7fa2 Bug 1800670 - Update cookie banner handling UI in protections popup r=pbz
This patch also implements bug 1800671 and bug 1800673.

Differential Revision: https://phabricator.services.mozilla.com/D164241
2023-02-02 19:12:57 +00:00
Butkovits Atila
4a919ce347 Backed out changeset f878cff45427 (bug 1800670) for causing failures at browser_protectionsUI_cookie_banner.js. CLOSED TREE 2023-02-01 20:40:46 +02:00
Jared Hirsch
9ab5498253 Bug 1800670 - Update cookie banner handling UI in protections popup r=pbz
This patch also implements bug 1800671 and bug 1800673.

Differential Revision: https://phabricator.services.mozilla.com/D164241
2023-02-01 14:51:39 +00:00
Noemi Erli
4198c1ee2f Backed out changeset 68de023d3c5c (bug 1800670) for causing failures in browser_protectionsUI_cookie_banner.js CLOSED TREE 2023-01-30 21:16:42 +02:00
Jared Hirsch
fd622a42aa Bug 1800670 - Update cookie banner handling UI in protections popup r=pbz
This patch also implements bug 1800671 and bug 1800673.

Differential Revision: https://phabricator.services.mozilla.com/D164241
2023-01-30 16:30:28 +00:00
Butkovits Atila
cd7bfe4eb2 Backed out changeset 0072aa5cd31d (bug 1800670) for causing multiple mochitest failures. CLOSED TREE 2023-01-30 15:26:29 +02:00
Jared Hirsch
053b5d681c Bug 1800670 - Update cookie banner handling UI in protections popup r=pbz
This patch also implements bug 1800671 and bug 1800673.

Differential Revision: https://phabricator.services.mozilla.com/D164241
2023-01-30 12:24:28 +00:00
Paul Zuehlcke
3f8ec65b7e Bug 1809700 - Refactor detect-only mode into separate pref. r=timhuang,settings-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D166831
2023-01-20 12:22:09 +00:00
Marian-Vasile Laza
b2525b4d3c Backed out 2 changesets (bug 1809700) for causing automation/mochitest/marionette failures. CLOSED TREE
Backed out changeset 7d58f9afe4b7 (bug 1809700)
Backed out changeset 8a37c048a169 (bug 1809700)
2023-01-19 21:33:08 +02:00
Paul Zuehlcke
681768e6f8 Bug 1809700 - Refactor detect-only mode into separate pref. r=timhuang,settings-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D166831
2023-01-19 17:12:00 +00:00
Mark Banner
3a07fcf436 Bug 1806503 - Automatically replace Cu.reportError with console.error (browser/actors, browser/base). r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D165068
2022-12-27 10:08:58 +00:00
Francesco Lodolo (:flod)
dd34dc2343 Bug 1801915 - Migrate confirmation hints to Fluent, r=eemeli,credential-management-reviewers,sgalich
Differential Revision: https://phabricator.services.mozilla.com/D162746
2022-11-22 20:12:55 +00:00
Paul Zuehlcke
e1185b00c8 Bug 1798960 - Hide cookie banner handling per-site toggle in MODE_DETECT_ONLY. r=timhuang
Differential Revision: https://phabricator.services.mozilla.com/D161731
2022-11-14 22:50:42 +00:00
Iulian Moraru
707bbcff6a Backed out 7 changesets (bug 1798960) for causing bc failures on browser_startup_content_subframe.js.
Backed out changeset 37160a6f6d6e (bug 1798960)
Backed out changeset 955c6861b6df (bug 1798960)
Backed out changeset d4d687020c42 (bug 1798960)
Backed out changeset 9b95f762751a (bug 1798960)
Backed out changeset 3ab8c890086d (bug 1798960)
Backed out changeset ddd6e63f05dc (bug 1798960)
Backed out changeset 1810be532880 (bug 1798960)
2022-11-14 23:44:21 +02:00
Paul Zuehlcke
6f55a3b0cf Bug 1798960 - Hide cookie banner handling per-site toggle in MODE_DETECT_ONLY. r=timhuang
Differential Revision: https://phabricator.services.mozilla.com/D161731
2022-11-14 20:38:18 +00:00
Paul Zuehlcke
f2614f2ed6 Bug 1798669 - Extend protections popup event telemetry to include cookie banner handling toggle. r=timhuang
Differential Revision: https://phabricator.services.mozilla.com/D161064
2022-11-09 18:14:06 +00:00
Paul Zuehlcke
2cbc80b675 Bug 1795041 - Add a cookie banner handling per-site toggle to the protection panel. r=timhuang
Differential Revision: https://phabricator.services.mozilla.com/D160254
2022-11-01 13:34:56 +00:00
Itiel
fc690917a6 Bug 1797591 - Center the icon in the trackers list when no trackers are detected r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D160399
2022-10-27 11:56:37 +00:00
Itiel
8d45186ac0 Bug 1790232 - Use subviewbutton for the Protections popup buttons and cleanup some CSS r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D157045
2022-10-25 19:02:45 +00:00
Emilio Cobos Álvarez
e83fac1f59 Bug 1795944 - Remove descriptionheightworkaround. r=Gijs
Stuff wraps properly now with flexbox emulation.

Differential Revision: https://phabricator.services.mozilla.com/D159621
2022-10-19 11:55:29 +00:00
Emilio Cobos Álvarez
13572bce66 Bug 1788273 - Tweak popup alignment so that it looks good on mirrored wayland popups. r=dao,mak
When these panels had arrows, I guess the bottomcenter topleft alignment
made sense so that you could precisely align the arrow, but that's not
what we do now.

Don't use bottomcenter / leftcenter / rightcenter, since we really want
the sides to align.

This shouldn't change behavior on any platform except Linux + Wayland,
where the alignment looks good now in the case of bug 1784876.

Differential Revision: https://phabricator.services.mozilla.com/D156099
2022-09-02 20:26:29 +00:00
Butkovits Atila
c520b707bd Backed out changeset 368a7ce1b104 (bug 1788273) for causing failures at browser_recently_closed_tabs.js. CLOSED TREE 2022-09-02 16:35:55 +03:00
Emilio Cobos Álvarez
0777329f69 Bug 1788273 - Tweak popup alignment so that it looks good on mirrored wayland popups. r=dao,mak
When these panels had arrows, I guess the bottomcenter topleft alignment
made sense so that you could precisely align the arrow, but that's not
what we do now.

Don't use bottomcenter / leftcenter / rightcenter, since we really want
the sides to align.

This shouldn't change behavior on any platform except Linux + Wayland,
where the alignment looks good now in the case of bug 1784876.

Differential Revision: https://phabricator.services.mozilla.com/D156099
2022-09-02 11:18:54 +00:00
Itiel
4d4daefdf5 Bug 1710885 - Hide the toolbarseparator in the protections popup when needed r=hpeuckmann
Differential Revision: https://phabricator.services.mozilla.com/D155863
2022-09-02 08:02:58 +00:00
Iulian Moraru
3c09fc13df Backed out 3 changesets (bug 1780074, bug 1780347) for causing multiple failures. CLOSED TREE
Backed out changeset ee4c4d34816c (bug 1780347)
Backed out changeset a13d3939b98a (bug 1780074)
Backed out changeset 3bc739f7de43 (bug 1780074)
2022-07-20 14:57:48 +03:00
Mark Banner
3ad13294d8 Bug 1780074 - Migrate newtab consumers to use ESM imports directly. r=daleharvey,application-update-reviewers,nalexander
Differential Revision: https://phabricator.services.mozilla.com/D152114
2022-07-20 10:36:52 +00:00
Hannah Peuckmann
7c1bad4edc Bug 1764761 - Remove/replace the network.cookie.lifetimePolicy. r=pbz,necko-reviewers,mkaply,dom-storage-reviewers,agi,asuth,dragana
Differential Revision: https://phabricator.services.mozilla.com/D144548
2022-06-29 17:33:37 +00:00
Shane Hughes
179572cc9c Bug 1724622 - Fix missing ETP toast popup animation. r=pbz,Gijs
When the tracking protection toast popup closes on a timer, it doesn't
smoothly fade out, because it uses PanelMultiView.hidePopup instead of
panelNode.hidePopup. The static method on PanelMultiView ultimately
calls panelNode.hidePopup, but it doesn't have a parameter for enabling
the animation so it passes nothing to that method. This patch extends
PanelMultiView's hidePopup class methods to add an optional `animate`
parameter, and adds that parameter to the toast popup's hidePopup call.
This should slightly reduce the speed of part of
browser_protectionsUI.js but I don't think it affects any other tests.

Differential Revision: https://phabricator.services.mozilla.com/D146394
2022-05-24 16:04:23 +00:00
Shane Hughes
17ae4592fa Bug 1750129 - Remove old/obsolete reference to photon tracking protection icon animation. r=jaws
Differential Revision: https://phabricator.services.mozilla.com/D135961
2022-02-25 17:58:31 +00:00
Benjamin VanderSloot
83bac9db86 Bug 1731739 part 2 - Use site as key for 3rdPartyStorage permissions, rather than origin r=anti-tracking-reviewers,pbz,timhuang
- Adding browser tests to verify correct behavior in integration
    - New test that fails on previous version: toolkit/components/antitracking/test/browser/browser_storageAccessScopeSameSiteWrite.js
- Add the ability to store permission by site, use 3rdPartyStorage for this
- No change is made to permission reads. These already proceed recursively, which eventually reach the site.
- When fetching all permissions for a principal, also look for site-scoped permissions on its site's principal

Differential Revision: https://phabricator.services.mozilla.com/D130675
2021-11-23 18:25:58 +00:00
Marian-Vasile Laza
0e7ef02d35 Backed out 3 changesets (bug 1731739) for causing build bustages on PermissionManager.cpp.
Backed out changeset 2f723b6e625b (bug 1731739)
Backed out changeset 7b053cfeab3e (bug 1731739)
Backed out changeset c4a31c29c441 (bug 1731739)
2021-11-23 19:06:14 +02:00
Benjamin VanderSloot
921cf98880 Bug 1731739 part 2 - Use site as key for 3rdPartyStorage permissions, rather than origin r=anti-tracking-reviewers,pbz,timhuang
- Adding browser tests to verify correct behavior in integration
    - New test that fails on previous version: toolkit/components/antitracking/test/browser/browser_storageAccessScopeSameSiteWrite.js
- Add the ability to store permission by site, use 3rdPartyStorage for this
- No change is made to permission reads. These already proceed recursively, which eventually reach the site.
- When fetching all permissions for a principal, also look for site-scoped permissions on its site's principal

Differential Revision: https://phabricator.services.mozilla.com/D130675
2021-11-23 16:18:42 +00:00
Molly Howell
e9e71b8796 Bug 1703608 - Hide doorhangers while protections panel is open. r=emalysz
Differential Revision: https://phabricator.services.mozilla.com/D117693
2021-07-06 15:37:44 +00:00
Paul Zuehlcke
b029bd3c30 Bug 1710857 - Fixed protections panel cookie state label and button. r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D114990
2021-05-18 09:51:06 +00:00
Sam Foster
1e6aff940f Bug 1704152 - Update the tracking protection icon, and remove the state transition animation. r=jaws
* Updates the addressbar "lock" icon for the tracking-protection blocked/disabled state, the default "no trackers" state, and the "trackers blocked" state. Where we used to animate the transition to trackers blocked, its now a static iconwith the same blue/purple gradient fill.

* Remove browser_protectionsUI_animation.js which was specifically testing the animation behavior and use of the animation frames as visible icons, which is no longer the case

* Rename and adjust browser_protectionsUI_animation_2.js which is primarily testing the active/not state of the icon

Differential Revision: https://phabricator.services.mozilla.com/D111507
2021-04-16 17:47:29 +00:00
Dão Gottwald
725e4d8466 Bug 1701306 - Remove custom code setting the "open" attribute on panel anchors. r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D110817
2021-04-14 13:57:34 +00:00
Alexandru Michis
815cf5dade Backed out changeset 80f482be9920 (bug 1704152) for causing bc failures in browser_protectionsUI_animation.js
CLOSED TREE
2021-04-13 23:27:38 +03:00
Sam Foster
c3f86167b6 Bug 1704152 - Update the tracking protection icon, and remove the state transition animation. r=jaws
Updates the addressbar "lock" icon for the tracking-protection blocked/disabled state, the default "no trackers" state, and the "trackers blocked" state. Where we used to animate the transition to trackers blocked, its now a static iconwith the same blue/purple gradient fill.

Differential Revision: https://phabricator.services.mozilla.com/D111507
2021-04-13 17:35:56 +00:00
Paul Zuehlcke
4401c9a7ca Bug 1699669 - Added learn more link to the shim-allow warning in the protections panel. r=johannh,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D110150
2021-04-13 16:11:21 +00:00
Paul Zuehlcke
58eba8e1ac Bug 1699668 - Refactor siteProtections blockers and add a warning for trackers allowed by shims. r=johannh,flod
Differential Revision: https://phabricator.services.mozilla.com/D109717
2021-04-13 16:11:21 +00:00