Commit graph

245 commits

Author SHA1 Message Date
Malte Juergens
1b7e49f639 Bug 1864464 - Fix HTTPS-Only nested URI handling in identity panel r=freddyb
Differential Revision: https://phabricator.services.mozilla.com/D196538
2023-12-20 12:52:13 +00:00
Dana Keeler
4c2785e75c Bug 1867624 - remove nsIX509Cert.isBuiltInRoot for blocking the main thread r=jschanck,extension-reviewers,application-update-reviewers,nalexander,robwu
Differential Revision: https://phabricator.services.mozilla.com/D195292
2023-12-18 17:28:32 +00:00
Benjamin VanderSloot
e72674d7b6 Bug 1525943 - Add associated to the identity UI - r=pbz,Gijs,nika,flod
Differential Revision: https://phabricator.services.mozilla.com/D193806
2023-11-30 18:32:48 +00:00
Malte Juergens
70d7585b3a Bug 1863286 - Schemeless HTTPS-First overrides HTTPS-Only in identity pane r=freddyb
Differential Revision: https://phabricator.services.mozilla.com/D192821
2023-11-06 15:43:57 +00:00
Marc Seibert
fa13bd0d23 Bug 1860528 - Mixed content warning doesn't look right with enabled.r=dao
Differential Revision: https://phabricator.services.mozilla.com/D192017
2023-11-01 11:22:39 +00:00
Frederik Braun
7291dac470 Bug 1812192 - Store schemeless address bar loads in loadinfo and upgrade to https with fallback r=necko-reviewers,webidl,smaug,freddyb,kershaw
Depends on D179794

Differential Revision: https://phabricator.services.mozilla.com/D179795
2023-10-11 17:49:42 +00:00
Cristian Tuns
5fabc0ee57 Backed out 6 changesets (bug 1812192) for causing browser_schemeless.js failures. CLOSED TREE
Backed out changeset 3d07a92324d0 (bug 1812192)
Backed out changeset 9c2a1ff6c90d (bug 1812192)
Backed out changeset fa6784f8b0f4 (bug 1812192)
Backed out changeset 0f39aba7e4d5 (bug 1812192)
Backed out changeset ef7219327a10 (bug 1812192)
Backed out changeset 9833b559342e (bug 1812192)
2023-10-10 10:02:25 -04:00
Frederik Braun
aed55ecb55 Bug 1812192 - Store schemeless address bar loads in loadinfo and upgrade to https with fallback r=necko-reviewers,webidl,smaug,freddyb,kershaw
Depends on D179794

Differential Revision: https://phabricator.services.mozilla.com/D179795
2023-10-10 08:43:00 +00:00
Marc Seibert
28647db072 Bug 1850492 - Remove security.insecure_connection_icon.enabled and security.insecure_connection_icon.pbmode.enabled prefs.r=dao
Differential Revision: https://phabricator.services.mozilla.com/D187031
2023-09-05 10:12:44 +00:00
Malte Juergens
05a00d1692 Bug 1720458: Do not isolate https-only-load-insecure by origin attributes r=fluent-reviewers,settings-reviewers,flod,ckerschb,Gijs
Do not isolate `https-only-load-insecure` by origin attributes. This way the HTTPS-Only exceptions will behave similar to the `cookie` permission. This means that exceptions set in the system settings will also apply to private windows, but exceptions set in private windows via the identity pane will be reset after closing the browser.

Depends on D182761

Differential Revision: https://phabricator.services.mozilla.com/D183745
2023-07-24 13:31:19 +00:00
Malte Juergens
31665cb4bb Bug 1757297: Only work with http scheme for HTTPS-Only exceptions r=freddyb,settings-reviewers,Gijs
- Update the HTTPS-Only dropdown in the site identity pane to always set exceptions for the http version of the current origin.
- Add new parameter `forcedHTTP` to `gPermissionManager`, in order to only allow origins with a http scheme to be added in the HTTPS-Only section of the settings. This means when a https URL is added as an exeption, it will automatically be converted into a http one.
- Add a migration to convert all existing HTTPS-Only exceptions with a https scheme to a http scheme.
- Update `browser_https_only_exceptions.js` and `browser_identityPopup_HttpsOnlyMode.js` to account for this new behaviour.

Differential Revision: https://phabricator.services.mozilla.com/D182761
2023-07-24 13:31:19 +00:00
Malte Juergens
a7c59a9b78 Bug 1838183: Include HTTPS-First in current HTTPS-Only exemption options on site identity pane r=freddyb,fluent-reviewers
Depends on D182322

Differential Revision: https://phabricator.services.mozilla.com/D181356
2023-07-11 11:07:24 +00:00
anwar
2d4137d28a Bug 1773087 - Clean up unused browser.protections_panel.enabled pref. r=pbz
Differential Revision: https://phabricator.services.mozilla.com/D176929
2023-06-09 08:37:57 +00:00
Mark Banner
130a655906 Bug 1826062 - Automatic fixes for upgrading Prettier to 2.8.8. r=mossop,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,denschub,devtools-reviewers,sparky,calu
Differential Revision: https://phabricator.services.mozilla.com/D177027
2023-05-20 12:26:53 +00:00
Mark Banner
8219a5c503 Bug 1826062 - Automatic fixes for Prettier 2.0.5 upgrade. r=mossop,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,denschub,devtools-reviewers,sparky,owlish
Differential Revision: https://phabricator.services.mozilla.com/D177025
2023-05-20 12:26:49 +00:00
Ebilite Uchenna
3ecf643cb4 Bug 1814266 - Use moz-support-link for the "identify-popup-custom-root-learn-more" label. r=tgiles,flod
Differential Revision: https://phabricator.services.mozilla.com/D173701
2023-04-14 15:01:10 +00:00
Noah
4371549920 Bug 1814261 - Use moz-support-link in Mixed Content Blocking. r=tgiles,flod
Differential Revision: https://phabricator.services.mozilla.com/D173620
2023-04-13 15:14:25 +00:00
Csoregi Natalia
fd43043337 Backed out 2 changesets (bug 1814261) as per request. CLOSED TREE
Backed out changeset 8640c4a18d9e (bug 1814261)
Backed out changeset c00c8fc88dbd (bug 1814261)
2023-04-06 18:40:06 +03:00
Noah
47b283c6e9 Bug 1814261 - Use moz-support-link in Mixed Content Blocking. r=tgiles,flod
Differential Revision: https://phabricator.services.mozilla.com/D173620
2023-04-06 06:00:16 +00:00
Noemi Erli
e465420048 Backed out 2 changesets (bug 1814266) for causing failures in browser_identityPopup_focus.js
Backed out changeset fb7b697636ae (bug 1814266)
Backed out changeset 7e5ac07b53d9 (bug 1814266)
2023-04-06 00:02:41 +03:00
Ebilite Uchenna
b9a1be77e6 Bug 1814266 - Use moz-support-link for the "identify-popup-custom-root-learn-more" label. r=tgiles,flod
Differential Revision: https://phabricator.services.mozilla.com/D173701
2023-04-05 20:23:05 +00:00
Gijs Kruitbosch
9e07759558 Bug 1810141 - fix loadURI callers that already have an nsIURI reference or where creating one is clearly safe, r=mossop,geckoview-reviewers,extension-reviewers,settings-reviewers,mconley,m_kato
There are 3 types of changes in this commit:

- from `loadURI(foo.spec)` to `loadURI(foo)`, as there's already a URI
- from `loadURI("string")` to `loadURI(Services.io.newURI("string"))` as the URL is hardcoded
- one or two where there is perhaps an intermediate variable but the patch
  context should still make it trivial to ascertain the change is correct.

Depends on D168393

Differential Revision: https://phabricator.services.mozilla.com/D168394
2023-02-13 23:50:40 +00:00
Cristina Horotan
5f4356e527 Backed out 9 changesets (bug 1810141) for several test failures on a CLOSED TREE
Backed out changeset 8781a0d1254d (bug 1810141)
Backed out changeset 131037295784 (bug 1810141)
Backed out changeset 3852fbe290f4 (bug 1810141)
Backed out changeset 118f131a524a (bug 1810141)
Backed out changeset ab5d76846e10 (bug 1810141)
Backed out changeset dce3aa683445 (bug 1810141)
Backed out changeset 4dc41d90dbb3 (bug 1810141)
Backed out changeset 50b57ba1a061 (bug 1810141)
Backed out changeset 569de94781e4 (bug 1810141)
2023-02-13 16:05:30 +02:00
Gijs Kruitbosch
6add9ed34d Bug 1810141 - fix loadURI callers that already have an nsIURI reference or where creating one is clearly safe, r=mossop,geckoview-reviewers,extension-reviewers,settings-reviewers,mconley,m_kato
There are 3 types of changes in this commit:

- from `loadURI(foo.spec)` to `loadURI(foo)`, as there's already a URI
- from `loadURI("string")` to `loadURI(Services.io.newURI("string"))` as the URL is hardcoded
- one or two where there is perhaps an intermediate variable but the patch
  context should still make it trivial to ascertain the change is correct.

Depends on D168393

Differential Revision: https://phabricator.services.mozilla.com/D168394
2023-02-13 12:55:24 +00:00
Bilal
a3d0c20309 Bug 1798634 - Converted AboutHttpsOnlyError JSM modules to ESM. r=kpatenio,Standard8
Differential Revision: https://phabricator.services.mozilla.com/D167450
2023-01-23 16:26:37 +00:00
Mark Banner
3a07fcf436 Bug 1806503 - Automatically replace Cu.reportError with console.error (browser/actors, browser/base). r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D165068
2022-12-27 10:08:58 +00:00
Itiel
a4d22ff977 Bug 1798211 - Improve the identity panel layout and CSS r=pbz
Differential Revision: https://phabricator.services.mozilla.com/D160725
2022-11-01 01:25:58 +00:00
Marian-Vasile Laza
1c6a6c7dd8 Backed out changeset 0e774d830db6 (bug 1798211) for causing bc failures on browser_addCertException.js. CLOSED TREE 2022-11-01 01:01:59 +02:00
Itiel
bb2b4a4003 Bug 1798211 - Improve the identity panel layout and CSS r=pbz
Differential Revision: https://phabricator.services.mozilla.com/D160725
2022-10-31 22:10:09 +00:00
Emilio Cobos Álvarez
13572bce66 Bug 1788273 - Tweak popup alignment so that it looks good on mirrored wayland popups. r=dao,mak
When these panels had arrows, I guess the bottomcenter topleft alignment
made sense so that you could precisely align the arrow, but that's not
what we do now.

Don't use bottomcenter / leftcenter / rightcenter, since we really want
the sides to align.

This shouldn't change behavior on any platform except Linux + Wayland,
where the alignment looks good now in the case of bug 1784876.

Differential Revision: https://phabricator.services.mozilla.com/D156099
2022-09-02 20:26:29 +00:00
Butkovits Atila
c520b707bd Backed out changeset 368a7ce1b104 (bug 1788273) for causing failures at browser_recently_closed_tabs.js. CLOSED TREE 2022-09-02 16:35:55 +03:00
Emilio Cobos Álvarez
0777329f69 Bug 1788273 - Tweak popup alignment so that it looks good on mirrored wayland popups. r=dao,mak
When these panels had arrows, I guess the bottomcenter topleft alignment
made sense so that you could precisely align the arrow, but that's not
what we do now.

Don't use bottomcenter / leftcenter / rightcenter, since we really want
the sides to align.

This shouldn't change behavior on any platform except Linux + Wayland,
where the alignment looks good now in the case of bug 1784876.

Differential Revision: https://phabricator.services.mozilla.com/D156099
2022-09-02 11:18:54 +00:00
Paul Zuehlcke
8ed95d1fe1 Bug 1756609 - Remove security.secure_connection_icon_color_gray pref. r=prathiksha
Differential Revision: https://phabricator.services.mozilla.com/D139391
2022-03-09 11:09:19 +00:00
Paul Zuehlcke
0c27c573a8 Bug 1699658 - Special handling for siteIdentity security state of pdf viewer pages. r=Gijs,ckerschb
Differential Revision: https://phabricator.services.mozilla.com/D140055
2022-03-09 11:08:15 +00:00
Emilio Cobos Álvarez
00cc720134 Bug 1753995 - Remove non-test usage of WindowUtils.screenPixelsPerCSSPixel. r=mconley
It does the same as window.devicePixelRatio. However a bunch of this
code is copy-pasted code trying to scale a canvas, but not messing with
full zoom is the right thing to do.

The full zoom value in the top level browser.xhtml page is always 1
anyways, and WindowsPreviewPerTab looking at the current browser tab's
full zoom is just bizarre...

Differential Revision: https://phabricator.services.mozilla.com/D138020
2022-02-07 18:23:35 +00:00
Hannah Peuckmann
09b6c3a033 Bug 1567443 - Added flag for indicating secure Chrome UI in nsIAboutModule. r=pbz,webcompat-reviewers,twisniewski
Differential Revision: https://phabricator.services.mozilla.com/D128188
2021-10-26 13:32:31 +00:00
Cristian Tuns
0b4f04d43f Backed out changeset 177e6f28d348 (bug 1567443) for causing mochitest failures on browser_check_identity_state.js. CLOSED TREE 2021-10-25 06:45:43 -04:00
Hannah Peuckmann
06382f1212 Bug 1567443 - Using nsIAboutModule flag instead of regex to indicate secure about page. r=pbz,webcompat-reviewers,twisniewski
Differential Revision: https://phabricator.services.mozilla.com/D128188
2021-10-25 09:34:06 +00:00
Michael Kohler
2a78d18891 Bug 1707887 - Do not show nav arrow on security button in Site Identity when button is disabled r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D125095
2021-09-21 08:18:22 +00:00
Gijs Kruitbosch
4afa73a07d Bug 1724212 - add a tooltip and show more of the 'not secure' item so languages other than English fit, r=pbz
Differential Revision: https://phabricator.services.mozilla.com/D122851
2021-08-17 14:15:09 +00:00
Gijs Kruitbosch
4882e4a471 Bug 1721654 - show 'Not Secure' chiclet for certificate errors, r=pbz
This also causes nssFailure2 network errors to be treated as certificate errors
in the identity block, and adjusts tests for this new reality. It also readds
a test to test a non-cert-related network error to ensure that case doesn't
lose coverage.

Differential Revision: https://phabricator.services.mozilla.com/D121176
2021-08-02 15:35:10 +00:00
Sandor Molnar
b03d68bff4 Backed out changeset f6b029cbc49f (bug 1721654) for causing bc failures in browser_navigation_failures. CLOSED TREE 2021-08-02 17:22:00 +03:00
Gijs Kruitbosch
c88bc927dc Bug 1721654 - show 'Not Secure' chiclet for certificate errors, r=pbz
This also causes nssFailure2 network errors to be treated as certificate errors
in the identity block, and adjusts tests for this new reality. It also readds
a test to test a non-cert-related network error to ensure that case doesn't
lose coverage.

Differential Revision: https://phabricator.services.mozilla.com/D121176
2021-08-02 13:20:27 +00:00
Paul Zuehlcke
aeffb2f87e Bug 1711869 - Part 3: Update site identity for SiteDataManager base domain changes. r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D116861
2021-07-06 21:10:59 +00:00
R. Martinho Fernandes
7ea1bcd018 Bug 1597600 - make certificate overrides depend on origin attributes r=keeler,geckoview-reviewers,smaug,agi
Differential Revision: https://phabricator.services.mozilla.com/D91962
2021-06-01 06:55:07 +00:00
Dorel Luca
211b017ce9 Backed out changeset 089c88b9657b (bug 1597600) for XPCshell failures in toolkit/components/cleardata/tests/unit/test_certs.js. CLOSED TREE 2021-05-29 23:31:00 +03:00
R. Martinho Fernandes
a9e55ea7fc Bug 1597600 - make certificate overrides depend on origin attributes r=keeler,geckoview-reviewers,smaug,agi
Differential Revision: https://phabricator.services.mozilla.com/D91962
2021-05-29 19:34:35 +00:00
Gijs Kruitbosch
cd50b177a7 Bug 1711523 - remove private proton tracking flags in frontend modules, r=mak,emalysz,desktop-theme-reviewers,harry
Differential Revision: https://phabricator.services.mozilla.com/D116009
2021-05-28 19:33:38 +00:00
Emma Malysz
3fcda6fea5 Bug 1709160, net error pages should have security panel view available in the control center r=pbz
Differential Revision: https://phabricator.services.mozilla.com/D114134
2021-05-04 19:25:43 +00:00
Anshul Sahai
7b08dcedd7 Bug 1575080 - Changing the identity icon and the string inside the identity panel for net error pages. r=fluent-reviewers,johannh
Differential Revision: https://phabricator.services.mozilla.com/D112384
2021-05-03 07:51:14 +00:00