Commit graph

110 commits

Author SHA1 Message Date
Gijs Kruitbosch
f457ccd655 Bug 1646780 - use a template to wrap the identity popup while it's not needed, r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D78894
2020-06-19 00:02:11 +00:00
Mike Conley
4d269fae1d Bug 1642804 - Make sure to show notification silencing option in private browsing WebRTC screen sharing panel. r=pbz
Differential Revision: https://phabricator.services.mozilla.com/D78120
2020-06-09 23:37:24 +00:00
Razvan Maries
9f0ce65335 Backed out 2 changesets (bug 1642804, bug 1642803) for perma failures on browser_devices_get_user_media_in_xorigin_frame.js. CLOSED TREE
Backed out changeset 48f9a72a27a0 (bug 1642803)
Backed out changeset 53ec379c8e0e (bug 1642804)
2020-06-09 18:57:29 +03:00
Mike Conley
ce7a7c818e Bug 1642804 - Make sure to show notification silencing option in private browsing WebRTC screen sharing panel. r=pbz
Differential Revision: https://phabricator.services.mozilla.com/D78120
2020-06-09 10:33:30 +00:00
Mike Conley
4ad11c158e Bug 1639997 - Update WebRTC browser mochitests to test both old and new global indicators. r=pbz
Differential Revision: https://phabricator.services.mozilla.com/D76738
2020-05-26 18:01:47 +00:00
Mike Conley
93c3fbc24e Bug 1636207 - Fork the WebRTC global indicator for a refresh. r=florian
Differential Revision: https://phabricator.services.mozilla.com/D74332
2020-05-18 18:55:28 +00:00
Mike Conley
e08905a04a Bug 1634703 - Return nsIMediaDevice active devices list from mediaCaptureWindowState. r=jib,geckoview-reviewers,agi
Differential Revision: https://phabricator.services.mozilla.com/D73479
2020-05-12 14:49:46 +00:00
Kris Maglione
f3354d4788 Bug 1617254: Rename BrowsingContext.getChildren() to .children. r=nika
Differential Revision: https://phabricator.services.mozilla.com/D63699

--HG--
extra : moz-landing-system : lando
2020-02-25 22:33:53 +00:00
Arthur Iakab
73b6d9dca6 Backed out changeset 5616425b54da (bug 1617254)for casuing multiple browser-chrome failures.
CLOSED TREE
2020-02-26 00:09:34 +02:00
Kris Maglione
c65ef42473 Bug 1617254: Rename BrowsingContext.getChildren() to .children. r=nika
Differential Revision: https://phabricator.services.mozilla.com/D63699

--HG--
extra : moz-landing-system : lando
2020-02-25 21:03:58 +00:00
Noemi Erli
6b488deed0 Backed out changeset 034e2e79ecfa (bug 1617254) for causing build bustages CLOSED TREE 2020-02-25 21:59:14 +02:00
Kris Maglione
e4c4115afb Bug 1617254: Rename BrowsingContext.getChildren() to .children. r=nika
Differential Revision: https://phabricator.services.mozilla.com/D63699

--HG--
extra : moz-landing-system : lando
2020-02-25 19:39:25 +00:00
Neil Deakin
3be2884a5d Bug 1608584, shouldn't pass true to browserLoaded to wait for the subframe to load, also fixes 1608497, r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D60439

--HG--
extra : moz-landing-system : lando
2020-01-22 14:56:36 +00:00
Neil Deakin
0799339d93 Bug 1601301, modify browser_devices_get_user_media_in_frame.js to iterate twice, once performing the operation on two same-process frames, and a second time with frames that in fission mode would be in different processes, r=johannh
The observer listening is also modified to listen to notifications from all frames.

Differential Revision: https://phabricator.services.mozilla.com/D56571

--HG--
extra : moz-landing-system : lando
2020-01-10 15:35:03 +00:00
Neil Deakin
16f95497b9 Bug 1601301, rework webrtc permission granting UI around JSWindowActor, performing the work of determining the ultimate state for the tab icon and menu in the parent rather than the content process, r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D56570

--HG--
rename : browser/modules/webrtcUI.jsm => browser/actors/WebRTCParent.jsm
extra : moz-landing-system : lando
2020-01-10 15:09:59 +00:00
Neil Deakin
f4cc73018c Bug 1601301, add an 'include descendants' flag to mediaCaptureWindowState. With fission, need to handle each subframe separately, r=jib
The window will be supplied in the recording-device-events notification and mediaCaptureWindowState will be called on each window in turn.

Differential Revision: https://phabricator.services.mozilla.com/D56569

--HG--
extra : moz-landing-system : lando
2020-01-10 15:29:08 +00:00
Kris Maglione
0b1a146519 Bug 1596918: Part 4c - Fix callers which depend on document lifecycle changes. r=mccr8
ContentTask tasks have a different lifetime than SpecialPowers tasks, with the
former being tied to the lifetime of a message manager and the latter tied to
the lifetime of a window global. That means that existing ContentTask callers
which expect to be able to register load listeners before the creation of a
window global, or which expect to persist after a page has navigated, won't
work as SpecialPowers tasks.

Since those sorts of tasks are not really resilient in the face of Fission,
they should really be written to work differently, but this patch mostly just
reverts them to using ContentTask for the time being.

Differential Revision: https://phabricator.services.mozilla.com/D53744

--HG--
extra : moz-landing-system : lando
2019-12-13 20:36:36 +00:00
Kris Maglione
9853440599 Bug 1596918: Part 3b - Run code formatters on files changed by previous patch. r=mccr8,remote-protocol-reviewers,ato
Differential Revision: https://phabricator.services.mozilla.com/D53741

--HG--
extra : moz-landing-system : lando
2019-12-13 20:36:24 +00:00
Kris Maglione
94e3b0bd8d Bug 1596918: Part 3a - Scripted rewrite of most ContentTask.spawn calls to SpecialPowers.spawn calls. r=mccr8,remote-protocol-reviewers,ato
This is generally pretty straightforward, and rewrites nearly all calls. It
skips the ones that it can detect using frame script globals like
`sendAsyncMessage`, though.

Differential Revision: https://phabricator.services.mozilla.com/D53740

--HG--
extra : moz-landing-system : lando
2019-12-13 20:36:16 +00:00
Emma Malysz
57215abe07 Bug 1601094, rename the remaining .xul files in browser/ to .xhtml r=marionette-reviewers,whimboo,mossop
Differential Revision: https://phabricator.services.mozilla.com/D55751

--HG--
rename : browser/base/content/aboutDialog.xul => browser/base/content/aboutDialog.xhtml
rename : browser/base/content/newInstall.xul => browser/base/content/newInstall.xhtml
rename : browser/base/content/pageinfo/pageInfo.xul => browser/base/content/pageinfo/pageInfo.xhtml
rename : browser/base/content/safeMode.xul => browser/base/content/safeMode.xhtml
rename : browser/base/content/sanitize.xul => browser/base/content/sanitize.xhtml
rename : browser/base/content/titlebar-items.inc.xul => browser/base/content/titlebar-items.inc.xhtml
rename : browser/base/content/webext-panels.xul => browser/base/content/webext-panels.xhtml
rename : browser/base/content/webrtcIndicator.xul => browser/base/content/webrtcIndicator.xhtml
rename : browser/components/downloads/content/contentAreaDownloadsView.xul => browser/components/downloads/content/contentAreaDownloadsView.xhtml
rename : browser/components/migration/content/migration.xul => browser/components/migration/content/migration.xhtml
rename : browser/components/places/content/bookmarkProperties.xul => browser/components/places/content/bookmarkProperties.xhtml
rename : browser/components/places/content/bookmarksSidebar.xul => browser/components/places/content/bookmarksSidebar.xhtml
rename : browser/components/places/content/historySidebar.xul => browser/components/places/content/historySidebar.xhtml
rename : browser/components/places/content/places.xul => browser/components/places/content/places.xhtml
rename : browser/components/shell/content/setDesktopBackground.xul => browser/components/shell/content/setDesktopBackground.xhtml
extra : moz-landing-system : lando
2019-12-11 00:27:19 +00:00
shindli
91924fedc7 Backed out 9 changesets (bug 1596918) for causing mochitest permafailures in toolkit/content/tests/chrome/test_findbar_events.xhtml CLOSED TREE
Backed out changeset 45a1c42118f2 (bug 1596918)
Backed out changeset db09910ffa56 (bug 1596918)
Backed out changeset 5c9d9f141c10 (bug 1596918)
Backed out changeset 6a135670d603 (bug 1596918)
Backed out changeset 3a0184e0df72 (bug 1596918)
Backed out changeset 2f0036486823 (bug 1596918)
Backed out changeset a770c6d08d52 (bug 1596918)
Backed out changeset ef062eb7a6ee (bug 1596918)
Backed out changeset a6ea596e98db (bug 1596918)
2019-12-11 03:09:26 +02:00
Kris Maglione
356e59c6bc Bug 1596918: Part 4c - Fix callers which depend on document lifecycle changes. r=mccr8
ContentTask tasks have a different lifetime than SpecialPowers tasks, with the
former being tied to the lifetime of a message manager and the latter tied to
the lifetime of a window global. That means that existing ContentTask callers
which expect to be able to register load listeners before the creation of a
window global, or which expect to persist after a page has navigated, won't
work as SpecialPowers tasks.

Since those sorts of tasks are not really resilient in the face of Fission,
they should really be written to work differently, but this patch mostly just
reverts them to using ContentTask for the time being.

Differential Revision: https://phabricator.services.mozilla.com/D53744

--HG--
extra : moz-landing-system : lando
2019-12-10 23:07:22 +00:00
Kris Maglione
3ca78ce8e3 Bug 1596918: Part 3b - Run code formatters on files changed by previous patch. r=mccr8,remote-protocol-reviewers,ato
Differential Revision: https://phabricator.services.mozilla.com/D53741

--HG--
extra : moz-landing-system : lando
2019-12-10 23:07:21 +00:00
Kris Maglione
16a9b29848 Bug 1596918: Part 3a - Scripted rewrite of most ContentTask.spawn calls to SpecialPowers.spawn calls. r=mccr8,remote-protocol-reviewers,ato
This is generally pretty straightforward, and rewrites nearly all calls. It
skips the ones that it can detect using frame script globals like
`sendAsyncMessage`, though.

Differential Revision: https://phabricator.services.mozilla.com/D53740

--HG--
extra : moz-landing-system : lando
2019-12-10 23:07:13 +00:00
Noemi Erli
82d41a33b2 Backed out 9 changesets (bug 1596918) for causing multiple browser-chrome failures
Backed out changeset 415007efd8c9 (bug 1596918)
Backed out changeset 011eb5ce927b (bug 1596918)
Backed out changeset e5fd3ee22ea1 (bug 1596918)
Backed out changeset 0bca4de31d40 (bug 1596918)
Backed out changeset 11ec4393f23d (bug 1596918)
Backed out changeset c5404a7c286d (bug 1596918)
Backed out changeset 7e9304405a46 (bug 1596918)
Backed out changeset fa0f0aeabf99 (bug 1596918)
Backed out changeset de196b077000 (bug 1596918)
2019-12-07 22:26:43 +02:00
Kris Maglione
bd497b1a21 Bug 1596918: Part 4c - Fix callers which depend on document lifecycle changes. r=mccr8
ContentTask tasks have a different lifetime than SpecialPowers tasks, with the
former being tied to the lifetime of a message manager and the latter tied to
the lifetime of a window global. That means that existing ContentTask callers
which expect to be able to register load listeners before the creation of a
window global, or which expect to persist after a page has navigated, won't
work as SpecialPowers tasks.

Since those sorts of tasks are not really resilient in the face of Fission,
they should really be written to work differently, but this patch mostly just
reverts them to using ContentTask for the time being.

Differential Revision: https://phabricator.services.mozilla.com/D53744

--HG--
extra : moz-landing-system : lando
2019-12-07 18:44:34 +00:00
Kris Maglione
fa3556c3fc Bug 1596918: Part 3b - Run code formatters on files changed by previous patch. r=mccr8,remote-protocol-reviewers,ato
Differential Revision: https://phabricator.services.mozilla.com/D53741

--HG--
extra : moz-landing-system : lando
2019-12-07 18:44:34 +00:00
Kris Maglione
910eab35d2 Bug 1596918: Part 3a - Scripted rewrite of most ContentTask.spawn calls to SpecialPowers.spawn calls. r=mccr8,remote-protocol-reviewers,ato
This is generally pretty straightforward, and rewrites nearly all calls. It
skips the ones that it can detect using frame script globals like
`sendAsyncMessage`, though.

Differential Revision: https://phabricator.services.mozilla.com/D53740

--HG--
extra : moz-landing-system : lando
2019-12-07 19:11:58 +00:00
Daniel Varga
84a601a6d4 Backed out 17 changesets (bug 1596918) for multiple browser-chrome and dev-tools failures. On a CLOSED TREE
Backed out changeset ab87d2c1afae (bug 1596918)
Backed out changeset 775f3b06a687 (bug 1596918)
Backed out changeset 67cc63ef5d7f (bug 1596918)
Backed out changeset 7d290bcd2067 (bug 1596918)
Backed out changeset 048db9f4db7c (bug 1596918)
Backed out changeset 96a79d2ba614 (bug 1596918)
Backed out changeset be770d112dd8 (bug 1596918)
Backed out changeset 302c8ab8391c (bug 1596918)
Backed out changeset 44ef8f20732e (bug 1596918)
Backed out changeset 38c11ebfb8ff (bug 1596918)
Backed out changeset b586fc081374 (bug 1596918)
Backed out changeset 12283166716f (bug 1596918)
Backed out changeset 99b0421015d8 (bug 1596918)
Backed out changeset 97ec49dbbbf3 (bug 1596918)
Backed out changeset ec79478f58f1 (bug 1596918)
Backed out changeset c6d356833bb8 (bug 1596918)
Backed out changeset 5ef6026806c8 (bug 1596918)
2019-12-07 03:12:07 +02:00
Kris Maglione
73e3d8bcf6 Bug 1596918: Part 4c - Fix callers which depend on document lifecycle changes. r=mccr8
ContentTask tasks have a different lifetime than SpecialPowers tasks, with the
former being tied to the lifetime of a message manager and the latter tied to
the lifetime of a window global. That means that existing ContentTask callers
which expect to be able to register load listeners before the creation of a
window global, or which expect to persist after a page has navigated, won't
work as SpecialPowers tasks.

Since those sorts of tasks are not really resilient in the face of Fission,
they should really be written to work differently, but this patch mostly just
reverts them to using ContentTask for the time being.

Differential Revision: https://phabricator.services.mozilla.com/D53744

--HG--
extra : moz-landing-system : lando
2019-12-06 22:15:25 +00:00
Kris Maglione
b5238224ba Bug 1596918: Part 3b - Run code formatters on files changed by previous patch. r=mccr8,remote-protocol-reviewers,ato
Differential Revision: https://phabricator.services.mozilla.com/D53741

--HG--
extra : moz-landing-system : lando
2019-12-06 22:14:22 +00:00
Kris Maglione
20da940e14 Bug 1596918: Part 3a - Scripted rewrite of most ContentTask.spawn calls to SpecialPowers.spawn calls. r=mccr8,remote-protocol-reviewers,ato
This is generally pretty straightforward, and rewrites nearly all calls. It
skips the ones that it can detect using frame script globals like
`sendAsyncMessage`, though.

Differential Revision: https://phabricator.services.mozilla.com/D53740

--HG--
extra : moz-landing-system : lando
2019-12-06 22:14:14 +00:00
Thomas Nguyen
a0b817ac65 Bug 1483631 - Restrict nested permission requests in webrtc with permission delegate r=jib
Differential Revision: https://phabricator.services.mozilla.com/D47417

--HG--
extra : moz-landing-system : lando
2019-12-04 15:39:14 +00:00
Gurzau Raul
4f21dcd081 Backed out 4 changesets (bug 1483631) for failing at browser_temporary_permissions.js on a CLOSED TREE.
Backed out changeset f5bb5f6a148f (bug 1483631)
Backed out changeset c5e562c1d590 (bug 1483631)
Backed out changeset 7ef09193a7ef (bug 1483631)
Backed out changeset a909dcbbea2b (bug 1483631)
2019-12-03 21:57:55 +02:00
Thomas Nguyen
023216a561 Bug 1483631 - Restrict nested permission requests in webrtc with permission delegate r=jib
Differential Revision: https://phabricator.services.mozilla.com/D47417

--HG--
extra : moz-landing-system : lando
2019-12-03 16:25:31 +00:00
Neil Deakin
e2d055a3b8 Bug 1589664, adapt the webrtc tests to work with fission enabled. Remove the webrtc framescript in favour of calling BrowserTestUtils methods or SpecialPowers.spawn instead, r=florian
Differential Revision: https://phabricator.services.mozilla.com/D49736

--HG--
extra : moz-landing-system : lando
2019-10-29 00:32:04 +00:00
Johann Hofmann
ff1911cf74 Bug 1580319 - Clear PopupNotifications UI state when no checkbox is present. r=prathiksha
In getUserMedia we didn't use to have prompts without a checkbox, thus this bug couldn't manifest.
Now we do hide the checkbox for iframes, so this code path is triggered and doesn't properly
reset the UI state between prompts.

Differential Revision: https://phabricator.services.mozilla.com/D45911

--HG--
extra : moz-landing-system : lando
2019-09-16 09:44:07 +00:00
Paul Zuehlcke
89fb47a8d9 Bug 1531303 - Refactored tests using PermissionManager URI methods to use PermissionTestUtils. r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D41029

--HG--
extra : moz-landing-system : lando
2019-08-15 14:32:48 +00:00
Ciure Andrei
b454daea7a Backed out 3 changesets (bug 1531303) for causing close_window/close.py and browser_permissions_dialog.js to perma fail CLOSED TREE
Backed out changeset 87305e83174e (bug 1531303)
Backed out changeset 0c75c3bac00b (bug 1531303)
Backed out changeset 865c2a5d40da (bug 1531303)
2019-08-14 13:07:55 +03:00
Paul Zuehlcke
93bacc1004 Bug 1531303 - Refactored tests using PermissionManager URI methods to use PermissionTestUtils. r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D41029

--HG--
extra : moz-landing-system : lando
2019-08-14 08:31:23 +00:00
Paul Zuehlcke
5a377a3a37 Bug 630614 - Show an indicator when geolocation is in use. r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D35428

--HG--
extra : moz-landing-system : lando
2019-07-30 08:28:31 +00:00
Csoregi Natalia
141bcffcc8 Backed out changeset 3855d35999dd (bug 630614) for causing failures on browser_ext_tabs_sharingState.js. CLOSED TREE 2019-07-29 14:32:05 +03:00
Paul Zuehlcke
15afab0390 Bug 630614 - Show an indicator when geolocation is in use. r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D35428

--HG--
extra : moz-landing-system : lando
2019-07-29 08:37:55 +00:00
Victor Porof
f9f5914039 Bug 1561435 - Format browser/base/, a=automatic-formatting
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D36041

--HG--
extra : source : 96b3895a3b2aa2fcb064c85ec5857b7216884556
2019-07-05 09:48:57 +02:00
Carolina Jimenez Gomez
c374c10150 Bug 1530183 - Change promiseWaitForCondition for TestUtils.waitForCondition r=johannh
however, in the file head.js other functions use BrowserTestUtils instead of TestUtils, so I wasn't sure which of those is the
correct one, so I used the one suggested in the issue.

Differential Revision: https://phabricator.services.mozilla.com/D21011

--HG--
extra : moz-landing-system : lando
2019-02-25 14:46:22 +00:00
Brian Grinstead
04c18529e4 Bug 1487065 - Implement popup-notification as a Custom Element r=MattN
Differential Revision: https://phabricator.services.mozilla.com/D17699

--HG--
rename : toolkit/content/widgets/notification.xml => toolkit/content/widgets/popupnotification.js
extra : moz-landing-system : lando
2019-02-07 22:16:26 +00:00
Myk Melez
25349d2601 Bug 1518283 - prohibit blank lines at the beginning and end of blocks (eslint padded-blocks) r=mossop,Standard8
Differential Revision: https://phabricator.services.mozilla.com/D17526

--HG--
extra : moz-landing-system : lando
2019-01-30 17:26:25 +00:00
Kris Maglione
e930b89c34 Bug 1514594: Part 3 - Change ChromeUtils.import API.
***
Bug 1514594: Part 3a - Change ChromeUtils.import to return an exports object; not pollute global. r=mccr8

This changes the behavior of ChromeUtils.import() to return an exports object,
rather than a module global, in all cases except when `null` is passed as a
second argument, and changes the default behavior not to pollute the global
scope with the module's exports. Thus, the following code written for the old
model:

  ChromeUtils.import("resource://gre/modules/Services.jsm");

is approximately the same as the following, in the new model:

  var {Services} = ChromeUtils.import("resource://gre/modules/Services.jsm");

Since the two behaviors are mutually incompatible, this patch will land with a
scripted rewrite to update all existing callers to use the new model rather
than the old.
***
Bug 1514594: Part 3b - Mass rewrite all JS code to use the new ChromeUtils.import API. rs=Gijs

This was done using the followng script:

https://bitbucket.org/kmaglione/m-c-rewrites/src/tip/processors/cu-import-exports.jsm
***
Bug 1514594: Part 3c - Update ESLint plugin for ChromeUtils.import API changes. r=Standard8

Differential Revision: https://phabricator.services.mozilla.com/D16747
***
Bug 1514594: Part 3d - Remove/fix hundreds of duplicate imports from sync tests. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16748
***
Bug 1514594: Part 3e - Remove no-op ChromeUtils.import() calls. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16749
***
Bug 1514594: Part 3f.1 - Cleanup various test corner cases after mass rewrite. r=Gijs
***
Bug 1514594: Part 3f.2 - Cleanup various non-test corner cases after mass rewrite. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16750

--HG--
extra : rebase_source : 359574ee3064c90f33bf36c2ebe3159a24cc8895
extra : histedit_source : b93c8f42808b1599f9122d7842d2c0b3e656a594%2C64a3a4e3359dc889e2ab2b49461bab9e27fc10a7
2019-01-17 10:18:31 -08:00
Mark Banner
15b881a65f Bug 1521707 - Move promisePopupEvent to BrowserTestUtils.jsm. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D17259

--HG--
extra : moz-landing-system : lando
2019-01-23 14:04:46 +00:00
Andreas Pehrson
1bd9ff020f Bug 1421724 - Steal back focus from global webrtc indicator when doing second gUM requests. r=florian
Differential Revision: https://phabricator.services.mozilla.com/D15711

--HG--
extra : moz-landing-system : lando
2019-01-04 14:43:46 +00:00