nagai/fune
3
0
Fork 0
forked from mirrors/gecko-dev
Code Pull requests Activity
813976 commits 1 branch 98 tags 6.4 GiB
Commit graph

5556 commits

Author SHA1 Message Date
Marian-Vasile Laza
f54a464c90 Backed out changeset 2f74f8f2ed19 (bug 1689816) for causing reftest failures on skip-ink-multiline-position.html. 2022-09-26 23:24:03 +03:00
Emilio Cobos Álvarez
f875681246 Bug 1689816 - Implement <tabpanels> and <deck> without XUL layout. r=Gijs,Jamie,morgan,preferences-reviewers,mconley,TYLin 
Gijs for front-end bits, layout for the new CSS properties and the
removal of nsDeckFrame / nsStackLayout, Jamie and Morgan for the a11y
changes.

As discussed in the bug, the main tricky part here is handling a11y
correctly. For <deck>, that's trivial (just use `visibility: hidden` to
hide the panels visually, while removing the unselected panels from the
a11y tree).

For <tabpanels> however we need to do something special. We do want to
hide stuff visually, but we want to preserve the contents in the a11y
tree.

For that, the easiest fix is introducing a new privileged CSS property
(-moz-subtree-hidden-only-visually), which takes care of not painting
the frame, but marks stuff offscreen in the accessibility tree. This is
not intended to be a property used widely.

Other than that, the changes are relatively straight-forward, though
some of the accessible/mac changes I could get a sanity-check on.

Differential Revision: https://phabricator.services.mozilla.com/D157875
 2022-09-26 17:40:30 +00:00
Emilio Cobos Álvarez
cb0b3ab372 Bug 1791972 - Simplify dialog stack and rdm styles. r=Gijs,devtools-reviewers,jdescottes 
.browserContainer is relatively positioned, so we can position the
tab-modal dialogs absolutely inside it instead of making them part of
the browser stack.

While at it, make the rdm toolbar part of the regular browserContainer,
just like the regular devtools toolbox is. That way there's no need to
do ResizeObserver shenanigans to be able to let it grow. Keep it also
absolutely positioned tho, because we need to overlay the whole
container when the device modal is opened. That's somewhat gross.

This should in general be simpler to understand than the current set-up,
and more performant to since it avoids the dialog stack from forming
part of the browser element's flow.

Differential Revision: https://phabricator.services.mozilla.com/D157912
 2022-09-23 22:23:37 +00:00
Brian
34064a8838 Bug 1788925 - Convert AboutReader from JSM to ESM. r=Gijs. 
Differential Revision: https://phabricator.services.mozilla.com/D157034
 2022-09-23 21:19:12 +00:00
Evan
f71e1c1af2 Bug 1788783 -Converted Picture in Picture JSM modules to ESMs. r=kpatenio 
Differential Revision: https://phabricator.services.mozilla.com/D157039
 2022-09-23 18:11:48 +00:00
Daisuke Akatsuka
042de19c2e Bug 1790814: Depends on existing tabs to change the tab to open about:addons page. r=daleharvey 
Differential Revision: https://phabricator.services.mozilla.com/D157400
 2022-09-21 22:58:47 +00:00
Ryan VanderMeulen
0109742091 Bug 1784692 - Revert focus behavior for new windows introduced by bug 1770818. a=backout 2022-09-21 14:08:31 -04:00
Niklas Baumgardner
33d42fbb13 Bug 1790823 - Firefox View button should not be open when added to toolbar. r=dao 
Differential Revision: https://phabricator.services.mozilla.com/D157662
 2022-09-19 21:54:45 +00:00
Julian Descottes
87ef6aa2ff Bug 1790753 - [devtools] Track all devtools sockets in DevToolsSocketStatus r=ochameau,Gijs 
The DevToolsSocketStatus could be misleading for any usage other than the current one from browser.js since it misses browser toolbox sockets

This patch allows the singleton to track all sockets but changes the API to allow consumers to exclude browser toolbox sockets.

Differential Revision: https://phabricator.services.mozilla.com/D157300
 2022-09-14 19:11:22 +00:00
Sarah Clements
204e4fc381 Bug 1787979 - keyboard shortcut navigates to the wrong tab from Firefox View tab r=dao 
* Remove index: 0 in FirefoxViewHandler.openTab
* Add condition in tabbrowser _selectNextTab for FirefoxView tab
* Fix tests

Differential Revision: https://phabricator.services.mozilla.com/D156688
 2022-09-14 15:20:01 +00:00
Marian-Vasile Laza
02b993c483 Backed out changeset 9bf0a16672ec (bug 1787979) for causing bc failures on browser_sma_click_element.js. CLOSED TREE 2022-09-14 16:45:04 +03:00
Sarah Clements
20971e4d83 Bug 1787979 - keyboard shortcut navigates to the wrong tab from Firefox View tab r=dao 
* Remove index: 0 in FirefoxViewHandler.openTab
* Add condition in tabbrowser _selectNextTab for FirefoxView tab
* Fix tests

Differential Revision: https://phabricator.services.mozilla.com/D156688
 2022-09-14 11:24:58 +00:00
Brian
b34f9afb6d Bug 1788776 - Convert screenshots component from JSM to ESM. r=niklas. 
Differential Revision: https://phabricator.services.mozilla.com/D157038
 2022-09-11 19:08:38 +00:00
Bernard Igiri
ae6f7157e4 Bug 1784054 - Enable full height scrolling in Colorway Closet modal in small windows r=dao 
Updated SubDialog.jsm's sizeTo=available to have better support for responsive layouts with the ability to specify max height and widths on the dialog.

Differential Revision: https://phabricator.services.mozilla.com/D155014
 2022-09-08 17:43:58 +00:00
Mark Banner
c9b0aa74c1 Bug 1789254 - Migrate enterprisepolicies consumers to use ESM imports directly. r=mkaply,necko-reviewers,application-update-reviewers,nalexander 
Differential Revision: https://phabricator.services.mozilla.com/D156464
 2022-09-08 14:40:07 +00:00
Norisz Fay
1bb0960ae2 Backed out 3 changesets (bug 1789254) for causing bc failures on browser_xpcom_graph_wait.js CLOSED TREE 
Backed out changeset bea1e1ba4a14 (bug 1789254)
Backed out changeset 4086aaa5f3d0 (bug 1789254)
Backed out changeset 131cac1d1146 (bug 1789254)
 2022-09-08 17:14:00 +03:00
Mark Banner
5dca28c108 Bug 1789254 - Migrate enterprisepolicies consumers to use ESM imports directly. r=mkaply,necko-reviewers,application-update-reviewers,nalexander 
Differential Revision: https://phabricator.services.mozilla.com/D156464
 2022-09-08 12:43:32 +00:00
Dão Gottwald
684a24a549 Bug 1787797 - Let the Firefox View menu item re-add the button to the tabs toolbar if it got previously removed. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D156412
 2022-09-07 12:21:25 +00:00
Katherine Patenio
b1e0f5998c Bug 1767827: Use Nimbus feature (with pref fallback) as the condition for enabling Firefox View r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D156004
 2022-09-02 15:45:21 +00:00
Gijs Kruitbosch
ba0b238fde Bug 1787437 - close the Firefox View tab when removing the FxView toolbar item completely, r=dao 
Differential Revision: https://phabricator.services.mozilla.com/D155921
 2022-09-02 12:49:54 +00:00
James Teow
3f63de5a98 Bug 1779465 - Part 1: Show search term on default SERP - r=adw 
Differential Revision: https://phabricator.services.mozilla.com/D153280
 2022-09-01 19:26:29 +00:00
Niklas Baumgardner
cda1615035 Bug 1784294 - Sync tabs when Firefox View tab is selected. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D154825
 2022-09-01 13:06:50 +00:00
Daisuke Akatsuka
836333a034 Bug 1786249: Fixup sponsored link. r=mak 
Differential Revision: https://phabricator.services.mozilla.com/D155807
 2022-08-30 22:02:18 +00:00
Butkovits Atila
59d03e0b1d Backed out 2 changesets (bug 1676492) for causing failures at test_navigation.py. CLOSED TREE 
Backed out changeset 09fd88048f35 (bug 1676492)
Backed out changeset bc76e6966ec9 (bug 1676492)
 2022-08-30 20:56:51 +03:00
Sean Feng
712dda078c Bug 1750034 - Remove lazyload telemetry related code r=emilio 
We have decided to use 600px in all directions, there's no need
to keep the telemetry stuff around.

Differential Revision: https://phabricator.services.mozilla.com/D155879
 2022-08-30 16:00:11 +00:00
Neil Deakin
507f721d6c Bug 1676492, show the bookmarks toolbar when a new window is opened when the preference is set to show a blank page, r=Mardak,preferences-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D155003
 2022-08-30 14:02:02 +00:00
Neil Deakin
444a492608 Bug 1676492, create a special blank tab page that will show the bookmarks toolbar when 'Only Show on New Tab' is used' even when the new tab page is disabled, r=Gijs,Mardak 
Differential Revision: https://phabricator.services.mozilla.com/D154319
 2022-08-30 14:02:01 +00:00
Meg Viar
4120ecafe3 Bug 1786356 - Create Firefox View open Tracker r=niklas,jprickett 
Differential Revision: https://phabricator.services.mozilla.com/D155432
 2022-08-26 16:16:17 +00:00
Gijs Kruitbosch
31960f9a88 Bug 1787443 - ensure fxview button is always present by default, also for upgrading profiles, r=dao 
Differential Revision: https://phabricator.services.mozilla.com/D155695
 2022-08-26 15:50:18 +00:00
Mark Banner
fb7f9b8a58 Bug 1786899 - Remove unused uri argument to BrowserSearch.addEngine. r=jteow 
Differential Revision: https://phabricator.services.mozilla.com/D155498
 2022-08-26 07:55:44 +00:00
Mark Banner
ef27351558 Bug 1786899 - Remove unused BrowserSearch.loadAddEngines and remove formatURL. r=jteow,preferences-reviewers 
formatURL is only used in one other place - nsContextMenu.js, so we don't really need that when we can call the necessary function direct.

Also moves `searchEnginesURL` into SearchUIUtils, as that seems a reasonable place to start storing things like that.

Differential Revision: https://phabricator.services.mozilla.com/D155496
 2022-08-26 07:55:44 +00:00
Paul Zuehlcke
3e16fc7823 Bug 1751481 - Enable felt privacy features by default and integrate with Nimbus. r=dao,preferences-reviewers,Gijs 
Depends on D155013

Differential Revision: https://phabricator.services.mozilla.com/D155065
 2022-08-25 11:17:39 +00:00
Dão Gottwald
fc26620216 Bug 1786293 - Move Firefox View button from CustomizableWidgets to markup. r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D155356
 2022-08-24 15:51:44 +00:00
Norisz Fay
ccea767237 Backed out changeset ebba7740ac81 (bug 1784294) for causing bc failures on browser_setup_state.js CLOSED TREE 2022-08-24 09:33:55 +03:00
Niklas Baumgardner
31e1c7de1e Bug 1784294 - Sync tabs when Firefox View tab is selected. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D154825
 2022-08-24 02:43:35 +00:00
Daisuke Akatsuka
ca76247e3d Bug 1565751: Use 'SetURI' event for custom new window. r=adw,scunnane 
Differential Revision: https://phabricator.services.mozilla.com/D155184
 2022-08-24 00:43:04 +00:00
Dão Gottwald
7174d39cef Bug 1774435 - Remove NIGHTLY_BUILD conditions for Firefox View. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D154398
 2022-08-23 09:50:42 +00:00
Dão Gottwald
f5f3bf4611 Bug 1785819 - Announce Firefox View toolbar button as a tab to screen readers. r=ayeddi 
Differential Revision: https://phabricator.services.mozilla.com/D154986
 2022-08-18 17:02:02 +00:00
Daisuke Akatsuka
9a83490432 Bug 1784369: Make opening in new window target for inheritance of sponsored sessions. r=daleharvey 
Differential Revision: https://phabricator.services.mozilla.com/D154483
 2022-08-16 00:41:01 +00:00
Norisz Fay
b1df28edbf Backed out 3 changesets (bug 1784369, bug 1784242) for causing node newtab failures CLOSED TREE 
Backed out changeset f19a8a76a85b (bug 1784242)
Backed out changeset 0722fc4bb4fa (bug 1784242)
Backed out changeset 2d4131b0ca28 (bug 1784369)
 2022-08-16 03:19:32 +03:00
Daisuke Akatsuka
05112fc891 Bug 1784369: Make opening in new window target for inheritance of sponsored sessions. r=daleharvey 
Differential Revision: https://phabricator.services.mozilla.com/D154483
 2022-08-15 23:45:32 +00:00
Stephanie Cunnane
670b9de81f Bug 1770818 - Focus the address bar when opening a new window with a custom new window URL configured. r=adw 
Differential Revision: https://phabricator.services.mozilla.com/D151946
 2022-08-11 22:05:35 +00:00
Daisuke Akatsuka
e15624b98f Bug 1776607: Record search source from context menu. r=mak 
Depends on D151574

Differential Revision: https://phabricator.services.mozilla.com/D153430
 2022-08-08 21:07:32 +00:00
Daisuke Akatsuka
b1ef8cd2cd Bug 1776607: Record search source for urlbar. r=mak 
Differential Revision: https://phabricator.services.mozilla.com/D151573
 2022-08-08 21:07:31 +00:00
Ben Hearsum
fcc72f99cf Bug 1766636: ensure page info dialog opened by private browsing window groups with the correct taskbar icon r=Gijs 
`nsWindow::Create` will do the right thing (including keeping this behaviour off by default for now) as long as `private` is set appropriately.

Differential Revision: https://phabricator.services.mozilla.com/D152460
 2022-08-08 15:59:38 +00:00
William Durand
c7d049842d Bug 1780746 - Add new Telemetry objects for manage/remove/report events in unified extensions context menu. r=rpl 
Differential Revision: https://phabricator.services.mozilla.com/D153460
 2022-08-05 13:58:15 +00:00
Niklas Baumgardner
51ffb2fe73 Bug 1782723 - init Firefox View only in Nightly builds. r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D153488
 2022-08-03 12:03:55 +00:00
Shane Hughes
7a051f00ca Bug 1782717 - Fix back/forward menu tooltip string for current page item to indicate it will reload page. r=Gijs,flod 
The back/forward menu shows tooltips when hovering menuitems. For the
current page, the tooltip says Stay on this page, but the effect of the
menuitem is actually to reload the current page. So change the tooltip
string to reflect that the page will reload when the item is clicked.

Differential Revision: https://phabricator.services.mozilla.com/D153468
 2022-08-03 09:56:23 +00:00
Ryan VanderMeulen
cc938d4a90 Bug 1773042 - Remove the accessibility indicator. r=eeejay,Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D152928
 2022-08-02 16:36:27 +00:00
Dão Gottwald
7c4732f5fe Bug 1782675 - Add button helper to FirefoxViewHandler and make attention a boolean attribute. r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D153447
 2022-08-02 12:20:07 +00:00