Commit graph

79 commits

Author SHA1 Message Date
Brendan Dahl
aa526601d4 Bug 1434077 - Inline indicators overlay. r=Paolo
This is part of the work to remove XUL overlays. The overlay was originally
created to help startup performance, but inlining the overlay seems to
no longer have detrimental effects to performance and is more straightforward.

MozReview-Commit-ID: 7sfVel6qvgv

--HG--
extra : rebase_source : b6311cf1fb98851b4f4203c314ae9ecc8160d766
2018-02-14 12:20:58 -08:00
Kris Maglione
918ed6c474 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl

--HG--
extra : source : 12fc4dee861c812fd2bd032c63ef17af61800c70
extra : intermediate-source : 34c999fa006bffe8705cf50c54708aa21a962e62
extra : histedit_source : b2be2c5e5d226e6c347312456a6ae339c1e634b0
2018-01-29 15:20:18 -08:00
Cosmin Sabou
9a65a40178 Backed out 3 changesets (bug 1431533) for Android mochitest failures on testEventDispatcher on a CLOSED TREE
Backed out changeset a1eca62826a1 (bug 1431533)
Backed out changeset 34c999fa006b (bug 1431533)
Backed out changeset e2674287e57f (bug 1431533)
2018-01-30 07:17:48 +02:00
Kris Maglione
6476f95b13 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl

--HG--
extra : source : 12fc4dee861c812fd2bd032c63ef17af61800c70
2018-01-29 15:20:18 -08:00
Brindusan Cristian
af8879d1eb Backed out 2 changesets (bug 1431533) for ESlint failures on a CLOSED TREE
Backed out changeset 6e56f4c8843e (bug 1431533)
Backed out changeset 12fc4dee861c (bug 1431533)
2018-01-30 02:32:43 +02:00
Kris Maglione
c276bb9375 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl

--HG--
extra : rebase_source : c004a023389f1f6bf3d2f3efe93c13d423b23ccd
2018-01-29 15:20:18 -08:00
Erica Wright
ca7e87e24c Bug 1033395 - Panels Should Be Anchored from the Same Height on the Toolbar. r=johannh
MozReview-Commit-ID: 6bhlfeD1esE

--HG--
extra : rebase_source : 9f6eeffb105baf8fe54c509369c6b5eadc88c598
2017-09-13 15:49:32 -04:00
Phil Ringnalda
dcda41b943 Backed out changeset 5b9d2ebcf44e (bug 1033395) for failures in browser_overflow_anchor.js
MozReview-Commit-ID: LfhmJLydnaF
2017-10-16 22:01:54 -07:00
Erica Wright
d29984c27b Bug 1033395 - Panels Should Be Anchored from the Same Height on the Toolbar. r=johannh
MozReview-Commit-ID: 6bhlfeD1esE

--HG--
extra : rebase_source : 6e2d645505f154ae556827032af2e51f32657484
2017-09-13 15:49:32 -04:00
Gijs Kruitbosch
e931ee1884 Bug 1399490 - fix unhiding the downloads button in customize mode if it was moved to the palette, r=nhnt11
MozReview-Commit-ID: 7Q8yPzBVxim

--HG--
extra : rebase_source : 865ec5357bcadabb12d7f08692cd4995b9914fc6
2017-09-13 16:24:13 +01:00
Gijs Kruitbosch
ecf2be01ab Bug 1397447 - make downloads button autohide by default, r=mak
MozReview-Commit-ID: E9izQpa4fFZ

--HG--
extra : rebase_source : 11dc3f1b98f53f5897a3185253b68d2cf7d5083b
extra : source : 97f7f5175b2fc3adfb193783f7ecb70b5b9b4562
2017-09-08 14:16:36 +01:00
Zibi Braniecki
70e0d2b8e8 Bug 1398390 - Only react to mousedown if it is a left-click. r=Gijs
MozReview-Commit-ID: Ie2Xgasg2eN

--HG--
extra : rebase_source : 5e58c418f91a1802328c4128dffd2c1ab9aa067f
2017-09-09 22:17:19 -07:00
Sebastian Hengst
a4b102b6d9 Backed out changeset 1a8147d55b02 (bug 1398390) for failing browser-chrome's browser_overflow_anchor.js at least on macOS and Windows. r=backout 2017-09-10 09:37:30 +02:00
Zibi Braniecki
923420c64a Bug 1398390 - Only react to mousedown if it is a left-click. r=Gijs
MozReview-Commit-ID: Ie2Xgasg2eN

--HG--
extra : rebase_source : 9aeed150b6106210bbe06e8a98ae602e5471851b
2017-09-09 22:17:19 -07:00
Gijs Kruitbosch
e47e6f071c Back out changeset 97f7f5175b2f (bug 1371765) because we're changing the plan for the downloads button, rs=backout,firebot,paolo
MozReview-Commit-ID: FTvFDV5nuG6

--HG--
extra : rebase_source : af8ed6b6da9adc1badbdc5016aacb877511875f0
2017-08-25 13:32:47 +01:00
Gijs Kruitbosch
ace9ca19d1 Bug 1371765 - make downloads button non-customizable, r=jaws,Paolo
MozReview-Commit-ID: E9izQpa4fFZ

--HG--
extra : rebase_source : f2c8a292c5bddb2dfde656b0f37fe2abee371ea0
2017-08-16 15:54:36 +01:00
Sam Foster
cb750380af Bug 1388183 - Queue and play the last download notification instead of truncating/aborting it. r=Paolo
* Maintain a _nextNotificationType LIFO "queue" of one, to play overlapping events in series
* _showNotification assumes everything could have changed since it was last called
* Signature of showEventNotification is unchanged, but most of its work is now done in _showNotification

MozReview-Commit-ID: 8sv4DZoZU65

--HG--
extra : rebase_source : 6c7fe7fd3b1d0401247d964d378c6829b04e2b93
2017-08-11 16:06:02 -07:00
Sebastian Hengst
549eba284b Backed out changeset bf522e33426e (bug 1388183) for eslint failure browser/components/downloads/content/indicator.js. r=backout on a CLOSED TREE 2017-08-17 22:04:54 +02:00
Sam Foster
c01a1898f4 Bug 1388183 - Queue and play the last download notification instead of truncating/aborting it. r=Paolo
* Maintain a _nextNotificationType LIFO "queue" of one, to play overlapping events in series
* _showNotification assumes everything could have changed since it was last called
* Signature of showEventNotification is unchanged, but most of its work is now done in _showNotification

MozReview-Commit-ID: 8sv4DZoZU65

--HG--
extra : rebase_source : 9d6a0fc905b42e8843693f6c5fe8cd1444d08868
2017-08-11 16:06:02 -07:00
Jared Wein
76f886b972 Bug 1385913 - Remove MOZ_PHOTON_ANIMATIONS ifdef. r=Gijs
MozReview-Commit-ID: 40TP43EKPCU

--HG--
extra : rebase_source : 203f7449e8345ed5c779dfc4fd5e9bd515b89da8
2017-08-07 12:37:34 -04:00
Sam Foster
6130972950 Bug 1376519 - Photon download notifications. r=Paolo
* Filmstrip style svg animation for start download notification, vertically centered to allow for variable-height toolbar buttons
* Simultaneous identifer "dip" animation on the icon for download start
* Identifier icon bounce animation for download finish (no notification animation in the #downloads-animation-container)
* Always measure the anchor element as toolbarheight may change in a session (e.g. switching to compact mode)
* Conditionally include the start/finish pngs for non-Photon builds
* Have #downloads-notification-anchor hidden by default, and show it before measuring for placement. This avoids the interference with scrolling/APZ when the notifier element is tall enough to overlap the tabbrowser element

MozReview-Commit-ID: LJF6iV9HiJi

--HG--
extra : rebase_source : 80238cf0240c32943667ee4c141c756813b2728e
2017-07-31 09:36:27 -07:00
Sebastian Hengst
5e99d130c4 Backed out changeset c6bbe349d654 (bug 1376519) on suspicion of letting mochitest test_bug574663.html fail. r=backout 2017-07-24 21:06:49 +02:00
Sam Foster
97c128c536 Bug 1376519 - Photon download notifications. r=Paolo
* Filmstrip style svg animation for start download notification, vertically centered to allow for variable-height toolbar buttons
* Simultaneous identifer "dip" animation on the icon for download start
* Identifier icon bounce animation for download finish (no notification animation in the #downloads-animation-container)
* Always measure the anchor element as toolbarheight may change in a session (e.g. switching to compact mode)
* Conditionally include the start/finish pngs for non-Photon builds

MozReview-Commit-ID: LJF6iV9HiJi

--HG--
extra : rebase_source : 4af001e78fef409ff7ff6b273bc426c438f25de3
2017-07-13 10:59:59 -07:00
Sam Foster
9afb8e9798 Bug 1375309 - Implement Photon download progressbar r=Paolo
* Split out the arrow and progressbar in the indicatorOverlay for individual animation.
* Group icon and progressbar parts into addressable elements in a single download-icons.svg

MozReview-Commit-ID: KAn0gFqjKjc

--HG--
extra : rebase_source : 4df5377be7d6d0b42eaebd1e28286b81fd555ec2
2017-06-28 15:03:52 -07:00
Doug Thayer
f1396f3334 Bug 1359733 - (pt. 5) Pull out indicator.js badges r=Gijs
See also pt. 4. We are moving app menu notification state
into a jsm since it is not specific to one window and this
simplifies work for the new app update UI.

MozReview-Commit-ID: InEp5b0y2n0

--HG--
extra : rebase_source : afe4870fe01d64c7b870ddf568c525e6b12f27b2
2017-05-15 11:57:58 -07:00
Sam Foster
fb61af287a Bug 1329109 - remove unused time and progressbar code from downloads toolbar icon. r=Paolo
This removes the arrowStyledIndicator killswitch and the associated ability for system add-ons to restore the previous design of the Downloads Indicator in the toolbar. The removal includes all the related code, styles, and strings. Based on the original patch by :rexboy.

MozReview-Commit-ID: 2OEBzPNzl0O

--HG--
extra : rebase_source : f40a319bb4afacb9e196465fc901cb3eb0b25ab5
2017-05-08 10:11:52 -07:00
Doug Thayer
f463069928 Bug 893505 - Simplify the application update UI r=chmanchester,enndeakin+6102,Gijs,rstrong
There's quite a few changes in here. At a high level, all we're trying to do
is to replace the old update popup with a less intrusive and more modern
doorhanger (set of doorhangers) for various update failure conditions.

MozReview-Commit-ID: 24sESMTosNX

--HG--
extra : rebase_source : ee0c1e00fe3f99e16388f0de17274ff97a3b9fcf
2017-03-21 13:50:09 -07:00
Yiren Wang
5f88f7294a Bug 1264206 - Enable ESLint for browser/components/downloads and fix the existing issues. r=Standard8
MozReview-Commit-ID: HDjTxdFCnRp
2017-04-03 10:25:05 +01:00
Rex Lee
b24135064f Bug 1270012 - Show a bouncing animation for toolbar download icon whenever a download is started. r=paolo
MozReview-Commit-ID: GCDhtYCVC6

--HG--
extra : rebase_source : 2b3c4e12265c9c064651ab3f1359d796c07415b1
2016-09-12 18:27:22 +08:00
Rex Lee
7e3e9279f6 Bug 1338984 - Adjust brightness with respect to download progress for arrow-typed progress icon. r=Paolo
MozReview-Commit-ID: 9pMRmsduskA

--HG--
extra : rebase_source : 3202e80f51320c54e1e26d6a6d50babd5e15d7f5
2017-02-24 17:33:41 +08:00
Rex Lee
1801ff7637 Bug 1270006 - Fill portion of the icon on download button as indicator to download progress r=Paolo
MozReview-Commit-ID: BqYow8jWCVD

--HG--
extra : rebase_source : 4b365535089619a5faf0d3c4f0c4dcd6b4067a43
2016-08-24 18:39:53 +08:00
Florian Quèze
85611a7b6d Bug 1331081 - script generated patch to omit addEventListener/removeEventListener's third parameter when it's false, r=jaws.
--HG--
extra : rebase_source : a22344ee1569f58f1f0a01017bfe0d46a6a14602
2017-01-17 11:50:25 +01:00
Tooru Fujisawa
9bfd0f50fc Bug 92737 - Part 8: Download multiple files when multiple items are dropped on Downloads button. r=enndeakin 2014-12-21 19:05:03 +09:00
Panos Astithas
6809a297cd Bug 1139472 - Extend the attention state of the Downloads Indicator to indicate success or failure. r=paolo
With this change two new attention states are introduced, "severe" and "warning",
along with the previous "success" and "no attention" states. "No attention" is
still a falsy value in order to mitigate any add-on compatibility issues.
"severe" and "warning states" now display an icon badge to the downloads button
(or the hamburger button if the downloads button is tucked away).

MozReview-Commit-ID: 3gc9Ji7zCXY
2016-04-22 23:09:07 +03:00
Matthew Turnbull
e8fcc4d761 Bug 1213620 - Expose DownloadsButton to the global scope for addon-compat. r=gijs 2015-10-11 14:35:00 +02:00
Carsten "Tomcat" Book
08997000eb Backed out 2 changesets (bug 1202902) to recking bug 1202902 to be able to reopen inbound on a CLOSED TREE
Backed out changeset 647025383676 (bug 1202902)
Backed out changeset d70c7fe532c6 (bug 1202902)
2015-10-07 14:03:21 +02:00
Sebastian Hengst
cdcff6d0a7 Backed out changeset c6b267589d0d (bug 1202902) for Mulet Reftest, W3C Platform Test and other failures. r=backout a=backout on a CLOSED TREE 2015-10-07 13:36:26 +02:00
Shu-yu Guo
52e365bb7b Bug 1202902 - Fix the world. (r=ato for marionette, rs=Mossop for rest) 2015-10-06 14:00:30 -07:00
Tooru Fujisawa
e3e8c7540e Bug 1207491 - Part 6: Remove use of expression closure from browser/components/downloads/. r=Gijs
--HG--
extra : commitid : 8BIIBSCXIf9
extra : rebase_source : cca677e0c83e99cca719f5b6f794060fa0144205
2015-09-23 18:36:20 +09:00
Paolo Amadini
d4c5c8ca0b Bug 1115364 - Downloads Panel code style refresh. r=jaws 2014-12-29 12:35:27 +00:00
Jim Blandy
7e20285e70 Bug 914753: Make Emacs file variable header lines correct, or at least consistent. DONTBUILD r=ehsan
The -*- file variable lines -*- establish per-file settings that Emacs will
pick up. This patch makes the following changes to those lines (and touches
nothing else):

 - Never set the buffer's mode.

   Years ago, Emacs did not have a good JavaScript mode, so it made sense
   to use Java or C++ mode in .js files. However, Emacs has had js-mode for
   years now; it's perfectly serviceable, and is available and enabled by
   default in all major Emacs packagings.

   Selecting a mode in the -*- file variable line -*- is almost always the
   wrong thing to do anyway. It overrides Emacs's default choice, which is
   (now) reasonable; and even worse, it overrides settings the user might
   have made in their '.emacs' file for that file extension. It's only
   useful when there's something specific about that particular file that
   makes a particular mode appropriate.

 - Correctly propagate settings that establish the correct indentation
   level for this file: c-basic-offset and js2-basic-offset should be
   js-indent-level. Whatever value they're given should be preserved;
   different parts of our tree use different indentation styles.

 - We don't use tabs in Mozilla JS code. Always set indent-tabs-mode: nil.
   Remove tab-width: settings, at least in files that don't contain tab
   characters.

 - Remove js2-mode settings that belong in the user's .emacs file, like
   js2-skip-preprocessor-directives.
2014-06-24 22:12:07 -07:00
Gijs Kruitbosch
820ad0464c Bug 963143 - Australis - fix nits for download finish notification patch, rs=mak
--HG--
extra : rebase_source : dec8b20839abdfccb9429d949b2e20709495ad9d
2014-03-15 19:21:36 +01:00
Gijs Kruitbosch
5c52c42a0c Bug 963143 - downloads animation no longer showing when button is in Australis' menu or overflow panel, r=mak
--HG--
extra : rebase_source : 2e74cb17e9a080a2dd5bd27b501b4fe1719bd310
2014-03-14 17:01:34 +01:00
Gijs Kruitbosch
af6f8f6fef Merge mozilla-central and ux 2013-11-12 09:27:50 +01:00
Gijs Kruitbosch
7ec6121dd6 Bug 935836 - should ensure button is operational when it's not, r=mconley 2013-11-11 14:24:54 +01:00
Matthew Noorenberghe
be474fa47a Merge mozilla-central to UX 2013-11-05 01:04:20 -08:00
Paolo Amadini
147dff90bb Bug 899110 - Remove the code to switch between different back-ends from the Downloads Panel. r=enn 2013-11-04 19:21:13 +01:00
Gijs Kruitbosch
d2c7103f90 Bug 916256 - download animation should anchor on panel anchor when the downloads button is in a panel, r=mconley 2013-10-07 15:54:25 +02:00
Gijs Kruitbosch
4ef230e3b8 Merge m-c to ux 2013-10-03 17:20:04 +02:00
Gijs Kruitbosch
3c0e16851b Bug 922847 - Separate animation from download button, r=mconley 2013-10-01 14:15:00 +02:00