Commit graph

22557 commits

Author SHA1 Message Date
Lina Cambridge
f9abd62b34 Bug 1596322 - Add XPCOM bindings for Rust Sync engines. r=markh,tcsc,LougeniaBailey
This commit adds a new crate for bridging Rust Sync engines to Desktop,
and a `mozIBridgedSyncEngine` for accessing the bridge via JS.
Naturally, the bridge is called Golden Gate. 😊 For more information
on how to use it, please see `golden_gate/src/lib.rs`.

Other changes include:

* Ensuring the test Sync server uses UTF-8 for requests and responses.
* Renaming `mozISyncedBookmarksMirrorLogger` to `mozIServicesLogger`,
  and moving it into the shared Sync interfaces.

The `BridgedEngine` trait lives in its own crate, called
`golden_gate_traits`, to make it easier to eventually move into a-s.
`Interruptee` and `Interrupted` already exist in a-s, and are
duplicated in this crate for now.

Differential Revision: https://phabricator.services.mozilla.com/D65268

--HG--
extra : moz-landing-system : lando
2020-04-09 15:45:37 +00:00
Ciure Andrei
130b66d511 Backed out 2 changesets (bug 1626573) for causing lint failures CLOSED TREE
Backed out changeset 0d461e174640 (bug 1626573)
Backed out changeset 00443a958bbc (bug 1626573)
2020-04-09 15:54:59 +03:00
Subhamoy Sengupta
8db691de33 Bug 1626573 - P2 - Browser Mochitests added to test if opening blob URL in a new tab by right clicking works r=baku
Two cases have been tested:

  1. Right-click opening a blob URL
  2. Right-click opening a blob URL, which points to a blob of type html, which fetches another blob URL

Differential Revision: https://phabricator.services.mozilla.com/D70197

--HG--
extra : moz-landing-system : lando
2020-04-09 11:55:58 +00:00
Artem
c864bc38f7 Bug 1609563 - Migrate browser-allTabsMenu.inc.xhtml to Fluent r=fluent-reviewers,mconley,flod
Differential Revision: https://phabricator.services.mozilla.com/D70238

--HG--
extra : moz-landing-system : lando
2020-04-09 06:14:25 +00:00
Oana Pop Rus
90abf0bc61 Backed out 2 changesets (bug 1625513) for bc failures in browser/base/content/test/siteIdentity/browser_identity_UI.js on a CLOSED TREE
Backed out changeset 876b33334577 (bug 1625513)
Backed out changeset 69f75d37ae8e (bug 1625513)

--HG--
extra : rebase_source : e8752080577e762777eff9cda7a695bfa2ccd4cf
2020-04-09 00:57:32 +03:00
Emma Malysz
a7282ce447 Bug 1590573, create a unified approach for caching fragments in our Custom Elements r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D58866

--HG--
extra : moz-landing-system : lando
2020-04-08 16:17:50 +00:00
William Durand
b90b5b3778 Bug 1489430 - Add "Remove Extension" context menu item for pageAction. r=robwu,mstriemer,fluent-reviewers,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D69831

--HG--
extra : moz-landing-system : lando
2020-04-08 14:18:53 +00:00
Dão Gottwald
3b8b1171af Bug 1627969 - Remove the megabar pref. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D70023

--HG--
extra : moz-landing-system : lando
2020-04-08 19:04:24 +00:00
Nika Layzell
e7ed7401ba Bug 1625513 - Part 1: Perform onMayChangeProcess handling within DocumentLoadListener, r=mattwoodrow,pbone,droeh
When I first added this method last year, I added it in JS, handled from within
SessionStore.jsm, as that was the easiest place to do it. Now that
DocumentLoadListener exists, it makes more sense to handle this logic directly
from within that code.

Many parts of the process switch are still handled by frontend JS, such as
selecting remote types, and performing toplevel process switches.

Differential Revision: https://phabricator.services.mozilla.com/D68594

--HG--
extra : moz-landing-system : lando
2020-04-08 16:56:37 +00:00
Arthur Iakab
d2c2253278 Backed out changeset 5616dd0ad683 (bug 1592877) for causing browser-chrome failures on browser_aboutCertError_manySANsError.js
CLOSED TREE
2020-04-08 15:26:13 +03:00
Lupita Arroyo
929140139b Bug 1592877 - Truncate SANs to 50 in aboutNetError.js and add a test for it. r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D68730

--HG--
extra : moz-landing-system : lando
2020-04-08 11:22:10 +00:00
aarushivij
ac01256b16 Bug 1624820 - aboutNetError's setNetErrorMessageFromCode likes to pass empty strings to document.l10n.formatValues which produces errors r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D69230

--HG--
extra : moz-landing-system : lando
2020-04-08 09:46:34 +00:00
Razvan Maries
072b678c5a Backed out changeset 6b7c81561ecc (bug 1590573) for marionette perma failures on test_refresh_firefox.py. CLOSED TREE 2020-04-08 07:43:49 +03:00
Emma Malysz
b657384896 Bug 1590573, create a unified approach for caching fragments in our Custom Elements r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D58866

--HG--
extra : moz-landing-system : lando
2020-04-07 23:56:45 +00:00
Nika Layzell
f036c4e342 Bug 1616353 - Part 8: Remove forceInitialBrowserNonRemote, r=Gijs
This method is no longer necessary, as frontend will always make the correct
decisions for the remoteness of the intial content browser by reading
openWindowInfo.

Differential Revision: https://phabricator.services.mozilla.com/D67058

--HG--
extra : moz-landing-system : lando
2020-04-07 21:39:47 +00:00
Nika Layzell
b99cf8f798 Bug 1616353 - Part 7.4: Pass nsOpenWindowInfo through tabbrowser, r=Gijs
The interface changes which browser.js and tabbrowser.js are being updated for
are performed in earlier parts. This patch just covers the required changes to
frontend code to propagate this information down to the nsFrameLoader when it is
created.

Differential Revision: https://phabricator.services.mozilla.com/D67053

--HG--
extra : moz-landing-system : lando
2020-04-07 21:39:37 +00:00
Nika Layzell
98528edbf2 Bug 1616353 - Part 6.2: Remove setOriginAttributesBeforeLoading API, r=smaug
This API is no longer possible to implement, as it will always try to set the
OriginAttributes on a content BrowsingContext after it has been attached, and JS
can never observe a detached BrowsingContext.

Users of this API are instead changed to perform assertions that
originAttributes have already been set correctly.

Differential Revision: https://phabricator.services.mozilla.com/D67046

--HG--
extra : moz-landing-system : lando
2020-04-07 21:39:14 +00:00
Razvan Maries
08e433da85 Backed out changeset 8748e324ef44 (bug 1623888) for perma failures on browser_UrlbarInput_overflow.js. CLOSED TREE 2020-04-08 00:06:41 +03:00
Marco Bonardo
7739949897 Bug 1623888. r=Gijs,Itiel
Differential Revision: https://phabricator.services.mozilla.com/D67817

--HG--
extra : moz-landing-system : lando
2020-04-07 19:48:58 +00:00
Itiel
c4f1336145 Bug 1627477 - Convert all relevant uses of left/right to logical properties in browser/base r=dao
Differential Revision: https://phabricator.services.mozilla.com/D69727

--HG--
extra : moz-landing-system : lando
2020-04-07 16:29:39 +00:00
Mihai Alexandru Michis
b719a733f2 Backed out 7 changesets (bug 1627477) for causing bc failures in browser_parsable_css.js
CLOSED TREE

Backed out changeset 96fcd3331e0a (bug 1627477)
Backed out changeset 30f7c9f36229 (bug 1627477)
Backed out changeset 4486a79e5691 (bug 1627477)
Backed out changeset 9d27d7893501 (bug 1627477)
Backed out changeset 4e1b2198a30a (bug 1627477)
Backed out changeset 2ff6d4196daf (bug 1627477)
Backed out changeset 9d13b52d9960 (bug 1627477)
2020-04-07 18:51:52 +03:00
Mark Banner
88fb3a72de Bug 1622243 - Implement the bookmark pages option in the library window. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D68776

--HG--
extra : moz-landing-system : lando
2020-04-07 12:56:19 +00:00
Itiel
8cdf09be7a Bug 1627477 - Convert all relevant uses of left/right to logical properties in browser/base r=dao
Differential Revision: https://phabricator.services.mozilla.com/D69727

--HG--
extra : moz-landing-system : lando
2020-04-06 17:07:16 +00:00
Mihai Alexandru Michis
af4ac5130b Backed out changeset a32a1f5c2676 (bug 1609557) for causing bc failures.
CLOSED TREE
2020-04-07 12:39:37 +03:00
Julian
018ae5bc4a Bug 1609557 - Migrate placesContextMenu.inc.xhtml to Fluent. r=fluent-reviewers,flod,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D68733

--HG--
extra : moz-landing-system : lando
2020-04-07 08:46:02 +00:00
Edgar Chen
e2aca2c26d Bug 1615732 - Don't handle click event on Mac when ctrl key is pressed; r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D68775

--HG--
extra : moz-landing-system : lando
2020-04-06 20:56:14 +00:00
Edgar Chen
a32ab22c8c Bug 1615732 - Don't show page action panel on Mac when ctrl key is pressed; r=Gijs
On Mac, ctrl-click will send a context menu event from the widget, so we don't
want to bring up the panel when ctrl key is pressed.

Differential Revision: https://phabricator.services.mozilla.com/D66384

--HG--
extra : moz-landing-system : lando
2020-04-06 20:56:26 +00:00
Cosmin Sabou
3b3f1af25e Backed out 7 changesets (bug 1615732) for bc failures on browser_ext_pageAction_click_types.js. CLOSED TREE
Backed out changeset 031b8abf43a8 (bug 1615732)
Backed out changeset 297d82b338dc (bug 1615732)
Backed out changeset bbcb173e6c44 (bug 1615732)
Backed out changeset d7c5824d4579 (bug 1615732)
Backed out changeset f648cf0653a7 (bug 1615732)
Backed out changeset fcd441a2a860 (bug 1615732)
Backed out changeset fa861e50f198 (bug 1615732)

--HG--
extra : histedit_source : 16a05a43f3a9666c4fcf244062c28a5dc81061fd
2020-04-06 23:49:58 +03:00
Chris Martin
64e1fb7a45 Bug 1540776 - Have parent send color profile to child during launch r=aosmond,jld,jfkthame,florian
For Win32k lockdown, we need to remove the content processes' ability to
call GetICMProfileW(). Since it needs this to retrieve the output color
profile, a new synchronous call is added that allows it to request the
parent process to read this file on its behalf.

The contents of the file are now being cached as well, as this should help
ease some of the increased parent process I/O caused by the children not
being able to do this in their process anymore.

For performance reasons, during launch this information is passed directly
to the child through the SetXPCOMProcessAttributes call

Differential Revision: https://phabricator.services.mozilla.com/D66126

--HG--
extra : moz-landing-system : lando
2020-04-02 15:42:15 +00:00
Brian Grinstead
30b9da5519 Bug 1623992 - Automated rewrite from chrome://global/skin/ to chrome://global/skin/global.css in markup r=marionette-reviewers,perftest-reviewers,mossop,whimboo,sparky
This was generated with

```
cp .gitignore .rgignore
rg -l -g '*.{html,xhtml}' 'href="chrome://global/skin/"' | xargs sed -i "" 's/href\="chrome:\/\/global\/skin\/"/href\="chrome:\/\/global\/skin\/global.css"/g'
```

Differential Revision: https://phabricator.services.mozilla.com/D67687

--HG--
extra : moz-landing-system : lando
2020-04-03 22:23:23 +00:00
Edgar Chen
0de61803a3 Bug 1615732 - Don't handle click event on Mac when ctrl key is pressed; r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D68775

--HG--
extra : moz-landing-system : lando
2020-03-30 12:53:42 +00:00
Edgar Chen
feb7fe3776 Bug 1615732 - Don't show page action panel on Mac when ctrl key is pressed; r=Gijs
On Mac, ctrl-click will send a context menu event from the widget, so we don't
want to bring up the panel when ctrl key is pressed.

Differential Revision: https://phabricator.services.mozilla.com/D66384

--HG--
extra : moz-landing-system : lando
2020-03-13 17:42:04 +00:00
Bogdan Tara
d623691c7b Bug 40545 - Fix prettier errors on browser_selectpopup.js and SelectChild.jsm CLOSED TREE 2020-04-06 21:32:59 +03:00
Emilio Cobos Álvarez
ce71033ca1 Bug 40545 - Fix the empty-label attribute case in the select popup. r=chutten
And rename GetRenderLabel to GetRenderedLabel, as it's a slightly more
descriptive name IMHO.

Differential Revision: https://phabricator.services.mozilla.com/D69837

--HG--
extra : moz-landing-system : lando
2020-04-06 16:43:17 +00:00
Cosmin Sabou
3a544c8273 Backed out 2 changesets (bug 1625513) for causing several reftest failures. CLOSED TREE
Backed out changeset 64dfd2e32a7b (bug 1625513)
Backed out changeset a78ae89b25b6 (bug 1625513)

--HG--
extra : amend_source : b2383d74665a38a1fcf6cf0c3b62f6700002055c
extra : histedit_source : c9251ae9cdf46168c15328aa83655e2f93c95b85
2020-04-06 20:11:51 +03:00
Cosmin Sabou
aefb5f9c88 Backed out 24 changesets (bug 1616353) for fission assertion failures nsGlobalWindowOuter.cpp.
Backed out changeset 3a43210e4900 (bug 1616353)
Backed out changeset cb77e9149cf8 (bug 1616353)
Backed out changeset 3aacc7cfe33f (bug 1616353)
Backed out changeset c026b06063a5 (bug 1616353)
Backed out changeset 580e790c5d17 (bug 1616353)
Backed out changeset 6f09bc1c476d (bug 1616353)
Backed out changeset 6955906262c0 (bug 1616353)
Backed out changeset a7700472807a (bug 1616353)
Backed out changeset a4735096e01b (bug 1616353)
Backed out changeset bd1706c57d91 (bug 1616353)
Backed out changeset 363c13296fda (bug 1616353)
Backed out changeset e414df387524 (bug 1616353)
Backed out changeset 765d3364cca0 (bug 1616353)
Backed out changeset 8a13355b4ac4 (bug 1616353)
Backed out changeset ada17fb8fca7 (bug 1616353)
Backed out changeset 6b6b99af186d (bug 1616353)
Backed out changeset ea966e78b296 (bug 1616353)
Backed out changeset cb88e0bbb3b9 (bug 1616353)
Backed out changeset f89a89015114 (bug 1616353)
Backed out changeset ae6058552969 (bug 1616353)
Backed out changeset f42bb5b48c1b (bug 1616353)
Backed out changeset 1ab9d22c73bb (bug 1616353)
Backed out changeset 2692c2c1396b (bug 1616353)
Backed out changeset 11a279c8da08 (bug 1616353)
2020-04-06 20:03:02 +03:00
Chris H-C
8b1032cdc9 Bug 40545 - Options to use label attribute when present r=emilio,jfkthame,mats
According to spec, option elements with label attributes should show and use
those labels rather than their element text. So let's do that.

Requires some trickery because the option element is a block element (so it
lays out its width based on its text content) so we put its label (if it has
one) in its ::before and skip frame generation so it measures the text of its
label, not of its text node children.

Differential Revision: https://phabricator.services.mozilla.com/D63545

--HG--
extra : moz-landing-system : lando
2020-04-06 16:06:36 +00:00
Nika Layzell
312045489f Bug 1625513 - Part 1: Perform onMayChangeProcess handling within DocumentLoadListener, r=mattwoodrow,pbone,droeh
When I first added this method last year, I added it in JS, handled from within
SessionStore.jsm, as that was the easiest place to do it. Now that
DocumentLoadListener exists, it makes more sense to handle this logic directly
from within that code.

Many parts of the process switch are still handled by frontend JS, such as
selecting remote types, and performing toplevel process switches.

Differential Revision: https://phabricator.services.mozilla.com/D68594

--HG--
extra : moz-landing-system : lando
2020-04-06 15:17:40 +00:00
Nika Layzell
60b5a34a33 Bug 1616353 - Part 8: Remove forceInitialBrowserNonRemote, r=Gijs
This method is no longer necessary, as frontend will always make the correct
decisions for the remoteness of the intial content browser by reading
openWindowInfo.

Differential Revision: https://phabricator.services.mozilla.com/D67058

--HG--
extra : moz-landing-system : lando
2020-04-06 14:30:22 +00:00
Nika Layzell
7be2efaa78 Bug 1616353 - Part 7.4: Pass nsOpenWindowInfo through tabbrowser, r=Gijs
The interface changes which browser.js and tabbrowser.js are being updated for
are performed in earlier parts. This patch just covers the required changes to
frontend code to propagate this information down to the nsFrameLoader when it is
created.

Differential Revision: https://phabricator.services.mozilla.com/D67053

--HG--
extra : moz-landing-system : lando
2020-04-06 14:30:07 +00:00
Nika Layzell
f0e314fa2a Bug 1616353 - Part 6.2: Remove setOriginAttributesBeforeLoading API, r=smaug
This API is no longer possible to implement, as it will always try to set the
OriginAttributes on a content BrowsingContext after it has been attached, and JS
can never observe a detached BrowsingContext.

Users of this API are instead changed to perform assertions that
originAttributes have already been set correctly.

Differential Revision: https://phabricator.services.mozilla.com/D67046

--HG--
extra : moz-landing-system : lando
2020-04-06 14:29:50 +00:00
Riley Byrd
aef12bf890 Bug 1608202 - downloads.dtd to Fluent r=mconley,Gijs,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D59634

--HG--
extra : moz-landing-system : lando
2020-04-03 14:47:28 +00:00
jayati
84bf0fdb08 Bug 1619314 - Improve visibility of mobile protection icons in high contrast mode. r=ntim
Differential Revision: https://phabricator.services.mozilla.com/D68701

--HG--
rename : browser/base/content/logos/etp-mobile-light.svg => browser/base/content/logos/etp-mobile.svg
rename : browser/base/content/logos/lockwise-light.svg => browser/base/content/logos/lockwise-mobile.svg
extra : moz-landing-system : lando
2020-04-03 13:15:58 +00:00
Mark Banner
bb413bca06 Bug 1590803 - Clean up uses of SearchService.getDefaultEngines where we can now use engine.isAppProvided. r=daleharvey
Differential Revision: https://phabricator.services.mozilla.com/D69235

--HG--
extra : moz-landing-system : lando
2020-04-03 11:36:35 +00:00
Matthew Noorenberghe
3f7f09f6df Bug 1625075 - Use HTMLInputElement.hasBeenTypePassword for the context menu. r=sfoster
* Remove usernameField from getFieldContext since it isn't used if we return the state of the specified field. Then we don't need the hacky override for usernameField depending on hasBeenTypePassword.
* Return early in LMP._onPasswordEditedOrGenerated if the tab closes to address a test failure in browser_context_menu.js.

Differential Revision: https://phabricator.services.mozilla.com/D69314

--HG--
extra : moz-landing-system : lando
2020-04-02 22:28:09 +00:00
Dorel Luca
af82b27122 Backed out 2 changesets (bug 1590803) for browser-chrome failures in browser/browser_placeholder.js. CLOSED TREE
Backed out changeset 6256694a9047 (bug 1590803)
Backed out changeset efd1d1868d70 (bug 1590803)

--HG--
extra : histedit_source : 0dfcd9580b8b8a2274402ba9f32f43a07b7854dd
2020-04-02 18:39:32 +03:00
Mark Banner
b85978d734 Bug 1590803 - Clean up uses of SearchService.getDefaultEngines where we can now use engine.isAppProvided. r=daleharvey
Depends on D69233

Differential Revision: https://phabricator.services.mozilla.com/D69235

--HG--
extra : moz-landing-system : lando
2020-04-02 14:31:45 +00:00
Zibi Braniecki
44bbaba5c4 Bug 1602808 - Revert Window Title to use DTD. r=fluent-reviewers,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D68661

--HG--
extra : moz-landing-system : lando
2020-04-01 18:44:03 +00:00
Kris Maglione
fca28e80fb Bug 1618170: Fix merge bustage from BrowsingContext.getChildren change. r=nika
Differential Revision: https://phabricator.services.mozilla.com/D64427

--HG--
extra : moz-landing-system : lando
2020-04-01 19:31:54 +00:00
Henri Sivonen
fea31290d0 Bug 1616772 - Re-enable browser/base/content/test/fullscreen/browser_bug1557041.js for Fission. r=pbz
Differential Revision: https://phabricator.services.mozilla.com/D67303

--HG--
extra : moz-landing-system : lando
2020-03-18 17:48:28 +00:00