Commit graph

89 commits

Author SHA1 Message Date
Rob Wu
12da42fbbe Bug 1394019 - Handle DOMWindowClose of extension popup in parent r=zombie
Starting from bug 1533949, the DOMWindowClose event is forwarded to the
`<browser>` element, so there is no need for a custom
"Extension:DOMWindowClose" message any more.

Differential Revision: https://phabricator.services.mozilla.com/D60721

--HG--
extra : moz-landing-system : lando
2020-02-10 15:09:03 +00:00
Tomislav Jovanovic
8bc1284a85 Bug 1604058 - Verify remote conduits coming from extension pages r=robwu,rpl
Differential Revision: https://phabricator.services.mozilla.com/D57252

--HG--
extra : moz-landing-system : lando
2019-12-21 00:36:11 +00:00
Neil Deakin
01f6409a03 Bug 1590752, remove now unneeded content.js framescript, r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D50585

--HG--
extra : moz-landing-system : lando
2019-10-31 10:11:52 +00:00
Tim Nguyen
b6d8cc41ad Bug 1569375 - Refactor browser panel CSS to reduce shadow DOM traversal after CE conversion. r=dao
Differential Revision: https://phabricator.services.mozilla.com/D39594

--HG--
extra : moz-landing-system : lando
2019-07-31 15:22:08 +00:00
Alexis Beingessner
bb09834391 Bug 1547351 - Automatically set content process render root r=kats
This implements the idea of automatically setting a content proc's
render root based on the render root enclosing the iframe that
points to it. There was a bit of cleanup in here that was a bit
tricky to extract from the core patch revolving around how we
use the Api(...) helper. This was to avoid the situation where
we use the Api(...) helper before our render root is initialized,
when we don't actually have to. I.e., when we just want the root
WebRenderAPI in all cases.

An alternative to this approach could be to fully built out the
WebRender transactions and just queue those up to be sent. However,
transaction building has various side effects which are committed
before the transaction is actually sent, so we would have to build
out some scheme for deferring those as well. This seemed simpler.

Patch primarily written by :dthayer

Differential Revision: https://phabricator.services.mozilla.com/D37078

--HG--
extra : moz-landing-system : lando
2019-07-24 14:10:56 +00:00
Andreea Pavel
6665820f48 Backed out 3 changesets (bug 1547351) for assertion failures on a CLOSED TREE
Backed out changeset 77ef8e8bc669 (bug 1547351)
Backed out changeset b594f8e47025 (bug 1547351)
Backed out changeset 6e5d426cd313 (bug 1547351)
2019-07-15 17:47:40 +03:00
Alexis Beingessner
81f39dd2b0 Bug 1547351 - Automatically set content process render root r=kats
This implements the idea of automatically setting a content proc's
render root based on the render root enclosing the iframe that
points to it. There was a bit of cleanup in here that was a bit
tricky to extract from the core patch revolving around how we
use the Api(...) helper. This was to avoid the situation where
we use the Api(...) helper before our render root is initialized,
when we don't actually have to. I.e., when we just want the root
WebRenderAPI in all cases.

An alternative to this approach could be to fully built out the
WebRender transactions and just queue those up to be sent. However,
transaction building has various side effects which are committed
before the transaction is actually sent, so we would have to build
out some scheme for deferring those as well. This seemed simpler.

Patch primarily written by :dthayer

Differential Revision: https://phabricator.services.mozilla.com/D37078

--HG--
extra : moz-landing-system : lando
2019-07-15 13:18:44 +00:00
Mihai Alexandru Michis
fb4bad51c9 Backed out 2 changesets (bug 1547351) for causing bustages in nsTArray.h CLOSED TREE
Backed out changeset 46c9b479034f (bug 1547351)
Backed out changeset 4689b2870416 (bug 1547351)
2019-07-12 17:37:24 +03:00
Alexis Beingessner
6126cdbed2 Bug 1547351 - Automatically set content process render root r=kats
This implements the idea of automatically setting a content proc's
render root based on the render root enclosing the iframe that
points to it. There was a bit of cleanup in here that was a bit
tricky to extract from the core patch revolving around how we
use the Api(...) helper. This was to avoid the situation where
we use the Api(...) helper before our render root is initialized,
when we don't actually have to. I.e., when we just want the root
WebRenderAPI in all cases.

An alternative to this approach could be to fully built out the
WebRender transactions and just queue those up to be sent. However,
transaction building has various side effects which are committed
before the transaction is actually sent, so we would have to build
out some scheme for deferring those as well. This seemed simpler.

Patch primarily written by :dthayer

Differential Revision: https://phabricator.services.mozilla.com/D37078

--HG--
extra : moz-landing-system : lando
2019-07-12 14:14:22 +00:00
Coroiu Cristina
e6daafc804 Backed out 2 changesets (bug 1547351) for build bustage at gfx/layers/wr/WebRenderBridgeParent.cpp on a CLOSED TREE
Backed out changeset af34904f00c7 (bug 1547351)
Backed out changeset 94db0d98be90 (bug 1547351)
2019-07-12 08:40:27 +03:00
Alexis Beingessner
bc15a4daa5 Bug 1547351 - Automatically set content process render root r=kats
This implements the idea of automatically setting a content proc's
render root based on the render root enclosing the iframe that
points to it. There was a bit of cleanup in here that was a bit
tricky to extract from the core patch revolving around how we
use the Api(...) helper. This was to avoid the situation where
we use the Api(...) helper before our render root is initialized,
when we don't actually have to. I.e., when we just want the root
WebRenderAPI in all cases.

An alternative to this approach could be to fully built out the
WebRender transactions and just queue those up to be sent. However,
transaction building has various side effects which are committed
before the transaction is actually sent, so we would have to build
out some scheme for deferring those as well. This seemed simpler.

Patch primarily written by :dthayer

Differential Revision: https://phabricator.services.mozilla.com/D37078

--HG--
extra : moz-landing-system : lando
2019-07-12 05:14:05 +00:00
Gurzau Raul
09c2a7cb24 Backed out 2 changesets (bug 1547351) for build bustages at WebRenderBridgeParent.cpp on a CLOSED TREE.
Backed out changeset b294575c279c (bug 1547351)
Backed out changeset 69260373f95c (bug 1547351)
2019-07-12 06:47:35 +03:00
Alexis Beingessner
7d0ec2c7ed Bug 1547351 - Automatically set content process render root r=kats
This implements the idea of automatically setting a content proc's
render root based on the render root enclosing the iframe that
points to it. There was a bit of cleanup in here that was a bit
tricky to extract from the core patch revolving around how we
use the Api(...) helper. This was to avoid the situation where
we use the Api(...) helper before our render root is initialized,
when we don't actually have to. I.e., when we just want the root
WebRenderAPI in all cases.

An alternative to this approach could be to fully built out the
WebRender transactions and just queue those up to be sent. However,
transaction building has various side effects which are committed
before the transaction is actually sent, so we would have to build
out some scheme for deferring those as well. This seemed simpler.

Patch primarily written by :dthayer

Differential Revision: https://phabricator.services.mozilla.com/D37078

--HG--
extra : moz-landing-system : lando
2019-07-12 03:19:28 +00:00
Sylvestre Ledru
90fac8fa22 Bug 1562642 - Part 3 - Add missing MPL2 headers in browser & toolkit r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D37217

--HG--
extra : moz-landing-system : lando
2019-07-10 12:03:37 +00:00
Andreea Pavel
b698eeec56 Backed out changeset 3d59cb02b6ff (bug 1562642) for eslint failure on a CLOSED TREE 2019-07-10 14:44:29 +03:00
Sylvestre Ledru
fd95abf361 Bug 1562642 - Part 3 - Add missing MPL2 headers in browser & toolkit r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D37217

--HG--
extra : moz-landing-system : lando
2019-07-10 11:15:25 +00:00
Victor Porof
1f830c96da Bug 1561435 - Format browser/components/, a=automatic-formatting
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D36042

--HG--
extra : source : d3afcafdce650a6f36cebbc126ee93b17f13cf52
2019-07-05 09:53:32 +02:00
Doug Thayer
53b5f4b6e8 Bug 1547351 - Set renderroot of extension popup on browser element r=mattwoodrow
I'm not sure when/if this stopped working, but it appears the -moz-stack
display of the stack element doesn't send us through the admittedly
brittle pathways that allow us to create nsDisplayRenderRoots. This
brittleness is a consequence of copying the use of the "layer"
attribute and is discussed in the core document splitting bug. It's
outside the scope of this bug to fix that.

Differential Revision: https://phabricator.services.mozilla.com/D31006

--HG--
extra : moz-landing-system : lando
2019-05-14 16:58:40 +00:00
Doug Thayer
b172543596 Bug 1441308 - Core renderroot splitting changes r=kats,sotaro
This is a large patch that contains all of the core changes for
renderroot splitting.

Differential Revision: https://phabricator.services.mozilla.com/D20701

--HG--
extra : moz-landing-system : lando
2019-03-22 18:28:42 +00:00
Ciure Andrei
3de853018a Backed out 7 changesets (bug 1441308)for causing webrender build bustages CLOSED TREE
Backed out changeset 1764701d11d1 (bug 1441308)
Backed out changeset 32f7793dfd1a (bug 1441308)
Backed out changeset d8b4d6ec9b40 (bug 1441308)
Backed out changeset e2f83e4816dd (bug 1441308)
Backed out changeset baee8ada680f (bug 1441308)
Backed out changeset c09a51622e98 (bug 1441308)
Backed out changeset 737807563dd5 (bug 1441308)
2019-03-22 10:52:44 +02:00
Doug Thayer
5b3a0454a4 Bug 1441308 - Core renderroot splitting changes r=kats,sotaro
This is a large patch that contains all of the core changes for
renderroot splitting.

Differential Revision: https://phabricator.services.mozilla.com/D20701

--HG--
extra : moz-landing-system : lando
2019-03-22 03:15:14 +00:00
Neil Deakin
66040975f2 Bug 1519953, replace calls to retrieve boxobject position and size with getBoundingClientRect, r=gijs
--HG--
extra : rebase_source : 65a9e08513ada3cda6beeb09d7f8a53620c2999f
2019-03-01 12:26:45 -05:00
Luca Greco
3e8c931f9b Bug 1446027 - Prevents synchronous uninterruptible reflow from ExtensionPopups.jsm. r=kmag
Differential Revision: https://phabricator.services.mozilla.com/D12158

--HG--
extra : moz-landing-system : lando
2019-01-30 20:08:08 +00:00
Kris Maglione
e930b89c34 Bug 1514594: Part 3 - Change ChromeUtils.import API.
***
Bug 1514594: Part 3a - Change ChromeUtils.import to return an exports object; not pollute global. r=mccr8

This changes the behavior of ChromeUtils.import() to return an exports object,
rather than a module global, in all cases except when `null` is passed as a
second argument, and changes the default behavior not to pollute the global
scope with the module's exports. Thus, the following code written for the old
model:

  ChromeUtils.import("resource://gre/modules/Services.jsm");

is approximately the same as the following, in the new model:

  var {Services} = ChromeUtils.import("resource://gre/modules/Services.jsm");

Since the two behaviors are mutually incompatible, this patch will land with a
scripted rewrite to update all existing callers to use the new model rather
than the old.
***
Bug 1514594: Part 3b - Mass rewrite all JS code to use the new ChromeUtils.import API. rs=Gijs

This was done using the followng script:

https://bitbucket.org/kmaglione/m-c-rewrites/src/tip/processors/cu-import-exports.jsm
***
Bug 1514594: Part 3c - Update ESLint plugin for ChromeUtils.import API changes. r=Standard8

Differential Revision: https://phabricator.services.mozilla.com/D16747
***
Bug 1514594: Part 3d - Remove/fix hundreds of duplicate imports from sync tests. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16748
***
Bug 1514594: Part 3e - Remove no-op ChromeUtils.import() calls. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16749
***
Bug 1514594: Part 3f.1 - Cleanup various test corner cases after mass rewrite. r=Gijs
***
Bug 1514594: Part 3f.2 - Cleanup various non-test corner cases after mass rewrite. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16750

--HG--
extra : rebase_source : 359574ee3064c90f33bf36c2ebe3159a24cc8895
extra : histedit_source : b93c8f42808b1599f9122d7842d2c0b3e656a594%2C64a3a4e3359dc889e2ab2b49461bab9e27fc10a7
2019-01-17 10:18:31 -08:00
Rob Wu
9ee0822242 Bug 1518598 - Return early if popup has already been closed r=mixedpuppy
Differential Revision: https://phabricator.services.mozilla.com/D16033

--HG--
extra : moz-landing-system : lando
2019-01-15 18:50:49 +00:00
Gijs Kruitbosch
76afb51661 Bug 1493655 - make nsISecureBrowserUI initialize from a docshell instead of a window, r=keeler,nika
This also removes the (afaict, unused) stub implementation from TabParent. The netwerk header
inclusions were necessary because those files included TabParent.h and through it,
nsISecureBrowserUI, but now TabParent.h no longer does that.

Differential Revision: https://phabricator.services.mozilla.com/D6829

--HG--
extra : moz-landing-system : lando
2018-09-26 17:48:38 +00:00
Brendan Dahl
f6923ccc24 Bug 1485426 - Use createXULElement instead of createElement in XUL docs. r=bgrins
Preparing for transitioning to XHTML.

MozReview-Commit-ID: JLlmUxsvhIB

Differential Revision: https://phabricator.services.mozilla.com/D4265

--HG--
extra : moz-landing-system : lando
2018-08-25 00:16:27 +00:00
Cosmin Sabou
1c8ad7b4ba Merge mozilla-inbound to mozilla-central. a=merge 2018-08-15 03:51:45 +03:00
Brian Grinstead
829d7647d3 Bug 1479538 - Rewrite non-test callers of document.createElementNS(XUL_NS, ...) to use document.createXULElement(...);r=paolo
Differential Revision: https://phabricator.services.mozilla.com/D3275

--HG--
extra : moz-landing-system : lando
2018-08-14 16:22:44 +00:00
Kris Maglione
f99ee35b82 Bug 1480244: Part 5 - Run most framescripts in shared scope. r=mconley
Creating non-shared scopes for frame scripts is fairly expensive. After these
changes it's even more expensive. However, many frame scripts have no use for
the shared scopes at all. Run-once scripts which execute in closures, for
instance, make no use of them. And after bug 1472491, neither do most of our
default frame scripts.

MozReview-Commit-ID: 9PK7bYdQ0yh

--HG--
extra : rebase_source : db2516d2f00a75e233e1957649f2b62a9299b7cd
2018-08-10 13:58:18 -07:00
Kris Maglione
4470001b70 Bug 1452514: Correctly handle a browser window closing before its popups do. r=mixedpuppy
MozReview-Commit-ID: DOqfniMPf87

--HG--
extra : rebase_source : 5945da4ce1496c984448bc05c86efcbc27645c88
2018-07-19 19:03:20 -07:00
Kris Maglione
fcedebb912 Bug 1471102: Move more code out of ExtensionUtils.jsm. r=aswan
MozReview-Commit-ID: Fqlv5BRuuW8

--HG--
extra : rebase_source : 348f037abd9cecfa080183bc365e5f005eac1bd6
extra : amend_source : 05dbfd12f553fc3f2a93374402e34d271e26d767
2018-06-25 19:30:21 -07:00
Jared Wein
1ee5bff85e Bug 1459066 - Overflow menu WebExtension subview header should use the default browser styling instead of the extension's styling. r=mixedpuppy
MozReview-Commit-ID: EtQ6VS5OH0e

--HG--
extra : rebase_source : 8e557423fa443d40e8db69dc46bad2709a11b38e
2018-05-07 13:06:46 -04:00
Dorel Luca
8ee8fc461e Backed out 2 changesets (bug 1317581) for Browser chrome failures on toolkit/components/extensions/test/browser/browser_ext_themes_arrowpanels.js. CLOSED TREE
Backed out changeset 5cc146254899 (bug 1317581)
Backed out changeset 963466173a74 (bug 1317581)
2018-04-18 18:54:38 +03:00
Jared Wein
7ee1860850 Bug 1317581 - DateTimePicker should support high contrast mode on Windows. r=dao
MozReview-Commit-ID: DEBBjcgHIyH

--HG--
extra : rebase_source : 9b52b15a0af9a56ad724dd578884856d4d5e7e20
2018-03-22 13:01:28 -04:00
Mark Striemer
ddc263525f Bug 1397809 - Part 1: Convert New Tab doorhanger to a generic class r=aswan,Gijs
MozReview-Commit-ID: 40RwrXjtsJJ

--HG--
extra : rebase_source : f688846407d32d3ec68ef96ea7432da9ed08a145
2017-12-19 13:56:04 -06:00
Jared Wein
5c4c017fb8 Bug 1453803 - Increase the opacity of the default border color for WebExtension popups. r=ntim
MozReview-Commit-ID: AeDmPJtPdBE

--HG--
extra : rebase_source : 56a6e4231e55770cd8d488941b2fd0ce1f69fe89
2018-04-12 18:48:39 -04:00
Jared Wein
4181599591 Bug 1449933 - Webextension popups that don't define a background-color can be hard to read. r=mixedpuppy
MozReview-Commit-ID: CVXySkhYaem

--HG--
extra : rebase_source : b744e0fc1a23997d6d92af4b12e9a6d3b00fecbf
2018-03-30 15:29:31 -07:00
Kris Maglione
b2ea14013a Bug 1451058: Follow-up: Fix window leak in popup tests. r=bustage
MozReview-Commit-ID: 7ucAN5usp0o
2018-04-06 19:22:39 -07:00
Kris Maglione
8ee1c6373c Bug 1451058: Save temporary popup pre-load panel for remote popups. r=mixedpuppy
Creating the temporary panel for a pre-load popup can be expensive, especially
for OOP popups, where we need to create a compositor. Since we currently need
to create a pre-load popup every time we hover over a browser action with a
popup, it's probably worth saving and re-using them, rather than always
creating a new one.

MozReview-Commit-ID: GwG7qJNdk8f

--HG--
extra : rebase_source : 9d8f139167b6cad8047c3ac75e5ff84886c27da2
extra : source : 29b2567d16eb2d8d58da6e3b616c42eebb0de9f1
2018-04-03 11:14:49 -07:00
Andreea Pavel
4098782378 Backed out 2 changesets (bug 1451058) for failing browser chrome at browser/components/extensions/test/browser/test-oop-extensions/browser_ext_browserAction_popup.js on a CLOSED TREE
Backed out changeset 7047a6811fdc (bug 1451058)
Backed out changeset 29b2567d16eb (bug 1451058)
2018-04-06 10:39:42 +03:00
Kris Maglione
33adeee7c7 Bug 1451058: Follow-up: Fix unhandled rejections. r=bustage
MozReview-Commit-ID: FELukWQ8fEz

--HG--
extra : rebase_source : 39e0e482a16c597b968f3977ffb5d59cf736cf53
2018-04-05 21:33:42 -07:00
Kris Maglione
a3fbdb02c5 Bug 1451058: Save temporary popup pre-load panel for remote popups. r=mixedpuppy
Creating the temporary panel for a pre-load popup can be expensive, especially
for OOP popups, where we need to create a compositor. Since we currently need
to create a pre-load popup every time we hover over a browser action with a
popup, it's probably worth saving and re-using them, rather than always
creating a new one.

MozReview-Commit-ID: GwG7qJNdk8f

--HG--
extra : rebase_source : 221d4804b6ed022ee578c6002e8c7def408fa632
extra : amend_source : f32a1f00af43ba5869d07cff4f55671a1f417b01
2018-04-03 11:14:49 -07:00
Tim Nguyen
e002c63fa4 Bug 1444760 - Combine loadURIWithFlags and loadURI methods. r=dao
MozReview-Commit-ID: 5dsyKwvjYht

--HG--
extra : rebase_source : 881e10f2987606e84e55c267260661c0f7b3b746
2018-03-16 23:21:46 +00:00
Margareta Eliza Balazs
27703664b0 Backed out 2 changesets (bug 1444760) for ES lint failure in /builds/worker/checkouts/gecko/browser/base/content/browser.js on a CLOSED TREE
Backed out changeset 71f61091a716 (bug 1444760)
Backed out changeset 4956db1e9bdd (bug 1444760)
2018-03-25 15:29:54 +03:00
Tim Nguyen
e2ed0b5dfb Bug 1444760 - Combine loadURIWithFlags and loadURI methods. r=dao
MozReview-Commit-ID: 5dsyKwvjYht

--HG--
extra : rebase_source : 8e9f24d20829021db2239435c7d8d0db08e28bf9
2018-03-16 23:21:46 +00:00
Sam Foster
c11210d2df Bug 1402845 - Fix panelview sizing when customRectGetter is used. r=mikedeboer,Paolo
* The extension content drives the sizing of the browser and popup that contains it via the Extension:BrowserResized message. The ignoreResizes property throttles/debounces this initially, stashing the dimensions received rather than triggering resize of the popup for every message. When the popup is a subview and fixedWidth, we ignore width but *do* want to use the stashed height value.

* Until the panel is given visibility, it has 0 height, so after setting visibility, wait until the next refresh-driver tick before measuring any header which should get added to the overall view height

MozReview-Commit-ID: AgcruVb9QPA

--HG--
extra : rebase_source : 429503a7d38559cc8670a3205b3290b8e0bbbfa2
2017-10-05 10:23:53 -07:00
Shane Caraveo
dd3edd16c4 Bug 1398713 pass triggeringPrincipal when using browser.loadURI, r=Gijs,kmag 2018-02-28 17:32:01 -06:00
Shane Caraveo
2f634add59 Bug 1324255 make webextension panels focused when opened, r=Gijs,rpl 2018-02-15 09:52:54 -07:00
Andrew McCreight
5dec0e0beb Bug 1432992, part 1 - Remove definitions of Ci, Cr, Cc, and Cu. r=florian
This patch was autogenerated by my decomponents.py

It covers almost every file with the extension js, jsm, html, py,
xhtml, or xul.

It removes blank lines after removed lines, when the removed lines are
preceded by either blank lines or the start of a new block. The "start
of a new block" is defined fairly hackily: either the line starts with
//, ends with */, ends with {, <![CDATA[, """ or '''. The first two
cover comments, the third one covers JS, the fourth covers JS embedded
in XUL, and the final two cover JS embedded in Python. This also
applies if the removed line was the first line of the file.

It covers the pattern matching cases like "var {classes: Cc,
interfaces: Ci, utils: Cu, results: Cr} = Components;". It'll remove
the entire thing if they are all either Ci, Cr, Cc or Cu, or it will
remove the appropriate ones and leave the residue behind. If there's
only one behind, then it will turn it into a normal, non-pattern
matching variable definition. (For instance, "const { classes: Cc,
Constructor: CC, interfaces: Ci, utils: Cu } = Components" becomes
"const CC = Components.Constructor".)

MozReview-Commit-ID: DeSHcClQ7cG

--HG--
extra : rebase_source : d9c41878036c1ef7766ef5e91a7005025bc1d72b
2018-02-06 09:36:57 -08:00