Commit graph

109 commits

Author SHA1 Message Date
Marco Bonardo
2dc20c6432 Bug 1621328 - Move CreateExposableURI into nsIOService. r=Gijs,mayhemer
Differential Revision: https://phabricator.services.mozilla.com/D66269

--HG--
extra : moz-landing-system : lando
2020-03-13 12:44:36 +00:00
Ehsan Akhgari
5d2fded7b8 Bug 1601786 - Remove the "allow on any site" option from the storage access API prompt; r=baku
Differential Revision: https://phabricator.services.mozilla.com/D56246

--HG--
extra : moz-landing-system : lando
2019-12-18 21:31:35 +00:00
Gurzau Raul
3bacc0f758 Backed out changeset c7842b0d5e8a (bug 1601786) for failing at browser_PermissionUI_prompts.js on a CLOSED TREE. 2019-12-18 22:42:51 +02:00
Ehsan Akhgari
482983dc47 Bug 1601786 - Remove the "allow on any site" option from the storage access API prompt; r=baku
Differential Revision: https://phabricator.services.mozilla.com/D56246

--HG--
extra : moz-landing-system : lando
2019-12-18 15:50:55 +00:00
Kearwood Kip Gilbert
19ba3b0322 Bug 1580567 - Implement XR device access permission UI r=fluent-reviewers,bzbarsky,pbz,daoshengmu,imanol
Added @rbarker as a reviewer to check if this will work well within GeckoView for FxR / Android.
Added @bzbarsky for test_interfaces.html.  -- I'd like to re-land the secure origin requirement for WebVR as part of this patch, as it doesn't help to have UI that can't guarantee the identity of the origin.  (This was backed out due to test failures originally, and since been fixed)

Differential Revision: https://phabricator.services.mozilla.com/D45951

--HG--
rename : browser/components/privatebrowsing/test/browser/browser_privatebrowsing_geoprompt.js => browser/components/privatebrowsing/test/browser/browser_privatebrowsing_rememberprompt.js
extra : moz-landing-system : lando
2019-12-12 03:10:51 +00:00
Johann Hofmann
3292e920dc Bug 1601784 - Use a built-in "Learn More" link instead of custom nodes for the storage access prompt. r=ewright
Differential Revision: https://phabricator.services.mozilla.com/D56553

--HG--
extra : moz-landing-system : lando
2019-12-11 10:08:19 +00:00
Brindusan Cristian
9c36dcbf23 Backed out 2 changesets (bug 1580567, bug 1599927) for mochitest failures at test_interfaces.html. CLOSED TREE
Backed out changeset 0e0d88942d33 (bug 1599927)
Backed out changeset 522c8d183bd5 (bug 1580567)

--HG--
rename : browser/components/privatebrowsing/test/browser/browser_privatebrowsing_rememberprompt.js => browser/components/privatebrowsing/test/browser/browser_privatebrowsing_geoprompt.js
2019-12-11 05:31:08 +02:00
Kearwood Kip Gilbert
7c8ce74b8f Bug 1580567 - Implement XR device access permission UI r=fluent-reviewers,bzbarsky,pbz,daoshengmu,imanol
Added @rbarker as a reviewer to check if this will work well within GeckoView for FxR / Android.
Added @bzbarsky for test_interfaces.html.  -- I'd like to re-land the secure origin requirement for WebVR as part of this patch, as it doesn't help to have UI that can't guarantee the identity of the origin.  (This was backed out due to test failures originally, and since been fixed)

Differential Revision: https://phabricator.services.mozilla.com/D45951

--HG--
rename : browser/components/privatebrowsing/test/browser/browser_privatebrowsing_geoprompt.js => browser/components/privatebrowsing/test/browser/browser_privatebrowsing_rememberprompt.js
extra : moz-landing-system : lando
2019-12-11 01:38:17 +00:00
shindli
652f3b0296 Backed out 2 changesets (bug 1580567, bug 1599927) for causing permafailures in dom/tests/mochitest/general/test_interfaces.html CLOSED TREE
Backed out changeset aeceec922866 (bug 1599927)
Backed out changeset 29809135f18e (bug 1580567)

--HG--
rename : browser/components/privatebrowsing/test/browser/browser_privatebrowsing_rememberprompt.js => browser/components/privatebrowsing/test/browser/browser_privatebrowsing_geoprompt.js
2019-12-11 03:32:44 +02:00
Kearwood Kip Gilbert
6a9c22db45 Bug 1580567 - Implement XR device access permission UI r=fluent-reviewers,bzbarsky,pbz,daoshengmu,imanol
Added @rbarker as a reviewer to check if this will work well within GeckoView for FxR / Android.
Added @bzbarsky for test_interfaces.html.  -- I'd like to re-land the secure origin requirement for WebVR as part of this patch, as it doesn't help to have UI that can't guarantee the identity of the origin.  (This was backed out due to test failures originally, and since been fixed)

Differential Revision: https://phabricator.services.mozilla.com/D45951

--HG--
rename : browser/components/privatebrowsing/test/browser/browser_privatebrowsing_geoprompt.js => browser/components/privatebrowsing/test/browser/browser_privatebrowsing_rememberprompt.js
extra : moz-landing-system : lando
2019-12-10 23:55:05 +00:00
Johann Hofmann
841a3f40fb Bug 1600942 - Remove event telemetry for permission prompt studies. r=Ehsan
Depends on D56540

Differential Revision: https://phabricator.services.mozilla.com/D56541

--HG--
extra : moz-landing-system : lando
2019-12-10 14:39:49 +00:00
Razvan Maries
30d4c4f26d Backed out changeset 15f8fa34d2f4 (bug 1580567) for perma fails on browser_temporary_permissions_expiry.js and browser_privatebrowsing_rememberprompt.js. CLOSED TREE
--HG--
rename : browser/components/privatebrowsing/test/browser/browser_privatebrowsing_rememberprompt.js => browser/components/privatebrowsing/test/browser/browser_privatebrowsing_geoprompt.js
2019-12-05 01:05:34 +02:00
Kearwood Kip Gilbert
ef6bdce0ec Bug 1580567 - Implement XR device access permission UI r=fluent-reviewers,bzbarsky,pbz,daoshengmu,imanol
Added @rbarker as a reviewer to check if this will work well within GeckoView for FxR / Android.
Added @bzbarsky for test_interfaces.html.  -- I'd like to re-land the secure origin requirement for WebVR as part of this patch, as it doesn't help to have UI that can't guarantee the identity of the origin.  (This was backed out due to test failures originally, and since been fixed)

Differential Revision: https://phabricator.services.mozilla.com/D45951

--HG--
rename : browser/components/privatebrowsing/test/browser/browser_privatebrowsing_geoprompt.js => browser/components/privatebrowsing/test/browser/browser_privatebrowsing_rememberprompt.js
extra : moz-landing-system : lando
2019-12-04 21:10:56 +00:00
Thomas Nguyen
1e82cdc161 Bug 1483631 - Prompt with both first party and third party origin if we are delegating permission with allows all feature policy. r=baku
Differential Revision: https://phabricator.services.mozilla.com/D51839

--HG--
extra : moz-landing-system : lando
2019-12-04 15:39:26 +00:00
Thomas Nguyen
fd744cea01 Bug 1483631 - Restrict nested permission requests in ContentPermissionPrompt with permission delegate r=baku,mccr8
Differential Revision: https://phabricator.services.mozilla.com/D47416

--HG--
extra : moz-landing-system : lando
2019-12-04 15:39:03 +00:00
Gurzau Raul
4f21dcd081 Backed out 4 changesets (bug 1483631) for failing at browser_temporary_permissions.js on a CLOSED TREE.
Backed out changeset f5bb5f6a148f (bug 1483631)
Backed out changeset c5e562c1d590 (bug 1483631)
Backed out changeset 7ef09193a7ef (bug 1483631)
Backed out changeset a909dcbbea2b (bug 1483631)
2019-12-03 21:57:55 +02:00
Thomas Nguyen
14991f5ba2 Bug 1483631 - Prompt with both first party and third party origin if we are delegating permission with allows all feature policy. r=baku
Differential Revision: https://phabricator.services.mozilla.com/D51839

--HG--
extra : moz-landing-system : lando
2019-12-03 16:24:39 +00:00
Thomas Nguyen
d48ace2c5f Bug 1483631 - Restrict nested permission requests in ContentPermissionPrompt with permission delegate r=baku,mccr8
Differential Revision: https://phabricator.services.mozilla.com/D47416

--HG--
extra : moz-landing-system : lando
2019-12-03 16:25:51 +00:00
Sebastian Streich
2fbc46096e Bug 1580782 - Remove JS Callsites for Principal->GetURI->Schemeis r=ckerschb
Differential Revision: https://phabricator.services.mozilla.com/D45685

--HG--
extra : moz-landing-system : lando
2019-09-26 10:47:33 +00:00
Paul Zuehlcke
172c56e5ba Bug 1580189 - Clear geolocation permission for sub-frames with active sharing state. r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D45827

--HG--
extra : moz-landing-system : lando
2019-09-25 09:16:32 +00:00
monikamaheshwari
9d60e0d578 Bug 1578683 Turn on ESLint rule prefer-boolean-length-check for toolkit and browser r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D45629

--HG--
extra : moz-landing-system : lando
2019-09-14 09:39:26 +00:00
Johann Hofmann
e91d880e08 Bug 1570674 - Default to "Never Allow" for notification permission prompt denials. r=Ehsan
Differential Revision: https://phabricator.services.mozilla.com/D43081

--HG--
extra : moz-landing-system : lando
2019-08-22 16:24:56 +00:00
Paul Zuehlcke
f568195330 Bug 1574124 - Updated PermissionUI.jsm to use SitePermissions principal methods. r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D42337

--HG--
extra : moz-landing-system : lando
2019-08-20 12:15:00 +00:00
Ehsan Akhgari
56e165b9ce Bug 1573236 - Part 1: Move the Storage Access API heuristics and telemetry from the front-end to Gecko; r=johannh,baku
This will allow these heuristics to be used on mobile.
This depends on GeckoView supporting a JavaScript module
at resource:///modules/BrowserUsageTelemetry.jsm with the
interface described in nsIBrowserUsage.idl.  Bug 1573238 has
been filed in order to implement this module on GeckoView.

Differential Revision: https://phabricator.services.mozilla.com/D41621

--HG--
extra : moz-landing-system : lando
2019-08-14 21:00:51 +00:00
Paul Zuehlcke
5a377a3a37 Bug 630614 - Show an indicator when geolocation is in use. r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D35428

--HG--
extra : moz-landing-system : lando
2019-07-30 08:28:31 +00:00
Csoregi Natalia
141bcffcc8 Backed out changeset 3855d35999dd (bug 630614) for causing failures on browser_ext_tabs_sharingState.js. CLOSED TREE 2019-07-29 14:32:05 +03:00
Paul Zuehlcke
15afab0390 Bug 630614 - Show an indicator when geolocation is in use. r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D35428

--HG--
extra : moz-landing-system : lando
2019-07-29 08:37:55 +00:00
Paul Zuehlcke
39687fe7bb Bug 1522120 - Remove permission prompts when entering full-screen and leave full-screen when a permission prompt is shown. r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D36932

--HG--
extra : moz-landing-system : lando
2019-07-24 16:17:54 +00:00
Ehsan Akhgari
b8a13cc9e5 Bug 1558503 - Preserve the order of the arguments in the localized storageAccess.message string; r=johannh,flod
Differential Revision: https://phabricator.services.mozilla.com/D37468

--HG--
extra : moz-landing-system : lando
2019-07-10 15:05:47 +00:00
Victor Porof
af7d1d3b67 Bug 1561435 - Format browser/modules/, a=automatic-formatting
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D36046

--HG--
extra : source : f3c632037a1064c41b1f8b02f477c854b2fb4362
2019-07-05 09:55:19 +02:00
Johann Hofmann
52d5f250f1 Bug 1557729 - Use principal for permission post prompts instead of URI. r=xeonchen
Differential Revision: https://phabricator.services.mozilla.com/D35033

--HG--
extra : moz-landing-system : lando
2019-06-14 15:49:25 +00:00
Boris Zbarsky
9de72a3ac6 Bug 1557793 part 2. Stop using [array] in nsIStringBundle. r=Pike
Differential Revision: https://phabricator.services.mozilla.com/D34196

--HG--
extra : moz-landing-system : lando
2019-06-11 15:51:51 +00:00
Liang-Heng Chen
4ad2af201e Bug 1330467 - part 5. Access permissions by principal in PermissionUI.jsm; r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D19926

--HG--
extra : moz-landing-system : lando
2019-05-17 13:23:08 +00:00
Mihai Alexandru Michis
97df17e745 Backed out 11 changesets (bug 1330467) as requested by xeonchen on IRC. CLOSED TREE
Backed out changeset 0229d5353d50 (bug 1330467)
Backed out changeset 2f2308fe5747 (bug 1330467)
Backed out changeset 2cd09bae2bdf (bug 1330467)
Backed out changeset 2648f5bb1804 (bug 1330467)
Backed out changeset 4686eebd8962 (bug 1330467)
Backed out changeset b43fa07d5756 (bug 1330467)
Backed out changeset 35d96a4ff659 (bug 1330467)
Backed out changeset 6ac44130d2bb (bug 1330467)
Backed out changeset f939c61e051f (bug 1330467)
Backed out changeset 0ae215d91758 (bug 1330467)
Backed out changeset 1d48bdbb4035 (bug 1330467)
2019-05-17 16:19:06 +03:00
Liang-Heng Chen
602ef3ab3b Bug 1330467 - part 5. Access permissions by principal in PermissionUI.jsm; r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D19926

--HG--
extra : moz-landing-system : lando
2019-05-08 09:03:06 +00:00
Johann Hofmann
6407007ebd Bug 1536454 - Part 4 - Add event telemetry for permission prompt studies. r=Ehsan
Differential Revision: https://phabricator.services.mozilla.com/D26945

--HG--
extra : moz-landing-system : lando
2019-04-18 13:43:29 +00:00
Johann Hofmann
9fb44dc7a9 Bug 1508961 - Show a notification icon after automatically dismissing permission prompts. r=MattN
This adds support for a "post-prompt" that appears dismissed (only the icon showing) when
the browser decides to automatically deny a permission request from a site (either based on
internal heuristics or because the user prefers not to receive permission prompts).

In order to move quickly and not overload the patch I have only implemented the post-prompting
for desktop-notification so far, however, implementing it for other permissions should be
a trivial follow-up.

Differential Revision: https://phabricator.services.mozilla.com/D25415

--HG--
extra : moz-landing-system : lando
2019-04-05 10:22:19 +00:00
Johann Hofmann
79332e3ef4 Bug 1524619 - Part 1 - Add support for requiring user gestures for push notifications. r=Ehsan,MattN
Differential Revision: https://phabricator.services.mozilla.com/D23647

--HG--
extra : rebase_source : ef6bb77983b135c0c352e8fe0a37ba72e4f69718
2019-03-15 11:43:17 +01:00
ui.manish
33fd585ed0 Bug 1479335 - Remove permissions close button r=nhnt11
Differential Revision: https://phabricator.services.mozilla.com/D16264

--HG--
extra : moz-landing-system : lando
2019-02-24 20:33:33 +00:00
Razvan Maries
7a5c7bab52 Backed out changeset 8c7ac177290e (bug 1479335) for ES Lint fialure. CLOSED TREE 2019-02-24 12:17:38 +02:00
ui.manish
4d1af398d9 Bug 1479335 - Remove permissions close button r=nhnt11
Differential Revision: https://phabricator.services.mozilla.com/D16264

--HG--
extra : moz-landing-system : lando
2019-02-24 09:58:15 +00:00
Narcis Beleuzu
42bafc21a1 Backed out changeset b94501076533 (bug 1479335) for firefox-ui-functional failures on test_notifications.py 2019-02-24 04:13:17 +02:00
ui.manish
5c91d29d6a Bug 1479335 - Remove permissions close button r=nhnt11
Differential Revision: https://phabricator.services.mozilla.com/D16264

--HG--
extra : moz-landing-system : lando
2019-02-24 00:17:40 +00:00
ui.manish
5460bb6581 Bug 1497838- Consider removing Geolocation values in SECURITY_UI r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D18363

--HG--
extra : moz-landing-system : lando
2019-02-04 12:13:20 +00:00
Ehsan Akhgari
a418695e65 Bug 1513309 - Add telemetry for the storage access API; r=johannh,janerik
Differential Revision: https://phabricator.services.mozilla.com/D17860

--HG--
extra : moz-landing-system : lando
2019-01-30 12:41:58 +00:00
Kris Maglione
e930b89c34 Bug 1514594: Part 3 - Change ChromeUtils.import API.
***
Bug 1514594: Part 3a - Change ChromeUtils.import to return an exports object; not pollute global. r=mccr8

This changes the behavior of ChromeUtils.import() to return an exports object,
rather than a module global, in all cases except when `null` is passed as a
second argument, and changes the default behavior not to pollute the global
scope with the module's exports. Thus, the following code written for the old
model:

  ChromeUtils.import("resource://gre/modules/Services.jsm");

is approximately the same as the following, in the new model:

  var {Services} = ChromeUtils.import("resource://gre/modules/Services.jsm");

Since the two behaviors are mutually incompatible, this patch will land with a
scripted rewrite to update all existing callers to use the new model rather
than the old.
***
Bug 1514594: Part 3b - Mass rewrite all JS code to use the new ChromeUtils.import API. rs=Gijs

This was done using the followng script:

https://bitbucket.org/kmaglione/m-c-rewrites/src/tip/processors/cu-import-exports.jsm
***
Bug 1514594: Part 3c - Update ESLint plugin for ChromeUtils.import API changes. r=Standard8

Differential Revision: https://phabricator.services.mozilla.com/D16747
***
Bug 1514594: Part 3d - Remove/fix hundreds of duplicate imports from sync tests. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16748
***
Bug 1514594: Part 3e - Remove no-op ChromeUtils.import() calls. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16749
***
Bug 1514594: Part 3f.1 - Cleanup various test corner cases after mass rewrite. r=Gijs
***
Bug 1514594: Part 3f.2 - Cleanup various non-test corner cases after mass rewrite. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16750

--HG--
extra : rebase_source : 359574ee3064c90f33bf36c2ebe3159a24cc8895
extra : histedit_source : b93c8f42808b1599f9122d7842d2c0b3e656a594%2C64a3a4e3359dc889e2ab2b49461bab9e27fc10a7
2019-01-17 10:18:31 -08:00
Ehsan Akhgari
ea0beadb68 Bug 1516889 - Part 2: Make sure the storage access API prompt is denied when pressing Esc; r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D16737
2019-01-21 11:23:22 -05:00
Ciure Andrei
eb5345d4eb Backed out 2 changesets (bug 1516889) for failing browser_storageAccessDoorHanger.js CLOSED TREE
Backed out changeset fe40c77b54b4 (bug 1516889)
Backed out changeset 95fee3425c55 (bug 1516889)
2019-01-21 17:48:11 +02:00
Ehsan Akhgari
46e587fc36 Bug 1516889 - Part 2: Make sure the storage access API prompt is denied when pressing Esc; r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D16737
2019-01-21 09:57:31 -05:00
alwu
294f48db51 Bug 1513039 - part12 : remove temporary allow. r=daleharvey,florian
After removing autoplay doorhanger, we won't have temporary allow.

Differential Revision: https://phabricator.services.mozilla.com/D14340

--HG--
extra : moz-landing-system : lando
2019-01-07 18:42:55 +00:00