Commit graph

106 commits

Author SHA1 Message Date
Andrew Osmond
fa0605af64 Bug 1854669. r=gfx-reviewers,lsalzman
Differential Revision: https://phabricator.services.mozilla.com/D194537
2023-12-05 15:23:37 +00:00
Ray Kraesig
9abd025f05 Bug 1858225 - [1/9] rename CreateWinFileDialogAsync to CreateWinFileDialogActor r=win-reviewers,mhowell,gerard-majax
We're about to add some code that will actually create a file dialog,
rather than just the actor, asynchronously. Rename this function to make
it clear which of those it does.

(That it does so asynchronously is probably sufficiently communicated by
the return type.)

Differential Revision: https://phabricator.services.mozilla.com/D193733
2023-12-01 05:03:18 +00:00
Cosmin Sabou
c3f8e90d2c Backed out 11 changesets (bug 1858225) for causing build bustages on nsFilePicker.cpp. CLOSED TREE
Backed out changeset 808f68da4438 (bug 1858225)
Backed out changeset e6f456e40dda (bug 1858225)
Backed out changeset d1efbf517c7e (bug 1858225)
Backed out changeset 61c8a62b47c5 (bug 1858225)
Backed out changeset 9b1f0d37b74b (bug 1858225)
Backed out changeset f57ac4a387f2 (bug 1858225)
Backed out changeset 9b2c6eaf137e (bug 1858225)
Backed out changeset 6aacb8fde7e1 (bug 1858225)
Backed out changeset 2eb38cba55d6 (bug 1858225)
Backed out changeset c31dfa5f9be5 (bug 1858225)
Backed out changeset 82b7b851c429 (bug 1858225)
2023-12-01 00:18:29 +02:00
Ray Kraesig
f74bfc7431 Bug 1858225 - [1/9] rename CreateWinFileDialogAsync to CreateWinFileDialogActor r=win-reviewers,mhowell,gerard-majax
We're about to add some code that will actually create a file dialog,
rather than just the actor, asynchronously. Rename this function to make
it clear which of those it does.

(That it does so asynchronously is probably sufficiently communicated by
the return type.)

Differential Revision: https://phabricator.services.mozilla.com/D193733
2023-11-30 19:59:15 +00:00
Ray Kraesig
3c94ba2a4e Bug 1837079 - [6/10] Properly destroy actors and utility processes r=ipc-reviewers,nika
The IPC subsystem effectively owns IPC actors, and requires an explicit
call to `Close()` to destroy a toplevel actor: releasing the last RefPtr
doesn't cut it. Similarly, the UtilityProcessManager owns the utility
processes it creates, and one must explicitly call `DestroyProcess()`.

Handle both of these lifetime issues by using a custom meta-RefPtr for
WinFileDialogParent which will close the actor and kill the process upon
its final `Release()`.

Differential Revision: https://phabricator.services.mozilla.com/D180345
2023-10-26 18:21:28 +00:00
Ray Kraesig
6c2facfc0c Bug 1837079 - [5/10] Create WinFileDialog IPDL protocol and implementation r=gstoll,handyman,ipc-reviewers,nika,win-reviewers,mhowell
Create and implement a new top-level IPC protocol, `PWinFileDialog`,
using the primitives from bug 1833450 and the new sandboxing type from
the previous commit.

Again, this commit does not actually create any instances of the new
protocol; that will come in a later commit in this patchset.

Differential Revision: https://phabricator.services.mozilla.com/D180342
2023-10-26 18:21:28 +00:00
Iulian Moraru
87c1675542 Backed out 10 changesets (bug 1837079) for causing build bustages on UtilityProcessManager.cpp. CLOSED TREE
Backed out changeset b36fd9deb165 (bug 1837079)
Backed out changeset 0253a50d16a9 (bug 1837079)
Backed out changeset 799ea189e748 (bug 1837079)
Backed out changeset 70eab0533b00 (bug 1837079)
Backed out changeset 488707a84723 (bug 1837079)
Backed out changeset d56484304ec3 (bug 1837079)
Backed out changeset 36d3afd881b4 (bug 1837079)
Backed out changeset 3f2fd4d7a511 (bug 1837079)
Backed out changeset 078b848cd09e (bug 1837079)
Backed out changeset 64390c163748 (bug 1837079)
2023-09-15 22:17:21 +03:00
Ray Kraesig
8dfb30cd32 Bug 1837079 - [8/10] Implement file-dialog utility-process-crash tests r=handyman,ipc-reviewers,mstange,gerard-majax,nika,profiler-reviewers
Implement a mochitest confirming the stability of Firefox when the
file-picker crashes (patterned loosely off the existing geolocation
crash tests).

Differential Revision: https://phabricator.services.mozilla.com/D184723
2023-09-15 18:10:01 +00:00
Ray Kraesig
5631927f07 Bug 1837079 - [6/10] Properly destroy actors and utility processes r=ipc-reviewers,nika
The IPC subsystem effectively owns IPC actors, and requires an explicit
call to `Close()` to destroy a toplevel actor: releasing the last RefPtr
doesn't cut it. Similarly, the UtilityProcessManager owns the utility
processes it creates, and one must explicitly call `DestroyProcess()`.

Handle both of these lifetime issues by using a custom meta-RefPtr for
WinFileDialogParent which will close the actor and kill the process upon
its final `Release()`.

Differential Revision: https://phabricator.services.mozilla.com/D180345
2023-09-15 18:10:01 +00:00
Ray Kraesig
2e9d3b7548 Bug 1837079 - [5/10] Create WinFileDialog IPDL protocol and implementation r=gstoll,handyman,ipc-reviewers,nika
Create and implement a new top-level IPC protocol, `PWinFileDialog`,
using the primitives from bug 1833450 and the new sandboxing type from
the previous commit.

Again, this commit does not actually create any instances of the new
protocol; that will come in a later commit in this patchset.

Differential Revision: https://phabricator.services.mozilla.com/D180342
2023-09-15 18:10:01 +00:00
Kagami Sascha Rosylight
b65d4356c8 Bug 1842825 - Split new Observer() outside of ipc::UtilityProcessManager r=ipc-reviewers,nika
Differential Revision: https://phabricator.services.mozilla.com/D183260
2023-07-12 13:44:32 +00:00
Alexandre Lissy
876c09034b Bug 1829108 - Relax assertions on UtilityProcessManager r=ipc-reviewers,nika
Differential Revision: https://phabricator.services.mozilla.com/D177466
2023-05-10 08:34:23 +00:00
Alexandre Lissy
2abab73fe2 Bug 1828620 - Revert Trace RejectPromise() on Utility launch r=ipc-reviewers,nika
Differential Revision: https://phabricator.services.mozilla.com/D177465
2023-05-10 08:34:23 +00:00
Alexandre Lissy
aff55f2123 Bug 1772796 - Add profiling markers to Utility process launch r=padenot
Differential Revision: https://phabricator.services.mozilla.com/D176015
2023-04-26 11:48:43 +00:00
Alexandre Lissy
a87d90f461 Bug 1828460 - Trace RejectPromise() on Utility launch r=ipc-reviewers,nika
Differential Revision: https://phabricator.services.mozilla.com/D175694
2023-04-18 20:48:45 +00:00
Alexandre Lissy
0bea0e3f93 Bug 1819311 - Limit hard crash when utility process is not starting r=nika
Differential Revision: https://phabricator.services.mozilla.com/D174778
2023-04-13 08:35:24 +00:00
David Parks
2e959c2130 Bug 1704500: Add WindowsUtils kind of utility process on Windows r=gerard-majax,ipc-reviewers,nika
Adds a new type of utility process that is set up to handle Windows OS objects.  We are adding this process type to run Windows geolocation APIs but more services are expected to be included in it.  The ILocation APIs have a race condition that would otherwise crash the main process.  The ILocation work is in a later patch in the series.

Depends on D155017

Differential Revision: https://phabricator.services.mozilla.com/D155018
2023-01-31 21:10:26 +00:00
David Parks
04713ddc93 Bug 1704500: Add logging to UtilityProcessHost/Manager r=gerard-majax
Adds a "utilityproc" log to trace utility process launch and shutdown steps.

Differential Revision: https://phabricator.services.mozilla.com/D155017
2023-01-31 21:10:26 +00:00
Iulian Moraru
fb1e6d6e57 Backed out 7 changesets (bug 1704500) for causing bc failures on browser_utility_geolocation_crashed.js. CLOSED TREE
Backed out changeset afcc1e8b5ad7 (bug 1704500)
Backed out changeset 1c27f9c36fda (bug 1704500)
Backed out changeset c0f0a280aaea (bug 1704500)
Backed out changeset 4be2d58ddf54 (bug 1704500)
Backed out changeset 1386732459ce (bug 1704500)
Backed out changeset 88e8015e1ec4 (bug 1704500)
Backed out changeset d96e810e20ec (bug 1704500)
2023-01-29 03:17:48 +02:00
David Parks
6161ee57c1 Bug 1704500: Add WindowsUtils kind of utility process on Windows r=gerard-majax,ipc-reviewers,nika
Adds a new type of utility process that is set up to handle Windows OS objects.  We are adding this process type to run Windows geolocation APIs but more services are expected to be included in it.  The ILocation APIs have a race condition that would otherwise crash the main process.  The ILocation work is in a later patch in the series.

Depends on D155017

Differential Revision: https://phabricator.services.mozilla.com/D155018
2023-01-28 21:00:48 +00:00
David Parks
b2d24d88ba Bug 1704500: Add logging to UtilityProcessHost/Manager r=gerard-majax
Adds a "utilityproc" log to trace utility process launch and shutdown steps.

Differential Revision: https://phabricator.services.mozilla.com/D155017
2023-01-28 21:00:48 +00:00
Sandor Molnar
ea48d05eba Backed out 7 changesets (bug 1704500) for causing multiple failures in browser_utility_geolocation_crashed/test_geolocation_reset_accuracy CLOSED TREE
Backed out changeset c3ae64389c26 (bug 1704500)
Backed out changeset 747d84ff17c7 (bug 1704500)
Backed out changeset 313b8770dc51 (bug 1704500)
Backed out changeset 30632246ee2b (bug 1704500)
Backed out changeset 90a8d51fc17c (bug 1704500)
Backed out changeset a1d1a97a2ffa (bug 1704500)
Backed out changeset 6bfb4d8de1e1 (bug 1704500)
2023-01-27 05:49:32 +02:00
David Parks
f921985dfb Bug 1704500: Add WindowsUtils kind of utility process on Windows r=gerard-majax,ipc-reviewers,nika
Adds a new type of utility process that is set up to handle Windows OS objects.  We are adding this process type to run Windows geolocation APIs but more services are expected to be included in it.  The ILocation APIs have a race condition that would otherwise crash the main process.  The ILocation work is in a later patch in the series.

Depends on D155017

Differential Revision: https://phabricator.services.mozilla.com/D155018
2023-01-26 20:15:06 +00:00
David Parks
9ec7b795b8 Bug 1704500: Add logging to UtilityProcessHost/Manager r=gerard-majax
Adds a "utilityproc" log to trace utility process launch and shutdown steps.

Differential Revision: https://phabricator.services.mozilla.com/D155017
2023-01-26 20:15:06 +00:00
Cristian Tuns
d1e6642127 Backed out 7 changesets (bug 1704500) for causing build bustages CLOSED TREE
Backed out changeset e48723d8d42e (bug 1704500)
Backed out changeset 897b985f9298 (bug 1704500)
Backed out changeset c2474d1c0046 (bug 1704500)
Backed out changeset d4508f8ba7df (bug 1704500)
Backed out changeset 241be693628d (bug 1704500)
Backed out changeset 341ec2465c7d (bug 1704500)
Backed out changeset 0d1c0dcd7645 (bug 1704500)
2023-01-25 15:33:33 -05:00
David Parks
41fcb215d0 Bug 1704500: Add WindowsUtils kind of utility process on Windows r=gerard-majax,ipc-reviewers,nika
Adds a new type of utility process that is set up to handle Windows OS objects.  We are adding this process type to run Windows geolocation APIs but more services are expected to be included in it.  The ILocation APIs have a race condition that would otherwise crash the main process.  The ILocation work is in a later patch in the series.

Depends on D155017

Differential Revision: https://phabricator.services.mozilla.com/D155018
2023-01-25 19:58:45 +00:00
David Parks
6a29255196 Bug 1704500: Add logging to UtilityProcessHost/Manager r=gerard-majax
Adds a "utilityproc" log to trace utility process launch and shutdown steps.

Differential Revision: https://phabricator.services.mozilla.com/D155017
2023-01-25 19:58:45 +00:00
Marian-Vasile Laza
a8db73b494 Backed out 8 changesets (bug 1704500) for causing build bustages on UtilityProcessHost.cpp. CLOSED TREE
Backed out changeset da69da68588d (bug 1704500)
Backed out changeset 8f1b73a96bb0 (bug 1704500)
Backed out changeset 817d104b3a3e (bug 1704500)
Backed out changeset 1c84f8f0796a (bug 1704500)
Backed out changeset 93e59d5488dc (bug 1704500)
Backed out changeset f85e8eed6fed (bug 1704500)
Backed out changeset e581bfdf0f8e (bug 1704500)
Backed out changeset 5d62d1a33cf8 (bug 1704500)
2023-01-25 05:18:00 +02:00
Otto Länd
97b7518d94 Bug 1704500, 1704500, 1704500, 1704500, 1704500, 1704500, 1704500: apply code formatting via Lando
# ignore-this-changeset
2023-01-25 02:52:24 +00:00
David Parks
f0feadd478 Bug 1704500: Add WindowsUtils kind of utility process on Windows r=gerard-majax,ipc-reviewers,nika
Adds a new type of utility process that is set up to handle Windows OS objects.  We are adding this process type to run Windows geolocation APIs but more services are expected to be included in it.  The ILocation APIs have a race condition that would otherwise crash the main process.  The ILocation work is in a later patch in the series.

Depends on D155017

Differential Revision: https://phabricator.services.mozilla.com/D155018
2023-01-25 02:48:56 +00:00
David Parks
6a2f1c0b29 Bug 1704500: Add logging to UtilityProcessHost/Manager r=gerard-majax
Adds a "utilityproc" log to trace utility process launch and shutdown steps.

Differential Revision: https://phabricator.services.mozilla.com/D155017
2023-01-25 02:48:55 +00:00
Sean Feng
18ee907a90 Bug 1532644 - Implement the initial version of the Javascript Validator for ORB r=farre,smaug
For things that can be parsed as Javascript, we need to figure out
if they are JSON, and we want to block opaque JSON resources for ORB.

This initial version just checks the first byte of the response, and
blocks it if it's a curly bracket.

Differential Revision: https://phabricator.services.mozilla.com/D163283
2023-01-09 15:27:18 +00:00
Sandor Molnar
0835a2e28c Backed out 4 changesets (bug 1532644) for causing wpt failures in /fetch/api/abort/general.any.serviceworker.html CLOSED TREE
Backed out changeset e18eed2287d2 (bug 1532644)
Backed out changeset 49c1638654d6 (bug 1532644)
Backed out changeset 2943c62bd7a2 (bug 1532644)
Backed out changeset 0a736f3ff23c (bug 1532644)
2022-12-29 02:36:49 +02:00
Sean Feng
7f77b9aa60 Bug 1532644 - Implement the initial version of the Javascript Validator for ORB r=farre,smaug
For things that can be parsed as Javascript, we need to figure out
if they are JSON, and we want to block opaque JSON resources for ORB.

This initial version just checks the first byte of the response, and
blocks it if it's a curly bracket.

Differential Revision: https://phabricator.services.mozilla.com/D163283
2022-12-28 20:12:25 +00:00
Marian-Vasile Laza
54d965fe8b Backed out 3 changesets (bug 1532644) for causing wpt failures on credentials.sub.html.
Backed out changeset 380433f77fc0 (bug 1532644)
Backed out changeset e1140838e735 (bug 1532644)
Backed out changeset f58b82a75c29 (bug 1532644)
2022-12-21 04:16:56 +02:00
Sean Feng
f3b35814c7 Bug 1532644 - Implement the initial version of the Javascript Validator for ORB r=farre,smaug
For things that can be parsed as Javascript, we need to figure out
if they are JSON, and we want to block opaque JSON resources for ORB.

This initial version just checks the first byte of the response, and
blocks it if it's a curly bracket.

Differential Revision: https://phabricator.services.mozilla.com/D163283
2022-12-20 21:41:08 +00:00
Alexandre Lissy
399dbc0fe6 Bug 1792636 - Make Utility process crash a non fatal error r=alwu,nika
Differential Revision: https://phabricator.services.mozilla.com/D160268
2022-10-28 16:12:51 +00:00
Alexandre Lissy
06ac7c2582 Bug 1788596 - Release UtilityProcessManager at the right moment r=nika
Differential Revision: https://phabricator.services.mozilla.com/D156847
2022-10-06 15:51:59 +00:00
Alexandre Lissy
bb317b2bae Bug 1788596 - Remove UTILITY_AUDIO_DECODING_GENERIC r=nika,media-playback-reviewers,alwu
Differential Revision: https://phabricator.services.mozilla.com/D156285
2022-10-06 15:51:56 +00:00
Sandor Molnar
9e30e89e90 Backed out 13 changesets (bug 1788596) for causing build bustage in toolkit/components/processtools/ProcInfo_common.cpp CLOSED TREE
Backed out changeset 620c85305800 (bug 1788596)
Backed out changeset 1f64776a859a (bug 1788596)
Backed out changeset 707e4c9c8801 (bug 1788596)
Backed out changeset 2221a97ebe97 (bug 1788596)
Backed out changeset d50fd0551159 (bug 1788596)
Backed out changeset 7e2ad8c47afb (bug 1788596)
Backed out changeset f87c5fb2c36f (bug 1788596)
Backed out changeset 61dd9a9eb714 (bug 1788596)
Backed out changeset a67c4ea1c8b3 (bug 1788596)
Backed out changeset 1be7af1214cf (bug 1788596)
Backed out changeset e99c7089bf93 (bug 1788596)
Backed out changeset 9a87f108548b (bug 1788596)
Backed out changeset 3dd59224f38b (bug 1788596)
2022-10-06 16:28:46 +03:00
Alexandre Lissy
3fa6e7cc2c Bug 1788596 - Release UtilityProcessManager at the right moment r=nika
Differential Revision: https://phabricator.services.mozilla.com/D156847
2022-10-06 10:56:44 +00:00
Alexandre Lissy
1d211b0ec1 Bug 1788596 - Remove UTILITY_AUDIO_DECODING_GENERIC r=nika,media-playback-reviewers,alwu
Differential Revision: https://phabricator.services.mozilla.com/D156285
2022-10-06 10:56:41 +00:00
Sandor Molnar
2fb4e10f0d Backed out 13 changesets (bug 1788596) for causing browser-chrome failures in security/sandbox/test/browser_sandbox_test.js CLOSED TREE
Backed out changeset 338c18d01cfd (bug 1788596)
Backed out changeset 9d4a5c557191 (bug 1788596)
Backed out changeset 1d1d15dbe44c (bug 1788596)
Backed out changeset e9d29218beba (bug 1788596)
Backed out changeset 397e6c6587f3 (bug 1788596)
Backed out changeset 077fd3a987ca (bug 1788596)
Backed out changeset 2fc674146915 (bug 1788596)
Backed out changeset 4ebb8837ee1a (bug 1788596)
Backed out changeset 9040533dabe1 (bug 1788596)
Backed out changeset 8b27ee4d4168 (bug 1788596)
Backed out changeset 93f50c2f0b9e (bug 1788596)
Backed out changeset 3e7125be66fa (bug 1788596)
Backed out changeset 63ee00ea9be6 (bug 1788596)
2022-10-06 10:28:00 +03:00
Alexandre Lissy
981b8ee4ca Bug 1788596 - Release UtilityProcessManager at the right moment r=nika
Differential Revision: https://phabricator.services.mozilla.com/D156847
2022-10-06 06:14:09 +00:00
Alexandre Lissy
272b0c9273 Bug 1788596 - Remove UTILITY_AUDIO_DECODING_GENERIC r=nika,media-playback-reviewers,alwu
Differential Revision: https://phabricator.services.mozilla.com/D156285
2022-10-06 06:14:06 +00:00
alwu
3d1bc29d56 Bug 1785738 - part4 : run media engine in the new utility process. r=gerard-majax,azebrowski
This patch moves the media engine from the RDD process to the new
utility process, and create video bridge between the new utility process
and the GPU process in order to share the texture.

Differential Revision: https://phabricator.services.mozilla.com/D155901
2022-09-03 00:53:59 +00:00
alwu
4029b6998d Bug 1785738 - part3 : rename 'UtilityProcessManager::StartAudioDecoding()' because we would do video decoding in the utility process as well. r=gerard-majax
Differential Revision: https://phabricator.services.mozilla.com/D155900
2022-09-03 00:53:59 +00:00
Alexandre Lissy
b135ca0732 Bug 1780796 - Use one process per platform decoder module sandbox requirements r=alwu,nika,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D152545
2022-09-01 12:59:32 +00:00
Sylvestre Ledru
42f6811d95 Bug 1519636 - Reformat recent changes to the Google coding style r=andi,media-playback-reviewers,necko-reviewers,padenot,dragana
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D148375
2022-06-07 12:32:55 +00:00
Alexandre Lissy
2455fdcc08 Bug 1769624 - Verify shutdown status before asserting r=nika
Differential Revision: https://phabricator.services.mozilla.com/D146567
2022-05-19 23:50:57 +00:00