nagai/fune
3
0
Fork 0
forked from mirrors/gecko-dev
Code Pull requests Activity
916492 commits 1 branch 98 tags 6.4 GiB
Commit graph

915 commits

Author SHA1 Message Date
Jonathan Sudiaman
3547e9b03f Bug 1883231 - Don't update search results for a stale query in Firefox View. r=nsharpley,fxview-reviewers,places-reviewers,Standard8,sidebar-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D208946
 2024-05-09 13:34:37 +00:00
Jules Simplicio
d840cf36af Bug 1894393 - Undo the Firefox View work that made tab attention dot color in Linux and lwt on hcm match between chrome and in-content r=desktop-theme-reviewers,fxview-reviewers,emilio,kcochrane 
Per https://bugzilla.mozilla.org/show_bug.cgi?id=1884351 and after discussing with theme developers, and Amy Lee from UX, we decided to stick to Linux's existing theming pattern (use platform accent color for chrome accents, and design system colors for in-content), and undo the work that made Firefox's View attention dot color match between in-content and chrome.

Differential Revision: https://phabricator.services.mozilla.com/D209073
 2024-05-01 03:58:09 +00:00
Jonathan Sudiaman
2cdb67a81c Bug 1887220 - Rework map computations in history r=fxview-reviewers,places-reviewers,sidebar-reviewers,nsharpley,sclements 
- Consolidates `historyMapByDate`, `historyMapBySite`, and `searchResults` into one single `historyCache`, which represents all of the visits that should be rendered by the host and what options are currently in place.
- Converts `HistoryController` to a system level module.
- Adds preventative code to account for race conditions in cases during test verification.

Differential Revision: https://phabricator.services.mozilla.com/D207861
 2024-04-30 20:03:14 +00:00
Jonathan Sudiaman
fefc790575 Bug 1867614 - fxview-tab-list story is broken, shows a "ChromeUtils is not defined" error r=fxview-reviewers,reusable-components-reviewers,hjones,nsharpley 
Remove transitive dependency on `ChromeUtils` that is causing this error.

Differential Revision: https://phabricator.services.mozilla.com/D208380
 2024-04-23 21:26:09 +00:00
dschomburg
e63de59f5c Bug 1853818 - Remove toolkit/branding/accounts.ftl file r=flod,fluent-reviewers,settings-reviewers,credential-management-reviewers,fxview-reviewers,omc-reviewers,firefox-desktop-core-reviewers ,mconley,aminomancer,mak,sgalich,nsharpley,mkaply 
Differential Revision: https://phabricator.services.mozilla.com/D190612
 2024-04-22 16:24:30 +00:00
Nikki Sharpley
c458c1c11a Bug 1887237 - Intermittent TV browser/components/firefoxview/tests/browser/browser_firefoxview_paused.js r=fxview-reviewers,kcochrane 
- reduce number of tests in `browser_firefoxview_paused.js` to solve timeout issue

Differential Revision: https://phabricator.services.mozilla.com/D207453
 2024-04-17 20:02:08 +00:00
Kelly Cochrane
23e51d8269 Bug 1873942 - Add test coverage for device connection and sync r=fxview-reviewers,nsharpley 
Differential Revision: https://phabricator.services.mozilla.com/D207750
 2024-04-17 20:00:35 +00:00
Anna Yeddi
e4fb243edd Bug 1884986 - Update tests to check for new ARIA roles. r=fxview-reviewers,sfoster. 
Depends on D206272

Differential Revision: https://phabricator.services.mozilla.com/D207488
 2024-04-16 23:57:19 +00:00
Anna Yeddi
6eee9a9520 Bug 1884981 - Import history from another browser section on Firefox View History tab would not announce the context for buttons on it. r=fxview-reviewers,kcochrane 
Adding a grouping markup on the `import-history-banner`, so the text outside of the focusable CTAs is being announced to a screen reader user.

Note: the heading remains implicit (being only styled to look as such but it is not marked up appropriately an is a generic `<span>`)

Differential Revision: https://phabricator.services.mozilla.com/D206272
 2024-04-16 23:57:18 +00:00
Anna Yeddi
72d920332c Bug 1884986 - Ensure the control on an empty card on Firefox View would announce the group info. r=fxview-reviewers,Jamie 
Since the wrapper of the `<details>` element cannot access its labeling element (included in the slot), we could move the grouping attributes to the `<card-container>` element itself. This would also allow us to remove an additional `<section>` container and reduce the number of nested groups exposed to the Accessibility API, including the case where another `<details>` element is being added for the inner card.

This patch also removes the extra `group` container for an empty card to reduce the verbocity of the announcement and the nesting complexity, while keeping the grouping programmatically indicated (just not duplicated in the case of an empty card where the additional card template is added).

Differential Revision: https://phabricator.services.mozilla.com/D206261
 2024-04-16 23:57:18 +00:00
Nikki Sharpley
d0f70542e1 Bug 1851697 - Remove Firefox View button notification dot r=fxview-reviewers,desktop-theme-reviewers,dao,jsudiaman 
This was disabled in bug 1787980 so we needed to remove the obsolete code.

Differential Revision: https://phabricator.services.mozilla.com/D207473
 2024-04-16 22:02:52 +00:00
Kelly Cochrane
6d07671d4b Bug 1877120 - Ensure virtual-list intersection observer fires only once expected fxview-tab-list items have rendered r=fxview-reviewers,sfoster,mstriemer 
Differential Revision: https://phabricator.services.mozilla.com/D207476
 2024-04-16 18:31:20 +00:00
Sandor Molnar
a1b5483a02 Backed out 2 changesets (bug 1884981, bug 1884986) for causing bc failures @ browser_firefoxview.js CLOSED TREE 
Backed out changeset ae9729a59875 (bug 1884981)
Backed out changeset 2ad302b112b2 (bug 1884986)
 2024-04-16 00:10:30 +03:00
Anna Yeddi
4247a52f34 Bug 1884981 - Import history from another browser section on Firefox View History tab would not announce the context for buttons on it. r=fxview-reviewers,kcochrane 
Adding a grouping markup on the `import-history-banner`, so the text outside of the focusable CTAs is being announced to a screen reader user.

Note: the heading remains implicit (being only styled to look as such but it is not marked up appropriately an is a generic `<span>`)

Differential Revision: https://phabricator.services.mozilla.com/D206272
 2024-04-15 18:41:00 +00:00
Anna Yeddi
4d7deb2876 Bug 1884986 - Ensure the control on an empty card on Firefox View would announce the group info. r=fxview-reviewers,Jamie 
Since the wrapper of the `<details>` element cannot access its labeling element (included in the slot), we could move the grouping attributes to the `<card-container>` element itself. This would also allow us to remove an additional `<section>` container and reduce the number of nested groups exposed to the Accessibility API, including the case where another `<details>` element is being added for the inner card.

This patch also removes the extra `group` container for an empty card to reduce the verbocity of the announcement and the nesting complexity, while keeping the grouping programmatically indicated (just not duplicated in the case of an empty card where the additional card template is added).

Differential Revision: https://phabricator.services.mozilla.com/D206261
 2024-04-15 18:41:00 +00:00
Kelly Cochrane
e5ad708be7 Bug 1873957 - Add missing test coverage for error states for Synced Tabs in Firefox View r=fxview-reviewers,nsharpley,sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D206956
 2024-04-11 15:45:31 +00:00
Jonathan Sudiaman
e0e15ff907 Bug 1879925 - Replace Synced Tabs component in sidebar r=sidebar-reviewers,fxview-reviewers,nsharpley,sfoster,desktop-theme-reviewers,sclements 
https://treeherder.mozilla.org/jobs?repo=try&revision=b2e04c07c3582baefbc4cc8e219ba33626788180

Differential Revision: https://phabricator.services.mozilla.com/D205646
 2024-04-11 14:35:43 +00:00
Sam Foster
b181fbd7ad Bug 1888841 - Fix typo when passing sourceWindowId to SessionStore's forgetClosedTabById. r=fxview-reviewers,jsudiaman,kcochrane 
Differential Revision: https://phabricator.services.mozilla.com/D206431
 2024-04-09 22:59:27 +00:00
Nikki Sharpley
a835d20d8f Bug 1881107 - Remove delay opening context menu due to awaiting fetched devices r=fxview-reviewers,jsudiaman,sfoster 
I've moved the call to fetch devices to occur in connectedCallback rather than holding up the context menu toggle function.
https://profiler.firefox.com/from-browser/calltree/?globalTrackOrder=80w7&hiddenGlobalTracks=1w6&hiddenLocalTracksByPid=56852-134~56853-0~56859-0~56860-0~56858-0~56861-0~56857-0~56856-0&thread=c&v=10

Differential Revision: https://phabricator.services.mozilla.com/D205390
 2024-04-09 20:41:21 +00:00
Yi Xiong Wong
3839c61dbc Bug 1880914 - Move browser/tab closing functions. r=Gijs,perftest-reviewers,devtools-reviewers,fxview-reviewers,sessionstore-reviewers,sfoster,kshampur 
Differential Revision: https://phabricator.services.mozilla.com/D206197
 2024-04-08 17:21:01 +00:00
Sandor Molnar
5fb629f1cb Backed out changeset f108b931f2d5 (bug 1881107) for causing bc failures @ browser_opentabs_pinned_tabs.js 2024-04-06 01:57:55 +03:00
Nikki Sharpley
91d3dc863c Bug 1881107 - Remove delay opening context menu due to awaiting fetched devices r=fxview-reviewers,jsudiaman,sfoster 
I've moved the call to fetch devices to occur in connectedCallback rather than holding up the context menu toggle function.
https://profiler.firefox.com/from-browser/calltree/?globalTrackOrder=80w7&hiddenGlobalTracks=1w6&hiddenLocalTracksByPid=56852-134~56853-0~56859-0~56860-0~56858-0~56861-0~56857-0~56856-0&thread=c&v=10

Differential Revision: https://phabricator.services.mozilla.com/D205390
 2024-04-05 19:53:53 +00:00
Kelly Cochrane
e29e0562cf Bug 1889769 - Fix alignment of tab rows in Firefox View r=fxview-reviewers,nsharpley 
Differential Revision: https://phabricator.services.mozilla.com/D206705
 2024-04-05 14:14:42 +00:00
Cristian Tuns
6cf7b07a43 Backed out changeset 03cfb27bc3a2 (bug 1881107) for causing bc failures in browser_opentabs_pinned_tabs.js CLOSED TREE 2024-04-04 17:38:48 -04:00
Nikki Sharpley
cc4b7e9822 Bug 1881107 - Remove delay opening context menu due to awaiting fetched devices r=fxview-reviewers,jsudiaman,sfoster 
I've moved the call to fetch devices to occur in connectedCallback rather than holding up the context menu toggle function.
https://profiler.firefox.com/from-browser/calltree/?globalTrackOrder=80w7&hiddenGlobalTracks=1w6&hiddenLocalTracksByPid=56852-134~56853-0~56859-0~56860-0~56858-0~56861-0~56857-0~56856-0&thread=c&v=10

Differential Revision: https://phabricator.services.mozilla.com/D205390
 2024-04-04 19:08:19 +00:00
Sam Foster
4765d125ef Bug 1873025 - Fix the displayed relative time for open tabs listing to match the recency sorting.r=jsudiaman,fxview-reviewers,tabbrowser-reviewers,dao 
* Carry over lastAccessed times from tabs that haven't been seen/active this session.
* Use the lastSeenActive rather than lastAccessed timestamp for labeling open tabs in firefox view.

Differential Revision: https://phabricator.services.mozilla.com/D198892
 2024-04-04 16:27:32 +00:00
Sam Foster
12228dff42 Bug 1858460 - Include source events in OpenTabsTarget events and improve how we test the recency-sorted tab lists. r=fxview-reviewers,sclements 
* Include a list of source events in the debounced and consolidated change events dispatched by OpenTabsTarget
* Rework browser_opentabs_recency.js to use session restore for window and tab creation
* Eliminate some of the races in the test by waiting for the correct tab list state
* Re-enable the test for windows - it remains intermittent on macos and linux
* Add sizemodechange as a tab-recency-related event

Differential Revision: https://phabricator.services.mozilla.com/D206174
 2024-04-04 16:27:32 +00:00
Yi Xiong Wong
cd747f1f77 Bug 1880914 - Move BrowserOpenTab. r=Gijs,webdriver-reviewers,perftest-reviewers,extension-reviewers,sessionstore-reviewers,tabbrowser-reviewers,home-newtab-reviewers,thecount,whimboo,dao,afinder,omc-reviewers,aminomancer 
Differential Revision: https://phabricator.services.mozilla.com/D205529
 2024-04-03 10:32:27 +00:00
Jonathan Sudiaman
e883ef8dfe Bug 1861400 - Remove sync if disabled by policy r=fxview-reviewers,nsharpley,kcochrane 
Brings the Firefox View behavior in line with what is done in `browser-sync.js`.

Differential Revision: https://phabricator.services.mozilla.com/D205881
 2024-04-01 21:50:10 +00:00
Hanna Jones
c1021a6f87 Bug 1850037 - Part 2: Use moz-button to remove ghost button styles in fxview r=fxview-reviewers,desktop-theme-reviewers,reusable-components-reviewers,kcochrane,mstriemer,dao 
Differential Revision: https://phabricator.services.mozilla.com/D187932
 2024-04-01 16:08:41 +00:00
Nikki Sharpley
89022a0076 Bug 1883231 - Prevent "no results" from showing if history search is still in progress r=fxview-reviewers,places-reviewers,sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D205756
 2024-04-01 13:14:01 +00:00
Yi Xiong Wong
bfa71f327f Bug 1880914 - Move BrowserHome. r=Gijs,extension-reviewers,sessionstore-reviewers,dao 
Differential Revision: https://phabricator.services.mozilla.com/D205528
 2024-03-28 17:05:02 +00:00
Jonathan Sudiaman
895f791b99 Bug 1887647 - Tabs from other devices doesn't render on first load r=fxview-reviewers,nsharpley,sfoster 
Ensure that we always call `requestUpdate()` when needed.

Differential Revision: https://phabricator.services.mozilla.com/D205582
 2024-03-28 13:42:33 +00:00
Nikki Sharpley
1975fae7ce Bug 1879926 - Add Lit history component to Sidebar r=fxview-reviewers,desktop-theme-reviewers,dao,kcochrane,fluent-reviewers,jsudiaman,kpatenio 
Styling and templates will change as we receive UX specs.

Depends on D202726

Differential Revision: https://phabricator.services.mozilla.com/D204226
 2024-03-26 20:09:37 +00:00
Kelly Cochrane
5967ae753d Bug 1880542 - Refactor fxview-tab-list and fxview-tab-row r=sfoster,fxview-reviewers,jsudiaman 
Differential Revision: https://phabricator.services.mozilla.com/D205499
 2024-03-26 18:01:02 +00:00
Emilio Cobos Álvarez
fecb5ced0a Bug 1877298 - Make tab color in firefox view match the browser UI on Linux and prefers-contrast modes. r=dao,kcochrane,desktop-theme-reviewers,fxview-reviewers,jules 
Differential Revision: https://phabricator.services.mozilla.com/D204891
 2024-03-25 20:23:33 +00:00
Anna Yeddi
562009c2c1 Bug 1883722 - Update Firefox View stylesheets to use forced-colors instead of prefers-contrast to make room for macOS specific styling. r=morgan,desktop-theme-reviewers,fxview-reviewers?,#fxview-reviewers. 
As part of the [HCM and Increased Contrast Support in FX project](https://docs.google.com/document/d/1x37hxRrP9B2c3luy7sz748PCuVygvD3REsluQRQpfYE/edit?usp=sharing), the Accessibility team is auditing existing `prefers-contrast` media query blocks in mozilla-central. For each block with `prefers-contrast` media we want to convert it to `forced-colors` where appropriate.

Refer to the [bug 1877780 #c0](https://bugzilla.mozilla.org/show_bug.cgi?id=1877780#c0) for more information about the project.

Differential Revision: https://phabricator.services.mozilla.com/D203650
 2024-03-22 21:01:56 +00:00
Kelly Cochrane
b5d4a529bc Bug 1883876 - Update window list in Open Tabs in Fx View when moving a tab between windows r=fxview-reviewers,sclements,sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D203971
 2024-03-22 17:02:53 +00:00
Kelly Cochrane
09b5807997 Bug 1877298 - Create reusable token for color used in the tab attention radial gradient. r=desktop-theme-reviewers,fxview-reviewers,reusable-components-reviewers,jules,dao,kcochrane 
Differential Revision: https://phabricator.services.mozilla.com/D202736
 2024-03-22 16:24:02 +00:00
Stanca Serban
3deefc0df9 Backed out changeset 319a405e8b57 (bug 1883876) for causing mochitests failures in browser_blanking.js. 2024-03-22 18:22:25 +02:00
Kelly Cochrane
f77250a5ba Bug 1883876 - Update window list in Open Tabs in Fx View when moving a tab between windows r=fxview-reviewers,sclements,sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D203971
 2024-03-22 14:02:18 +00:00
Sandor Molnar
80fa71c9ea Backed out changeset 153aa2b4247f (bug 1883876) for causing multiple bc failures @ browser/components/firefoxview/<...> & browser/components/aboutwelcome/<...> 2024-03-21 21:46:22 +02:00
Kelly Cochrane
ee6e9f682a Bug 1883876 - Update window list in Open Tabs in Fx View when moving a tab between windows r=fxview-reviewers,sclements,sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D203971
 2024-03-21 18:44:36 +00:00
Jonathan Sudiaman
86b13540d5 Bug 1880539 - Refactor firefoxview/syncedtabs.mjs to make business logic more reusable r=fxview-reviewers,nsharpley,sclements 
Decoupling complex business logic from UI components.

https://treeherder.mozilla.org/jobs?repo=try&revision=a65ebee15c1ef5f47411326b0c9ba2394e17d80f

Differential Revision: https://phabricator.services.mozilla.com/D204081
 2024-03-19 23:21:13 +00:00
Anna Yeddi
abfd9860dc Bug 1886114 - Remove fail-if notation from the Firefox View test passing a11y-checks. r=sfoster,fxview-reviewers 
the updated version of the Show More link activation has resolved the issue that was there before: the link used to be clicked when it still had `hidden` attribute on - probably, right before it was rendered as shown/un-hidden, since the test harness is moving too fast. In this updated case, all the instances of the Show More links being clicked while they are visible and, therefore, accessible for the Accessibility API. We could safely remove the `fail-if` since it's working now as expected

Differential Revision: https://phabricator.services.mozilla.com/D205151
 2024-03-19 23:07:42 +00:00
Sandor Molnar
f7cf405cf5 Backed out changeset 2092d43bfaae (bug 1880539) for causing bc failures @ browser/components/firefoxview/tests/browser/<...> CLOSED TREE 2024-03-19 18:29:33 +02:00
Jonathan Sudiaman
3b3cfcef03 Bug 1880539 - Refactor firefoxview/syncedtabs.mjs to make business logic more reusable r=fxview-reviewers,nsharpley,sclements 
Decoupling complex business logic from UI components.

https://treeherder.mozilla.org/jobs?repo=try&revision=a65ebee15c1ef5f47411326b0c9ba2394e17d80f

Differential Revision: https://phabricator.services.mozilla.com/D204081
 2024-03-19 14:03:41 +00:00
Dave Townsend
a9a51bf046 Bug 1864896: Autofix unused function arguments (browser). r=webcompat-reviewers,mconley,fxview-reviewers,desktop-theme-reviewers,omc-reviewers,migration-reviewers,twisniewski,aminomancer,dao,sclements,firefox-desktop-core-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D203005
 2024-03-19 09:36:35 +00:00
Sam Foster
60a189fad8 Bug 1877678 - Improve window switching in the opentabs cards tests. r=fxview-reviewers,sclements 
* Adds a new switchToWindow helper and calls it in openFirefoxViewTab to ensure we wait until the window is active
* Fix some fallout from this change in the browser_opentabs_recency.js test

Differential Revision: https://phabricator.services.mozilla.com/D201861
 2024-03-18 21:08:13 +00:00
Sam Foster
c333ce93fa Bug 1877678 - Split out the some of the open tabs tests into their own file. r=fxview-reviewers,sclements 
Differential Revision: https://phabricator.services.mozilla.com/D202486
 2024-03-18 21:08:12 +00:00