Commit graph

71 commits

Author SHA1 Message Date
Jonathan Sudiaman
3547e9b03f Bug 1883231 - Don't update search results for a stale query in Firefox View. r=nsharpley,fxview-reviewers,places-reviewers,Standard8,sidebar-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D208946
2024-05-09 13:34:37 +00:00
Jonathan Sudiaman
fefc790575 Bug 1867614 - fxview-tab-list story is broken, shows a "ChromeUtils is not defined" error r=fxview-reviewers,reusable-components-reviewers,hjones,nsharpley
Remove transitive dependency on `ChromeUtils` that is causing this error.

Differential Revision: https://phabricator.services.mozilla.com/D208380
2024-04-23 21:26:09 +00:00
Kelly Cochrane
6d07671d4b Bug 1877120 - Ensure virtual-list intersection observer fires only once expected fxview-tab-list items have rendered r=fxview-reviewers,sfoster,mstriemer
Differential Revision: https://phabricator.services.mozilla.com/D207476
2024-04-16 18:31:20 +00:00
Jonathan Sudiaman
e0e15ff907 Bug 1879925 - Replace Synced Tabs component in sidebar r=sidebar-reviewers,fxview-reviewers,nsharpley,sfoster,desktop-theme-reviewers,sclements
https://treeherder.mozilla.org/jobs?repo=try&revision=b2e04c07c3582baefbc4cc8e219ba33626788180

Differential Revision: https://phabricator.services.mozilla.com/D205646
2024-04-11 14:35:43 +00:00
Hanna Jones
c1021a6f87 Bug 1850037 - Part 2: Use moz-button to remove ghost button styles in fxview r=fxview-reviewers,desktop-theme-reviewers,reusable-components-reviewers,kcochrane,mstriemer,dao
Differential Revision: https://phabricator.services.mozilla.com/D187932
2024-04-01 16:08:41 +00:00
Nikki Sharpley
89022a0076 Bug 1883231 - Prevent "no results" from showing if history search is still in progress r=fxview-reviewers,places-reviewers,sfoster
Differential Revision: https://phabricator.services.mozilla.com/D205756
2024-04-01 13:14:01 +00:00
Kelly Cochrane
5967ae753d Bug 1880542 - Refactor fxview-tab-list and fxview-tab-row r=sfoster,fxview-reviewers,jsudiaman
Differential Revision: https://phabricator.services.mozilla.com/D205499
2024-03-26 18:01:02 +00:00
Dave Townsend
a9a51bf046 Bug 1864896: Autofix unused function arguments (browser). r=webcompat-reviewers,mconley,fxview-reviewers,desktop-theme-reviewers,omc-reviewers,migration-reviewers,twisniewski,aminomancer,dao,sclements,firefox-desktop-core-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D203005
2024-03-19 09:36:35 +00:00
Kelly Cochrane
ec892767dc Bug 1884322 - Only toggle mute/unmute tabs in Fx View with Enter/Space keys if using keyboard navigation r=fxview-reviewers,jsudiaman
Differential Revision: https://phabricator.services.mozilla.com/D204042
2024-03-09 17:14:17 +00:00
Nikki Sharpley
c93c77d631 Bug 1884170 - Missing options button icon in history fixed r=fxview-reviewers,kcochrane
Added correct secondary class names to show options button icon in history.

Differential Revision: https://phabricator.services.mozilla.com/D203928
2024-03-07 21:39:31 +00:00
Kelly Cochrane
ebd50133c8 Bug 1883890 - Ensure proper HCM styles are being applied to media button for pinned tabs in Fx View r=fxview-reviewers,ayeddi,nsharpley
Differential Revision: https://phabricator.services.mozilla.com/D203827
2024-03-07 18:32:21 +00:00
Kelly Cochrane
4356fdde79 Bug 1883337 - Ensure focus is moved when mute/unmute button is removed in Fx View r=fxview-reviewers,nsharpley,jsudiaman
Differential Revision: https://phabricator.services.mozilla.com/D203484
2024-03-05 15:49:24 +00:00
Norisz Fay
22920d0f27 Backed out changeset c23d6a5f066e (bug 1883337) for causing bc failures on browser_opentabs_pinned_tabs.js CLOSED TREE 2024-03-05 17:10:15 +02:00
Kelly Cochrane
4c7911d465 Bug 1883337 - Ensure focus is moved when mute/unmute button is removed in Fx View r=fxview-reviewers,nsharpley,jsudiaman
Differential Revision: https://phabricator.services.mozilla.com/D203484
2024-03-05 13:49:03 +00:00
Jonathan Sudiaman
4c8fd972e5 Bug 1876165 - Create BookmarkList class that internally stays up-to-date to indicate bookmarked open tabs in Fx View r=mak,fxview-reviewers,places-reviewers,fluent-reviewers,bolsson,sfoster,desktop-theme-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D201759
2024-03-04 13:02:16 +00:00
Iulian Moraru
cdaf956a6a Backed out changeset bfb6942faf35 (bug 1876165) for causing multiple bc failures. CLOSED TREE 2024-03-01 16:20:18 +02:00
Jonathan Sudiaman
69051d0e86 Bug 1876165 - Create BookmarkList class that internally stays up-to-date to indicate bookmarked open tabs in Fx View r=mak,fxview-reviewers,places-reviewers,fluent-reviewers,bolsson,sfoster,desktop-theme-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D201759
2024-03-01 13:34:08 +00:00
Nikki Sharpley
f5f3c4cf15 Bug 1879609 - Add pinned indicator for urls pinned in New Tab r=fxview-reviewers,desktop-theme-reviewers,emilio
- added pin icons to the tab row for tabs pinned in New Tab

Differential Revision: https://phabricator.services.mozilla.com/D201770
2024-02-29 02:26:27 +00:00
Nikki Sharpley
c2a33192da Bug 1857298 - Add close button to open tabs in view r=fxview-reviewers,fluent-reviewers,desktop-theme-reviewers,bolsson,sclements
- created tertiary button option for tab rows, styled by a class prop
- added close button to open tabs rows
- removed close tab from open tab context menu
- updated tests to reflect removed panel item in open tab context menu
- added test for the new open tabs close button
- added telemetry for close open tab (requires data review)
- added test suite for keyboard navigation across tab row buttons

Depends on D201652

Differential Revision: https://phabricator.services.mozilla.com/D200689
2024-02-28 19:37:22 +00:00
Stanca Serban
7d719a0f5f Backed out 2 changesets (bug 1857298) for causing mochitests failures in browser_parsable_css.js. CLOSED TREE
Backed out changeset 32ca524f7abf (bug 1857298)
Backed out changeset c4ed2e3e1ff2 (bug 1857298)
2024-02-28 20:47:18 +02:00
Nikki Sharpley
88756da91d Bug 1857298 - Add close button to open tabs in view r=fxview-reviewers,fluent-reviewers,desktop-theme-reviewers,bolsson,sclements
- created tertiary button option for tab rows, styled by a class prop
- added close button to open tabs rows
- removed close tab from open tab context menu
- updated tests to reflect removed panel item in open tab context menu
- added test for the new open tabs close button
- added telemetry for close open tab (requires data review)
- added test suite for keyboard navigation across tab row buttons

Differential Revision: https://phabricator.services.mozilla.com/D200689
2024-02-28 17:31:17 +00:00
Kelly Cochrane
349a25f771 Bug 1849175 - Add pinned tabs to Open Tabs in Firefox View r=desktop-theme-reviewers,fxview-reviewers,fluent-reviewers,flod,sclements,nsharpley,dao
Differential Revision: https://phabricator.services.mozilla.com/D201652
2024-02-27 23:33:19 +00:00
Natalia Csoregi
1fd32d1a3e Backed out 3 changesets (bug 1877678, bug 1849175) for causing failures on browser_opentabs_recency.js CLOSED TREE
Backed out changeset 67fd66802500 (bug 1849175)
Backed out changeset da9aa1960b63 (bug 1877678)
Backed out changeset 8d9e1646bd6e (bug 1877678)
2024-02-28 00:22:14 +02:00
Kelly Cochrane
805b8667a7 Bug 1849175 - Add pinned tabs to Open Tabs in Firefox View r=desktop-theme-reviewers,fxview-reviewers,fluent-reviewers,flod,sclements,nsharpley,dao
Differential Revision: https://phabricator.services.mozilla.com/D201652
2024-02-27 20:30:59 +00:00
Cristian Tuns
ec624a75b1 Backed out changeset f9c17890d242 (bug 1849175) for causing bc failures in browser_opentabs_firefoxview.js CLOSED TREE 2024-02-27 11:56:55 -05:00
Kelly Cochrane
557ded09f5 Bug 1849175 - Add pinned tabs to Open Tabs in Firefox View r=desktop-theme-reviewers,fxview-reviewers,fluent-reviewers,flod,sclements,nsharpley,dao
Differential Revision: https://phabricator.services.mozilla.com/D201652
2024-02-27 16:27:20 +00:00
Iulian Moraru
08629b9d2c Backed out changeset 37ef0aa2d2b5 (bug 1857298) for causing bc failures on browser_recentlyclosed_firefoxview.js. 2024-02-20 18:06:25 +02:00
Nikki Sharpley
1a596d38ec Bug 1857298 - Add close button to open tabs in view r=fxview-reviewers,fluent-reviewers,desktop-theme-reviewers,bolsson,sclements
- created tertiary button option for tab rows, styled by a class prop
- added close button to open tabs rows
- removed close tab from open tab context menu
- updated tests to reflect removed panel item in open tab context menu
- added test for the new open tabs close button
- added telemetry for close open tab (requires data review)
- added test suite for keyboard navigation across tab row buttons

Differential Revision: https://phabricator.services.mozilla.com/D200689
2024-02-20 14:50:25 +00:00
Kelly Cochrane
94b1ae8aae Bug 1857005 - Add indicators to open tabs in Fx View r=desktop-theme-reviewers,fxview-reviewers,fluent-reviewers,sfoster,bolsson
Differential Revision: https://phabricator.services.mozilla.com/D199119
2024-01-30 19:52:31 +00:00
Kelly Cochrane
bd0f803dd5 Bug 1870141 - Only recalculate maxRenderCountEstimate in virtual-list if itemHeightEstimate is greater than 0 r=sclements,fxview-reviewers,sfoster
Differential Revision: https://phabricator.services.mozilla.com/D196588
2023-12-18 16:46:55 +00:00
Kelly Cochrane
92f69f8295 Bug 1857634 - Pause updates and clear interval time in fxview-tab-list when containing cards are collapsed r=sfoster,fxview-reviewers,sclements
Differential Revision: https://phabricator.services.mozilla.com/D194421
2023-12-12 21:50:56 +00:00
Noemi Erli
92a10c2108 Backed out changeset c5f52ea7e7d0 (bug 1857634) for causing failures in test_fxview_tab_list.html 2023-12-12 22:39:33 +02:00
Kelly Cochrane
927996dd37 Bug 1857634 - Pause updates and clear interval time in fxview-tab-list when containing cards are collapsed r=sfoster,fxview-reviewers,sclements
Differential Revision: https://phabricator.services.mozilla.com/D194421
2023-12-12 18:02:04 +00:00
Jonathan Sudiaman
3de7983045 Bug 1867325 - Small UI updates to Search in Recently closed tabs and History r=fxview-reviewers,desktop-theme-reviewers,dao,sclements
Differential Revision: https://phabricator.services.mozilla.com/D195893
2023-12-11 15:49:57 +00:00
Kelly Cochrane
a51e44665b Bug 1868443 - Update calculation for viewport height in Firefox View r=fxview-reviewers,sclements
Differential Revision: https://phabricator.services.mozilla.com/D195723
2023-12-07 13:54:25 +00:00
Kelly Cochrane
4826d47124 Bug 1859788 - Implement virtualizer to improve performance of history in Firefox View r=jsudiaman,fxview-reviewers,reusable-components-reviewers,hjones,sfoster,mstriemer
Differential Revision: https://phabricator.services.mozilla.com/D184581
2023-12-04 17:50:04 +00:00
Cosmin Sabou
62b1c8b8d7 Backed out changeset e1b32d718ed1 (bug 1859788) for high frequency failures on browser_firefoxview_next_general_telemetry.js. 2023-11-30 20:33:51 +02:00
Kelly Cochrane
234b79048d Bug 1859788 - Implement virtualizer to improve performance of history in Firefox View r=jsudiaman,fxview-reviewers,reusable-components-reviewers,hjones,sfoster,mstriemer
Differential Revision: https://phabricator.services.mozilla.com/D184581
2023-11-30 16:54:08 +00:00
Norisz Fay
f8a308f78e Backed out changeset d3d999e4ff71 (bug 1859788) for causing bc failures on browser_firefoxview_next.js 2023-11-28 20:31:50 +02:00
Kelly Cochrane
241249e8ec Bug 1859788 - Implement virtualizer to improve performance of history in Firefox View r=jsudiaman,fxview-reviewers,reusable-components-reviewers,hjones,sfoster,mstriemer
Differential Revision: https://phabricator.services.mozilla.com/D184581
2023-11-28 16:56:45 +00:00
Jonathan Sudiaman
fd64955080 Bug 1859829 - Add search to recently closed tabs r=fxview-reviewers,fluent-reviewers,bolsson,sclements
Linear search through the list of recently closed tabs, and some light refactoring for the sake of upcoming search enhancements.

Differential Revision: https://phabricator.services.mozilla.com/D193692
2023-11-21 18:01:05 +00:00
Jonathan Sudiaman
3645ff1757 Bug 1826328 - Add search capability to view in history r=fxview-reviewers,places-reviewers,fluent-reviewers,flod,mak,sclements
Leverages `AUTOCOMPLETE_MATCH` in order to add search functionality to Fx View History.

https://treeherder.mozilla.org/jobs?repo=try&revision=a45a29326ba22252756cd9d142e9199508b6693b

Differential Revision: https://phabricator.services.mozilla.com/D190844
2023-11-08 02:17:13 +00:00
Logan Rosen
ba0d5e580e Bug 1860931 - fix bug in fxview-tab-list.mjs r=fxview-reviewers,sclements
There are two equals signs when there should be just one. This was made more obvious after applying Prettier v3's auto formatting.

Differential Revision: https://phabricator.services.mozilla.com/D190411
2023-10-25 09:41:31 +00:00
Kelly Cochrane
d7be52313a Bug 1854603 - Truncate domains to one line for list items in Firefox View r=desktop-theme-reviewers,fxview-reviewers,dao,sclements
Differential Revision: https://phabricator.services.mozilla.com/D190822
2023-10-16 16:12:26 +00:00
Sam Foster
ce30877412 Bug 1857118 - Avoid rendering tab lists and stop the interval timer when not visible. r=jsudiaman,fxview-reviewers,kcochrane
Differential Revision: https://phabricator.services.mozilla.com/D190242
2023-10-11 17:52:03 +00:00
Sandor Molnar
bbd31940fd Backed out 2 changesets (bug 1857118, bug 1841797) for causing bc failures on browser/components/firefoxview/tests/browser/firefoxview-next/browser_opentabs_recency_next.js
Backed out changeset 08d1791bf44b (bug 1857118)
Backed out changeset 444f6de78b7e (bug 1841797)
2023-10-11 09:31:47 +03:00
Sam Foster
63d2d8af99 Bug 1857118 - Avoid rendering tab lists and stop the interval timer when not visible. r=jsudiaman,fxview-reviewers,kcochrane
Differential Revision: https://phabricator.services.mozilla.com/D190242
2023-10-10 21:59:46 +00:00
Norisz Fay
a7813860d4 Backed out changeset 9dfc3bfb7943 (bug 1857118) for causing mochitest failures on test_opentabs.html 2023-10-09 20:23:18 +03:00
Sam Foster
3a6a37c59a Bug 1857118 - Avoid rendering tab lists and stop the interval timer when not visible. r=jsudiaman,fxview-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D190242
2023-10-09 13:44:04 +00:00
Kelly Cochrane
d3f578853d Bug 1852229 - Fix spacing between synced devices on Recent Browsing r=sclements,fxview-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D188640
2023-09-20 14:32:56 +00:00