Commit graph

506 commits

Author SHA1 Message Date
Neil Deakin
fa63e4a464 Bug 371900, always fire a command event on key elements except for those that are marked not to, r=masayuki
The edit-related commands are special because they are handled by ShortcutKeyDefinitions.cpp yet we have duplicate keys because we want the menu disabled state to update properly, so we don't fire command events on those.

Differential Revision: https://phabricator.services.mozilla.com/D135157
2022-01-11 20:02:29 +00:00
criss
e2948093fb Backed out 2 changesets (bug 371900) for causing bug 1749182 . CLOSED TREE
Backed out changeset e59035c65af3 (bug 371900)
Backed out changeset 6434bce9c7d4 (bug 371900)
2022-01-09 16:26:02 +02:00
Neil Deakin
6b88580db1 Bug 371900, always fire a command event on key elements except for those that are marked not to, r=masayuki
The edit-related commands are special because they are handled by ShortcutKeyDefinitions.cpp yet we have duplicate keys because we want the menu disabled state to update properly, so we don't fire command events on those.

Differential Revision: https://phabricator.services.mozilla.com/D135157
2022-01-08 18:07:21 +00:00
Jonathan Watt
2a9a0b264a Bug 1702501 - Remove print.tab_modal.enabled pref and old frontend print preview code. r=mstriemer
Differential Revision: https://phabricator.services.mozilla.com/D134699
2022-01-06 18:55:38 +00:00
Chris Peterson
38b49d89f5 Bug 1661791 - Remove "New Non-Fission Window" menu item. r=mconley
Now that Fission is the default, we don't want people to open Fission and non-Fission windows in the same session.

Differential Revision: https://phabricator.services.mozilla.com/D133854
2021-12-16 05:26:41 +00:00
Emma Malysz
08da538533 Bug 1725430: disable screenshot shortcut for extension when screenshots.browser.component.enabled is true. r=emalysz,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D125850
2021-09-28 20:01:35 +00:00
criss
c036c2f5c2 Backed out changeset ec019c0205a9 (bug 1725430) for causing failures on dbg-toggling-tools.js 2021-09-28 00:42:30 +03:00
Emma Malysz
53a01f5fb9 Bug 1725430: disable screenshot shortcut for extension when screenshots.browser.component.enabled is true. r=emalysz,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D125850
2021-09-27 17:30:35 +00:00
Narcis Beleuzu
033a7edbff Backed out changeset ceaaed353b66 (bug 1725430) for assertion failure on ErrorResult.h . CLOSED TREE 2021-09-22 01:09:22 +03:00
Emma Malysz
6fede10fc1 Bug 1725430: disable screenshot shortcut for extension when screenshots.browser.component.enabled is true. r=emalysz,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D125850
2021-09-21 20:37:48 +00:00
Gijs Kruitbosch
1d7f4797cd Bug 1712306 - add telemetry for the close multiple tabs modal, r=jaws
Differential Revision: https://phabricator.services.mozilla.com/D115840
2021-05-27 21:01:01 +00:00
Emilio Cobos Álvarez
915f02d25c Bug 1694951 - Remove printing.trigger telemetry. r=jwatt,marionette-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D106465
2021-03-01 11:36:43 +00:00
Micah Tigley
ee30ccbff9 Bug 1675549 - Stop using the 2h2020 pref to block new shortcut for the bookmarks toolbar. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D96471
2020-11-09 21:43:17 +00:00
Kartikaya Gupta
8ee9f46d79 Bug 1660054 - Hook up the zoom-reset action to also reset APZ/scaling zoom. r=Gijs,nika,botond
The goal here is to hook up the ctrl+0 keyboard shortcut to reset the scaling
zoom applied by pinch gestures (on touchscreen or trackpad), in addition to
resetting the reflow zoom (aka full zoom). This patch also makes other mechanisms
to reset the reflow zoom (e.g. clicking on the "100%" label in the hamburger menu)
also reset scaling zoom, which I think makes sense for consistency.

Most of this patch is just plumbing, but I'm unfamiliar with these codepaths
so requesting review from relevant owners to make sure it's sane.

Differential Revision: https://phabricator.services.mozilla.com/D94624
2020-10-28 22:48:57 +00:00
Mihai Alexandru Michis
48192aab09 Backed out changeset 952da6bff887 (bug 1660054) for causing bc failures in browser_test_reset_scaling_zoom.js
CLOSED TREE
2020-10-28 23:00:15 +02:00
Kartikaya Gupta
c75bed1584 Bug 1660054 - Hook up the zoom-reset action to also reset APZ/scaling zoom. r=Gijs,nika,botond
The goal here is to hook up the ctrl+0 keyboard shortcut to reset the scaling
zoom applied by pinch gestures (on touchscreen or trackpad), in addition to
resetting the reflow zoom (aka full zoom). This patch also makes other mechanisms
to reset the reflow zoom (e.g. clicking on the "100%" label in the hamburger menu)
also reset scaling zoom, which I think makes sense for consistency.

Most of this patch is just plumbing, but I'm unfamiliar with these codepaths
so requesting review from relevant owners to make sure it's sane.

Differential Revision: https://phabricator.services.mozilla.com/D94624
2020-10-28 19:14:18 +00:00
Jared Wein
3d2a8005c8 Bug 727668 - Show bookmarks toolbar on the new tab page. r=Gijs,fluent-reviewers,marionette-reviewers,whimboo
This adds the ability to force the bookmarks toolbar to appear on all pages. The checkbox in the toolbar context menu will reflect if the toolbar will appear outside of the newtab page. The toolbar will always appear on the newtab page. Profiles that already had the toolbar showing will have a migration to keep their experience unchanged.

Differential Revision: https://phabricator.services.mozilla.com/D89222
2020-10-26 02:32:07 +00:00
Mihai Alexandru Michis
f11e661f24 Backed out changeset ba261cf25651 (bug 727668) for causing marionette failures in test_screenshot.py
CLOSED TREE
2020-10-22 06:13:54 +03:00
Jared Wein
e0e5f6bba3 Bug 727668 - Show bookmarks toolbar on the new tab page. r=Gijs,fluent-reviewers
This adds the ability to force the bookmarks toolbar to appear on all pages. The checkbox in the toolbar context menu will reflect if the toolbar will appear outside of the newtab page. The toolbar will always appear on the newtab page. Profiles that already had the toolbar showing will have a migration to keep their experience unchanged.

Differential Revision: https://phabricator.services.mozilla.com/D89222
2020-10-21 19:20:20 +00:00
Narcis Beleuzu
8945877156 Backed out 1 changesets (bug 727668) for bc failures on browser_aboutNewTab_bookmarksToolbar.js . CLOSED TREE
Backed out changeset 5b6a14b4e16e (bug 727668)
2020-10-19 21:19:17 +03:00
Jared Wein
0e83701c0c Bug 727668 - Show bookmarks toolbar on the new tab page. r=Gijs,fluent-reviewers
This adds the ability to force the bookmarks toolbar to appear on all pages. The checkbox in the toolbar context menu will reflect if the toolbar will appear outside of the newtab page. The toolbar will always appear on the newtab page. Profiles that already had the toolbar showing will have a migration to keep their experience unchanged.

Differential Revision: https://phabricator.services.mozilla.com/D89222
2020-10-19 16:38:17 +00:00
Emilio Cobos Álvarez
4e68e78542 Bug 1669925 - Add a printing.trigger keyed scalar to record what triggers a particular print dialog. r=jwatt,marionette-reviewers,maja_zf
In order to avoid over/under-counting, we need to treat window.print()
specially. The new UI was using aOpenWindowInfo.isForPrintPreview for
that, but that doesn't quite work for the old UI (because it will
trigger a regular print, not a preview).

But since isForPrintPreview was only really needed to distinguish
window.print(), just rename it and set it to true when the old UI is
triggered by window.print() as well.

Differential Revision: https://phabricator.services.mozilla.com/D92925
2020-10-09 14:59:46 +00:00
Micah Tigley
3524fbc87d Bug 1328637 - Add a keyboard shortcut for showing/hiding the bookmarks toolbar. r=jaws,fluent-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D90132
2020-09-29 15:04:54 +00:00
Chris Jackson
47438f7e2a Bug 1599376 - Fixed toggle picture in picture shortcut on MacOS. r=Gijs,fluent-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D90018
2020-09-12 19:26:38 +00:00
Emilio Cobos Álvarez
5b82674837 Bug 1660739 - Fix tabs.printPreview API with the new print preview design. r=mstriemer,mixedpuppy
Return a promise from PrintUtils.printPreview which resolves when the
new print preview dialog is closed.

Differential Revision: https://phabricator.services.mozilla.com/D88013
2020-08-26 03:10:47 +00:00
Asif Youssuff
ccf1654f72 Bug 1553945 - Added a keyboard shortcut to show history on macOS r=mak,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D84897
2020-07-30 08:54:56 +00:00
Kris Taeleman
5dff16d2f3 Bug 1652877 - Make ctrl-shift-minus zoom out like ctrl-shift-plus zooms in. r=botond,flod,fluent-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D83570
2020-07-18 06:14:19 +00:00
Mark Striemer
2027ee64c6 Bug 1652627 - Setup a pref for tab modal print UI r=Gijs,sfoster
This creates the print.modal_print_preview.enabled pref to manage
whether the tab modal print UI should be used and creates some
files we'll need for the UI to use.

Differential Revision: https://phabricator.services.mozilla.com/D83445
2020-07-16 22:16:22 +00:00
Kashav Madan
8bf5a0784d Bug 1647334 - Inherit the private browsing bit for new (Non-)Fission windows opened from the File menu, r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D80480
2020-06-22 15:58:24 +00:00
Jared Wein
d9d492eda7 Bug 887515 - Restore multiple tab closings using Undo Close Tab(s) after a multiple-tab operation. r=fluent-reviewers,flod,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D76087
2020-05-30 06:48:18 +00:00
Mihai Alexandru Michis
415dcacc56 Backed out changeset 3d607fcf4dee (bug 887515) for causing failures in toolbar-context-menu-undo-close-tab
CLOSED TREE
2020-05-30 09:25:30 +03:00
Jared Wein
803b52c5dd Bug 887515 - Restore multiple tab closings using Undo Close Tab(s) after a multiple-tab operation. r=fluent-reviewers,flod,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D76087
2020-05-30 05:38:56 +00:00
Nicolas Silva
bdabdf112f Bug 1635016 - Remove the rest of the SetTransactionLogging glue. r=jrmuizel
Differential Revision: https://phabricator.services.mozilla.com/D74866
2020-05-18 12:11:33 +00:00
Neil Deakin
b8f7ac9956 Bug 1591469, move reader mode to use JSWindowActor instead of message managers, r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D71452
2020-05-13 19:22:20 +00:00
Bogdan Tara
be25a1cf76 Backed out changeset 3a50d857d097 (bug 1591469) for newtab failures complaining about AboutReaderParent CLOSED TREE 2020-05-12 06:13:10 +03:00
Neil Deakin
f9054b8cff Bug 1591469, move reader mode to use JSWindowActor instead of message managers, r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D71452
2020-05-12 01:06:51 +00:00
Andrew Osmond
84731cd82b Bug 1561367 - Implement initial support for capturing multiple frames. r=kvark
This patch adds support for the capture and replaying of multiple frames
during normal operation of Firefox. Ctrl + Shift + 6 starts capturing
and pressing it again stops capturing. It attempts to capture the minimum
amount of data required to replay a sequence for debugging purposes.

There are several known limitations, particularly surrounding replaying
when transitioning between snapshots of the resource cache. It will
reload the entire document set, causing greater delay between frames.
Should you advance too quickly, it may also panic due to a race between
the current frame still being generated, and the new frame resetting the
resource cache state. These should be resolved with time, and the
current implementation should be workable to at least capture/debug most
animated issues with some effort.

It also adds support for loading dynamic properties which is necessary
for accurate replaying of a captured frame (sequence or individual)
which are in the middle of an animation.

Differential Revision: https://phabricator.services.mozilla.com/D59755
2020-04-20 16:03:53 +00:00
Stefan Hindli
84357fecdc Backed out changeset 419be9960357 (bug 1561367) for causing wrench bustages CLOSED TREE 2020-04-20 17:22:53 +03:00
Andrew Osmond
69a83fc13a Bug 1561367 - Implement initial support for capturing multiple frames. r=kvark
This patch adds support for the capture and replaying of multiple frames
during normal operation of Firefox. Ctrl + Shift + 6 starts capturing
and pressing it again stops capturing. It attempts to capture the minimum
amount of data required to replay a sequence for debugging purposes.

There are several known limitations, particularly surrounding replaying
when transitioning between snapshots of the resource cache. It will
reload the entire document set, causing greater delay between frames.
Should you advance too quickly, it may also panic due to a race between
the current frame still being generated, and the new frame resetting the
resource cache state. These should be resolved with time, and the
current implementation should be workable to at least capture/debug most
animated issues with some effort.

It also adds support for loading dynamic properties which is necessary
for accurate replaying of a captured frame (sequence or individual)
which are in the middle of an animation.

Differential Revision: https://phabricator.services.mozilla.com/D59755
2020-04-20 12:53:03 +00:00
Mark Banner
88fb3a72de Bug 1622243 - Implement the bookmark pages option in the library window. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D68776

--HG--
extra : moz-landing-system : lando
2020-04-07 12:56:19 +00:00
John Dai
65d251761e Bug 1612254 - Stop marking the preferences shortcut as "reserved" on mac; r=April
Differential Revision: https://phabricator.services.mozilla.com/D63350

--HG--
extra : moz-landing-system : lando
2020-03-16 15:38:53 +00:00
Dão Gottwald
e938695219 Bug 1620536 - Move "Import from Another Browser" to the Help menu. r=Mardak,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D66551

--HG--
extra : moz-landing-system : lando
2020-03-13 17:29:15 +00:00
Andrew Osmond
772f973027 Bug 1608189 - Allow WebRender captures on beta/release if pref is set. r=jrmuizel,mconley
Differential Revision: https://phabricator.services.mozilla.com/D62916

--HG--
extra : moz-landing-system : lando
2020-02-25 15:23:31 +00:00
Zibi Braniecki
b7948d2eb6 Bug 1614107 - Use shortcut modifiers for toggle reader mode on non-windows platforms. r=MattN
Differential Revision: https://phabricator.services.mozilla.com/D62144

--HG--
extra : moz-landing-system : lando
2020-02-08 07:53:04 +00:00
Zibi Braniecki
b36c4e44b6 Bug 1612723 - Move reader mode l10n to use keycode. r=Gijs,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D61484

--HG--
extra : moz-landing-system : lando
2020-02-07 00:35:32 +00:00
Bogdan Tara
520b2f5d66 Backed out changeset 6495336fced4 (bug 1612723) for assertion failure on ErrorResult.h CLOSED TREE 2020-02-07 01:55:10 +02:00
Zibi Braniecki
c3fbf0c029 Bug 1612723 - Move reader mode l10n to use keycode. r=Gijs,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D61484

--HG--
extra : moz-landing-system : lando
2020-02-06 23:09:03 +00:00
Chris Henry
dcf5ffefe8 Bug 1604970 - make delete key work correctly even when shortcut permissions are restricted, r=NeilDeakin
Differential Revision: https://phabricator.services.mozilla.com/D61275

--HG--
extra : moz-landing-system : lando
2020-02-04 20:48:07 +00:00
Zibi Braniecki
f3db980355 Bug 1608022 - Migrate browser-sets to Fluent. r=fluent-reviewers,Gijs,flod
Differential Revision: https://phabricator.services.mozilla.com/D60068

--HG--
extra : moz-landing-system : lando
2020-01-30 21:07:20 +00:00
Zibi Braniecki
55d15562fd Bug 1608022 - Migrate the bookmark this page and edit bookmark strings to Fluent. r=fluent-reviewers,Gijs,flod
Differential Revision: https://phabricator.services.mozilla.com/D59387

--HG--
extra : moz-landing-system : lando
2020-01-30 21:07:08 +00:00