Commit graph

67 commits

Author SHA1 Message Date
Luke Crouch
6821fc0acd Bug 1664360 also use Region.jsm for vpn region restriction r=baku
Differential Revision: https://phabricator.services.mozilla.com/D90287
2020-09-16 12:04:10 +00:00
Luke Crouch
9cd7330a82 Bug 1664360 - introduce browser.privatebrowsing.vpnpromourl r=baku
Use browser.privatebrowsing.vpnpromourl pref to control the display and link
param value of the VPN promo in about:privatebrowsing.

Differential Revision: https://phabricator.services.mozilla.com/D89916
2020-09-14 09:29:44 +00:00
Neil Deakin
653fff4e36 Bug 1614744, convert about:privatebrowsing to JSWindowActor-based remote page manager, r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D71023
2020-04-29 23:19:15 +00:00
Jim Porter
9c55da7d77 Bug 1529969 - Only request info about the current engine to the parent; r=adw,Mardak
This patch adds a new ContentSearchHandoffUI class to be used when search
handoff is enabled in the newtab page, avoiding the much more complex
ContentSearchUI. This also reduces the amount of unnecessary information being
sent across processes.

Differential Revision: https://phabricator.services.mozilla.com/D48776

--HG--
extra : moz-landing-system : lando
2019-12-17 21:02:52 +00:00
Cosmin Sabou
205ac58f1b Backed out changeset 6636e1cd0c41 (bug 1529969) for causing node tests newtab failures. CLOSED TREE 2019-12-17 21:55:48 +02:00
Jim Porter
fb61d7ebae Bug 1529969 - Only request info about the current engine to the parent; r=adw,Mardak
This patch adds a new ContentSearchHandoffUI class to be used when search
handoff is enabled in the newtab page, avoiding the much more complex
ContentSearchUI. This also reduces the amount of unnecessary information being
sent across processes.

Differential Revision: https://phabricator.services.mozilla.com/D48776

--HG--
extra : moz-landing-system : lando
2019-12-17 07:06:59 +00:00
Mike de Boer
089165087b Bug 1587817 - Move the default search engine in Private Browsing mode for in-content search access points to be contained in ContentSearch.jsm. r=Mardak,Standard8
This reverts part of bug 1576158, so that all current and future in-content pages share the same implementation.

Differential Revision: https://phabricator.services.mozilla.com/D49559

--HG--
extra : moz-landing-system : lando
2019-10-17 13:02:09 +00:00
Mark Banner
818208e565 Bug 1580830 - Add a display to the private browsing page to inform of the new setting for search engines in private mode. r=mikedeboer,fluent-reviewers,flod
This implements the introduction display for the new search engine preference.

The decision for whether or not to display the introduction is handled in AboutPrivateBrowsingHandler.jsm, as we need
to limit it to being displayed once per session.

Differential Revision: https://phabricator.services.mozilla.com/D48722

--HG--
extra : moz-landing-system : lando
2019-10-10 20:00:51 +00:00
Mark Banner
b93f2c2970 Bug 1576158 - Display the private browsing engine on the private browsing page. r=Mardak
Differential Revision: https://phabricator.services.mozilla.com/D47208

--HG--
extra : moz-landing-system : lando
2019-09-27 14:54:38 +00:00
Victor Porof
1f830c96da Bug 1561435 - Format browser/components/, a=automatic-formatting
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D36042

--HG--
extra : source : d3afcafdce650a6f36cebbc126ee93b17f13cf52
2019-07-05 09:53:32 +02:00
Ricky Rosario
c93b7f1009 Bug 1556867 - Remove the old about:private browsing code and pref r=fluent-reviewers,Mardak,Pike,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D33711

--HG--
extra : moz-landing-system : lando
2019-06-10 17:01:54 +00:00
Ricky Rosario
bbd0796d2c Bug 1508364 - New UI for Private Browsing with Search r=andreio
MozReview-Commit-ID: 4WSGpL5Gvde

Differential Revision: https://phabricator.services.mozilla.com/D16854

--HG--
extra : moz-landing-system : lando
2019-01-21 20:14:26 +00:00
arthur.iakab
2ad2d8287a Backed out changeset 13f379946829 (bug 1508364) for functional ui test failures on private_browsing/test_about_private_browsing.py CLOSED TREE 2019-01-21 21:38:29 +02:00
Ricky Rosario
562d5578fe Bug 1508364 - New UI for Private Browsing with Search r=andreio
MozReview-Commit-ID: 4WSGpL5Gvde

Differential Revision: https://phabricator.services.mozilla.com/D16854

--HG--
extra : moz-landing-system : lando
2019-01-21 17:05:08 +00:00
Johann Hofmann
ac88585965 Bug 1502361 - Remove Content Blocking toggle from about:privatebrowsing. r=Ehsan
This simply removes the content blocking section when TP is not enabled to avoid overpromising.
We may update this UI to alert the user that TP is off after the UX team comes back with a new design.

Differential Revision: https://phabricator.services.mozilla.com/D10071

--HG--
extra : rebase_source : 6cf70948a142309edf06da3a53874bde2d7372e5
2018-10-29 17:10:24 +01:00
Ehsan Akhgari
1590b70886 Bug 1501286 - Part 3: Remove support for tracking protection UI in about:privatebrowsing r=johannh
Depends on D9520

Differential Revision: https://phabricator.services.mozilla.com/D9521

--HG--
extra : moz-landing-system : lando
2018-10-25 16:46:49 +00:00
Dorel Luca
9529a31c66 Backed out 5 changesets (bug 1501286) for browser-chrome failures in browser/components/uitour/test/browser_trackingProtection.js
Backed out changeset cac0d4aa79d1 (bug 1501286)
Backed out changeset 578d395f555e (bug 1501286)
Backed out changeset d9940451c373 (bug 1501286)
Backed out changeset ca6c3139bdd2 (bug 1501286)
Backed out changeset 93d6f4d54f78 (bug 1501286)

--HG--
extra : rebase_source : 04083c456cd0df6243861cf53e5c39c08888c5ad
2018-10-25 17:52:59 +03:00
Ehsan Akhgari
df7b68e39e Bug 1501286 - Part 3: Remove support for tracking protection UI in about:privatebrowsing r=johannh
Depends on D9520

Differential Revision: https://phabricator.services.mozilla.com/D9521

--HG--
extra : moz-landing-system : lando
2018-10-25 13:35:22 +00:00
Johann Hofmann
5c79352649 Bug 1490729 - Ensure that we send variation=0 for the TP UI on about:privatebrowsing. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D5680

--HG--
extra : moz-landing-system : lando
2018-09-12 18:12:45 +00:00
Jason Chapin
cb1b9f3b61 Bug 1457786 - Remove question-32.png. r=dao 2018-09-10 16:54:18 +02:00
Johann Hofmann
d27631651f Bug 1488933 - Link to the new content blocking onboarding from about:privatebrowsing when the CB UI is enabled. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D5090

--HG--
extra : moz-landing-system : lando
2018-09-06 13:30:40 +00:00
Soeren Hentzschel
bfb302ba9e Bug 1486915 - Use the "hidden" attribute instead of a "hide" class in aboutPrivateBrowsing.js r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D4821

--HG--
extra : moz-landing-system : lando
2018-09-05 09:28:17 +00:00
Johann Hofmann
6dd6bb0909 Bug 1484586 - Update about:privatebrowsing for content blocking. r=Gijs
This makes the about:privatebrowsing display "Content Blocking" instead
of "Tracking Protection" and makes the toggle flip the TP setting for PB
mode as well as the CB pref if it's turned off.

Differential Revision: https://phabricator.services.mozilla.com/D4395

--HG--
extra : moz-landing-system : lando
2018-08-28 21:01:19 +00:00
Christoph Kerschbaumer
25caec9ca2 Bug 1463663 - Prefix exported functions of the RemotePageManager with RPM. r=mossop 2018-06-27 09:08:32 +02:00
Christoph Kerschbaumer
2c105d2ff5 Bug 1459204: Have about:privatebrowsing rely on RemotePageManager instead of AboutCapabilities. r=mossop,baku 2018-06-07 11:32:27 +02:00
Dão Gottwald
e71fb1aa39 Bug 1448482 - Remove <title> element from about:privatebrowsing since tabbrowser already sets the title. r=Gijs
MozReview-Commit-ID: 7oQrfiK0FRa

--HG--
extra : rebase_source : dcaeae1f53682531709bd8333cdf38a0a7e21298
2018-03-27 23:34:23 +02:00
Margareta Eliza Balazs
b33efac796 Backed out changeset 49867cc4dcc2 (bug 1448482) for ss failures in browser/tools/mozscreenshots/primaryUI/browser_primaryUI.js on a CLOSED TREE 2018-03-27 20:13:36 +03:00
Dão Gottwald
08516a61ad Bug 1448482 - Remove <title> element from about:privatebrowsing since tabbrowser already sets the title. r=Gijs
MozReview-Commit-ID: 3VcK126FfWX

--HG--
extra : rebase_source : f06592918693f9eefbb7214e7232c8066be63740
2018-03-23 22:30:11 +01:00
Gijs Kruitbosch
9525b90d38 Bug 1427186 - stop ever showing 'new tab' as a title for about:privatebrowsing in private windows, r=dao
There are 3 issues here:
- the runtime changing of the title causes issues where the content title is
  not set. This is fixed by setting it to the private title by default;
  there is very little (if any) UI that allows users to even open
  about:privatebrowsing in 'normal' windows so we care a lot less about
  flicker there. To be able to include this title in the markup, we switched
  to a dtd.
- the 'empty tab' title we set on the tab initially is set when the tab is
  created. This has been updated to check for private windows, and default to
  'Private Browsing' instead. This will obviously also affect other new tabs
  in private browsing, but that seems desirable/consistent.
- Likewise, we use this title when updating a tab's title that we don't yet
  have a content title for (which can still happen while about:privatebrowsing
  is loading because e10s), and so that is updated, too.

MozReview-Commit-ID: nVfXD2M6UZ

--HG--
extra : rebase_source : e5a698da70f215d8c7ccca242fbddc0fcaf9bf6b
2018-03-07 20:13:54 +00:00
Gurzau Raul
a0c6a9fd08 Backed out changeset 4e5253710464 (bug 1427186) for failing ss tests on /mozscreenshots/primaryUI/browser_primaryUI.js and for failing bc tests on /privatebrowsing/test/browser/browser_privatebrowsing_windowtitle.js on a CLOSED TREE 2018-03-09 01:52:11 +02:00
Gijs Kruitbosch
10af740779 Bug 1427186 - stop ever showing 'new tab' as a title for about:privatebrowsing in private windows, r=dao
There are 3 issues here:
- the runtime changing of the title causes issues where the content title is
  not set. This is fixed by setting it to the private title by default;
  there is very little (if any) UI that allows users to even open
  about:privatebrowsing in 'normal' windows so we care a lot less about
  flicker there. To be able to include this title in the markup, we switched
  to a dtd.
- the 'empty tab' title we set on the tab initially is set when the tab is
  created. This has been updated to check for private windows, and default to
  'Private Browsing' instead. This will obviously also affect other new tabs
  in private browsing, but that seems desirable/consistent.
- Likewise, we use this title when updating a tab's title that we don't yet
  have a content title for (which can still happen while about:privatebrowsing
  is loading because e10s), and so that is updated, too.

MozReview-Commit-ID: nVfXD2M6UZ

--HG--
extra : rebase_source : 8bd41f1581213b77e1fabced7fc4021ab4cf4d17
2018-03-07 20:13:54 +00:00
Christoph Kerschbaumer
d0bbab23a2 Bug 1430751 - Apply unified behavior model for about: pages to about:privatebrowsing. r=gijs,mrbkap 2018-03-05 09:20:34 +01:00
Andrew McCreight
5dec0e0beb Bug 1432992, part 1 - Remove definitions of Ci, Cr, Cc, and Cu. r=florian
This patch was autogenerated by my decomponents.py

It covers almost every file with the extension js, jsm, html, py,
xhtml, or xul.

It removes blank lines after removed lines, when the removed lines are
preceded by either blank lines or the start of a new block. The "start
of a new block" is defined fairly hackily: either the line starts with
//, ends with */, ends with {, <![CDATA[, """ or '''. The first two
cover comments, the third one covers JS, the fourth covers JS embedded
in XUL, and the final two cover JS embedded in Python. This also
applies if the removed line was the first line of the file.

It covers the pattern matching cases like "var {classes: Cc,
interfaces: Ci, utils: Cu, results: Cr} = Components;". It'll remove
the entire thing if they are all either Ci, Cr, Cc or Cu, or it will
remove the appropriate ones and leave the residue behind. If there's
only one behind, then it will turn it into a normal, non-pattern
matching variable definition. (For instance, "const { classes: Cc,
Constructor: CC, interfaces: Ci, utils: Cu } = Components" becomes
"const CC = Components.Constructor".)

MozReview-Commit-ID: DeSHcClQ7cG

--HG--
extra : rebase_source : d9c41878036c1ef7766ef5e91a7005025bc1d72b
2018-02-06 09:36:57 -08:00
Kris Maglione
918ed6c474 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl

--HG--
extra : source : 12fc4dee861c812fd2bd032c63ef17af61800c70
extra : intermediate-source : 34c999fa006bffe8705cf50c54708aa21a962e62
extra : histedit_source : b2be2c5e5d226e6c347312456a6ae339c1e634b0
2018-01-29 15:20:18 -08:00
Cosmin Sabou
9a65a40178 Backed out 3 changesets (bug 1431533) for Android mochitest failures on testEventDispatcher on a CLOSED TREE
Backed out changeset a1eca62826a1 (bug 1431533)
Backed out changeset 34c999fa006b (bug 1431533)
Backed out changeset e2674287e57f (bug 1431533)
2018-01-30 07:17:48 +02:00
Kris Maglione
6476f95b13 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl

--HG--
extra : source : 12fc4dee861c812fd2bd032c63ef17af61800c70
2018-01-29 15:20:18 -08:00
Brindusan Cristian
af8879d1eb Backed out 2 changesets (bug 1431533) for ESlint failures on a CLOSED TREE
Backed out changeset 6e56f4c8843e (bug 1431533)
Backed out changeset 12fc4dee861c (bug 1431533)
2018-01-30 02:32:43 +02:00
Kris Maglione
c276bb9375 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl

--HG--
extra : rebase_source : c004a023389f1f6bf3d2f3efe93c13d423b23ccd
2018-01-29 15:20:18 -08:00
Johann Hofmann
9006d66671 Bug 1422903 - Prevent about:privatebrowsing favicon from flickering. r=florian
We apply a custom workaround to show about:home and about:newtab favicons
as early as possible for perceived performance, but didn't previously consider
the about:privatebrowsing page (which can act as both about:home and about:newtab).

MozReview-Commit-ID: gPiV08h0j0

--HG--
extra : rebase_source : 12a6ed0973013ed68e783ca3d39a9492c5185411
2017-12-13 05:55:10 -06:00
Mark Banner
42cb2dc6a3 Bug 1230373 - Enable mozilla/use-services for browser/components/ r=mossop
MozReview-Commit-ID: 9m9iss3jUJJ

--HG--
extra : rebase_source : e6a6f9dec168ab1d0e0343236db65f3dd1b44aeb
2017-10-11 15:43:51 +01:00
Jared Wein
a54eda04ca Bug 1348068 - Enable the key-spacing rule for eslint and fix the related issues. r=standard8
Running eslint with --fix didn't fix many of the issues. The majority here had to be fixed by hand but a significant majority of the issues were related to a few files that I was able to use find-and-replace with. I regret not making this in to separate commits of the hand-fixes and the fixes from --fix but I don't recall --fix fixing any of the issues.

MozReview-Commit-ID: ANyg2qfo3Qx

--HG--
extra : rebase_source : 61d2aa91bf9474af3d72a5dea41b25dca442c1b7
2017-03-21 14:29:43 -04:00
Mark Banner
d74b9431a6 Bug 1311345 - Enable eslint of browser/components/privatebrowsing/ - Automatically fixed changes by eslint. r=jaws
MozReview-Commit-ID: 2rmHK5vkpt1

--HG--
extra : rebase_source : d29a70e4adc9572bca8f425760ed0bf30a5188a4
2017-02-28 12:44:14 +00:00
Florian Quèze
85611a7b6d Bug 1331081 - script generated patch to omit addEventListener/removeEventListener's third parameter when it's false, r=jaws.
--HG--
extra : rebase_source : a22344ee1569f58f1f0a01017bfe0d46a6a14602
2017-01-17 11:50:25 +01:00
Ricky Chien
bc20d8239b Bug 1269485 - Improve New Private Browsing start-page background styles r=Gijs
MozReview-Commit-ID: 6gju3cfipJ3

--HG--
extra : transplant_source : %AC%E3bd%AA%20Ua%C4%BD%A2Xx%12%CA%26%97%E7%07%B8
2016-05-04 17:05:50 +08:00
Gijs Kruitbosch
bb5204b3fa Bug 1270496 - tracking protection switch on about:privatebrowsing should also affect the actual setting when using <space> to toggle it, r=jaws
MozReview-Commit-ID: 51bf9AT9eh9

--HG--
extra : rebase_source : 01abaa53ce46878b1015bec57c9173dad7d8d136
2016-05-05 16:28:28 +01:00
Ricky Chien
bdb9281e48 Bug 1259340 - New Private Browsing Window Update. r=past,Gijs
MozReview-Commit-ID: 5NbLribECvC
2016-04-24 16:01:45 +03:00
Paolo Amadini
80cafb07ab Bug 1236231 - Make sure the Tracking Protection tour doorhanger is not shown when the tour starts from about:privatebrowsing. r=past
--HG--
extra : commitid : fwfrZp33lp
extra : rebase_source : 5637764c31d2c0285501877b9302300ce8e7f8ed
2016-01-11 14:40:31 +00:00
Carsten "Tomcat" Book
08997000eb Backed out 2 changesets (bug 1202902) to recking bug 1202902 to be able to reopen inbound on a CLOSED TREE
Backed out changeset 647025383676 (bug 1202902)
Backed out changeset d70c7fe532c6 (bug 1202902)
2015-10-07 14:03:21 +02:00
Carsten "Tomcat" Book
e7ef778c9d Backed out 1 changesets (bug 1202902) for causing merge conflicts to mozilla-central
Backed out changeset cfc1820361f5 (bug 1202902)

--HG--
extra : rebase_source : 5d3db72337754bc7ab0ed0c30b2896100411ff92
2015-10-07 12:13:45 +02:00
Shu-yu Guo
d06b6030f6 Bug 1202902 - Scripted fix the world. 2015-10-06 14:00:31 -07:00