Commit graph

106 commits

Author SHA1 Message Date
Edouard Oger
ff5f53617b Bug 1528622 - Debounce FxA Send Tab commands. r=markh,rfkelly
Differential Revision: https://phabricator.services.mozilla.com/D21286

--HG--
extra : moz-landing-system : lando
2019-03-12 01:05:03 +00:00
Kris Maglione
e930b89c34 Bug 1514594: Part 3 - Change ChromeUtils.import API.
***
Bug 1514594: Part 3a - Change ChromeUtils.import to return an exports object; not pollute global. r=mccr8

This changes the behavior of ChromeUtils.import() to return an exports object,
rather than a module global, in all cases except when `null` is passed as a
second argument, and changes the default behavior not to pollute the global
scope with the module's exports. Thus, the following code written for the old
model:

  ChromeUtils.import("resource://gre/modules/Services.jsm");

is approximately the same as the following, in the new model:

  var {Services} = ChromeUtils.import("resource://gre/modules/Services.jsm");

Since the two behaviors are mutually incompatible, this patch will land with a
scripted rewrite to update all existing callers to use the new model rather
than the old.
***
Bug 1514594: Part 3b - Mass rewrite all JS code to use the new ChromeUtils.import API. rs=Gijs

This was done using the followng script:

https://bitbucket.org/kmaglione/m-c-rewrites/src/tip/processors/cu-import-exports.jsm
***
Bug 1514594: Part 3c - Update ESLint plugin for ChromeUtils.import API changes. r=Standard8

Differential Revision: https://phabricator.services.mozilla.com/D16747
***
Bug 1514594: Part 3d - Remove/fix hundreds of duplicate imports from sync tests. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16748
***
Bug 1514594: Part 3e - Remove no-op ChromeUtils.import() calls. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16749
***
Bug 1514594: Part 3f.1 - Cleanup various test corner cases after mass rewrite. r=Gijs
***
Bug 1514594: Part 3f.2 - Cleanup various non-test corner cases after mass rewrite. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16750

--HG--
extra : rebase_source : 359574ee3064c90f33bf36c2ebe3159a24cc8895
extra : histedit_source : b93c8f42808b1599f9122d7842d2c0b3e656a594%2C64a3a4e3359dc889e2ab2b49461bab9e27fc10a7
2019-01-17 10:18:31 -08:00
Edouard Oger
40fc208fc3 Bug 1516997 p2 - Use hasSyncedThisSession to determine if Send Tab is configured and loading. r=markh
Depends on D15657

Differential Revision: https://phabricator.services.mozilla.com/D15658

--HG--
extra : moz-landing-system : lando
2019-01-03 22:29:03 +00:00
Art-Vanderlay
76fda25cc2 Bug 1507836 - Use long style in "last sync" date formatted r=eoger
Changed format style in "last sync" date from short to long.

Hovering over listed devices in 'send tab to device' on the page action menu shows the last sync date in the short style (last synced: 1 min ago). Changed this to display date in the long style (last synced: 1 minute ago).

Differential Revision: https://phabricator.services.mozilla.com/D13634

--HG--
extra : moz-landing-system : lando
2018-12-02 18:46:47 +00:00
Edouard Oger
c6eabb1525 Bug 1507294 - Display all compatible FxA devices in send tab menu. r=markh
Differential Revision: https://phabricator.services.mozilla.com/D11955

--HG--
extra : moz-landing-system : lando
2018-11-16 03:03:13 +00:00
Jared Wein
b08075b904 Bug 1492702 - Send the contextual link to the device, not the selected tab when a link is right-clicked. r=markh
Differential Revision: https://phabricator.services.mozilla.com/D6980

--HG--
extra : moz-landing-system : lando
2018-09-27 07:49:05 +00:00
Abdoulaye O. Ly
f39692c1fe Bug 1470555 - Implement ability to send a selection of tabs. r=flod,jaws
Differential Revision: https://phabricator.services.mozilla.com/D3126

--HG--
extra : moz-landing-system : lando
2018-09-04 14:36:05 +00:00
Mark Banner
691543ee89 Bug 1486739 - Add missing dangling commas in browser/, services/, taskcluster/ and toolkit/. r=mossop
Automatic changes by ESLint, except for manual corrections for .xml files.

Differential Revision: https://phabricator.services.mozilla.com/D4439

--HG--
extra : moz-landing-system : lando
2018-08-31 05:59:17 +00:00
Paolo Amadini
9ea46d2e0b Bug 1482645 - Part 2 - Don't use a broadcaster element to store sync state. r=markh
Differential Revision: https://phabricator.services.mozilla.com/D3147

--HG--
extra : rebase_source : 34dc6f38f7d8a5ad0e8ed570c9e7efb0c78ca219
2018-08-11 16:46:30 +01:00
Paolo Amadini
10acfef229 Bug 1482645 - Part 1 - Don't use broadcaster elements to show or hide sync interface elements. r=markh
Differential Revision: https://phabricator.services.mozilla.com/D3146

--HG--
extra : rebase_source : cf109b83c572b183cd69390ae0f6ef2c4c0339fa
2018-08-20 07:38:40 +01:00
Edouard Oger
7a730215d7 Bug 1483979 - Enable fxa commands r=markh
Differential Revision: https://phabricator.services.mozilla.com/D3569

--HG--
extra : moz-landing-system : lando
2018-08-17 17:56:52 +00:00
Brian Grinstead
abf1620630 Bug 1479125 - Migrate calls that expect an element to be returned to use element variation firstChild etc to firstElementChild etc;r=Paolo
This allows the JS to work in HTML documents, where whitespace is preserved. In XUL
documents, whitespace is ignored when parsing so text nodes are generally not returned.

The following changes were made, with manual cleanups as necessary (i.e. when firstChild actually
refers to a text node, or when firstChild is used in a loop to empty out an element):

  firstChild->firstElementChild
  lastChild->lastElementChild
  nextSibling->nextElementSibling
  previousSibling->previousElementSibling
  childNodes->children

MozReview-Commit-ID: 95NQ8syBhYw

--HG--
extra : rebase_source : 186d805f7a2a56694dda9032aceac2dfe5424753
2018-08-08 15:22:53 -07:00
Dave Townsend
389a969138 Bug 1479050: Migrate a number of call-sites to use document.createXULElement. r=bgrins
Differential Revision: https://phabricator.services.mozilla.com/D2489

--HG--
extra : moz-landing-system : lando
2018-07-31 19:13:38 +00:00
Edouard Oger
6ebb7fced3 Bug 1466933 - Implement FxA commands. r=markh,rfkelly
MozReview-Commit-ID: EXLO3vnu9vB

--HG--
extra : rebase_source : 75660e909647ef0dd4f56326d38fbe4c1e5f7716
2018-05-30 17:23:56 -04:00
Kris Maglione
a259026c9d Bug 1456035: Part 4 - Convert callers of XPCOMUtils.generateQI to ChromeUtils.generateQI. r=mccr8
This also removes any redundant Ci.nsISupports elements in the interface
lists.

This was done using the following script:

acecb401b7/processors/chromeutils-generateQI.jsm

MozReview-Commit-ID: AIx10P8GpZY

--HG--
extra : rebase_source : a29c07530586dc18ba040f19215475ac20fcfb3b
2018-04-22 20:55:06 -07:00
Edouard Oger
783ac499bc Bug 1442133 - FxA messages client implementation. r=markh,tcsc
MozReview-Commit-ID: EWYlZLdyUA0

--HG--
extra : rebase_source : ac540a5d1c26067c95314d07a32db8994f3dcee6
2018-03-07 13:38:12 -05:00
Amy Chan
d494f855f6 Bug 1446975 - Replace synced Tabs sidebar device icons. r=eoger
MozReview-Commit-ID: GnawrVrfpEz


--HG--
rename : browser/themes/shared/icons/device-mobile.svg => browser/themes/shared/icons/device-phone.svg
2018-04-12 19:22:38 -04:00
Gurzau Raul
50d002961a Backed out 2 changesets (bug 1446975) for failing xpcshell on sync/tests/unit/test_syncedtabs.js and browser-chrome failures e.g. test/urlbar/browser_page_action_menu.js on a CLOSED TREE
Backed out changeset 69653800c483 (bug 1446975)
Backed out changeset 44e3e7446b02 (bug 1446975)

--HG--
rename : browser/themes/shared/icons/device-phone.svg => browser/themes/shared/icons/device-mobile.svg
2018-04-13 01:28:22 +03:00
Amy Chan
711220e6e7 Bug 1446975 - Replace synced Tabs sidebar device icons. r=eoger
MozReview-Commit-ID: GnawrVrfpEz


--HG--
rename : browser/themes/shared/icons/device-mobile.svg => browser/themes/shared/icons/device-phone.svg
2018-04-12 16:18:22 -04:00
Jonathan Kingston
ff73ac0338 Bug 1374741 - Within browser/ make openUILinkIn() provide the correct triggeringPrincipal. r=gijs
MozReview-Commit-ID: 1NQrlWzIBja

--HG--
extra : rebase_source : 29d337e111d82e9c5729b5a59e1a16d06e67774c
2018-02-21 14:28:48 +00:00
Kit Cambridge
94aaf48948 Bug 1448929 - Fix first sync check in gSync.syncConfiguredAndLoading. r=eoger
MozReview-Commit-ID: 8Xk6DMHroTm

--HG--
extra : rebase_source : eba433ff16f9b3088958878cdc7223ec68f68e18
2018-03-26 09:35:29 -07:00
arthur.iakab
7dab3e47c9 Backed out changeset a687dfe9f2de (bug 1448929) for failing browser chrome tests on browser/base/content/test/urlbar/browser_page_action_menu.js on a CLOSED TREE 2018-03-26 22:40:23 +03:00
Kit Cambridge
1fdb02785a Bug 1448929 - Fix first sync check in gSync.syncConfiguredAndLoading. r=eoger
MozReview-Commit-ID: 8Xk6DMHroTm

--HG--
extra : rebase_source : 4dc5bbf2a2c70fb96872d6f9c68570241e6e2438
2018-03-26 09:35:29 -07:00
Edouard Oger
9b6026748b Bug 1184265 - Make last sync date be relative. r=markh
MozReview-Commit-ID: 2hB9F7Elynh

--HG--
extra : rebase_source : dbf962b1fd3f4121f0bcc8276e932f0c49ab90b3
2018-03-20 17:08:16 -04:00
Edouard Oger
4aea0be2d6 Bug 1439777 p2 - Remove weave:ui:* related code. r=markh,tcsc
MozReview-Commit-ID: D1H36YeiJCS

--HG--
extra : rebase_source : 16b7f01ed6f9b03534945d718c567dad0daa4ff3
2018-02-22 16:30:39 +08:00
Narcis Beleuzu
8c7d795b53 Backed out 2 changesets (bug 1439777) for xpcshell failures on /test_errorhandler_2.js
Backed out changeset d99402ad9ecc (bug 1439777)
Backed out changeset 1af3426dc956 (bug 1439777)
2018-03-06 04:43:41 +02:00
Edouard Oger
934abf11b3 Bug 1439777 p2 - Remove weave:ui:* related code. r=markh,tcsc
MozReview-Commit-ID: D1H36YeiJCS

--HG--
extra : rebase_source : dd7218b5f0bd36dc4c71d2a7c95a92bba4da2d12
2018-02-22 16:30:39 +08:00
shindli
51dcc3d916 Backed out 2 changesets (bug 1439777) for browser chrome in browser/components/customizableui/test/browser_remote_tabs_button.js and xpc-shell failures in services/sync/tests/unit/test_errorhandler_2.js on a CLOSED TREE
Backed out changeset 6e83f07e8f2f (bug 1439777)
Backed out changeset 8856efbc78a7 (bug 1439777)

--HG--
extra : histedit_source : 6472e71267b81d2ed8782eeb900c8e12b3e58e52
2018-03-05 18:59:03 +02:00
Edouard Oger
e68b9239b3 Bug 1439777 p2 - Remove weave:ui:* related code. r=markh,tcsc
MozReview-Commit-ID: D1H36YeiJCS

--HG--
extra : rebase_source : e90de5b437cc7fa8afcbe174c7bfb7bdce5b4c90
2018-02-22 16:30:39 +08:00
Edouard Oger
25db2f7ed6 Bug 1434706 - Add identity.fxaccounts.enabled pref to disable Sync and FxA. r=markh
MozReview-Commit-ID: 4UuppJyOi5s

--HG--
extra : rebase_source : 706d6a9a1187e9b666074d0dd68d03eda3fb448b
2018-02-15 11:24:44 +08:00
Csoregi Natalia
c8a2d994c8 Backed out changeset 22901b9f9199 (bug 1434706) for browser-chrome failures browser_contextmenu_sendtab.js. CLOSED TREE 2018-02-26 21:16:01 +02:00
Edouard Oger
7c03ced862 Bug 1434706 - Add identity.fxaccounts.enabled pref to disable Sync and FxA. r=markh
MozReview-Commit-ID: 4UuppJyOi5s

--HG--
extra : rebase_source : 7a19b04f9df52ff58f9837d9d45be54fd3190ec9
2018-02-15 11:24:44 +08:00
Cosmin Sabou
bfd2fc78a3 Backed out changeset a2147499c437 (bug 1434706) for frequent mochitest browser chrome failures on browser_contextmenu_sendpage.js 2018-02-23 22:15:08 +02:00
Edouard Oger
6e2641372c Bug 1434706 - Add identity.fxaccounts.enabled pref to disable Sync and FxA. r=markh
MozReview-Commit-ID: 4UuppJyOi5s

--HG--
extra : rebase_source : d5f7b31627424b652147674a520ae75571203994
2018-02-15 11:24:44 +08:00
shindli
f2126298f5 Backed out changeset 6e3058771f18 (bug 1434706) for bc6 and X failures in browser/base/content/test/general/browser_contextmenu_input.js and services/fxaccounts/tests/xpcshell/test_accounts.js respectively on a CLOSED TREE 2018-02-23 10:25:56 +02:00
Edouard Oger
1baec66b3d Bug 1434706 - Add identity.fxaccounts.enabled pref to disable Sync and FxA. r=markh
MozReview-Commit-ID: 4UuppJyOi5s

--HG--
extra : rebase_source : 328093c9985c29effb1380e012c35f6da6ee667a
2018-02-15 11:24:44 +08:00
Mark Hammond
9c04fa2a49 Bug 1437242 - don't drag browser-sync.js into places.xul. r=tcsc
MozReview-Commit-ID: FZTdHOUMMOK

--HG--
extra : rebase_source : 7740cd64da18f414fd07e356f2734b1ca7be1551
2018-02-13 10:47:55 +11:00
Edouard Oger
626be20bbb Bug 1427674 - Unify FxA content server URL preferences. r=markh,tcsc
MozReview-Commit-ID: 3zhHGAzQr0R

--HG--
extra : rebase_source : 013457dfb434c92134d2f244b389d21620c83595
2018-01-30 13:21:35 -05:00
Kris Maglione
918ed6c474 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl

--HG--
extra : source : 12fc4dee861c812fd2bd032c63ef17af61800c70
extra : intermediate-source : 34c999fa006bffe8705cf50c54708aa21a962e62
extra : histedit_source : b2be2c5e5d226e6c347312456a6ae339c1e634b0
2018-01-29 15:20:18 -08:00
Cosmin Sabou
9a65a40178 Backed out 3 changesets (bug 1431533) for Android mochitest failures on testEventDispatcher on a CLOSED TREE
Backed out changeset a1eca62826a1 (bug 1431533)
Backed out changeset 34c999fa006b (bug 1431533)
Backed out changeset e2674287e57f (bug 1431533)
2018-01-30 07:17:48 +02:00
Kris Maglione
6476f95b13 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl

--HG--
extra : source : 12fc4dee861c812fd2bd032c63ef17af61800c70
2018-01-29 15:20:18 -08:00
Brindusan Cristian
af8879d1eb Backed out 2 changesets (bug 1431533) for ESlint failures on a CLOSED TREE
Backed out changeset 6e56f4c8843e (bug 1431533)
Backed out changeset 12fc4dee861c (bug 1431533)
2018-01-30 02:32:43 +02:00
Kris Maglione
c276bb9375 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl

--HG--
extra : rebase_source : c004a023389f1f6bf3d2f3efe93c13d423b23ccd
2018-01-29 15:20:18 -08:00
Thom Chiovoloni
35250bb05a Bug 1384856 - Fix sync menu items showing incorrect state on mac r=eoger
MozReview-Commit-ID: Ipu7HXeZGZG

--HG--
extra : rebase_source : e322f0b633f77bcb0fa785f532414e25d3604ab7
2018-01-17 13:09:22 -05:00
Thom Chiovoloni
54402dd377 Bug 1425690 - Replace getCharPref with lazy pref getters in browser-sync.js r=eoger
MozReview-Commit-ID: 51qDl9P3wXX

--HG--
extra : rebase_source : b3babb14f236b81080f08c10d931c0ef7d6d3b5f
2017-12-16 13:25:19 -06:00
Edouard Oger
7fabe73930 Bug 1422106 - Show broken heart when unverified in synced tabs sidebar/panel. r=markh
MozReview-Commit-ID: BDTdmcIOHmn

--HG--
extra : rebase_source : c2b534461715f8db1e6cb8bc7910311cc4ff6611
2017-11-30 16:01:40 -05:00
Dorel Luca
171c255f60 Backed out changeset 1ca98c1618a6 (bug 1422106) for failing browser/components/customizableui/test/browser_synced_tabs_menu.js r=backout on a CLOSED TREE 2017-12-02 02:37:38 +02:00
Edouard Oger
afb8b81041 Bug 1422106 - Show broken heart when unverified in synced tabs sidebar/panel. r=markh
MozReview-Commit-ID: BDTdmcIOHmn

--HG--
extra : rebase_source : 747637f3746356e3da208acc41a3629bd2597e2e
2017-11-30 16:01:40 -05:00
Dorel Luca
e07748b33c Backed out changeset 3aff028846c0 (bug 1422106) for failing syncedtabs/test/xpcshell/test_SyncedTabsDeckComponent.js and browser-chrome's browser/components/customizableui/test/browser_synced_tabs_menu.js r=backout on a CLOSED TREE
--HG--
extra : rebase_source : ec98a160ef77f13abc4b067f8836e290e3b11e21
2017-12-02 00:33:41 +02:00
Edouard Oger
2a41681065 Bug 1422106 - Show broken heart when unverified in synced tabs sidebar/panel. r=markh
MozReview-Commit-ID: BDTdmcIOHmn

--HG--
extra : rebase_source : b1471e1ef0163b2d3b137852d285146f5a23f1fa
2017-11-30 16:01:40 -05:00