forked from mirrors/gecko-dev
01dda8797e
This prevents synchronous reflows when opening subviews. This also removes a superfluous invocation of the workaround while the panel is still hidden. MozReview-Commit-ID: DohLjntVaPU --HG-- extra : rebase_source : 8cd1b86168aee23d4e75556c2b11baf2c8dd0b9c
105 lines
3.6 KiB
JavaScript
105 lines
3.6 KiB
JavaScript
"use strict";
|
|
/* global PanelUI */
|
|
|
|
/**
|
|
* WHOA THERE: We should never be adding new things to
|
|
* EXPECTED_APPMENU_OPEN_REFLOWS. This is a whitelist that should slowly go
|
|
* away as we improve the performance of the front-end. Instead of adding more
|
|
* reflows to the whitelist, you should be modifying your code to avoid the reflow.
|
|
*
|
|
* See https://developer.mozilla.org/en-US/Firefox/Performance_best_practices_for_Firefox_fe_engineers
|
|
* for tips on how to do that.
|
|
*/
|
|
const EXPECTED_APPMENU_OPEN_REFLOWS = [
|
|
{
|
|
stack: [
|
|
"openPopup@chrome://global/content/bindings/popup.xml",
|
|
"openPopup/this._openPopupPromise<@resource:///modules/PanelMultiView.jsm",
|
|
],
|
|
},
|
|
|
|
{
|
|
stack: [
|
|
"get_alignmentPosition@chrome://global/content/bindings/popup.xml",
|
|
"adjustArrowPosition@chrome://global/content/bindings/popup.xml",
|
|
"onxblpopuppositioned@chrome://global/content/bindings/popup.xml",
|
|
],
|
|
},
|
|
|
|
{
|
|
stack: [
|
|
"get_alignmentPosition@chrome://global/content/bindings/popup.xml",
|
|
"_calculateMaxHeight@resource:///modules/PanelMultiView.jsm",
|
|
"handleEvent@resource:///modules/PanelMultiView.jsm",
|
|
],
|
|
},
|
|
|
|
{
|
|
stack: [
|
|
"_calculateMaxHeight@resource:///modules/PanelMultiView.jsm",
|
|
"handleEvent@resource:///modules/PanelMultiView.jsm",
|
|
],
|
|
|
|
maxCount: 6, // This number should only ever go down - never up.
|
|
},
|
|
];
|
|
|
|
add_task(async function() {
|
|
await ensureNoPreloadedBrowser();
|
|
|
|
// First, open the appmenu.
|
|
await withReflowObserver(async function() {
|
|
let popupShown =
|
|
BrowserTestUtils.waitForEvent(PanelUI.panel, "popupshown");
|
|
await PanelUI.show();
|
|
await popupShown;
|
|
}, EXPECTED_APPMENU_OPEN_REFLOWS);
|
|
|
|
// Now open a series of subviews, and then close the appmenu. We
|
|
// should not reflow during any of this.
|
|
await withReflowObserver(async function() {
|
|
// This recursive function will take the current main or subview,
|
|
// find all of the buttons that navigate to subviews inside it,
|
|
// and click each one individually. Upon entering the new view,
|
|
// we recurse. When the subviews within a view have been
|
|
// exhausted, we go back up a level.
|
|
async function openSubViewsRecursively(currentView) {
|
|
let navButtons = Array.from(currentView.querySelectorAll(".subviewbutton-nav"));
|
|
if (!navButtons) {
|
|
return;
|
|
}
|
|
|
|
for (let button of navButtons) {
|
|
info("Click " + button.id);
|
|
let promiseViewShown = BrowserTestUtils.waitForEvent(PanelUI.panel,
|
|
"ViewShown");
|
|
button.click();
|
|
let viewShownEvent = await promiseViewShown;
|
|
|
|
// Workaround until bug 1363756 is fixed, then this can be removed.
|
|
let container = PanelUI.multiView.querySelector(".panel-viewcontainer");
|
|
await BrowserTestUtils.waitForCondition(() => {
|
|
return !container.hasAttribute("width");
|
|
});
|
|
|
|
info("Shown " + viewShownEvent.originalTarget.id);
|
|
await openSubViewsRecursively(viewShownEvent.originalTarget);
|
|
promiseViewShown = BrowserTestUtils.waitForEvent(currentView,
|
|
"ViewShown");
|
|
PanelUI.multiView.goBack();
|
|
await promiseViewShown;
|
|
|
|
// Workaround until bug 1363756 is fixed, then this can be removed.
|
|
await BrowserTestUtils.waitForCondition(() => {
|
|
return !container.hasAttribute("width");
|
|
});
|
|
}
|
|
}
|
|
|
|
await openSubViewsRecursively(PanelUI.mainView);
|
|
|
|
let hidden = BrowserTestUtils.waitForEvent(PanelUI.panel, "popuphidden");
|
|
PanelUI.hide();
|
|
await hidden;
|
|
}, []);
|
|
});
|