fune/dom/promise/PromiseWindowProxy.cpp
Andrew McCreight 9cdfde0a5e Bug 1409115 - Fix leaks by adding promise window proxy. r=bkelly
The service worker job queue can get stuck sometimes, so we don't want
the per-process service worker data structure to hold strong
references to content. Instead, I add a proxy that is only a weak
reference. The wrinkle is that we need to keep the promise alive as
long as the job and the window are otherwise alive. I solve this by
putting a cycle collected reference to the promise on the window
itself.

MozReview-Commit-ID: GbmCY4ZIQWk

--HG--
extra : rebase_source : 363ea865fd51bb44f3e727cd3469e316370e7cbc
2017-12-06 16:48:18 -08:00

54 lines
1.5 KiB
C++

/* -*- Mode: C++; tab-width: 8; indent-tabs-mode: nil; c-basic-offset: 2 -*- */
/* vim: set ts=8 sts=2 et sw=2 tw=80: */
/* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this file,
* You can obtain one at http://mozilla.org/MPL/2.0/. */
#include "mozilla/dom/PromiseWindowProxy.h"
#include "nsGlobalWindowInner.h"
#include "nsPIDOMWindow.h"
#include "nsIWeakReference.h"
#include "mozilla/dom/Promise.h"
using namespace mozilla;
using namespace dom;
PromiseWindowProxy::PromiseWindowProxy(nsPIDOMWindowInner* aWindow, Promise* aPromise)
: mPromise(aPromise)
{
MOZ_ASSERT(NS_IsMainThread());
MOZ_DIAGNOSTIC_ASSERT(aWindow && aPromise);
auto* window = nsGlobalWindowInner::Cast(aWindow);
window->GetWeakReference(getter_AddRefs(mWindow));
window->AddPendingPromise(aPromise);
}
PromiseWindowProxy::~PromiseWindowProxy()
{
MOZ_ASSERT(NS_IsMainThread());
nsCOMPtr<nsPIDOMWindowInner> window = GetWindow();
if (window && mPromise) {
nsGlobalWindowInner::Cast(window)->RemovePendingPromise(mPromise);
}
}
RefPtr<Promise>
PromiseWindowProxy::Get() const
{
MOZ_ASSERT(NS_IsMainThread());
if (!mPromise) {
return nullptr;
}
RefPtr<Promise> promise(mPromise);
return promise;
}
nsCOMPtr<nsPIDOMWindowInner>
PromiseWindowProxy::GetWindow() const
{
MOZ_ASSERT(NS_IsMainThread());
nsCOMPtr<nsPIDOMWindowInner> window = do_QueryReferent(mWindow);
return window;
}