fune/netwerk/protocol/websocket/WebSocketConnectionChild.h
Nika Layzell 7ced96212e Bug 1778211 - Reject xpidl CDATA containing 'virtual', r=xpcom-reviewers,necko-reviewers,mccr8,dragana
We'll probably want to do something more accurate in the future with a
custom clang static analysis pass which validates that XPIDL interfaces
have the expected vtable and struct layout, however doing so would be
more involved than the string matching done in this patch.

In addition to checking for extra virtual methods, we'll likely also
want to check for data members on interfaces, and reject them unless the
class is marked as `[builtinclass]` in addition to some other attribute
which we'll need to add to prevent them from being implemented in Rust
(as c++ data members will not be reflected by the rust macro).

There were 2 instances of a comment which contained the word 'virtual'
within a CDATA block. These comments were moved out of the CDATA block
to avoid triggering the error.

Differential Revision: https://phabricator.services.mozilla.com/D151068
2022-07-06 14:53:06 +00:00

54 lines
1.9 KiB
C++

/* -*- Mode: C++; tab-width: 8; indent-tabs-mode: nil; c-basic-offset: 2 -*- */
/* vim: set sw=2 ts=8 et ft=cpp : */
/* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this file,
* You can obtain one at http://mozilla.org/MPL/2.0/. */
#ifndef mozilla_net_WebSocketConnectionChild_h
#define mozilla_net_WebSocketConnectionChild_h
#include "mozilla/net/PWebSocketConnectionChild.h"
#include "mozilla/net/WebSocketConnectionListener.h"
#include "nsIHttpChannelInternal.h"
namespace mozilla {
namespace net {
class WebSocketConnection;
// WebSocketConnectionChild only lives in socket process and uses
// WebSocketConnection to send/read data from socket. Only IPDL holds a strong
// reference to WebSocketConnectionChild, so the life time of
// WebSocketConnectionChild is bound to the IPC actor.
class WebSocketConnectionChild final : public PWebSocketConnectionChild,
public nsIHttpUpgradeListener,
public WebSocketConnectionListener {
public:
NS_DECL_THREADSAFE_ISUPPORTS
NS_DECL_NSIHTTPUPGRADELISTENER
WebSocketConnectionChild();
void Init(uint32_t aListenerId);
mozilla::ipc::IPCResult RecvWriteOutputData(nsTArray<uint8_t>&& aData);
mozilla::ipc::IPCResult RecvStartReading();
mozilla::ipc::IPCResult RecvDrainSocketData();
mozilla::ipc::IPCResult Recv__delete__() override;
void ActorDestroy(ActorDestroyReason aWhy) override;
void OnError(nsresult aStatus) override;
void OnTCPClosed() override;
nsresult OnDataReceived(uint8_t* aData, uint32_t aCount) override;
private:
virtual ~WebSocketConnectionChild();
RefPtr<WebSocketConnection> mConnection;
nsCOMPtr<nsIEventTarget> mSocketThread;
};
} // namespace net
} // namespace mozilla
#endif // mozilla_net_WebSocketConnectionChild_h