nagai/fune
3
0
Fork 0
forked from mirrors/gecko-dev
Code Pull requests Activity
fune/browser/components
History
Drew Willcoxon 07c118b07a Bug 1531295 - Ignore the SelectedOneOffButtonChanged event when the popup is closed. r=dao 
The SelectedOneOffButtonChanged event can fire when the popup is closed, so we should ignore it then. browser_switchTab_decodeuri.js hits this, as Mark says in the bug. The stack is:

  _on_SelectedOneOffButtonChanged@resource:///modules/UrlbarView.jsm:569:131
  handleEvent@resource:///modules/UrlbarView.jsm:298:23
  dispatchEvent@chrome://browser/content/search/search-one-offs.js:147:20
  set selectedButton@chrome://browser/content/search/search-one-offs.js:306:10
  _on_popuphidden/<@chrome://browser/content/search/search-one-offs.js:1281:7

Alternatively we could modify the selectedButton setter in the one offs not to fire the event when the popup is closed. However, theoretically someone could be interested in listening for the selected button change even then, so I think it's better to modify the listener here.

Differential Revision: https://phabricator.services.mozilla.com/D22204

--HG--
extra : moz-landing-system : lando
2019-03-06 08:25:44 +00:00
..
about Bug 1529088 - Hold the HTML-based about:config to Nightly until we get Product sign-off. r=florian,paolo 2019-02-27 21:54:57 +00:00
aboutconfig Bug 1524779 - Use a separate button to show all preferences. r=mconley,flod 2019-02-18 13:30:31 +00:00
attribution Bug 1514594: Part 3 - Change ChromeUtils.import API. 2019-01-17 10:18:31 -08:00
build Backed out 79 changesets (bug 1524687, bug 1524688) for crashes on mozilla::dom::ScreenOrientation::ScreenOrientation(nsPIDOMWindowInner *,nsScreen *). CLOSED TREE 2019-02-14 11:50:23 +02:00
contextualidentity Bug 1514594: Part 3 - Change ChromeUtils.import API. 2019-01-17 10:18:31 -08:00
controlcenter/content Bug 1513343 - Remove textarea binding and replace usages with html:textarea. r=bgrins,dao 2019-03-05 11:41:42 +00:00
customizableui Bug 1530801 - Replace waitForCondition in browser_947914_button_addons.js withTestUtils.waitForCondition r=johannh 2019-03-04 21:36:02 +00:00
dirprovider Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format 2018-11-30 11:46:48 +01:00
downloads Bug 827976 - Downloads Manager doesn't need a reference to the hidden window. r=mak 2019-03-04 18:52:55 +00:00
enterprisepolicies Bug 1522856 - Add an "import" option to the file menu to make browser migration discoverable. r=MattN,felipe 2019-03-04 15:29:03 -08:00
extensions Bug 1529394 fix tests for pref'ing on incognito not_allowed r=rpl 2019-03-05 14:17:36 +00:00
library
migration Bug 1522856 - Add an "import" option to the file menu to make browser migration discoverable. r=MattN,felipe 2019-03-04 15:29:03 -08:00
newtab Bug 827976 - Downloads Manager doesn't need a reference to the hidden window. r=mak 2019-03-04 18:52:55 +00:00
originattributes Bug 1507110 - Allow hijacking localhost only if network.proxy.allow_hijacking_localhost is set r=Gijs,mayhemer,mkaply,jmaher 2019-02-19 21:53:22 +00:00
payments Backed out 79 changesets (bug 1524687, bug 1524688) for crashes on mozilla::dom::ScreenOrientation::ScreenOrientation(nsPIDOMWindowInner *,nsScreen *). CLOSED TREE 2019-02-14 11:50:23 +02:00
places Bug 1519953, replace calls to retrieve boxobject position and size with getBoundingClientRect, r=gijs 2019-03-01 12:26:45 -05:00
pocket Bug 1528751 - Add a custom eslint rule to check "consistent" if bracing. r=Standard8 2019-02-28 08:39:33 +00:00
preferences Bug 1532052 - Fix test that will fail when default values change. r=johannh 2019-03-05 15:01:23 +00:00
privatebrowsing Backed out changeset 40ddf7d53eaa (bug 1517528) for flake8 failures 2019-03-01 11:42:02 +01:00
protocolhandler Backed out 79 changesets (bug 1524687, bug 1524688) for crashes on mozilla::dom::ScreenOrientation::ScreenOrientation(nsPIDOMWindowInner *,nsScreen *). CLOSED TREE 2019-02-14 11:50:23 +02:00
resistfingerprinting Bug 1407366 - Part 5: Reset the Zoom in browser_bug1369357_site_specific_zoom_level.js r=johann 2019-02-06 12:59:26 -06:00
safebrowsing/content/test Bug 1514594: Part 3 - Change ChromeUtils.import API. 2019-01-17 10:18:31 -08:00
search Bug 1531751 - Correct search parameter for mapy.cz searchplugin used in Czech (cs) version of Firefox and Firefox for Android r=mkaply 2019-03-01 17:09:58 +00:00
sessionstore Bug 827976 - Use requestIdleCallback from Timer.jsm instead of from the hidden window. r=mconley 2019-03-04 18:53:22 +00:00
shell Bug 1528760 - Fix issues in the setDesktopBackground dialog following the ChromeUtils.import global changes. r=johannh 2019-02-18 15:53:45 +00:00
syncedtabs Bug 1518283 - prohibit blank lines at the beginning and end of blocks (eslint padded-blocks) r=mossop,Standard8 2019-01-30 17:26:25 +00:00
tests Bug 827976 - Test that the hidden window is not loaded before first paint. r=florian 2019-03-04 18:53:38 +00:00
touchbar Bug 1522039 - Changes default Touch Bar button set and replaces icon on Close Window button. r=bwinton,mikedeboer 2019-02-21 19:23:33 +00:00
translation Bug 1528751 - Add a custom eslint rule to check "consistent" if bracing. r=Standard8 2019-02-28 08:39:33 +00:00
uitour Bug 1530405 - Port the UITour tests to QuantumBar. r=MattN,mak. 2019-02-27 16:43:56 +00:00
urlbar Bug 1531295 - Ignore the SelectedOneOffButtonChanged event when the popup is closed. r=dao 2019-03-06 08:25:44 +00:00
.eslintrc.js
BrowserComponents.manifest Backed out 79 changesets (bug 1524687, bug 1524688) for crashes on mozilla::dom::ScreenOrientation::ScreenOrientation(nsPIDOMWindowInner *,nsScreen *). CLOSED TREE 2019-02-14 11:50:23 +02:00
BrowserContentHandler.jsm Bug 1529582 prevent addon-set external home pages in private browsing without permission r=rpl,Gijs 2019-02-28 18:12:46 +00:00
BrowserGlue.jsm Bug 827976 - Use an existing window for media telemetry. r=Gijs 2019-03-04 18:53:29 +00:00
components.conf Backed out 79 changesets (bug 1524687, bug 1524688) for crashes on mozilla::dom::ScreenOrientation::ScreenOrientation(nsPIDOMWindowInner *,nsScreen *). CLOSED TREE 2019-02-14 11:50:23 +02:00
distribution.js Bug 1514594: Part 3 - Change ChromeUtils.import API. 2019-01-17 10:18:31 -08:00
moz.build Bug 1529088 - Hold the HTML-based about:config to Nightly until we get Product sign-off. r=florian,paolo 2019-02-27 21:54:57 +00:00
nsIBrowserHandler.idl