fune/browser/base/content/test/sidebar/browser_sidebar_move.js
Emilio Cobos Álvarez 097eb3703e Bug 1820534 - Move front-end to modern flexbox. r=Gijs,dao,settings-reviewers,credential-management-reviewers,sgalich,devtools-reviewers,nchevobbe
Done mostly automatically via find/replace following the conversions
specified here:

  https://groups.google.com/a/mozilla.org/g/firefox-dev/c/9sGpF1TNbLk/m/QpU3oTUuAgAJ

For the most part I think the "flex: N N" usage could be simplified to
just "flex: N", but I wanted to preserve behavior (-moz-box-flex sets
both flex-grow and flex-shrink).

I changed legacy layout to also look at the order property rather than
-moz-box-ordinal-group because it made splitters and treecols easier (we
don't need to deal with both orders).

Differential Revision: https://phabricator.services.mozilla.com/D171715
2023-03-08 16:13:57 +00:00

72 lines
1.8 KiB
JavaScript

registerCleanupFunction(() => {
Services.prefs.clearUserPref("sidebar.position_start");
SidebarUI.hide();
});
const EXPECTED_START_ORDINALS = [
["sidebar-box", 1],
["sidebar-splitter", 2],
["appcontent", 3],
];
const EXPECTED_END_ORDINALS = [
["sidebar-box", 3],
["sidebar-splitter", 2],
["appcontent", 1],
];
function getBrowserChildrenWithOrdinals() {
let browser = document.getElementById("browser");
return [...browser.children].map(node => {
return [node.id, node.style.order];
});
}
add_task(async function() {
await SidebarUI.show("viewBookmarksSidebar");
SidebarUI.showSwitcherPanel();
let reversePositionButton = document.getElementById(
"sidebar-reverse-position"
);
let originalLabel = reversePositionButton.getAttribute("label");
let box = document.getElementById("sidebar-box");
// Default (position: left)
Assert.deepEqual(
getBrowserChildrenWithOrdinals(),
EXPECTED_START_ORDINALS,
"Correct ordinal (start)"
);
ok(!box.hasAttribute("positionend"), "Positioned start");
// Moved to right
SidebarUI.reversePosition();
SidebarUI.showSwitcherPanel();
Assert.deepEqual(
getBrowserChildrenWithOrdinals(),
EXPECTED_END_ORDINALS,
"Correct ordinal (end)"
);
isnot(
reversePositionButton.getAttribute("label"),
originalLabel,
"Label changed"
);
ok(box.hasAttribute("positionend"), "Positioned end");
// Moved to back to left
SidebarUI.reversePosition();
SidebarUI.showSwitcherPanel();
Assert.deepEqual(
getBrowserChildrenWithOrdinals(),
EXPECTED_START_ORDINALS,
"Correct ordinal (start)"
);
ok(!box.hasAttribute("positionend"), "Positioned start");
is(
reversePositionButton.getAttribute("label"),
originalLabel,
"Label is back to normal"
);
});