forked from mirrors/gecko-dev
		
	 7cb2f9a2dc
			
		
	
	
		7cb2f9a2dc
		
	
	
	
	
		
			
			Previously, `string-cache` defined:
*  An string-like `Atom` type,
* An `atom!("foo")` macro that expands to a value of that type, for a set of strings known at compile-time,
* A `struct Namespace(Atom);` type
* A `ns!(html)` macro that maps known prefixed to `Namespace` values with the corresponding namespace URL.
Adding a string to the static set required making a change to the `string-cache` crate.
With 0.3, the `Atom` type is now generic, with a type parameter that provides a set of static strings. We can have multiple such sets, defined in different crates. The `string_cache_codegen` crate, to be used in build scripts, generates code that defines such a set, a new atom type (a type alias for `Atom<_>` with the type parameter set), and an `atom!`-like macro.
The html5ever repository has a new `html5ever_atoms` crate that defines three such types: `Prefix`, `Namespace`, and `LocalName` (with respective `namespace_prefix!`, `namespace_url!`, and `local_name!` macros). It also defines the `ns!` macro like before.
This repository has a new `servo_atoms` crate in `components/atoms` that, for now, defines a single `Atom` type (and `atom!`) macro. (`servo_atoms::Atom` is defined as something like `type Atom = string_cache::Atom<ServoStaticStringSet>;`, so overall there’s now two types named `Atom`.)
In this PR, `servo_atoms::Atom` is used for everything else that was `string_cache::Atom` before. But more atom types can be defined as needed. Two reasons to do this are to auto-generate the set of static strings (I’m planning to do this for CSS property names, which is the motivation for this change), or to have the type system help us avoid mix up unrelated things (this is why we had a `Namespace` type ever before this change).
Introducing new types helped me find a bug: when creating a new attribute `dom::Element::set_style_attr`, would pass `Some(atom!("style"))` instead of `None` (now `Option<html5ever_atoms::Prefix>` instead of `Option<string_cache::Atom>`) to the `prefix` argument of `Attr::new`. I suppose the author of that code confused it with the `local_name` argument.
---
Note that Stylo is not affected by any of this. The `gecko_string_cache` module is unchanged, with a single `Atom` type. The `style` crate conditionally compiles `Prefix` and `LocalName` re-exports for that are both `gecko_string_cache::Atom` on stylo.
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).
<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____
<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
Source-Repo: https://github.com/servo/servo
Source-Revision: 5b4cc9568dbd5c15e5d2fbc62719172f11566ffa
		
	
			
		
			
				
	
	
		
			252 lines
		
	
	
	
		
			12 KiB
		
	
	
	
		
			Rust
		
	
	
	
	
	
			
		
		
	
	
			252 lines
		
	
	
	
		
			12 KiB
		
	
	
	
		
			Rust
		
	
	
	
	
	
| /* This Source Code Form is subject to the terms of the Mozilla Public
 | |
|  * License, v. 2.0. If a copy of the MPL was not distributed with this
 | |
|  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
 | |
| 
 | |
| use dom::attr::Attr;
 | |
| use dom::bindings::inheritance::Castable;
 | |
| use dom::bindings::inheritance::ElementTypeId;
 | |
| use dom::bindings::inheritance::HTMLElementTypeId;
 | |
| use dom::bindings::inheritance::NodeTypeId;
 | |
| use dom::bindings::inheritance::SVGElementTypeId;
 | |
| use dom::bindings::inheritance::SVGGraphicsElementTypeId;
 | |
| use dom::bindings::str::DOMString;
 | |
| use dom::document::Document;
 | |
| use dom::element::{AttributeMutation, Element};
 | |
| use dom::event::Event;
 | |
| use dom::htmlanchorelement::HTMLAnchorElement;
 | |
| use dom::htmlappletelement::HTMLAppletElement;
 | |
| use dom::htmlareaelement::HTMLAreaElement;
 | |
| use dom::htmlbaseelement::HTMLBaseElement;
 | |
| use dom::htmlbodyelement::HTMLBodyElement;
 | |
| use dom::htmlbuttonelement::HTMLButtonElement;
 | |
| use dom::htmlcanvaselement::HTMLCanvasElement;
 | |
| use dom::htmldetailselement::HTMLDetailsElement;
 | |
| use dom::htmlelement::HTMLElement;
 | |
| use dom::htmlfieldsetelement::HTMLFieldSetElement;
 | |
| use dom::htmlfontelement::HTMLFontElement;
 | |
| use dom::htmlformelement::HTMLFormElement;
 | |
| use dom::htmlheadelement::HTMLHeadElement;
 | |
| use dom::htmlhrelement::HTMLHRElement;
 | |
| use dom::htmliframeelement::HTMLIFrameElement;
 | |
| use dom::htmlimageelement::HTMLImageElement;
 | |
| use dom::htmlinputelement::HTMLInputElement;
 | |
| use dom::htmllabelelement::HTMLLabelElement;
 | |
| use dom::htmllielement::HTMLLIElement;
 | |
| use dom::htmllinkelement::HTMLLinkElement;
 | |
| use dom::htmlmediaelement::HTMLMediaElement;
 | |
| use dom::htmlmetaelement::HTMLMetaElement;
 | |
| use dom::htmlobjectelement::HTMLObjectElement;
 | |
| use dom::htmloptgroupelement::HTMLOptGroupElement;
 | |
| use dom::htmloptionelement::HTMLOptionElement;
 | |
| use dom::htmlscriptelement::HTMLScriptElement;
 | |
| use dom::htmlselectelement::HTMLSelectElement;
 | |
| use dom::htmlstyleelement::HTMLStyleElement;
 | |
| use dom::htmltablecellelement::HTMLTableCellElement;
 | |
| use dom::htmltableelement::HTMLTableElement;
 | |
| use dom::htmltablerowelement::HTMLTableRowElement;
 | |
| use dom::htmltablesectionelement::HTMLTableSectionElement;
 | |
| use dom::htmltemplateelement::HTMLTemplateElement;
 | |
| use dom::htmltextareaelement::HTMLTextAreaElement;
 | |
| use dom::htmltitleelement::HTMLTitleElement;
 | |
| use dom::node::{ChildrenMutation, CloneChildrenFlag, Node, UnbindContext};
 | |
| use dom::svgsvgelement::SVGSVGElement;
 | |
| use html5ever_atoms::LocalName;
 | |
| use style::attr::AttrValue;
 | |
| 
 | |
| /// Trait to allow DOM nodes to opt-in to overriding (or adding to) common
 | |
| /// behaviours. Replicates the effect of C++ virtual methods.
 | |
| pub trait VirtualMethods {
 | |
|     /// Returns self as the superclass of the implementation for this trait,
 | |
|     /// if any.
 | |
|     fn super_type(&self) -> Option<&VirtualMethods>;
 | |
| 
 | |
|     /// Called when attributes of a node are mutated.
 | |
|     /// https://dom.spec.whatwg.org/#attribute-is-set
 | |
|     /// https://dom.spec.whatwg.org/#attribute-is-removed
 | |
|     fn attribute_mutated(&self, attr: &Attr, mutation: AttributeMutation) {
 | |
|         if let Some(s) = self.super_type() {
 | |
|             s.attribute_mutated(attr, mutation);
 | |
|         }
 | |
|     }
 | |
| 
 | |
|     /// Returns the right AttrValue variant for the attribute with name `name`
 | |
|     /// on this element.
 | |
|     fn parse_plain_attribute(&self, name: &LocalName, value: DOMString) -> AttrValue {
 | |
|         match self.super_type() {
 | |
|             Some(ref s) => s.parse_plain_attribute(name, value),
 | |
|             _ => AttrValue::String(value.into()),
 | |
|         }
 | |
|     }
 | |
| 
 | |
|     /// Called when a Node is appended to a tree, where 'tree_in_doc' indicates
 | |
|     /// whether the tree is part of a Document.
 | |
|     fn bind_to_tree(&self, tree_in_doc: bool) {
 | |
|         if let Some(ref s) = self.super_type() {
 | |
|             s.bind_to_tree(tree_in_doc);
 | |
|         }
 | |
|     }
 | |
| 
 | |
|     /// Called when a Node is removed from a tree, where 'tree_in_doc'
 | |
|     /// indicates whether the tree is part of a Document.
 | |
|     /// Implements removing steps:
 | |
|     /// https://dom.spec.whatwg.org/#concept-node-remove-ext
 | |
|     fn unbind_from_tree(&self, context: &UnbindContext) {
 | |
|         if let Some(ref s) = self.super_type() {
 | |
|             s.unbind_from_tree(context);
 | |
|         }
 | |
|     }
 | |
| 
 | |
|     /// Called on the parent when its children are changed.
 | |
|     fn children_changed(&self, mutation: &ChildrenMutation) {
 | |
|         if let Some(ref s) = self.super_type() {
 | |
|             s.children_changed(mutation);
 | |
|         }
 | |
|     }
 | |
| 
 | |
|     /// Called during event dispatch after the bubbling phase completes.
 | |
|     fn handle_event(&self, event: &Event) {
 | |
|         if let Some(s) = self.super_type() {
 | |
|             s.handle_event(event);
 | |
|         }
 | |
|     }
 | |
| 
 | |
|     /// https://dom.spec.whatwg.org/#concept-node-adopt-ext
 | |
|     fn adopting_steps(&self, old_doc: &Document) {
 | |
|         if let Some(ref s) = self.super_type() {
 | |
|             s.adopting_steps(old_doc);
 | |
|         }
 | |
|     }
 | |
| 
 | |
|     /// https://dom.spec.whatwg.org/#concept-node-clone-ext
 | |
|     fn cloning_steps(&self, copy: &Node, maybe_doc: Option<&Document>,
 | |
|                      clone_children: CloneChildrenFlag) {
 | |
|         if let Some(ref s) = self.super_type() {
 | |
|             s.cloning_steps(copy, maybe_doc, clone_children);
 | |
|         }
 | |
|     }
 | |
| }
 | |
| 
 | |
| /// Obtain a VirtualMethods instance for a given Node-derived object. Any
 | |
| /// method call on the trait object will invoke the corresponding method on the
 | |
| /// concrete type, propagating up the parent hierarchy unless otherwise
 | |
| /// interrupted.
 | |
| pub fn vtable_for(node: &Node) -> &VirtualMethods {
 | |
|     match node.type_id() {
 | |
|         NodeTypeId::Element(ElementTypeId::HTMLElement(HTMLElementTypeId::HTMLAnchorElement)) => {
 | |
|             node.downcast::<HTMLAnchorElement>().unwrap() as &VirtualMethods
 | |
|         }
 | |
|         NodeTypeId::Element(ElementTypeId::HTMLElement(HTMLElementTypeId::HTMLAppletElement)) => {
 | |
|             node.downcast::<HTMLAppletElement>().unwrap() as &VirtualMethods
 | |
|         }
 | |
|         NodeTypeId::Element(ElementTypeId::HTMLElement(HTMLElementTypeId::HTMLAreaElement)) => {
 | |
|             node.downcast::<HTMLAreaElement>().unwrap() as &VirtualMethods
 | |
|         }
 | |
|         NodeTypeId::Element(ElementTypeId::HTMLElement(HTMLElementTypeId::HTMLBaseElement)) => {
 | |
|             node.downcast::<HTMLBaseElement>().unwrap() as &VirtualMethods
 | |
|         }
 | |
|         NodeTypeId::Element(ElementTypeId::HTMLElement(HTMLElementTypeId::HTMLBodyElement)) => {
 | |
|             node.downcast::<HTMLBodyElement>().unwrap() as &VirtualMethods
 | |
|         }
 | |
|         NodeTypeId::Element(ElementTypeId::HTMLElement(HTMLElementTypeId::HTMLButtonElement)) => {
 | |
|             node.downcast::<HTMLButtonElement>().unwrap() as &VirtualMethods
 | |
|         }
 | |
|         NodeTypeId::Element(ElementTypeId::HTMLElement(HTMLElementTypeId::HTMLCanvasElement)) => {
 | |
|             node.downcast::<HTMLCanvasElement>().unwrap() as &VirtualMethods
 | |
|         }
 | |
|         NodeTypeId::Element(ElementTypeId::HTMLElement(HTMLElementTypeId::HTMLDetailsElement)) => {
 | |
|             node.downcast::<HTMLDetailsElement>().unwrap() as &VirtualMethods
 | |
|         }
 | |
|         NodeTypeId::Element(ElementTypeId::HTMLElement(HTMLElementTypeId::HTMLFieldSetElement)) => {
 | |
|             node.downcast::<HTMLFieldSetElement>().unwrap() as &VirtualMethods
 | |
|         }
 | |
|         NodeTypeId::Element(ElementTypeId::HTMLElement(HTMLElementTypeId::HTMLFontElement)) => {
 | |
|             node.downcast::<HTMLFontElement>().unwrap() as &VirtualMethods
 | |
|         }
 | |
|         NodeTypeId::Element(ElementTypeId::HTMLElement(HTMLElementTypeId::HTMLFormElement)) => {
 | |
|             node.downcast::<HTMLFormElement>().unwrap() as &VirtualMethods
 | |
|         }
 | |
|         NodeTypeId::Element(ElementTypeId::HTMLElement(HTMLElementTypeId::HTMLHeadElement)) => {
 | |
|             node.downcast::<HTMLHeadElement>().unwrap() as &VirtualMethods
 | |
|         }
 | |
|         NodeTypeId::Element(ElementTypeId::HTMLElement(HTMLElementTypeId::HTMLHRElement)) => {
 | |
|             node.downcast::<HTMLHRElement>().unwrap() as &VirtualMethods
 | |
|         }
 | |
|         NodeTypeId::Element(ElementTypeId::HTMLElement(HTMLElementTypeId::HTMLImageElement)) => {
 | |
|             node.downcast::<HTMLImageElement>().unwrap() as &VirtualMethods
 | |
|         }
 | |
|         NodeTypeId::Element(ElementTypeId::HTMLElement(HTMLElementTypeId::HTMLIFrameElement)) => {
 | |
|             node.downcast::<HTMLIFrameElement>().unwrap() as &VirtualMethods
 | |
|         }
 | |
|         NodeTypeId::Element(ElementTypeId::HTMLElement(HTMLElementTypeId::HTMLInputElement)) => {
 | |
|             node.downcast::<HTMLInputElement>().unwrap() as &VirtualMethods
 | |
|         }
 | |
|         NodeTypeId::Element(ElementTypeId::HTMLElement(HTMLElementTypeId::HTMLLabelElement)) => {
 | |
|             node.downcast::<HTMLLabelElement>().unwrap() as &VirtualMethods
 | |
|         }
 | |
|         NodeTypeId::Element(ElementTypeId::HTMLElement(HTMLElementTypeId::HTMLLIElement)) => {
 | |
|             node.downcast::<HTMLLIElement>().unwrap() as &VirtualMethods
 | |
|         }
 | |
|         NodeTypeId::Element(ElementTypeId::HTMLElement(HTMLElementTypeId::HTMLLinkElement)) => {
 | |
|             node.downcast::<HTMLLinkElement>().unwrap() as &VirtualMethods
 | |
|         }
 | |
|         NodeTypeId::Element(ElementTypeId::HTMLElement(HTMLElementTypeId::HTMLMediaElement(_))) => {
 | |
|             node.downcast::<HTMLMediaElement>().unwrap() as &VirtualMethods
 | |
|         }
 | |
|         NodeTypeId::Element(ElementTypeId::HTMLElement(HTMLElementTypeId::HTMLMetaElement)) => {
 | |
|             node.downcast::<HTMLMetaElement>().unwrap() as &VirtualMethods
 | |
|         }
 | |
|         NodeTypeId::Element(ElementTypeId::HTMLElement(HTMLElementTypeId::HTMLObjectElement)) => {
 | |
|             node.downcast::<HTMLObjectElement>().unwrap() as &VirtualMethods
 | |
|         }
 | |
|         NodeTypeId::Element(ElementTypeId::HTMLElement(HTMLElementTypeId::HTMLOptGroupElement)) => {
 | |
|             node.downcast::<HTMLOptGroupElement>().unwrap() as &VirtualMethods
 | |
|         }
 | |
|         NodeTypeId::Element(ElementTypeId::HTMLElement(HTMLElementTypeId::HTMLOptionElement)) => {
 | |
|             node.downcast::<HTMLOptionElement>().unwrap() as &VirtualMethods
 | |
|         }
 | |
|         NodeTypeId::Element(ElementTypeId::HTMLElement(HTMLElementTypeId::HTMLScriptElement)) => {
 | |
|             node.downcast::<HTMLScriptElement>().unwrap() as &VirtualMethods
 | |
|         }
 | |
|         NodeTypeId::Element(ElementTypeId::HTMLElement(HTMLElementTypeId::HTMLSelectElement)) => {
 | |
|             node.downcast::<HTMLSelectElement>().unwrap() as &VirtualMethods
 | |
|         }
 | |
|         NodeTypeId::Element(ElementTypeId::HTMLElement(HTMLElementTypeId::HTMLStyleElement)) => {
 | |
|             node.downcast::<HTMLStyleElement>().unwrap() as &VirtualMethods
 | |
|         }
 | |
|         NodeTypeId::Element(ElementTypeId::HTMLElement(HTMLElementTypeId::HTMLTableElement)) => {
 | |
|             node.downcast::<HTMLTableElement>().unwrap() as &VirtualMethods
 | |
|         }
 | |
|         NodeTypeId::Element(ElementTypeId::HTMLElement(HTMLElementTypeId::HTMLTableCellElement(_))) => {
 | |
|             node.downcast::<HTMLTableCellElement>().unwrap() as &VirtualMethods
 | |
|         }
 | |
|         NodeTypeId::Element(ElementTypeId::HTMLElement(HTMLElementTypeId::HTMLTableRowElement)) => {
 | |
|             node.downcast::<HTMLTableRowElement>().unwrap() as &VirtualMethods
 | |
|         }
 | |
|         NodeTypeId::Element(ElementTypeId::HTMLElement(HTMLElementTypeId::HTMLTableSectionElement)) => {
 | |
|             node.downcast::<HTMLTableSectionElement>().unwrap() as &VirtualMethods
 | |
|         }
 | |
|         NodeTypeId::Element(ElementTypeId::HTMLElement(HTMLElementTypeId::HTMLTemplateElement)) => {
 | |
|             node.downcast::<HTMLTemplateElement>().unwrap() as &VirtualMethods
 | |
|         }
 | |
|         NodeTypeId::Element(ElementTypeId::HTMLElement(HTMLElementTypeId::HTMLTextAreaElement)) => {
 | |
|             node.downcast::<HTMLTextAreaElement>().unwrap() as &VirtualMethods
 | |
|         }
 | |
|         NodeTypeId::Element(ElementTypeId::HTMLElement(HTMLElementTypeId::HTMLTitleElement)) => {
 | |
|             node.downcast::<HTMLTitleElement>().unwrap() as &VirtualMethods
 | |
|         }
 | |
|         NodeTypeId::Element(ElementTypeId::SVGElement(SVGElementTypeId::SVGGraphicsElement(
 | |
|                     SVGGraphicsElementTypeId::SVGSVGElement
 | |
|                 ))) => {
 | |
|             node.downcast::<SVGSVGElement>().unwrap() as &VirtualMethods
 | |
|         }
 | |
|         NodeTypeId::Element(ElementTypeId::Element) => {
 | |
|             node.downcast::<Element>().unwrap() as &VirtualMethods
 | |
|         }
 | |
|         NodeTypeId::Element(_) => {
 | |
|             node.downcast::<HTMLElement>().unwrap() as &VirtualMethods
 | |
|         }
 | |
|         _ => {
 | |
|             node as &VirtualMethods
 | |
|         }
 | |
|     }
 | |
| }
 |