fune/toolkit/components/passwordmgr
Neil Deakin a7d450b343 Bug 1849122, set the autofill state directly on the input and select elements rather than using windowUtils and a separate hash that can be out of sync with each other, r=credential-management-reviewers,dimi
The existing autofill state is set on the form element using nsIDOMWindowUtils::AddManuallyManagedState, but a separate map #filledStateByElement within FormAutofillHandler.sys.mjs is used to keep track of which elements are filled in. However, this relies on input events that don't fire when form elements are hidden. In addition, when a page modifies the form field value directly, the preview state can be modified but the #filledStateByElement map is not.

Instead, remove the extra map, and just use the form field's autofill state directly. The form field will take responsibility for removing the preview state when its value changes.

This behaviour applies to single field input elements and select elements.

Differential Revision: https://phabricator.services.mozilla.com/D211000
2024-05-28 23:40:00 +00:00
..
test Bug 1835983 - Update tests in toolkit/components/passwordmgr/ to work with https-first enabled r=credential-management-reviewers,issammani 2024-05-22 13:38:22 +00:00
components.conf Bug 1885449 - Move GV code shared between Android and iOS to a shared directory. r=geckoview-reviewers,frontend-codestyle-reviewers,nalexander,owlish 2024-05-16 22:08:51 +00:00
crypto-SDR.sys.mjs
CSV.sys.mjs
InsecurePasswordUtils.sys.mjs
jar.mn
LoginAutoComplete.sys.mjs Bug 1894889 - Trigger autocomplete action from the parent process r=credential-management-reviewers,geckoview-reviewers,NeilDeakin,owlish 2024-05-21 19:06:35 +00:00
LoginCSVImport.sys.mjs
LoginExport.sys.mjs
LoginFormFactory.sys.mjs
LoginHelper.sys.mjs Bug 1886064, make usage of label and comment fields in autofill items more consistent, r=credential-management-reviewers,geckoview-reviewers,reusable-components-reviewers,owlish,sgalich,tgiles 2024-05-14 15:37:32 +00:00
LoginInfo.sys.mjs
LoginManager.shared.mjs
LoginManager.sys.mjs
LoginManagerAuthPrompter.sys.mjs Bug 1887712 - remove the unused prompts.modalType.httpAuth pref, r=pbz,necko-reviewers,credential-management-reviewers,sgalich,issammani,valentin 2024-04-08 13:46:38 +00:00
LoginManagerChild.sys.mjs Bug 1849122, set the autofill state directly on the input and select elements rather than using windowUtils and a separate hash that can be out of sync with each other, r=credential-management-reviewers,dimi 2024-05-28 23:40:00 +00:00
LoginManagerContextMenu.sys.mjs
LoginManagerParent.sys.mjs Bug 1894889 - Trigger autocomplete action from the parent process r=credential-management-reviewers,geckoview-reviewers,NeilDeakin,owlish 2024-05-21 19:06:35 +00:00
LoginManagerPrompter.sys.mjs
LoginManagerTelemetry.sys.mjs
LoginRecipes.sys.mjs
LoginRelatedRealms.sys.mjs
LoginStore.sys.mjs
metrics.yaml
moz.build Bug 1893623 - P2. Remove unused code r=credential-management-reviewers,sgalich 2024-04-29 20:35:04 +00:00
NewPasswordModel.sys.mjs
nsILoginInfo.idl
nsILoginManager.idl
nsILoginManagerAuthPrompter.idl
nsILoginManagerCrypto.idl
nsILoginManagerPrompter.idl
nsILoginMetaInfo.idl
nsIPromptInstance.idl
OSCrypto_win.sys.mjs
PasswordGenerator.sys.mjs
PasswordRulesManager.sys.mjs
PasswordRulesParser.sys.mjs
storage-desktop.sys.mjs
storage-geckoview.sys.mjs
storage-json.sys.mjs