forked from mirrors/gecko-dev
When one Firefox instance finishes starting up it releases the startup lock and deletes the lock directory. Other instances that are waiting to startup are in the meantime polling to acquire the lock but with the directory gone their next attempt just throws a failure and so they assume they don't have the lock yet and keep polling until they hit the five second timeout. With this patch before each attempt to acquire the lock we make sure that the lock directory exists first. Differential Revision: https://phabricator.services.mozilla.com/D161075
192 lines
5.1 KiB
C++
192 lines
5.1 KiB
C++
/* -*- Mode: C++; tab-width: 8; indent-tabs-mode: nil; c-basic-offset: 2 -*- */
|
|
/* vim:expandtab:shiftwidth=2:tabstop=8:
|
|
*/
|
|
/* This Source Code Form is subject to the terms of the Mozilla Public
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
|
|
|
|
#ifdef MOZ_WIDGET_GTK
|
|
# ifdef MOZ_ENABLE_DBUS
|
|
# include "nsDBusRemoteServer.h"
|
|
# include "nsDBusRemoteClient.h"
|
|
# else
|
|
# include "nsGTKRemoteServer.h"
|
|
# include "nsXRemoteClient.h"
|
|
# endif
|
|
#elif defined(XP_WIN)
|
|
# include "nsWinRemoteServer.h"
|
|
# include "nsWinRemoteClient.h"
|
|
#elif defined(XP_DARWIN)
|
|
# include "nsMacRemoteServer.h"
|
|
# include "nsMacRemoteClient.h"
|
|
#endif
|
|
#include "nsRemoteService.h"
|
|
|
|
#include "nsIObserverService.h"
|
|
#include "nsString.h"
|
|
#include "nsServiceManagerUtils.h"
|
|
#include "SpecialSystemDirectory.h"
|
|
#include "mozilla/TimeStamp.h"
|
|
#include "mozilla/UniquePtr.h"
|
|
|
|
// Time to wait for the remoting service to start
|
|
#define START_TIMEOUT_SEC 5
|
|
#define START_SLEEP_MSEC 100
|
|
|
|
using namespace mozilla;
|
|
|
|
extern int gArgc;
|
|
extern char** gArgv;
|
|
|
|
using namespace mozilla;
|
|
|
|
NS_IMPL_ISUPPORTS(nsRemoteService, nsIObserver)
|
|
|
|
nsRemoteService::nsRemoteService(const char* aProgram) : mProgram(aProgram) {
|
|
ToLowerCase(mProgram);
|
|
}
|
|
|
|
void nsRemoteService::SetProfile(nsACString& aProfile) { mProfile = aProfile; }
|
|
|
|
void nsRemoteService::LockStartup() {
|
|
nsCOMPtr<nsIFile> mutexDir;
|
|
nsresult rv = GetSpecialSystemDirectory(OS_TemporaryDirectory,
|
|
getter_AddRefs(mutexDir));
|
|
NS_ENSURE_SUCCESS_VOID(rv);
|
|
rv = mutexDir->AppendNative(mProgram);
|
|
NS_ENSURE_SUCCESS_VOID(rv);
|
|
|
|
const mozilla::TimeStamp epoch = mozilla::TimeStamp::Now();
|
|
do {
|
|
// If we have been waiting for another instance to release the lock it will
|
|
// have deleted the lock directory when doing so we have to make sure it
|
|
// exists every time we poll for the lock.
|
|
rv = mutexDir->Create(nsIFile::DIRECTORY_TYPE, 0700);
|
|
if (NS_SUCCEEDED(rv) || rv == NS_ERROR_FILE_ALREADY_EXISTS) {
|
|
mRemoteLockDir = mutexDir;
|
|
} else {
|
|
NS_WARNING("Unable to create startup lock directory.");
|
|
return;
|
|
}
|
|
|
|
rv = mRemoteLock.Lock(mRemoteLockDir, nullptr);
|
|
if (NS_SUCCEEDED(rv)) {
|
|
return;
|
|
}
|
|
|
|
mRemoteLockDir = nullptr;
|
|
PR_Sleep(START_SLEEP_MSEC);
|
|
} while ((mozilla::TimeStamp::Now() - epoch) <
|
|
mozilla::TimeDuration::FromSeconds(START_TIMEOUT_SEC));
|
|
|
|
NS_WARNING("Failed to lock for startup, continuing anyway.");
|
|
}
|
|
|
|
void nsRemoteService::UnlockStartup() {
|
|
if (mRemoteLockDir) {
|
|
mRemoteLock.Unlock();
|
|
mRemoteLock.Cleanup();
|
|
|
|
mRemoteLockDir->Remove(false);
|
|
mRemoteLockDir = nullptr;
|
|
}
|
|
}
|
|
|
|
RemoteResult nsRemoteService::StartClient(const char* aStartupToken) {
|
|
if (mProfile.IsEmpty()) {
|
|
return REMOTE_NOT_FOUND;
|
|
}
|
|
|
|
UniquePtr<nsRemoteClient> client;
|
|
#ifdef MOZ_WIDGET_GTK
|
|
# if defined(MOZ_ENABLE_DBUS)
|
|
client = MakeUnique<nsDBusRemoteClient>();
|
|
# else
|
|
client = MakeUnique<nsXRemoteClient>();
|
|
# endif
|
|
#elif defined(XP_WIN)
|
|
client = MakeUnique<nsWinRemoteClient>();
|
|
#elif defined(XP_DARWIN)
|
|
client = MakeUnique<nsMacRemoteClient>();
|
|
#else
|
|
return REMOTE_NOT_FOUND;
|
|
#endif
|
|
|
|
nsresult rv = client ? client->Init() : NS_ERROR_FAILURE;
|
|
if (NS_FAILED(rv)) return REMOTE_NOT_FOUND;
|
|
|
|
nsCString response;
|
|
bool success = false;
|
|
rv =
|
|
client->SendCommandLine(mProgram.get(), mProfile.get(), gArgc, gArgv,
|
|
aStartupToken, getter_Copies(response), &success);
|
|
// did the command fail?
|
|
if (!success) return REMOTE_NOT_FOUND;
|
|
|
|
// The "command not parseable" error is returned when the
|
|
// nsICommandLineHandler throws a NS_ERROR_ABORT.
|
|
if (response.EqualsLiteral("500 command not parseable"))
|
|
return REMOTE_ARG_BAD;
|
|
|
|
if (NS_FAILED(rv)) return REMOTE_NOT_FOUND;
|
|
|
|
return REMOTE_FOUND;
|
|
}
|
|
|
|
void nsRemoteService::StartupServer() {
|
|
if (mRemoteServer) {
|
|
return;
|
|
}
|
|
|
|
if (mProfile.IsEmpty()) {
|
|
return;
|
|
}
|
|
|
|
#ifdef MOZ_WIDGET_GTK
|
|
# if defined(MOZ_ENABLE_DBUS)
|
|
mRemoteServer = MakeUnique<nsDBusRemoteServer>();
|
|
# else
|
|
mRemoteServer = MakeUnique<nsGTKRemoteServer>();
|
|
# endif
|
|
#elif defined(XP_WIN)
|
|
mRemoteServer = MakeUnique<nsWinRemoteServer>();
|
|
#elif defined(XP_DARWIN)
|
|
mRemoteServer = MakeUnique<nsMacRemoteServer>();
|
|
#else
|
|
return;
|
|
#endif
|
|
|
|
if (!mRemoteServer) {
|
|
return;
|
|
}
|
|
|
|
nsresult rv = mRemoteServer->Startup(mProgram.get(), mProfile.get());
|
|
|
|
if (NS_FAILED(rv)) {
|
|
mRemoteServer = nullptr;
|
|
return;
|
|
}
|
|
|
|
nsCOMPtr<nsIObserverService> obs(
|
|
do_GetService("@mozilla.org/observer-service;1"));
|
|
if (obs) {
|
|
obs->AddObserver(this, "xpcom-shutdown", false);
|
|
obs->AddObserver(this, "quit-application", false);
|
|
}
|
|
}
|
|
|
|
void nsRemoteService::ShutdownServer() { mRemoteServer = nullptr; }
|
|
|
|
nsRemoteService::~nsRemoteService() {
|
|
UnlockStartup();
|
|
ShutdownServer();
|
|
}
|
|
|
|
NS_IMETHODIMP
|
|
nsRemoteService::Observe(nsISupports* aSubject, const char* aTopic,
|
|
const char16_t* aData) {
|
|
// This can be xpcom-shutdown or quit-application, but it's the same either
|
|
// way.
|
|
ShutdownServer();
|
|
return NS_OK;
|
|
}
|