forked from mirrors/gecko-dev
		
	 e930b89c34
			
		
	
	
		e930b89c34
		
	
	
	
	
		
			
			***
Bug 1514594: Part 3a - Change ChromeUtils.import to return an exports object; not pollute global. r=mccr8
This changes the behavior of ChromeUtils.import() to return an exports object,
rather than a module global, in all cases except when `null` is passed as a
second argument, and changes the default behavior not to pollute the global
scope with the module's exports. Thus, the following code written for the old
model:
  ChromeUtils.import("resource://gre/modules/Services.jsm");
is approximately the same as the following, in the new model:
  var {Services} = ChromeUtils.import("resource://gre/modules/Services.jsm");
Since the two behaviors are mutually incompatible, this patch will land with a
scripted rewrite to update all existing callers to use the new model rather
than the old.
***
Bug 1514594: Part 3b - Mass rewrite all JS code to use the new ChromeUtils.import API. rs=Gijs
This was done using the followng script:
https://bitbucket.org/kmaglione/m-c-rewrites/src/tip/processors/cu-import-exports.jsm
***
Bug 1514594: Part 3c - Update ESLint plugin for ChromeUtils.import API changes. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D16747
***
Bug 1514594: Part 3d - Remove/fix hundreds of duplicate imports from sync tests. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D16748
***
Bug 1514594: Part 3e - Remove no-op ChromeUtils.import() calls. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D16749
***
Bug 1514594: Part 3f.1 - Cleanup various test corner cases after mass rewrite. r=Gijs
***
Bug 1514594: Part 3f.2 - Cleanup various non-test corner cases after mass rewrite. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D16750
--HG--
extra : rebase_source : 359574ee3064c90f33bf36c2ebe3159a24cc8895
extra : histedit_source : b93c8f42808b1599f9122d7842d2c0b3e656a594%2C64a3a4e3359dc889e2ab2b49461bab9e27fc10a7
		
	
			
		
			
				
	
	
		
			112 lines
		
	
	
	
		
			3.8 KiB
		
	
	
	
		
			JavaScript
		
	
	
	
	
	
			
		
		
	
	
			112 lines
		
	
	
	
		
			3.8 KiB
		
	
	
	
		
			JavaScript
		
	
	
	
	
	
| /* This Source Code Form is subject to the terms of the Mozilla Public
 | |
| * License, v. 2.0. If a copy of the MPL was not distributed with this file,
 | |
| * You can obtain one at http://mozilla.org/MPL/2.0/. */
 | |
| 
 | |
| "use strict";
 | |
| 
 | |
| var EXPORTED_SYMBOLS = ["ShellService"];
 | |
| 
 | |
| const {AppConstants} = ChromeUtils.import("resource://gre/modules/AppConstants.jsm");
 | |
| const {Services} = ChromeUtils.import("resource://gre/modules/Services.jsm");
 | |
| const {XPCOMUtils} = ChromeUtils.import("resource://gre/modules/XPCOMUtils.jsm");
 | |
| ChromeUtils.defineModuleGetter(this, "WindowsRegistry",
 | |
|                                "resource://gre/modules/WindowsRegistry.jsm");
 | |
| 
 | |
| /**
 | |
|  * Internal functionality to save and restore the docShell.allow* properties.
 | |
|  */
 | |
| let ShellServiceInternal = {
 | |
|   /**
 | |
|    * Used to determine whether or not to offer "Set as desktop background"
 | |
|    * functionality. Even if shell service is available it is not
 | |
|    * guaranteed that it is able to set the background for every desktop
 | |
|    * which is especially true for Linux with its many different desktop
 | |
|    * environments.
 | |
|    */
 | |
|   get canSetDesktopBackground() {
 | |
|     if (AppConstants.platform == "win" ||
 | |
|         AppConstants.platform == "macosx") {
 | |
|       return true;
 | |
|     }
 | |
| 
 | |
|     if (AppConstants.platform == "linux") {
 | |
|       if (this.shellService) {
 | |
|         let linuxShellService = this.shellService
 | |
|                                     .QueryInterface(Ci.nsIGNOMEShellService);
 | |
|         return linuxShellService.canSetDesktopBackground;
 | |
|       }
 | |
|     }
 | |
| 
 | |
|     return false;
 | |
|   },
 | |
| 
 | |
|   /**
 | |
|    * Used to determine whether or not to show a "Set Default Browser"
 | |
|    * query dialog. This attribute is true if the application is starting
 | |
|    * up and "browser.shell.checkDefaultBrowser" is true, otherwise it
 | |
|    * is false.
 | |
|    */
 | |
|   _checkedThisSession: false,
 | |
|   get shouldCheckDefaultBrowser() {
 | |
|     // If we've already checked, the browser has been started and this is a
 | |
|     // new window open, and we don't want to check again.
 | |
|     if (this._checkedThisSession) {
 | |
|       return false;
 | |
|     }
 | |
| 
 | |
|     if (!Services.prefs.getBoolPref("browser.shell.checkDefaultBrowser")) {
 | |
|       return false;
 | |
|     }
 | |
| 
 | |
|     if (AppConstants.platform == "win") {
 | |
|       let optOutValue = WindowsRegistry.readRegKey(Ci.nsIWindowsRegKey.ROOT_KEY_CURRENT_USER,
 | |
|                                                    "Software\\Mozilla\\Firefox",
 | |
|                                                    "DefaultBrowserOptOut");
 | |
|       WindowsRegistry.removeRegKey(Ci.nsIWindowsRegKey.ROOT_KEY_CURRENT_USER,
 | |
|                                    "Software\\Mozilla\\Firefox",
 | |
|                                    "DefaultBrowserOptOut");
 | |
|       if (optOutValue == "True") {
 | |
|         Services.prefs.setBoolPref("browser.shell.checkDefaultBrowser", false);
 | |
|         return false;
 | |
|       }
 | |
|     }
 | |
| 
 | |
|     return true;
 | |
|   },
 | |
| 
 | |
|   set shouldCheckDefaultBrowser(shouldCheck) {
 | |
|     Services.prefs.setBoolPref("browser.shell.checkDefaultBrowser", !!shouldCheck);
 | |
|   },
 | |
| 
 | |
|   isDefaultBrowser(startupCheck, forAllTypes) {
 | |
|     // If this is the first browser window, maintain internal state that we've
 | |
|     // checked this session (so that subsequent window opens don't show the
 | |
|     // default browser dialog).
 | |
|     if (startupCheck) {
 | |
|       this._checkedThisSession = true;
 | |
|     }
 | |
|     if (this.shellService) {
 | |
|       return this.shellService.isDefaultBrowser(forAllTypes);
 | |
|     }
 | |
|     return false;
 | |
|   },
 | |
| };
 | |
| 
 | |
| XPCOMUtils.defineLazyServiceGetter(ShellServiceInternal, "shellService",
 | |
|   "@mozilla.org/browser/shell-service;1", Ci.nsIShellService);
 | |
| 
 | |
| /**
 | |
|  * The external API exported by this module.
 | |
|  */
 | |
| var ShellService = new Proxy(ShellServiceInternal, {
 | |
|   get(target, name) {
 | |
|     if (name in target) {
 | |
|       return target[name];
 | |
|     }
 | |
|     if (target.shellService) {
 | |
|       return target.shellService[name];
 | |
|     }
 | |
|     Services.console.logStringMessage(`${name} not found in ShellService: ${target.shellService}`);
 | |
|     return undefined;
 | |
|   },
 | |
| });
 |