forked from mirrors/gecko-dev
c48e1ed307
This patch implements a new, preffed-off tab opening/closing animation where the tab slides up and down in place. In addition, it adjusts some tests and code that were relying on the max-width transitionend event happening. The intent of the patch is to land it preffed-off and iterate on the design in the tree Differential Revision: https://phabricator.services.mozilla.com/D15955 --HG-- extra : moz-landing-system : lando
68 lines
2.6 KiB
JavaScript
68 lines
2.6 KiB
JavaScript
"use strict";
|
|
|
|
/**
|
|
* WHOA THERE: We should never be adding new things to EXPECTED_REFLOWS. This
|
|
* is a whitelist that should slowly go away as we improve the performance of
|
|
* the front-end. Instead of adding more reflows to the whitelist, you should
|
|
* be modifying your code to avoid the reflow.
|
|
*
|
|
* See https://developer.mozilla.org/en-US/Firefox/Performance_best_practices_for_Firefox_fe_engineers
|
|
* for tips on how to do that.
|
|
*/
|
|
const EXPECTED_REFLOWS = [
|
|
/**
|
|
* Nothing here! Please don't add anything new!
|
|
*/
|
|
];
|
|
|
|
/*
|
|
* This test ensures that there are no unexpected
|
|
* uninterruptible reflows when opening a new tab that will
|
|
* cause the existing tabs to squeeze smaller.
|
|
*/
|
|
add_task(async function() {
|
|
await ensureNoPreloadedBrowser();
|
|
|
|
// Compute the number of tabs we can put into the strip without
|
|
// overflowing, and remove one, so that we can create
|
|
// TAB_COUNT_FOR_SQUEEE tabs, and then one more, which should
|
|
// cause the tab to squeeze to a smaller size rather than overflow.
|
|
const TAB_COUNT_FOR_SQUEEZE = computeMaxTabCount() - 1;
|
|
|
|
await createTabs(TAB_COUNT_FOR_SQUEEZE);
|
|
|
|
await ensureFocusedUrlbar();
|
|
|
|
let tabStripRect = gBrowser.tabContainer.arrowScrollbox.getBoundingClientRect();
|
|
let textBoxRect = document.getAnonymousElementByAttribute(gURLBar,
|
|
"anonid", "moz-input-box").getBoundingClientRect();
|
|
|
|
await withPerfObserver(async function() {
|
|
let switchDone = BrowserTestUtils.waitForEvent(window, "TabSwitchDone");
|
|
BrowserOpenTab();
|
|
await BrowserTestUtils.waitForEvent(gBrowser.selectedTab, "TabAnimationEnd");
|
|
await switchDone;
|
|
}, {expectedReflows: EXPECTED_REFLOWS,
|
|
frames: {
|
|
filter: rects => rects.filter(r => !(
|
|
// We expect plenty of changed rects within the tab strip.
|
|
r.y1 >= tabStripRect.top && r.y2 <= tabStripRect.bottom &&
|
|
r.x1 >= tabStripRect.left && r.x2 <= tabStripRect.right &&
|
|
// It would make sense for each rect to have a width smaller than
|
|
// a tab (ie. tabstrip.width / tabcount), but tabs are small enough
|
|
// that they sometimes get reported in the same rect.
|
|
// So we accept up to the width of n-1 tabs.
|
|
r.w <= (gBrowser.tabs.length - 1) * Math.ceil(tabStripRect.width / gBrowser.tabs.length)
|
|
)),
|
|
exceptions: [
|
|
{name: "the urlbar placeolder moves up and down by a few pixels",
|
|
condition: r =>
|
|
r.x1 >= textBoxRect.left && r.x2 <= textBoxRect.right &&
|
|
r.y1 >= textBoxRect.top && r.y2 <= textBoxRect.bottom,
|
|
},
|
|
],
|
|
},
|
|
});
|
|
|
|
await removeAllButFirstTab();
|
|
});
|