forked from mirrors/gecko-dev
e930b89c34
***
Bug 1514594: Part 3a - Change ChromeUtils.import to return an exports object; not pollute global. r=mccr8
This changes the behavior of ChromeUtils.import() to return an exports object,
rather than a module global, in all cases except when `null` is passed as a
second argument, and changes the default behavior not to pollute the global
scope with the module's exports. Thus, the following code written for the old
model:
ChromeUtils.import("resource://gre/modules/Services.jsm");
is approximately the same as the following, in the new model:
var {Services} = ChromeUtils.import("resource://gre/modules/Services.jsm");
Since the two behaviors are mutually incompatible, this patch will land with a
scripted rewrite to update all existing callers to use the new model rather
than the old.
***
Bug 1514594: Part 3b - Mass rewrite all JS code to use the new ChromeUtils.import API. rs=Gijs
This was done using the followng script:
https://bitbucket.org/kmaglione/m-c-rewrites/src/tip/processors/cu-import-exports.jsm
***
Bug 1514594: Part 3c - Update ESLint plugin for ChromeUtils.import API changes. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D16747
***
Bug 1514594: Part 3d - Remove/fix hundreds of duplicate imports from sync tests. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D16748
***
Bug 1514594: Part 3e - Remove no-op ChromeUtils.import() calls. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D16749
***
Bug 1514594: Part 3f.1 - Cleanup various test corner cases after mass rewrite. r=Gijs
***
Bug 1514594: Part 3f.2 - Cleanup various non-test corner cases after mass rewrite. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D16750
--HG--
extra : rebase_source : 359574ee3064c90f33bf36c2ebe3159a24cc8895
extra : histedit_source : b93c8f42808b1599f9122d7842d2c0b3e656a594%2C64a3a4e3359dc889e2ab2b49461bab9e27fc10a7
52 lines
1.7 KiB
JavaScript
52 lines
1.7 KiB
JavaScript
/* This Source Code Form is subject to the terms of the Mozilla Public
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
|
|
"use strict";
|
|
|
|
const {actionCreators: ac, actionTypes: at} = ChromeUtils.import("resource://activity-stream/common/Actions.jsm");
|
|
|
|
/**
|
|
* NewTabInit - A placeholder for now. This will send a copy of the state to all
|
|
* newly opened tabs.
|
|
*/
|
|
this.NewTabInit = class NewTabInit {
|
|
constructor() {
|
|
this._repliedEarlyTabs = new Map();
|
|
}
|
|
|
|
reply(target) {
|
|
// Skip this reply if we already replied to an early tab
|
|
if (this._repliedEarlyTabs.get(target)) {
|
|
return;
|
|
}
|
|
|
|
const action = {type: at.NEW_TAB_INITIAL_STATE, data: this.store.getState()};
|
|
this.store.dispatch(ac.AlsoToOneContent(action, target));
|
|
|
|
// Remember that this early tab has already gotten a rehydration response in
|
|
// case it thought we lost its initial REQUEST and asked again
|
|
if (this._repliedEarlyTabs.has(target)) {
|
|
this._repliedEarlyTabs.set(target, true);
|
|
}
|
|
}
|
|
|
|
onAction(action) {
|
|
switch (action.type) {
|
|
case at.NEW_TAB_STATE_REQUEST:
|
|
this.reply(action.meta.fromTarget);
|
|
break;
|
|
case at.NEW_TAB_INIT:
|
|
// Initialize data for early tabs that might REQUEST twice
|
|
if (action.data.simulated) {
|
|
this._repliedEarlyTabs.set(action.data.portID, false);
|
|
}
|
|
break;
|
|
case at.NEW_TAB_UNLOAD:
|
|
// Clean up for any tab (no-op if not an early tab)
|
|
this._repliedEarlyTabs.delete(action.meta.fromTarget);
|
|
break;
|
|
}
|
|
}
|
|
};
|
|
|
|
const EXPORTED_SYMBOLS = ["NewTabInit"];
|