forked from mirrors/gecko-dev
e930b89c34
***
Bug 1514594: Part 3a - Change ChromeUtils.import to return an exports object; not pollute global. r=mccr8
This changes the behavior of ChromeUtils.import() to return an exports object,
rather than a module global, in all cases except when `null` is passed as a
second argument, and changes the default behavior not to pollute the global
scope with the module's exports. Thus, the following code written for the old
model:
ChromeUtils.import("resource://gre/modules/Services.jsm");
is approximately the same as the following, in the new model:
var {Services} = ChromeUtils.import("resource://gre/modules/Services.jsm");
Since the two behaviors are mutually incompatible, this patch will land with a
scripted rewrite to update all existing callers to use the new model rather
than the old.
***
Bug 1514594: Part 3b - Mass rewrite all JS code to use the new ChromeUtils.import API. rs=Gijs
This was done using the followng script:
https://bitbucket.org/kmaglione/m-c-rewrites/src/tip/processors/cu-import-exports.jsm
***
Bug 1514594: Part 3c - Update ESLint plugin for ChromeUtils.import API changes. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D16747
***
Bug 1514594: Part 3d - Remove/fix hundreds of duplicate imports from sync tests. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D16748
***
Bug 1514594: Part 3e - Remove no-op ChromeUtils.import() calls. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D16749
***
Bug 1514594: Part 3f.1 - Cleanup various test corner cases after mass rewrite. r=Gijs
***
Bug 1514594: Part 3f.2 - Cleanup various non-test corner cases after mass rewrite. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D16750
--HG--
extra : rebase_source : 359574ee3064c90f33bf36c2ebe3159a24cc8895
extra : histedit_source : b93c8f42808b1599f9122d7842d2c0b3e656a594%2C64a3a4e3359dc889e2ab2b49461bab9e27fc10a7
43 lines
1.7 KiB
JavaScript
43 lines
1.7 KiB
JavaScript
"use strict";
|
|
|
|
// Tests that unhandled promise rejections generate the appropriate
|
|
// console messages.
|
|
|
|
const {Services} = ChromeUtils.import("resource://gre/modules/Services.jsm");
|
|
const {AddonTestUtils} = ChromeUtils.import("resource://testing-common/AddonTestUtils.jsm");
|
|
const {PromiseTestUtils} = ChromeUtils.import("resource://testing-common/PromiseTestUtils.jsm");
|
|
|
|
PromiseTestUtils.expectUncaughtRejection(/could not be cloned/);
|
|
|
|
add_task(async function test_unhandled_dom_exception() {
|
|
let sandbox = Cu.Sandbox(Services.scriptSecurityManager.getSystemPrincipal());
|
|
sandbox.StructuredCloneHolder = StructuredCloneHolder;
|
|
|
|
let filename = "resource://foo/Bar.jsm";
|
|
|
|
let {messages} = await AddonTestUtils.promiseConsoleOutput(async () => {
|
|
let code = `new Promise(() => {
|
|
new StructuredCloneHolder(() => {});
|
|
});`;
|
|
|
|
Cu.evalInSandbox(code, sandbox, null, filename, 1);
|
|
|
|
// We need two trips through the event loop for this error to be reported.
|
|
await new Promise(executeSoon);
|
|
await new Promise(executeSoon);
|
|
});
|
|
|
|
// xpcshell tests on OS-X sometimes include an extra warning, which we
|
|
// unfortunately need to ignore:
|
|
messages = messages.filter(msg => !msg.message.includes(
|
|
"No chrome package registered for chrome://branding/locale/brand.properties"));
|
|
|
|
equal(messages.length, 1, "Got one console message");
|
|
|
|
let [msg] = messages;
|
|
ok(msg instanceof Ci.nsIScriptError, "Message is a script error");
|
|
equal(msg.sourceName, filename, "Got expected filename");
|
|
equal(msg.lineNumber, 2, "Got expected line number");
|
|
equal(msg.errorMessage, "DataCloneError: The object could not be cloned.",
|
|
"Got expected error message");
|
|
});
|