forked from mirrors/gecko-dev
Automatic update from web-platform-tests Fix DCHECK in FinishFragmentation(). The DCHECK is correct, but it's currently failing for a couple of reasons: 1. We don't truncate the block-end border/scrollbar/padding when we're past the block-end (we should, just like we do for the block-start one when resuming layout in AdjustBorderScrollbarPaddingForFragmentation()). I couldn't come up with a testcase where this causes broken layout, though, so it doesn't seem reasonable to waste space in NGBoxFragmentBuilder just to avoid a DCHECK. 2. Resolving the BFC offset may affect the state of IsKnownToFitInFragmentainer(). We should abort layout and retry in such cases, but it's not super-trivial. Filed crbug.com/1311824 for that. DCHECK that final_block_size is 0 instead. This is currently guaranteed with the current code, though, since we always set it to 0 if we're past the block-end. Still good for documentation, I suppose. Bug: 1310503, 1310238 Change-Id: Ifd75219497d5d8fa54b285c3a0110c2449c83f39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3560582 Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by: Alison Maher <almaher@microsoft.com> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/main@{#987589} -- wpt-commits: 8f5a0dd3bc2970ef1718efdb5042d3f43df70014 wpt-pr: 33442
10 lines
377 B
HTML
10 lines
377 B
HTML
<!DOCTYPE html>
|
|
<link rel="author" title="Morten Stenshorne" href="mailto:mstensho@chromium.org">
|
|
<link rel="help" href="https://bugs.chromium.org/p/chromium/issues/detail?id=1310238">
|
|
<div style="columns:5; column-fill:auto; height:100px;">
|
|
<div style="padding-bottom:1px;">
|
|
<div style="height:100px;">
|
|
<div style="height:450px;"></div>
|
|
</div>
|
|
</div>
|
|
</div>
|