forked from mirrors/gecko-dev
c8cf5edb7b
Automatic update from web-platform-tests Never force legacy layout on NG objects. Remove dangerous legacy fallback code from LayoutObject(), and do this safely in the child insertion code instead. Calling a virtual method in a base class constructor doesn't work. IsLayoutNGObject() would always return false, since that's how it's implemented in LayoutObject. This code could cause us to mark an NG object as requiring legacy fallback, which would make the NG engine delegate the job to the legacy engine. But the legacy engine would refuse to do anything, since it's an NG object, so it would delegate to NG, and so on... Infinite recursion. The !IsLayoutNGObject() check in LayoutObject() was a mistake added in CL:2414289, which basically had no effect at all. But we can just remove the entire thing now, and rely on the new hook in the child insertion code instead. Note that the new test doesn't fail without this fix when run normally by the test runner, because the test needs LayoutNGTextControl to be disabled in order to fail (so that we attempt legacy fallback), but this feature is currently set to "test". Unlike the fuzzer, it seems... Bug: 1181687 Change-Id: I2f174824e4b86d9ae2e5b3b319df7f6036b4f13d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2720104 Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#858052} -- wpt-commits: b71ded018fcecc54f69d7c4e399dd0b9b00eab06 wpt-pr: 27792
4 lines
226 B
HTML
4 lines
226 B
HTML
<!DOCTYPE html>
|
|
<link rel="author" title="Morten Stenshorne" href="mailto:mstensho@chromium.org">
|
|
<link rel="help" href="https://bugs.chromium.org/p/chromium/issues/detail?id=1181687">
|
|
<input style="display:layout(success);">
|