forked from mirrors/gecko-dev
3c7e4e1cec
Automatic update from web-platform-tests Trim whitespace around CSS custom declarations. There was a spec change a few years back, requiring us to strip spaces and comments from the beginning and end of CSS custom property declarations. We take a slight performance hit: Initial style (µs) Before After Perf 95% CI (BCa) =================== ========= ========= ======= ================= ECommerce 10041 9994 +0.5% [ +0.1%, +0.9%] Encyclopedia 106735 106744 -0.0% [ -0.6%, +0.4%] Extension 132830 133009 -0.1% [ -0.6%, +0.2%] News 42534 42653 -0.3% [ -1.0%, +0.1%] Search 2636 2662 -1.0% [ -1.4%, -0.6%] Social1 23298 23312 -0.1% [ -0.3%, +0.2%] Social2 1039 1042 -0.3% [ -1.0%, +0.4%] Sports 42680 42985 -0.7% [ -1.0%, -0.5%] Video 41971 42134 -0.4% [ -0.6%, -0.1%] Geometric mean -0.3% [ -0.5%, -0.1%] Parse (µs) Before After Perf 95% CI (BCa) =================== ========= ========= ======= ================= ECommerce 1360 1372 -0.9% [ -1.2%, -0.4%] Encyclopedia 7349 7384 -0.5% [ -0.7%, -0.2%] Extension 1349 1352 -0.2% [ -1.2%, +0.2%] News 7929 7982 -0.7% [ -1.0%, -0.3%] Search 4965 4997 -0.6% [ -0.9%, -0.4%] Social1 14752 14837 -0.6% [ -0.8%, -0.3%] Social2 617 620 -0.4% [ -1.4%, +0.7%] Sports 56182 56318 -0.2% [ -0.6%, +0.0%] Video 34720 35091 -1.1% [ -1.3%, -0.8%] Geometric mean -0.6% [ -0.9%, -0.4%] Recalc style (µs) Before After Perf 95% CI (BCa) =================== ========= ========= ======= ================= ECommerce 11417 11378 +0.3% [ -0.2%, +0.8%] Encyclopedia 83808 84066 -0.3% [ -1.4%, +0.1%] Extension 120362 120394 -0.0% [ -0.7%, +0.3%] News 31566 31549 +0.1% [ -1.2%, +0.5%] Search 242 242 -0.0% [ -1.5%, +0.7%] Social1 17242 17203 +0.2% [ -0.1%, +0.4%] Social2 602 593 +1.4% [ +0.7%, +2.1%] Sports 22817 22874 -0.3% [ -0.5%, +0.0%] Video 25931 25969 -0.1% [ -0.4%, +0.1%] Geometric mean +0.1% [ -0.5%, +0.5%] We save a little bit of RAM, obviously, but not much. Fixed: 1211112 Fixed: 1220144 Change-Id: Ib7656de36d6a94d85ba25ecf60e9879b21c36468 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3341633 Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Steinar H Gunderson <sesse@chromium.org> Cr-Commit-Position: refs/heads/main@{#1116326} -- wpt-commits: c3ab769723cb249535a8845cc35af80975b8926d wpt-pr: 38905
70 lines
1.9 KiB
HTML
70 lines
1.9 KiB
HTML
<!DOCTYPE html>
|
|
<html class=reftest-wait>
|
|
<link rel="help" href="https://drafts.css-houdini.org/css-layout-api/#layout-invalidation">
|
|
<link rel="match" href="style-map-multi-ref.html">
|
|
<meta name="assert" content="This test checks that properties are correctly given to the layout function." />
|
|
|
|
<style>
|
|
.test {
|
|
background: red;
|
|
margin: 10px;
|
|
width: 100px;
|
|
|
|
/* Properties under test. */
|
|
--foo:bar;
|
|
margin-left: 2px;
|
|
}
|
|
|
|
@supports (display: layout(test)) {
|
|
.test {
|
|
background: green;
|
|
display: layout(test);
|
|
}
|
|
}
|
|
</style>
|
|
<script src="/common/reftest-wait.js"></script>
|
|
<script src="/common/worklet-reftest.js"></script>
|
|
|
|
<div class="test"></div>
|
|
|
|
<script id="code" type="text/worklet">
|
|
registerLayout('test', class {
|
|
static get inputProperties() {
|
|
return [ '--bar', '--foo', 'empty-cells', 'margin-left'];
|
|
}
|
|
|
|
async intrinsicSizes() {}
|
|
async layout(children, edges, constraints, styleMap) {
|
|
const expected = [
|
|
{property: '--bar', value: '[CSSUnparsedValue=]'},
|
|
{property: '--foo', value: '[CSSUnparsedValue=bar]'},
|
|
{property: 'empty-cells', value: '[CSSKeywordValue=show]'},
|
|
{property: 'margin-left', value: '[CSSUnitValue=2px]'},
|
|
];
|
|
|
|
const actual = Array.from(styleMap.keys()).sort().map((property) => {
|
|
const valueObject = styleMap.get(property);
|
|
const value = '[' + valueObject.constructor.name + '=' + valueObject.toString() + ']';
|
|
return {property, value};
|
|
});
|
|
|
|
if (expected.length != actual.length)
|
|
return {autoBlockSize: 0};
|
|
|
|
for (let i = 0; i < expected.length; i++) {
|
|
if (expected[i].property != actual[i].property)
|
|
return {autoBlockSize: 0};
|
|
|
|
if (expected[i].value != actual[i].value)
|
|
return {autoBlockSize: 0};
|
|
}
|
|
|
|
return {autoBlockSize: 100};
|
|
}
|
|
});
|
|
</script>
|
|
|
|
<script>
|
|
importWorkletAndTerminateTestAfterAsyncPaint(CSS.layoutWorklet, document.getElementById('code').textContent);
|
|
</script>
|
|
</html>
|