fune/dom/events/PaintRequest.h
Daniel Holbert ebd0469a04 Bug 1896745: Avoid unnecessary refcount traffic when appending DOMRect & PaintRequest to array-of-RefPtrs. r=mccr8
For these objects, we have an `Append(Foo*)` method which is just a
wrapper-function that appends to a `nsTArray<RefPtr<Foo>>`.  As it happens,
every callsite is passing in a local `RefPtr` variable that's no longer needed
after the call to `Append`.

It's slightly more performant to use move-semantics to directly transfer
ownership of the existing reference from the local variable to the array,
rather than having the reference count take one step forward and then one step
back, as we were doing before this patch.

Differential Revision: https://phabricator.services.mozilla.com/D210364
2024-05-14 22:12:30 +00:00

79 lines
2.3 KiB
C++

/* -*- Mode: C++; tab-width: 8; indent-tabs-mode: nil; c-basic-offset: 2 -*- */
/* vim: set ts=8 sts=2 et sw=2 tw=80: */
/* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
#ifndef mozilla_dom_PaintRequest_h_
#define mozilla_dom_PaintRequest_h_
#include "nsPresContext.h"
#include "mozilla/Attributes.h"
#include "mozilla/RefPtr.h"
#include "mozilla/dom/Event.h"
#include "nsWrapperCache.h"
namespace mozilla::dom {
class DOMRect;
class PaintRequest final : public nsISupports, public nsWrapperCache {
public:
explicit PaintRequest(Event* aParent) : mParent(aParent) {}
NS_DECL_CYCLE_COLLECTING_ISUPPORTS
NS_DECL_CYCLE_COLLECTION_WRAPPERCACHE_CLASS(PaintRequest)
virtual JSObject* WrapObject(JSContext* aCx,
JS::Handle<JSObject*> aGivenProto) override;
Event* GetParentObject() const { return mParent; }
already_AddRefed<DOMRect> ClientRect();
void GetReason(nsAString& aResult) const { aResult.AssignLiteral("repaint"); }
void SetRequest(const nsRect& aRequest) { mRequest = aRequest; }
private:
~PaintRequest() = default;
RefPtr<Event> mParent;
nsRect mRequest;
};
class PaintRequestList final : public nsISupports, public nsWrapperCache {
public:
explicit PaintRequestList(Event* aParent) : mParent(aParent) {}
NS_DECL_CYCLE_COLLECTING_ISUPPORTS
NS_DECL_CYCLE_COLLECTION_WRAPPERCACHE_CLASS(PaintRequestList)
virtual JSObject* WrapObject(JSContext* aCx,
JS::Handle<JSObject*> aGivenProto) override;
nsISupports* GetParentObject() { return mParent; }
void Append(RefPtr<PaintRequest>&& aElement) {
mArray.AppendElement(std::move(aElement));
}
uint32_t Length() { return mArray.Length(); }
PaintRequest* Item(uint32_t aIndex) { return mArray.SafeElementAt(aIndex); }
PaintRequest* IndexedGetter(uint32_t aIndex, bool& aFound) {
aFound = aIndex < mArray.Length();
if (!aFound) {
return nullptr;
}
return mArray.ElementAt(aIndex);
}
private:
~PaintRequestList() = default;
nsTArray<RefPtr<PaintRequest> > mArray;
RefPtr<Event> mParent;
};
} // namespace mozilla::dom
#endif // mozilla_dom_PaintRequest_h_