forked from mirrors/gecko-dev
2c93600238
First, `EditorBase::CreateTransactionForDeleteSelection` returns an instance of `EditAggregateTransaction`. It's a base class of `PlaceholderTransaction` and `DeleteRangeTransaction` but it's also a concrete class. However, it's too generic. Therefore, this patch creates `DeleteMultipleRangesTransaction` which is a simple sub-class of it, and makes `EditAggregateTransaction` be an abstract class. Then, add `AddChild` methods to each concrete class to restrict the type of child transactions. Next, `DeleteRangeTransaction` contains only `DeleteNodeTransaction` and `DeleteTextTransaction`. Therefore, once they have a common base class, we can check the type easier. Therefore, this patch also adds `DeleteContentTransactionBase` and `EditorBase::CreateTransactionForCollapsedRange` becomes clearer what it returns. With these changes, `DeleteRangeTransaction` obviously contains only `DeleteContentTransactionBase`, `DeleteMultipleRangesTransaction` contains only `DeleteRangeTransaction`, `DeleteNodeTransaction` and `DeleteTextTransaction`. And they are guaranteed at build time (at least from outside the classes). *** fix Differential Revision: https://phabricator.services.mozilla.com/D169038
24 lines
936 B
C++
24 lines
936 B
C++
/* -*- Mode: C++; tab-width: 2; indent-tabs-mode: nil; c-basic-offset: 2 -*- */
|
|
/* This Source Code Form is subject to the terms of the Mozilla Public
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
|
|
|
|
#include "DeleteContentTransactionBase.h"
|
|
|
|
#include "EditorBase.h"
|
|
|
|
namespace mozilla {
|
|
|
|
DeleteContentTransactionBase::DeleteContentTransactionBase(
|
|
EditorBase& aEditorBase)
|
|
: mEditorBase(&aEditorBase) {}
|
|
|
|
NS_IMPL_CYCLE_COLLECTION_INHERITED(DeleteContentTransactionBase,
|
|
EditTransactionBase, mEditorBase)
|
|
|
|
NS_IMPL_ADDREF_INHERITED(DeleteContentTransactionBase, EditTransactionBase)
|
|
NS_IMPL_RELEASE_INHERITED(DeleteContentTransactionBase, EditTransactionBase)
|
|
NS_INTERFACE_MAP_BEGIN_CYCLE_COLLECTION(DeleteContentTransactionBase)
|
|
NS_INTERFACE_MAP_END_INHERITING(EditTransactionBase)
|
|
|
|
} // namespace mozilla
|