forked from mirrors/gecko-dev
43b648c36b
This makes a couple of large changes: (1) "Generic" buttons (the ones added by `UrlbarView.#addRowButton()`) are now supported in all row types. The help button that's currently included in some types of rows when `result.payload.helpUrl` is defined is now supported for all row types, and two additional button types are now supported too: block buttons and labeled buttons. A row will get a block button if its `result.payload.isBlockable` is defined. It will get a labeled button if `result.payload.buttons` is defined and non-empty. A button can include a `url` property that is then added as an attribute on the button's element, and `UrlbarInput.pickResult()` will use this attribute to load the URL when the button is picked. (2) The reason I added labeled buttons is because it lets us support tip buttons without much more effort, which then lets us get rid of the special row type used for tips. With this patch, tips are now standard rows that use generic buttons. This approach should be compatible with the result menu, when we switch over to it, because we can include the help and block commands in the menu when `helpUrl` and `isBlockable` are defined, instead of creating buttons for them. Labeled buttons -- the ones used in tips -- would still be created. The result menu button itself can continue to be a generic button. It should also be compatible with including the result menu button inside the row selection. We'll still add buttons to `.urlbarView-row`, separate from `.urlbarView-row-inner`, so that the buttons can continue to be on the right side of the row. We can color the background of the row instead of the row-inner. As with D163630, my motivation for this change is to support generic buttons in dynamic result rows so that help and block buttons can be easily added to weather suggestions. Here too the larger changes of supporting generic labeled buttons and removing special rows for tips aren't strictly necessary, but I took the opportunity to rework things. Finally, this makes a few other changes: * It includes some of the more minor improvements to selection that I made in D163630. * It removes the help URL code from quick actions since it was decided not to show a help button. Currently, the button is hidden in CSS, but now that a generic help button is added for dynamic result rows when `result.payload.helpUrl` is defined, `helpUrl` needs to be removed from the payload to prevent a button from being added. * I removed the special tip wrapping behavior, where the tip button and help button would wrap below the tip's text. Instead, now the text wraps inside row-inner and the buttons always remain on the same horizontal as the text. I don't think it's worth the extra complication. Differential Revision: https://phabricator.services.mozilla.com/D163766 |
||
|---|---|---|
| .. | ||
| child | ||
| parent | ||
| schemas | ||
| test | ||
| .eslintrc.js | ||
| ext-browser.json | ||
| extension-linux-panel.css | ||
| extension-mac-panel.css | ||
| extension-mac.css | ||
| extension-win-panel.css | ||
| extension.css | ||
| ExtensionBrowsingData.jsm | ||
| ExtensionControlledPopup.jsm | ||
| ExtensionPopups.jsm | ||
| extensions-browser.manifest | ||
| jar.mn | ||
| moz.build | ||