forked from mirrors/gecko-dev
d8b7fb22e3
Summary: This moves the load of favicons into the content process. We use the same logic for finding favicons (based on waiting until none have shown up for a short time) but then load the favicon and convert it to a data uri which we then dispatch to the parent process. Along the way this fixes asssociating the load with the tab for WebExtension and devtools, fixes CSP usage for the load, fixes expiry detection of the favicon and stops us from loading the same resource twice. This change also merges the prefs browser.chrome.site_icons and browser.chrome.favicons leaving just the former controlling favicon loading. It adds the pref browser.chrome.guess_favicon to allow disabling guessing where a favicon might be located for a site (at <hostname>/favicon.ico). This is mainly to allow disabling this in tests where those additional yet automatic requests are uninteresting for the test. There are multiple clean-ups that can follow this but this is a first step along that path. MozReview-Commit-ID: E0Cs59UnxaF Reviewers: mak Tags: #secure-revision Bug #: 1453751 Differential Revision: https://phabricator.services.mozilla.com/D1672 Differential Revision: https://phabricator.services.mozilla.com/D1673 Differential Revision: https://phabricator.services.mozilla.com/D1674 Differential Revision: https://phabricator.services.mozilla.com/D1850 Differential Revision: https://phabricator.services.mozilla.com/D1869 --HG-- rename : browser/base/content/test/general/browser_bug408415.js => browser/base/content/test/favicons/browser_bug408415.js rename : browser/base/content/test/general/browser_bug550565.js => browser/base/content/test/favicons/browser_bug550565.js rename : browser/base/content/test/general/browser_favicon_change.js => browser/base/content/test/favicons/browser_favicon_change.js rename : browser/base/content/test/general/browser_favicon_change_not_in_document.js => browser/base/content/test/favicons/browser_favicon_change_not_in_document.js rename : browser/base/content/test/general/browser_subframe_favicons_not_used.js => browser/base/content/test/favicons/browser_subframe_favicons_not_used.js rename : browser/base/content/test/general/file_bug970276_favicon1.ico => browser/base/content/test/favicons/file_bug970276_favicon1.ico rename : browser/base/content/test/general/file_bug970276_favicon1.ico => browser/base/content/test/favicons/file_bug970276_favicon2.ico rename : browser/base/content/test/general/file_bug970276_popup1.html => browser/base/content/test/favicons/file_bug970276_popup1.html rename : browser/base/content/test/general/file_bug970276_popup2.html => browser/base/content/test/favicons/file_bug970276_popup2.html rename : browser/base/content/test/general/file_favicon_change.html => browser/base/content/test/favicons/file_favicon_change.html rename : browser/base/content/test/general/file_favicon_change_not_in_document.html => browser/base/content/test/favicons/file_favicon_change_not_in_document.html rename : browser/base/content/test/general/file_bug970276_favicon1.ico => browser/base/content/test/favicons/file_generic_favicon.ico rename : browser/base/content/test/general/file_with_favicon.html => browser/base/content/test/favicons/file_with_favicon.html extra : rebase_source : 6372b2681a59d267f966e9fa2ca9a54e3ff0cea0 extra : intermediate-source : b11aa832c41ac5beef9065f804d11fb7c9887990 extra : source : 638eb8a41245f6d9932861afda21edd5e0b2618a
44 lines
1.5 KiB
JavaScript
44 lines
1.5 KiB
JavaScript
/* Any copyright is dedicated to the Public Domain.
|
|
* http://creativecommons.org/publicdomain/zero/1.0/ */
|
|
|
|
"use strict";
|
|
|
|
/**
|
|
* Ensure that a pending tab has label and icon correctly set.
|
|
*/
|
|
add_task(async function test_label_and_icon() {
|
|
// Make sure that tabs are restored on demand as otherwise the tab will start
|
|
// loading immediately and we can't check its icon and label.
|
|
await SpecialPowers.pushPrefEnv({
|
|
set: [["browser.sessionstore.restore_on_demand", true]],
|
|
});
|
|
|
|
// Create a new tab.
|
|
let tab = BrowserTestUtils.addTab(gBrowser, "about:robots");
|
|
let browser = tab.linkedBrowser;
|
|
await promiseBrowserLoaded(browser);
|
|
// Because there is debounce logic in ContentLinkHandler.jsm to reduce the
|
|
// favicon loads, we have to wait some time before checking that icon was
|
|
// stored properly.
|
|
await BrowserTestUtils.waitForCondition(() => {
|
|
return gBrowser.getIcon(tab) != null;
|
|
}, "wait for favicon load to finish", 100, 5);
|
|
|
|
// Retrieve the tab state.
|
|
await TabStateFlusher.flush(browser);
|
|
let state = ss.getTabState(tab);
|
|
BrowserTestUtils.removeTab(tab);
|
|
browser = null;
|
|
|
|
// Open a new tab to restore into.
|
|
tab = BrowserTestUtils.addTab(gBrowser, "about:blank");
|
|
ss.setTabState(tab, state);
|
|
await promiseTabRestoring(tab);
|
|
|
|
// Check that label and icon are set for the restoring tab.
|
|
is(gBrowser.getIcon(tab), "chrome://browser/content/robot.ico", "icon is set");
|
|
is(tab.label, "Gort! Klaatu barada nikto!", "label is set");
|
|
|
|
// Cleanup.
|
|
BrowserTestUtils.removeTab(tab);
|
|
});
|