forked from mirrors/gecko-dev
7512d04e93
> Here it is. > > ~~There's two major things that are unfinished here:~~ > - ~~Dealing with the unroot_must_root lint. I'm not sure about the value of this lint with the new rooting API.~~ Done. > - ~~Updating the Cargo.locks to point to the new SM and SM binding.~~ Done. > > I also included my fixes for the rust update, but these will disappear in a rebase. A rust update is necessary to support calling `Drop` on `Heap<T>` correctly when `Heap<T>` is inside a `Rc<T>`. Otherwise `&self` points to the wrong location. > > Incremental GC is disabled here. I'm not sure how to deal with the incremental barriers so that's left for later. > > Generational GC works. SM doesn't work without it. > > The biggest change here is to the rooting API. `Root` was made movable, and `Temporary` and `JSRef` was removed. Movable `Root`s means there's no need for `Temporary`, and `JSRef`s aren't needed generally since it can be assumed that being able to obtain a reference to a dom object means it's already rooted. References have their lifetime bound to the Roots that provided them. DOM objects that haven't passed through `reflect_dom_object` don't need to be rooted, and DOM objects that have passed through `reflect_dom_object` can't be obtained without being rooted through `native_from_reflector_jsmanaged` or `JS::<T>::root()`. > > Support for `Heap<T>` ended up messier than I expected. It's split into two commits, but only because it's a bit difficult to fold them together. Supporting `Heap<T>` properly requires that that `Heap::<T>::set()` be called on something that won't move. I removed the Copy and Clone trait from `Heap<T>` so `Cell` can't hold `Heap<T>` - only `UnsafeCell` can hold it. > > `CallbackObject` is a bit tricky - I moved all callbacks into `Rc<T>` in order to make sure that the pointer inside to a `*mut JSObject` doesn't move. This is necessary for supporting `Heap<T>`. > > `RootedCollectionSet` is very general purpose now. Anything with `JSTraceable` can be rooted by `RootedCollectionSet`/`RootedTraceable`. Right now, `RootedTraceable` is only used to hold down dom objects before they're fully attached to their reflector. I had to make a custom mechanism to dispatch the trace call - couldn't figure out how to get trait objects working for this case. > > This has been tested with the following zeal settings: > > GC after every allocation > JS_GC_ZEAL=2,1 > > GC after every 100 allocations (important for catching use-after-free bugs) > JS_GC_ZEAL=2,100 > > Verify pre barriers > JS_GC_ZEAL=4,1 > > Verify post barriers > JS_GC_ZEAL=11,1 Source-Repo: https://github.com/servo/servo Source-Revision: e7808c526c348fea5e3b48af70b7f1a066652097
83 lines
3.3 KiB
Rust
83 lines
3.3 KiB
Rust
/* This Source Code Form is subject to the terms of the Mozilla Public
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
|
|
|
|
use document_loader::DocumentLoader;
|
|
use dom::bindings::codegen::Bindings::DocumentBinding::DocumentReadyState;
|
|
use dom::bindings::codegen::Bindings::DOMParserBinding;
|
|
use dom::bindings::codegen::Bindings::DOMParserBinding::DOMParserMethods;
|
|
use dom::bindings::codegen::Bindings::DOMParserBinding::SupportedType::{Text_html, Text_xml};
|
|
use dom::bindings::codegen::Bindings::WindowBinding::WindowMethods;
|
|
use dom::bindings::error::Fallible;
|
|
use dom::bindings::global::GlobalRef;
|
|
use dom::bindings::js::{JS, Root};
|
|
use dom::bindings::utils::{Reflector, reflect_dom_object};
|
|
use dom::document::{Document, DocumentHelpers, IsHTMLDocument};
|
|
use dom::document::DocumentSource;
|
|
use dom::window::{Window, WindowHelpers};
|
|
use parse::html::{ParseContext, parse_html};
|
|
use util::str::DOMString;
|
|
|
|
use std::borrow::ToOwned;
|
|
|
|
#[dom_struct]
|
|
pub struct DOMParser {
|
|
reflector_: Reflector,
|
|
window: JS<Window>, //XXXjdm Document instead?
|
|
}
|
|
|
|
impl DOMParser {
|
|
fn new_inherited(window: &Window) -> DOMParser {
|
|
DOMParser {
|
|
reflector_: Reflector::new(),
|
|
window: JS::from_ref(window),
|
|
}
|
|
}
|
|
|
|
pub fn new(window: &Window) -> Root<DOMParser> {
|
|
reflect_dom_object(box DOMParser::new_inherited(window), GlobalRef::Window(window),
|
|
DOMParserBinding::Wrap)
|
|
}
|
|
|
|
pub fn Constructor(global: GlobalRef) -> Fallible<Root<DOMParser>> {
|
|
Ok(DOMParser::new(global.as_window()))
|
|
}
|
|
}
|
|
|
|
impl<'a> DOMParserMethods for &'a DOMParser {
|
|
// https://domparsing.spec.whatwg.org/#the-domparser-interface
|
|
fn ParseFromString(self,
|
|
s: DOMString,
|
|
ty: DOMParserBinding::SupportedType)
|
|
-> Fallible<Root<Document>> {
|
|
let window = self.window.root();
|
|
let url = window.r().get_url();
|
|
let content_type = DOMParserBinding::SupportedTypeValues::strings[ty as usize].to_owned();
|
|
let doc = window.r().Document();
|
|
let doc = doc.r();
|
|
let loader = DocumentLoader::new(&*doc.loader());
|
|
match ty {
|
|
Text_html => {
|
|
let document = Document::new(window.r(), Some(url.clone()),
|
|
IsHTMLDocument::HTMLDocument,
|
|
Some(content_type),
|
|
None,
|
|
DocumentSource::FromParser,
|
|
loader);
|
|
parse_html(document.r(), s, &url, ParseContext::Owner(None));
|
|
document.r().set_ready_state(DocumentReadyState::Complete);
|
|
Ok(document)
|
|
}
|
|
Text_xml => {
|
|
//FIXME: this should probably be FromParser when we actually parse the string (#3756).
|
|
Ok(Document::new(window.r(), Some(url.clone()),
|
|
IsHTMLDocument::NonHTMLDocument,
|
|
Some(content_type),
|
|
None,
|
|
DocumentSource::NotFromParser,
|
|
loader))
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|