forked from mirrors/gecko-dev
		
	 30b37e77e5
			
		
	
	
		30b37e77e5
		
	
	
	
	
		
			
			<!-- Please describe your changes on the following line: --> See https://github.com/servo/rust-mozjs/issues/343#issuecomment-294513870 Heap::new() constructor is unsafe. Heap should be set after reflect_dom_object call in order to prevent potential GC crashes. <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable). <!-- Either: --> - [x] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: e8aa3759bd8f74f7a962e421bd0cbf2a0a3e35da --HG-- extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear extra : subtree_revision : 1f7e2346a5f25efa3e055ff02cd6b9090de23837
		
			
				
	
	
		
			135 lines
		
	
	
	
		
			4.7 KiB
		
	
	
	
		
			Rust
		
	
	
	
	
	
			
		
		
	
	
			135 lines
		
	
	
	
		
			4.7 KiB
		
	
	
	
		
			Rust
		
	
	
	
	
	
| /* This Source Code Form is subject to the terms of the Mozilla Public
 | |
|  * License, v. 2.0. If a copy of the MPL was not distributed with this
 | |
|  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
 | |
| 
 | |
| use core::nonzero::NonZero;
 | |
| use dom::bindings::codegen::Bindings::VRPoseBinding;
 | |
| use dom::bindings::codegen::Bindings::VRPoseBinding::VRPoseMethods;
 | |
| use dom::bindings::js::Root;
 | |
| use dom::bindings::reflector::{DomObject, Reflector, reflect_dom_object};
 | |
| use dom::globalscope::GlobalScope;
 | |
| use dom_struct::dom_struct;
 | |
| use js::jsapi::{Heap, JSContext, JSObject};
 | |
| use js::typedarray::{Float32Array, CreateWith};
 | |
| use std::ptr;
 | |
| use webvr_traits::webvr;
 | |
| 
 | |
| #[dom_struct]
 | |
| pub struct VRPose {
 | |
|     reflector_: Reflector,
 | |
|     position: Heap<*mut JSObject>,
 | |
|     orientation: Heap<*mut JSObject>,
 | |
|     linear_vel: Heap<*mut JSObject>,
 | |
|     angular_vel: Heap<*mut JSObject>,
 | |
|     linear_acc: Heap<*mut JSObject>,
 | |
|     angular_acc: Heap<*mut JSObject>,
 | |
| }
 | |
| 
 | |
| #[allow(unsafe_code)]
 | |
| unsafe fn update_or_create_typed_array(cx: *mut JSContext,
 | |
|                       src: Option<&[f32]>,
 | |
|                       dst: &Heap<*mut JSObject>) {
 | |
|     match src {
 | |
|         Some(data) => {
 | |
|             if dst.get().is_null() {
 | |
|                 let _ = Float32Array::create(cx, CreateWith::Slice(data), dst.handle_mut());
 | |
|             } else {
 | |
|                 typedarray!(in(cx) let array: Float32Array = dst.get());
 | |
|                 if let Ok(mut array) = array {
 | |
|                     array.update(data);
 | |
|                 }
 | |
|             }
 | |
|         },
 | |
|         None => {
 | |
|             if !dst.get().is_null() {
 | |
|                 dst.set(ptr::null_mut());
 | |
|             }
 | |
|         }
 | |
|     }
 | |
| }
 | |
| 
 | |
| #[inline]
 | |
| #[allow(unsafe_code)]
 | |
| fn heap_to_option(heap: &Heap<*mut JSObject>) -> Option<NonZero<*mut JSObject>> {
 | |
|     let js_object = heap.get();
 | |
|     if js_object.is_null() {
 | |
|         None
 | |
|     } else {
 | |
|         unsafe {
 | |
|             Some(NonZero::new(js_object))
 | |
|         }
 | |
|     }
 | |
| }
 | |
| 
 | |
| impl VRPose {
 | |
|     fn new_inherited() -> VRPose {
 | |
|         VRPose {
 | |
|             reflector_: Reflector::new(),
 | |
|             position: Heap::default(),
 | |
|             orientation: Heap::default(),
 | |
|             linear_vel: Heap::default(),
 | |
|             angular_vel: Heap::default(),
 | |
|             linear_acc: Heap::default(),
 | |
|             angular_acc: Heap::default(),
 | |
|         }
 | |
|     }
 | |
| 
 | |
|     pub fn new(global: &GlobalScope, pose: &webvr::VRPose) -> Root<VRPose> {
 | |
|         let root = reflect_dom_object(box VRPose::new_inherited(),
 | |
|                                       global,
 | |
|                                       VRPoseBinding::Wrap);
 | |
|         root.update(&pose);
 | |
|         root
 | |
|     }
 | |
| 
 | |
|     #[allow(unsafe_code)]
 | |
|     pub fn update(&self, pose: &webvr::VRPose) {
 | |
|         let cx = self.global().get_cx();
 | |
|         unsafe {
 | |
|             update_or_create_typed_array(cx, pose.position.as_ref().map(|v| &v[..]), &self.position);
 | |
|             update_or_create_typed_array(cx, pose.orientation.as_ref().map(|v| &v[..]), &self.orientation);
 | |
|             update_or_create_typed_array(cx, pose.linear_velocity.as_ref().map(|v| &v[..]), &self.linear_vel);
 | |
|             update_or_create_typed_array(cx, pose.angular_velocity.as_ref().map(|v| &v[..]), &self.angular_vel);
 | |
|             update_or_create_typed_array(cx, pose.linear_acceleration.as_ref().map(|v| &v[..]), &self.linear_acc);
 | |
|             update_or_create_typed_array(cx, pose.angular_acceleration.as_ref().map(|v| &v[..]), &self.angular_acc);
 | |
|         }
 | |
|     }
 | |
| }
 | |
| 
 | |
| impl VRPoseMethods for VRPose {
 | |
|     #[allow(unsafe_code)]
 | |
|     // https://w3c.github.io/webvr/#dom-vrpose-position
 | |
|     unsafe fn GetPosition(&self, _cx: *mut JSContext) -> Option<NonZero<*mut JSObject>> {
 | |
|         heap_to_option(&self.position)
 | |
|     }
 | |
| 
 | |
|     #[allow(unsafe_code)]
 | |
|     // https://w3c.github.io/webvr/#dom-vrpose-linearvelocity
 | |
|     unsafe fn GetLinearVelocity(&self, _cx: *mut JSContext) -> Option<NonZero<*mut JSObject>> {
 | |
|         heap_to_option(&self.linear_vel)
 | |
|     }
 | |
| 
 | |
|     #[allow(unsafe_code)]
 | |
|     // https://w3c.github.io/webvr/#dom-vrpose-linearacceleration
 | |
|     unsafe fn GetLinearAcceleration(&self, _cx: *mut JSContext) -> Option<NonZero<*mut JSObject>> {
 | |
|         heap_to_option(&self.linear_acc)
 | |
|     }
 | |
| 
 | |
|     #[allow(unsafe_code)]
 | |
|     // https://w3c.github.io/webvr/#dom-vrpose-orientation
 | |
|     unsafe fn GetOrientation(&self, _cx: *mut JSContext) -> Option<NonZero<*mut JSObject>> {
 | |
|         heap_to_option(&self.orientation)
 | |
|     }
 | |
| 
 | |
|     #[allow(unsafe_code)]
 | |
|     // https://w3c.github.io/webvr/#dom-vrpose-angularvelocity
 | |
|     unsafe fn GetAngularVelocity(&self, _cx: *mut JSContext) -> Option<NonZero<*mut JSObject>> {
 | |
|         heap_to_option(&self.angular_vel)
 | |
|     }
 | |
| 
 | |
|     #[allow(unsafe_code)]
 | |
|     // https://w3c.github.io/webvr/#dom-vrpose-angularacceleration
 | |
|     unsafe fn GetAngularAcceleration(&self, _cx: *mut JSContext) -> Option<NonZero<*mut JSObject>> {
 | |
|         heap_to_option(&self.angular_acc)
 | |
|     }
 | |
| }
 |