forked from mirrors/gecko-dev
28243d5736
In Bug 1622749 a user preference for where to open new documents (from a service worker notification) was temporarily overriden in order to quickly fix a crash that was happening in mozilla::dom::ClientOpenWindow. The crash was ocurring when the pref "browser.link.open_newwindow" was set to 2, meaning new documents are opened in a new window, instead of a new tab. The reason the browser crashed is because the path for opening a new document is different depending on the current user setting, and in NEWWINDOW case we did not get a browsing context returned when calling mozilla::dom::OpenWindow which resulted in a failed assertion. The solution is to pass in a callback to mozilla::dom::OpenWindow as part of nsOpenWindowInfo object, and invoke that callback with a corresponding BrowsingContext in nsFrameLoader when that browsing context is ready. After we call mozilla::dom::OpenWindow, we wait on a promise, that will be resolved when the callback is invoked, before executing the rest of the code that depends on the browsing context for a newly opened document being available. Differential Revision: https://phabricator.services.mozilla.com/D72745
73 lines
2.1 KiB
C++
73 lines
2.1 KiB
C++
/* -*- Mode: C++; tab-width: 8; indent-tabs-mode: nil; c-basic-offset: 2 -*- */
|
|
/* vim: set ts=8 sts=2 et sw=2 tw=80: */
|
|
/* This Source Code Form is subject to the terms of the Mozilla Public
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
|
|
|
|
#include "nsOpenWindowInfo.h"
|
|
#include "mozilla/OriginAttributes.h"
|
|
#include "mozilla/dom/ToJSValue.h"
|
|
#include "mozilla/dom/BrowserParent.h"
|
|
|
|
NS_IMPL_ISUPPORTS(nsOpenWindowInfo, nsIOpenWindowInfo)
|
|
|
|
NS_IMETHODIMP nsOpenWindowInfo::GetParent(
|
|
mozilla::dom::BrowsingContext** aParent) {
|
|
*aParent = do_AddRef(mParent).take();
|
|
return NS_OK;
|
|
}
|
|
|
|
NS_IMETHODIMP nsOpenWindowInfo::GetIsRemote(bool* aIsRemote) {
|
|
*aIsRemote = mIsRemote;
|
|
return NS_OK;
|
|
}
|
|
|
|
NS_IMETHODIMP nsOpenWindowInfo::GetForceNoOpener(bool* aForceNoOpener) {
|
|
*aForceNoOpener = mForceNoOpener;
|
|
return NS_OK;
|
|
}
|
|
|
|
NS_IMETHODIMP nsOpenWindowInfo::GetScriptableOriginAttributes(
|
|
JSContext* aCx, JS::MutableHandle<JS::Value> aAttrs) {
|
|
bool ok = ToJSValue(aCx, mOriginAttributes, aAttrs);
|
|
NS_ENSURE_TRUE(ok, NS_ERROR_FAILURE);
|
|
return NS_OK;
|
|
}
|
|
|
|
const OriginAttributes& nsOpenWindowInfo::GetOriginAttributes() {
|
|
return mOriginAttributes;
|
|
}
|
|
|
|
BrowserParent* nsOpenWindowInfo::GetNextRemoteBrowser() {
|
|
return mNextRemoteBrowser;
|
|
}
|
|
|
|
nsIBrowsingContextReadyCallback*
|
|
nsOpenWindowInfo::BrowsingContextReadyCallback() {
|
|
return mBrowsingContextReadyCallback;
|
|
}
|
|
|
|
NS_IMPL_ISUPPORTS(nsBrowsingContextReadyCallback,
|
|
nsIBrowsingContextReadyCallback)
|
|
|
|
nsBrowsingContextReadyCallback::nsBrowsingContextReadyCallback(
|
|
RefPtr<BrowsingContextCallbackReceivedPromise::Private> aPromise)
|
|
: mPromise(std::move(aPromise)) {}
|
|
|
|
nsBrowsingContextReadyCallback::~nsBrowsingContextReadyCallback() {
|
|
if (mPromise) {
|
|
mPromise->Reject(NS_ERROR_FAILURE, __func__);
|
|
}
|
|
mPromise = nullptr;
|
|
}
|
|
|
|
NS_IMETHODIMP nsBrowsingContextReadyCallback::BrowsingContextReady(
|
|
BrowsingContext* aBC) {
|
|
if (aBC) {
|
|
mPromise->Resolve(aBC, __func__);
|
|
} else {
|
|
mPromise->Reject(NS_ERROR_FAILURE, __func__);
|
|
}
|
|
mPromise = nullptr;
|
|
return NS_OK;
|
|
}
|