forked from mirrors/gecko-dev
28243d5736
In Bug 1622749 a user preference for where to open new documents (from a service worker notification) was temporarily overriden in order to quickly fix a crash that was happening in mozilla::dom::ClientOpenWindow. The crash was ocurring when the pref "browser.link.open_newwindow" was set to 2, meaning new documents are opened in a new window, instead of a new tab. The reason the browser crashed is because the path for opening a new document is different depending on the current user setting, and in NEWWINDOW case we did not get a browsing context returned when calling mozilla::dom::OpenWindow which resulted in a failed assertion. The solution is to pass in a callback to mozilla::dom::OpenWindow as part of nsOpenWindowInfo object, and invoke that callback with a corresponding BrowsingContext in nsFrameLoader when that browsing context is ready. After we call mozilla::dom::OpenWindow, we wait on a promise, that will be resolved when the callback is invoked, before executing the rest of the code that depends on the browsing context for a newly opened document being available. Differential Revision: https://phabricator.services.mozilla.com/D72745
48 lines
1.4 KiB
C++
48 lines
1.4 KiB
C++
/* -*- Mode: C++; tab-width: 8; indent-tabs-mode: nil; c-basic-offset: 2 -*- */
|
|
/* vim: set ts=8 sts=2 et sw=2 tw=80: */
|
|
/* This Source Code Form is subject to the terms of the Mozilla Public
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
|
|
|
|
#ifndef nsOpenWindowInfo_h
|
|
#define nsOpenWindowInfo_h
|
|
|
|
#include "nsIOpenWindowInfo.h"
|
|
#include "nsISupportsImpl.h"
|
|
#include "mozilla/OriginAttributes.h"
|
|
#include "mozilla/RefPtr.h"
|
|
#include "mozilla/dom/ClientOpenWindowUtils.h"
|
|
|
|
class nsOpenWindowInfo : public nsIOpenWindowInfo {
|
|
public:
|
|
NS_DECL_ISUPPORTS
|
|
NS_DECL_NSIOPENWINDOWINFO
|
|
|
|
bool mForceNoOpener = false;
|
|
bool mIsRemote = false;
|
|
RefPtr<mozilla::dom::BrowserParent> mNextRemoteBrowser;
|
|
mozilla::OriginAttributes mOriginAttributes;
|
|
RefPtr<mozilla::dom::BrowsingContext> mParent;
|
|
RefPtr<nsIBrowsingContextReadyCallback> mBrowsingContextReadyCallback;
|
|
|
|
private:
|
|
virtual ~nsOpenWindowInfo() = default;
|
|
};
|
|
|
|
class nsBrowsingContextReadyCallback : public nsIBrowsingContextReadyCallback {
|
|
public:
|
|
NS_DECL_ISUPPORTS
|
|
NS_DECL_NSIBROWSINGCONTEXTREADYCALLBACK
|
|
|
|
explicit nsBrowsingContextReadyCallback(
|
|
RefPtr<mozilla::dom::BrowsingContextCallbackReceivedPromise::Private>
|
|
aPromise);
|
|
|
|
private:
|
|
virtual ~nsBrowsingContextReadyCallback();
|
|
|
|
RefPtr<mozilla::dom::BrowsingContextCallbackReceivedPromise::Private>
|
|
mPromise;
|
|
};
|
|
|
|
#endif // nsOpenWindowInfo_h
|