forked from mirrors/gecko-dev
1a1f42da37
This changeset is the result of adding modernize-use-default-member-init to tools/clang-tidy/config.yaml then proceeding to run `./mach static-analysis check netwerk/ --fix` I then went through the resulting fix and manually updated all of the member variables which were missed due to them having a non-trivial constructor. Note that the tool was only run on Linux, so code that only runs on some platforms may have been missed. The member variables that are still initialized in the contructor definition are: - bitfields (not all currently supported compilers allow default-member-init - variables that are initialized via a parameter - variables that use code not visible in the header file There are a few advantages to landing this change: - fewer lines of code - now declaration is in the same place as initialization this also makes it easier to see when looking at the header. - it makes it harder to miss initializing a member when adding a new contructor - variables that depend on an include guard look much nicer now Additionally I removed some unnecessary reinitialization of NetAddr members (it has a constructor that does that now), and changed nsWifiScannerDBus to use the thread-safe strtok_r instead of strtok. Differential Revision: https://phabricator.services.mozilla.com/D116980
110 lines
3.7 KiB
C++
110 lines
3.7 KiB
C++
/* -*- Mode: C++; tab-width: 2; indent-tabs-mode: nil; c-basic-offset: 2 -*- */
|
|
/* vim: set ts=4 sw=2 sts=2 et tw=80: */
|
|
/* This Source Code Form is subject to the terms of the Mozilla Public
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
|
|
|
|
#ifndef NS_GIOCHANNELCHILD_H
|
|
#define NS_GIOCHANNELCHILD_H
|
|
|
|
#include "mozilla/net/PGIOChannelChild.h"
|
|
#include "mozilla/net/ChannelEventQueue.h"
|
|
#include "nsBaseChannel.h"
|
|
#include "nsIUploadChannel.h"
|
|
#include "nsIProxiedChannel.h"
|
|
#include "nsIResumableChannel.h"
|
|
#include "nsIChildChannel.h"
|
|
#include "nsIEventTarget.h"
|
|
#include "nsIStreamListener.h"
|
|
|
|
class nsIEventTarget;
|
|
|
|
namespace mozilla {
|
|
namespace net {
|
|
|
|
class GIOChannelChild final : public PGIOChannelChild,
|
|
public nsBaseChannel,
|
|
public nsIChildChannel {
|
|
public:
|
|
using nsIStreamListener = ::nsIStreamListener;
|
|
|
|
NS_DECL_ISUPPORTS_INHERITED
|
|
NS_DECL_NSICHILDCHANNEL
|
|
|
|
NS_IMETHOD Cancel(nsresult aStatus) override;
|
|
NS_IMETHOD Suspend() override;
|
|
NS_IMETHOD Resume() override;
|
|
|
|
explicit GIOChannelChild(nsIURI* uri);
|
|
|
|
void AddIPDLReference();
|
|
void ReleaseIPDLReference();
|
|
|
|
NS_IMETHOD AsyncOpen(nsIStreamListener* aListener) override;
|
|
|
|
// Note that we handle this ourselves, overriding the nsBaseChannel
|
|
// default behavior, in order to be e10s-friendly.
|
|
NS_IMETHOD IsPending(bool* aResult) override;
|
|
|
|
nsresult OpenContentStream(bool aAsync, nsIInputStream** aStream,
|
|
nsIChannel** aChannel) override;
|
|
|
|
bool IsSuspended() const;
|
|
|
|
protected:
|
|
virtual ~GIOChannelChild() = default;
|
|
|
|
mozilla::ipc::IPCResult RecvOnStartRequest(const nsresult& aChannelStatus,
|
|
const int64_t& aContentLength,
|
|
const nsCString& aContentType,
|
|
const nsCString& aEntityID,
|
|
const URIParams& aURI) override;
|
|
mozilla::ipc::IPCResult RecvOnDataAvailable(const nsresult& aChannelStatus,
|
|
const nsCString& aData,
|
|
const uint64_t& aOffset,
|
|
const uint32_t& aCount) override;
|
|
mozilla::ipc::IPCResult RecvOnStopRequest(
|
|
const nsresult& aChannelStatus) override;
|
|
mozilla::ipc::IPCResult RecvFailedAsyncOpen(
|
|
const nsresult& aStatusCode) override;
|
|
mozilla::ipc::IPCResult RecvDeleteSelf() override;
|
|
|
|
void DoOnStartRequest(const nsresult& aChannelStatus,
|
|
const int64_t& aContentLength,
|
|
const nsCString& aContentType,
|
|
const nsCString& aEntityID, const URIParams& aURI);
|
|
void DoOnDataAvailable(const nsresult& aChannelStatus, const nsCString& aData,
|
|
const uint64_t& aOffset, const uint32_t& aCount);
|
|
void DoOnStopRequest(const nsresult& aChannelStatus);
|
|
void DoFailedAsyncOpen(const nsresult& aStatusCode);
|
|
void DoDeleteSelf();
|
|
|
|
void SetupNeckoTarget() override;
|
|
|
|
friend class NeckoTargetChannelFunctionEvent;
|
|
|
|
private:
|
|
nsCOMPtr<nsIInputStream> mUploadStream;
|
|
|
|
bool mIPCOpen = false;
|
|
const RefPtr<ChannelEventQueue> mEventQ;
|
|
|
|
bool mCanceled = false;
|
|
uint32_t mSuspendCount = 0;
|
|
;
|
|
bool mIsPending = false;
|
|
|
|
uint64_t mStartPos = 0;
|
|
nsCString mEntityID;
|
|
|
|
// Set if SendSuspend is called. Determines if SendResume is needed when
|
|
// diverting callbacks to parent.
|
|
bool mSuspendSent = false;
|
|
};
|
|
|
|
inline bool GIOChannelChild::IsSuspended() const { return mSuspendCount != 0; }
|
|
|
|
} // namespace net
|
|
} // namespace mozilla
|
|
|
|
#endif /* NS_GIOCHANNELCHILD_H */
|