fune/netwerk/protocol/http/BackgroundDataBridgeChild.cpp
Kershaw Chang d7d4941cf6 Bug 1662072 - Reduce one data copy in parent process when sending chunks to child process r=valentin
1. The data sent from `HttpBackgroundChannelParent` to `HttpBackgroundChannelChild` is using type `nsDependentCSubstring`, since I'd like to reduce one copy in parent process.
2. The data sent from `HttpTransactionChild` to `HttpTransactionParent` is using type `nsCString`. The main reason is that the data is actually captured in `HttpTransactionParent::RecvOnDataAvailable` [1] and put in channel event queue. If we use `nsDependentCSubstring` here, the data would be copied in parent process.
3.  In `HttpBackgroundChannelChild::RecvOnTransportAndData`, it's inevitable that the data is copied when assigning the data to a `nsCString`, since sometimes `HttpBackgroundChannelChild::RecvOnTransportAndData` needs to be queued and execute later.


[1] https://searchfox.org/mozilla-central/rev/969fc7fa6c3c7fc489f53b7b7f8c902028b5169f/netwerk/protocol/http/HttpTransactionParent.cpp#556

Differential Revision: https://phabricator.services.mozilla.com/D88781
2020-08-31 17:11:21 +00:00

58 lines
1.7 KiB
C++

/* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
#include "mozilla/net/BackgroundDataBridgeChild.h"
#include "mozilla/net/HttpBackgroundChannelChild.h"
namespace mozilla {
namespace net {
BackgroundDataBridgeChild::BackgroundDataBridgeChild(
HttpBackgroundChannelChild* aBgChild)
: mBgChild(aBgChild) {
MOZ_ASSERT(aBgChild);
}
BackgroundDataBridgeChild::~BackgroundDataBridgeChild() = default;
void BackgroundDataBridgeChild::ActorDestroy(ActorDestroyReason aWhy) {
mBgChild = nullptr;
}
mozilla::ipc::IPCResult BackgroundDataBridgeChild::RecvOnTransportAndData(
const uint64_t& offset, const uint32_t& count,
const nsDependentCSubstring& data) {
if (!mBgChild) {
return IPC_OK();
}
if (mBgChild->ChannelClosed()) {
Unused << Send__delete__(this);
return IPC_OK();
}
return mBgChild->RecvOnTransportAndData(NS_OK, NS_NET_STATUS_RECEIVING_FROM,
offset, count, data, true);
}
mozilla::ipc::IPCResult BackgroundDataBridgeChild::RecvOnStopRequest(
nsresult aStatus, const ResourceTimingStructArgs& aTiming,
const TimeStamp& aLastActiveTabOptHit,
const nsHttpHeaderArray& aResponseTrailers) {
if (!mBgChild) {
return IPC_OK();
}
if (mBgChild->ChannelClosed()) {
Unused << Send__delete__(this);
return IPC_OK();
}
return mBgChild->RecvOnStopRequest(aStatus, aTiming, aLastActiveTabOptHit,
aResponseTrailers,
nsTArray<ConsoleReportCollected>(), true);
}
} // namespace net
} // namespace mozilla