forked from mirrors/gecko-dev
0e91db76c5
TestNetworkLinkIdHashingWindows has two issues that, frighteningly, cancelled each other out under most conditions. First is that the `sscanf` format string uses curly braces when the test data does not have braces. Second is that the order of `nwGUIDS` does not match the sorting behavior of `nsNotifyAddrListener::HashSortedNetworkIds`. What ended up happening was that the sscanf failed, and left the entire GUID uninitialized. Then we used that uninitialized data over and over in `nwGUIDS` so the order didn't matter. However, under AddressSanitizer, the failure became evident, because (I think, haven't verified) that ASan's instrumentation messes with the contents of the stack between the four GUID parses, so we no longer use the same uninitialized data four times. And for bonus fun, this wasn't noticed in CI because we don't (yet) run ASan on GTests for Windows. Debugging this was... quite an adventure. Differential Revision: https://phabricator.services.mozilla.com/D63532 --HG-- extra : moz-landing-system : lando
88 lines
2.4 KiB
C++
88 lines
2.4 KiB
C++
#include <combaseapi.h>
|
|
|
|
#include "gtest/gtest.h"
|
|
#include "mozilla/SHA1.h"
|
|
#include "nsNotifyAddrListener.h"
|
|
|
|
using namespace mozilla;
|
|
|
|
GUID StringToGuid(const std::string& str) {
|
|
GUID guid;
|
|
sscanf(str.c_str(),
|
|
"%8lx-%4hx-%4hx-%2hhx%2hhx-%2hhx%2hhx%2hhx%2hhx%2hhx%2hhx",
|
|
&guid.Data1, &guid.Data2, &guid.Data3, &guid.Data4[0], &guid.Data4[1],
|
|
&guid.Data4[2], &guid.Data4[3], &guid.Data4[4], &guid.Data4[5],
|
|
&guid.Data4[6], &guid.Data4[7]);
|
|
|
|
return guid;
|
|
}
|
|
|
|
TEST(TestGuidHashWindows, Single)
|
|
{
|
|
// Setup
|
|
SHA1Sum expected_sha1;
|
|
SHA1Sum::Hash expected_digest;
|
|
|
|
GUID g1 = StringToGuid("264555b1-289c-4494-83d1-e158d1d95115");
|
|
|
|
expected_sha1.update(&g1, sizeof(GUID));
|
|
expected_sha1.finish(expected_digest);
|
|
|
|
std::vector<GUID> nwGUIDS;
|
|
nwGUIDS.push_back(g1);
|
|
SHA1Sum actual_sha1;
|
|
// Run
|
|
nsNotifyAddrListener::HashSortedNetworkIds(nwGUIDS, actual_sha1);
|
|
SHA1Sum::Hash actual_digest;
|
|
actual_sha1.finish(actual_digest);
|
|
|
|
// Assert
|
|
ASSERT_EQ(0, memcmp(&expected_digest, &actual_digest, sizeof(SHA1Sum::Hash)));
|
|
}
|
|
|
|
TEST(TestNetworkLinkIdHashingWindows, Multiple)
|
|
{
|
|
// Setup
|
|
SHA1Sum expected_sha1;
|
|
SHA1Sum::Hash expected_digest;
|
|
|
|
std::vector<GUID> nwGUIDS;
|
|
nwGUIDS.push_back(StringToGuid("00000000-0000-0000-0000-000000000001"));
|
|
nwGUIDS.push_back(StringToGuid("00000000-0000-0000-0000-000000000002"));
|
|
nwGUIDS.push_back(StringToGuid("00000000-0000-0000-0000-000000000003"));
|
|
nwGUIDS.push_back(StringToGuid("00000000-0000-0000-0000-000000000004"));
|
|
|
|
for (const auto& guid : nwGUIDS) {
|
|
expected_sha1.update(&guid, sizeof(GUID));
|
|
}
|
|
expected_sha1.finish(expected_digest);
|
|
|
|
// Ordered
|
|
std::vector<GUID> ordered;
|
|
for (const auto& guid : nwGUIDS) {
|
|
ordered.push_back(guid);
|
|
}
|
|
SHA1Sum ordered_sha1;
|
|
|
|
// Unordered
|
|
std::vector<GUID> reversed;
|
|
for (auto it = nwGUIDS.rbegin(); it != nwGUIDS.rend(); ++it) {
|
|
reversed.push_back(*it);
|
|
}
|
|
SHA1Sum reversed_sha1;
|
|
|
|
// Run
|
|
nsNotifyAddrListener::HashSortedNetworkIds(ordered, ordered_sha1);
|
|
SHA1Sum::Hash ordered_digest;
|
|
ordered_sha1.finish(ordered_digest);
|
|
|
|
nsNotifyAddrListener::HashSortedNetworkIds(reversed, reversed_sha1);
|
|
SHA1Sum::Hash reversed_digest;
|
|
reversed_sha1.finish(reversed_digest);
|
|
|
|
// Assert
|
|
ASSERT_EQ(0,
|
|
memcmp(&expected_digest, &ordered_digest, sizeof(SHA1Sum::Hash)));
|
|
ASSERT_EQ(0,
|
|
memcmp(&expected_digest, &reversed_digest, sizeof(SHA1Sum::Hash)));
|
|
}
|