fune/dom/xul/XULTooltipElement.cpp
Emilio Cobos Álvarez a7401488af Bug 1784265 - Drop support for flex attribute values other than 0 and 1. r=dholbert,mconley,preferences-reviewers
This makes it easier to get parity between legacy and regular flex
without having to either have tons of arbitrary attribute selectors in
the xul sheet, nor adding attribute lookup hacks to the html flexbox
layout.

Also, reimplement the remaining supported flex attribute-values (0 and 1)
purely in terms of CSS rules in xul.css (regardless of whether
emulate-moz-box-with-flex is enabled).

In practice these are pretty uncommon and the style attribute does the
trick in every case I've tried.

Add a debug-only assertion to ensure we preserve behavior for now.

Add a new test with another behavior difference between flexbox
emulation and old xul layout because the old reftest now passes. Use
replaced elements, which in modern flex are treated differently.

Differential Revision: https://phabricator.services.mozilla.com/D154394
2022-08-12 23:13:41 +00:00

104 lines
4.2 KiB
C++

/* -*- Mode: C++; tab-width: 8; indent-tabs-mode: nil; c-basic-offset: 2 -*- */
/* vim: set ts=8 sts=2 et sw=2 tw=80: */
/* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
#include "nsCOMPtr.h"
#include "mozilla/dom/Event.h"
#include "mozilla/dom/XULTooltipElement.h"
#include "mozilla/dom/NodeInfo.h"
#include "mozilla/EventDispatcher.h"
#include "nsContentCreatorFunctions.h"
#include "nsContentUtils.h"
#include "nsCTooltipTextProvider.h"
#include "nsITooltipTextProvider.h"
#include "nsServiceManagerUtils.h"
#include "nsThreadUtils.h"
namespace mozilla::dom {
nsXULElement* NS_NewXULTooltipElement(
already_AddRefed<mozilla::dom::NodeInfo>&& aNodeInfo) {
RefPtr<mozilla::dom::NodeInfo> nodeInfo(aNodeInfo);
auto* nim = nodeInfo->NodeInfoManager();
RefPtr<XULTooltipElement> tooltip =
new (nim) XULTooltipElement(nodeInfo.forget());
NS_ENSURE_SUCCESS(tooltip->Init(), nullptr);
return tooltip;
}
nsresult XULTooltipElement::Init() {
// Create the default child label node that will contain the text of the
// tooltip.
RefPtr<mozilla::dom::NodeInfo> nodeInfo;
nodeInfo = mNodeInfo->NodeInfoManager()->GetNodeInfo(
nsGkAtoms::description, nullptr, kNameSpaceID_XUL, nsINode::ELEMENT_NODE);
nsCOMPtr<Element> description;
nsresult rv = NS_NewXULElement(getter_AddRefs(description), nodeInfo.forget(),
dom::NOT_FROM_PARSER);
NS_ENSURE_SUCCESS(rv, rv);
description->SetAttr(kNameSpaceID_None, nsGkAtoms::_class,
u"tooltip-label"_ns, false);
ErrorResult error;
AppendChild(*description, error);
return error.StealNSResult();
}
nsresult XULTooltipElement::AfterSetAttr(int32_t aNameSpaceID, nsAtom* aName,
const nsAttrValue* aValue,
const nsAttrValue* aOldValue,
nsIPrincipal* aSubjectPrincipal,
bool aNotify) {
if (aNameSpaceID == kNameSpaceID_None && aName == nsGkAtoms::label) {
// When the label attribute of this node changes propagate the text down
// into child description element.
nsCOMPtr<nsIContent> description = GetFirstChild();
if (description && description->IsXULElement(nsGkAtoms::description)) {
nsAutoString value;
if (aValue) {
aValue->ToString(value);
}
nsContentUtils::AddScriptRunner(NS_NewRunnableFunction(
"XULTooltipElement::AfterSetAttr", [description, value]() {
Element* descriptionElement = description->AsElement();
descriptionElement->SetTextContent(value, IgnoreErrors());
}));
}
}
return nsXULElement::AfterSetAttr(aNameSpaceID, aName, aValue, aOldValue,
aSubjectPrincipal, aNotify);
}
nsresult XULTooltipElement::PostHandleEvent(EventChainPostVisitor& aVisitor) {
if (aVisitor.mEvent->mMessage == eXULPopupShowing &&
aVisitor.mEvent->IsTrusted() && !aVisitor.mEvent->DefaultPrevented() &&
AttrValueIs(kNameSpaceID_None, nsGkAtoms::page, nsGkAtoms::_true,
eCaseMatters) &&
!AttrValueIs(kNameSpaceID_None, nsGkAtoms::titletip, nsGkAtoms::_true,
eCaseMatters)) {
// When the tooltip node has the "page" attribute set to "true" the
// tooltip text provider is used to find the tooltip text from page where
// mouse is hovering over.
nsCOMPtr<nsITooltipTextProvider> textProvider =
do_GetService(NS_DEFAULTTOOLTIPTEXTPROVIDER_CONTRACTID);
nsString text;
nsString direction;
bool shouldChange = false;
if (textProvider) {
textProvider->GetNodeText(GetTriggerNode(), getter_Copies(text),
getter_Copies(direction), &shouldChange);
}
if (shouldChange) {
SetAttr(kNameSpaceID_None, nsGkAtoms::label, text, true);
SetAttr(kNameSpaceID_None, nsGkAtoms::direction, direction, true);
} else {
aVisitor.mEventStatus = nsEventStatus_eConsumeNoDefault;
aVisitor.mEvent->PreventDefault();
}
}
return NS_OK;
}
} // namespace mozilla::dom